Re: Freeze break: fix bug with Mutter and toolkit window positioning

2014-09-18 Thread Frederic Peters
Matthias Clasen wrote:
> On Thu, Sep 18, 2014 at 10:18 PM, Sriram Ramkrishna  
> wrote:
> > On Thu, Sep 18, 2014 at 3:13 PM, Owen Taylor  wrote:
> >> Would like to push the patches:
> >>
> >>  https://bugzilla.gnome.org/show_bug.cgi?id=736719
> >>
> >> The bug they fix is fairly bad misbehavior with non-GTK+ apps, in 
> >> particular with Qt apps.
> >>
> >> They are pretty straightforward, and basically are reverting back to an 
> >> earlier version
> >> of the code and I specifically tested that they also fix the original 
> >> problem with
> >> VirtualBox.
> >>
> >
> > +1 from me, anything that helps play nice with non-gtk+ apps for this
> > release will be good from an engagement perspective.
> >
> 
> Second +1, with a cautionary note on the dangers of refactoring old
> code like this, in particular when it affects interoperability with
> other toolkits/wms, and we don't have sufficient automatic testing in
> place...

Hum, as Sri is not a release team member, here's a +1 to replace his
:)


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Freeze break: fix bug with Mutter and toolkit window positioning

2014-09-18 Thread Matthias Clasen
On Thu, Sep 18, 2014 at 10:18 PM, Sriram Ramkrishna  wrote:
> On Thu, Sep 18, 2014 at 3:13 PM, Owen Taylor  wrote:
>> Would like to push the patches:
>>
>>  https://bugzilla.gnome.org/show_bug.cgi?id=736719
>>
>> The bug they fix is fairly bad misbehavior with non-GTK+ apps, in particular 
>> with Qt apps.
>>
>> They are pretty straightforward, and basically are reverting back to an 
>> earlier version
>> of the code and I specifically tested that they also fix the original 
>> problem with
>> VirtualBox.
>>
>
> +1 from me, anything that helps play nice with non-gtk+ apps for this
> release will be good from an engagement perspective.
>

Second +1, with a cautionary note on the dangers of refactoring old
code like this, in particular when it affects interoperability with
other toolkits/wms, and we don't have sufficient automatic testing in
place...
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Freeze break: fix bug with Mutter and toolkit window positioning

2014-09-18 Thread Sriram Ramkrishna
On Thu, Sep 18, 2014 at 3:13 PM, Owen Taylor  wrote:
> Would like to push the patches:
>
>  https://bugzilla.gnome.org/show_bug.cgi?id=736719
>
> The bug they fix is fairly bad misbehavior with non-GTK+ apps, in particular 
> with Qt apps.
>
> They are pretty straightforward, and basically are reverting back to an 
> earlier version
> of the code and I specifically tested that they also fix the original problem 
> with
> VirtualBox.
>

+1 from me, anything that helps play nice with non-gtk+ apps for this
release will be good from an engagement perspective.

sri
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Freeze break: fix bug with Mutter and toolkit window positioning

2014-09-18 Thread Owen Taylor
Would like to push the patches:

 https://bugzilla.gnome.org/show_bug.cgi?id=736719

The bug they fix is fairly bad misbehavior with non-GTK+ apps, in particular 
with Qt apps.

They are pretty straightforward, and basically are reverting back to an earlier 
version
of the code and I specifically tested that they also fix the original problem 
with
VirtualBox.

- Owen
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Freeze break request for epiphany

2014-09-18 Thread Frederic Peters
Carlos Garcia Campos wrote:
> 
> We recently introduced a regression that makes ephy open two windows
> when running in app mode, so every time you open a web app you end up
> with two windows with the web app loaded.
> 
> Patch is attached to https://bugzilla.gnome.org/show_bug.cgi?id=736922

Fine, approval 1 of 2.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Freeze break request: https://bugzilla.gnome.org/show_bug.cgi?id=733315

2014-09-18 Thread Frederic Peters
Jasper St. Pierre wrote:
> This is a blocker bug, and the relevant branches in GTK+ and mutter have
> been reviewed.

The GTK+ patch diff formatting is a bit messy as gtk_window_realize
was moved but Matthias said it's ok, so here's a second approval.

And +1 for the mutter changes.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Code freeze exception for gnome-software

2014-09-18 Thread Andre Klapper
r-t approval 2 of 2.

andre

On Thu, 2014-09-18 at 12:15 -0400, Matthias Clasen wrote:
> +1 from me.
> 
> On Thu, Sep 18, 2014 at 10:21 AM, Florian Müllner  wrote:
> > https://bugzilla.gnome.org/show_bug.cgi?id=736902

-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Freeze break request for epiphany

2014-09-18 Thread Carlos Garcia Campos

We recently introduced a regression that makes ephy open two windows
when running in app mode, so every time you open a web app you end up
with two windows with the web app loaded.

Patch is attached to https://bugzilla.gnome.org/show_bug.cgi?id=736922

Thanks, 
-- 
Carlos Garcia Campos
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462


pgp84BbAuNxZ3.pgp
Description: PGP signature
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Freeze break request: https://bugzilla.gnome.org/show_bug.cgi?id=733315

2014-09-18 Thread Jasper St. Pierre
This is a blocker bug, and the relevant branches in GTK+ and mutter have
been reviewed.

-- 
  Jasper
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Code freeze exception for gnome-software

2014-09-18 Thread Matthias Clasen
+1 from me.

On Thu, Sep 18, 2014 at 10:21 AM, Florian Müllner  wrote:
> Hey,
>
> I'd like to request a freeze break for
> https://bugzilla.gnome.org/show_bug.cgi?id=736902, which fixes an
> issue with Software's app-folder dialog not closing(*). The patch is
> straight-forward and obvious, and fixes a fairly annoying problem.
>
> -- Florian
>
>
> (*) it turns out that unlike what the bug claims, the behavior is not
> deterministic, e.g. the dialog closes correctly when the top of the
> stack happens to be "falsey"
> ___
> release-team@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


[gnome-photos] Created branch gnome-3-14

2014-09-18 Thread Debarshi Ray
The branch 'gnome-3-14' was created pointing to:

 dfe679a... Added Nepali translation

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Code freeze exception for gnome-software

2014-09-18 Thread Florian Müllner
Hey,

I'd like to request a freeze break for
https://bugzilla.gnome.org/show_bug.cgi?id=736902, which fixes an
issue with Software's app-folder dialog not closing(*). The patch is
straight-forward and obvious, and fixes a fairly annoying problem.

-- Florian


(*) it turns out that unlike what the bug claims, the behavior is not
deterministic, e.g. the dialog closes correctly when the top of the
stack happens to be "falsey"
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Freeze break request for gnome-shell

2014-09-18 Thread Frederic Peters
Piñeiro wrote:
> This bug:
> https://bugzilla.gnome.org/show_bug.cgi?id=736821
> 
> makes gnome-shell mostly inaccessible. The fix is trivial, and was
> already reviewed and accepted by gnome-shell developers.
> 
> Andre already give a 1/2 from release team on the bug. I could do the
> same, but I guess that it would be strange to give a release-team vote
> on an own bug.

Ok, 2/2


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Freeze break request for gnome-shell

2014-09-18 Thread Piñeiro
This bug:
https://bugzilla.gnome.org/show_bug.cgi?id=736821

makes gnome-shell mostly inaccessible. The fix is trivial, and was
already reviewed and accepted by gnome-shell developers.

Andre already give a 1/2 from release team on the bug. I could do the
same, but I guess that it would be strange to give a release-team vote
on an own bug.

Best regards

-- 

Alejandro Piñeiro

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Permission to break hard code freeze - Support giflib-5.1.0

2014-09-18 Thread Frederic Peters
Martyn Russell wrote:
> Hi all,
> 
> Javier commented on this bug for GNOME 3.14 and I'm formally asking for
> permission to release with the patch attached:
> 
>   https://bugzilla.gnome.org/show_bug.cgi?id=734351

Great; with Javier initial approval, consider this the second one.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Permission to break hard code freeze - Support giflib-5.1.0

2014-09-18 Thread Martyn Russell

Hi all,

Javier commented on this bug for GNOME 3.14 and I'm formally asking for 
permission to release with the patch attached:


  https://bugzilla.gnome.org/show_bug.cgi?id=734351

Thanks,

--
Regards,
Martyn

Founder & Director @ Lanedo GmbH.
http://www.linkedin.com/in/martynrussell
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.