orca 3.36.6
News General: * Add some sanity checks to prevent crashing due to GStreamer failure = ChangeLog = https://download.gnome.org/sources/orca/3.36/orca-3.36.6.changes (407) Download https://download.gnome.org/sources/orca/3.36/orca-3.36.6.tar.xz (3.30M) sha256sum: 18ef9a930a78c8030558b0d4145f7278ccf3e09911d00d88173e40f325feb3f0 ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-38
The branch 'gnome-3-38' was created pointing to: 09bbfb4... Web: Fall back on object attributes for absent text attribu ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
orca 3.36.5
News Web + Thunderbird: * Fix regression breaking access to content (incomplete cherry-pick) = ChangeLog = https://download.gnome.org/sources/orca/3.36/orca-3.36.5.changes (500) Download https://download.gnome.org/sources/orca/3.36/orca-3.36.5.tar.xz (3.41M) sha256sum: bd88799377468b75e2571504efb3d2ca4b1f2162e0c41b88a5d51a4fee18cb5b ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
orca 3.36.4
News Web: * Fix false positive causing us to not present self-referential labels * Fix crash caused by author using aria-labelledby pointing to itself * Always speak the current line when caret moves due to mouse click so that presentation is consistent regardless of the element * Fix bug causing events from Google Docs to be ignored when a dialog appears but lacks focus Thunderbird: * Fix bug causing us to incorrectly update our location within settings General: * Fix bug causing learn mode to not work in (at least) gnome-shell controls New and updated translations (THANKS EVERYONE!!!): frFrenchCharles Monzat kkKazakhBaurzhan Muftakhidinov ukUkrainian Yuri Chornoivan = ChangeLog = https://download.gnome.org/sources/orca/3.36/orca-3.36.4.changes (2.24K) Download https://download.gnome.org/sources/orca/3.36/orca-3.36.4.tar.xz (3.41M) sha256sum: 9f47cedae2baeb71e94ef1466dad339f051684a74428c7798bdcdf6157cdd8e8 ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-36
The branch 'gnome-3-36' was created pointing to: 8d79181... Update our state when input event has to search for the act ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-34
The branch 'gnome-3-34' was created pointing to: 2751a7f... Post-release version bump ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-32
The branch 'gnome-3-32' was created. Summary of new commits: ade193b... Post-release version bump ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-30
The branch 'gnome-3-30' was created pointing to: a1d6c7b... Merge branch 'profile-special-chars' into 'master' ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
orca 3.28.1
News Web + Email: * Fix Orca-triggered focus change in Thunderbird message composition window General: * Handle event floods from Caja and Nautilus more efficiently Braille: * Release device when braille is deactivated for some applications * Fix bogus dots appearing after text New and updated translations (THANKS EVERYONE!!!): svSwedishAnders Jonsson = ChangeLog = https://download.gnome.org/sources/orca/3.28/orca-3.28.1.changes (1.27K) Download https://download.gnome.org/sources/orca/3.28/orca-3.28.1.tar.xz (2.35M) sha256sum: 4f14144a722d26c6e5492298600df0161ce841bf8eae81fd2b27387e2c638512 ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-28
The branch 'gnome-3-28' was created pointing to: 043487f... Release prep ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
orca 3.28.0
News Web + Email: * Ensure focus is grabbed on image links when navigating * Fix bug causing notifications to trigger browse mode LibreOffice: * Improve heuristic to identify spellcheck dialog General: * Ensure list name is presented for ancestor lists New and updated translations (THANKS EVERYONE!!!): csCzech Marek Černocký daDanish Alan Mortensen deGerman Tim Sabsch esSpanishDaniel Mustieles fiFinnishJiri Grönroos frFrench Claude Paroz huHungarian Gábor Kelemen, Balázs Úr itItalianMilo Casagrande ltLithuanian Aurimas Černius lvLatvianRūdolfs Mazurs nlDutch Nathan Follens slSlovenian Matej Urbančič srSerbianМарко Костић sr@latin Serbian Latin Милош Поповић svSwedishAnders Jonsson trTurkishEmin Tufan Çetin zh_CN Chinese (China)Mingcong Bai = ChangeLog = https://download.gnome.org/sources/orca/3.28/orca-3.28.0.changes (4.11K) Download https://download.gnome.org/sources/orca/3.28/orca-3.28.0.tar.xz (2.35M) sha256sum: 823949416a7df8ca21d01cde33f4f6fe87aa051552c5f7c9cb012a5074ffc2cb ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-26
The branch 'gnome-3-26' was created pointing to: 3d8d7ec... Post-release version bump ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-22
The branch 'gnome-3-22' was created pointing to: 3484179... Post-release version bump ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-20
The branch 'gnome-3-20' was created pointing to: e834fd6... Work around Google Maps killing the focused widget ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-18
The branch 'gnome-3-18' was created pointing to: b5a1c8f... Prep for the 3.18.2 release ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: GNOME 3.16 Blocker Report
I'd like to add one myself, which I just filed: https://bugzilla.gnome.org/show_bug.cgi?id=745967 Thanks! --joanie On 03/08/2015 06:42 PM, Giovanni Campagna wrote: Would it be possible to take a look at https://bugzilla.gnome.org/show_bug.cgi?id=704619 before 3.16? I know seahorse is in deep maintenance mode because the maintainer was reassigned to other projects, but the bug is definitely a blocker for the search provider functionality. Giovanni On Fri, Feb 27, 2015 at 8:34 AM, Andre Klapper ak...@gmx.net mailto:ak...@gmx.net wrote: Blocker bugs are listed on your product's overview page: https://bugzilla.gnome.org/page.cgi?id=browse.html Feel encouraged to take a look / update the status etc. === bijiben == Popover placement issues https://bugzilla.gnome.org/show_bug.cgi?id=728859 === evolution-data-server == Gnome shell keeps poping modal dialog for gmail password https://bugzilla.gnome.org/show_bug.cgi?id=728496 === folks == Store state about enabled BlueZ persona stores https://bugzilla.gnome.org/show_bug.cgi?id=720274 === gnome-calculator == Awkward relationship between input area and results list https://bugzilla.gnome.org/show_bug.cgi?id=743499 === gnome-documents == List view looks messy https://bugzilla.gnome.org/show_bug.cgi?id=723843 === gnome-music == Visible content loading https://bugzilla.gnome.org/show_bug.cgi?id=704257 === gnome-photos == better performing thumbnails https://bugzilla.gnome.org/show_bug.cgi?id=740425 === gnome-shell == Disabled app-menu entries should look disabled https://bugzilla.gnome.org/show_bug.cgi?id=745175 Candidate window not functioning on overview https://bugzilla.gnome.org/show_bug.cgi?id=745167 Legacy tray icons of some applications either too small or appear blank/missing https://bugzilla.gnome.org/show_bug.cgi?id=721596 display legacy status icons somewhere https://bugzilla.gnome.org/show_bug.cgi?id=745162 Previous-/Next-page buttons for IME candidates are wrong https://bugzilla.gnome.org/show_bug.cgi?id=744959 Modal password boxes prevent users from looking up or generating passwords https://bugzilla.gnome.org/show_bug.cgi?id=688434 No follow-up notification after reacting to chat message https://bugzilla.gnome.org/show_bug.cgi?id=744948 mouse hover and keyboard focus identical https://bugzilla.gnome.org/show_bug.cgi?id=745246 Wi-Fi password dialog pops up without invitation https://bugzilla.gnome.org/show_bug.cgi?id=740750 === gnome-software == list of updates disappears after removing an app https://bugzilla.gnome.org/show_bug.cgi?id=739669 doesn't show updates when there are updates https://bugzilla.gnome.org/show_bug.cgi?id=739666 === gnome-user-share == Nautilus infobar for personal file sharing is ambigous https://bugzilla.gnome.org/show_bug.cgi?id=740375 === gtk+ == Frame clock synchronization broken https://bugzilla.gnome.org/show_bug.cgi?id=740424 avahi-discovered CUPS printers don't work https://bugzilla.gnome.org/show_bug.cgi?id=743323 === mutter == [REGRESSION] [Notifications] incomplete screenshots when opened notifications/calendar from top panel https://bugzilla.gnome.org/show_bug.cgi?id=744978 === nautilus == Tooltip display for last item makes item uneditable (when not using status bar) https://bugzilla.gnome.org/show_bug.cgi?id=651293 === totem == Properties should be available from overview https://bugzilla.gnome.org/show_bug.cgi?id=723900 === yelp == Home page isn't very attractive / engaging https://bugzilla.gnome.org/show_bug.cgi?id=740304 Further bugs good to fix (3.16 in the Whiteboard field): === evolution-data-server == Gnome shell keeps poping modal dialog for gmail password https://bugzilla.gnome.org/show_bug.cgi?id=728496 === gdm == login screen stuck after switching users https://bugzilla.gnome.org/show_bug.cgi?id=719418 === mutter == gdm greeter crash https://bugzilla.gnome.org/show_bug.cgi?id=743566 === totem == Add Favorites/bookmarks https://bugzilla.gnome.org/show_bug.cgi?id=357843 -- Andre Klapper | ak...@gmx.net mailto:ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ desktop-devel-list mailing list desktop-devel-l...@gnome.org mailto:desktop-devel-l...@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list ___ desktop-devel-list mailing list
[orca] Created branch gnome-3-16
The branch 'gnome-3-16' was created pointing to: 54a8898... Post-release version bump ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Orca string-freeze (and technically gui-freeze) break request
Thank you Daniel and Alexandre!!! And thank you entire i18n team for all the work you do. In order to get the string in so that translation can proceed, I've gone ahead and committed the patch to the gnome-3-14 branch. Surely the Release Team will not object to an i18n-approved tiny addition to a hidden GUI that facilitates the switch away from non-Free software to GNU/Linux. ;) But if I'm wrong, I can always comment out the lines which actually add it to the GUI. --joanie On 09/13/2014 06:07 AM, Daniel Mustieles García wrote: 2/2 from i18n Cheers! 2014-09-13 10:13 GMT+02:00 Alexandre Franke alexandre.fra...@gmail.com mailto:alexandre.fra...@gmail.com: On Sat, Sep 13, 2014 at 12:33 AM, Joanmarie Diggs jdi...@igalia.com mailto:jdi...@igalia.com wrote: Hey all. Hi Joanmarie! I've just committed a change to Orca master that I'd like to also commit to Orca's gnome-3-14 branch and include in the approaching release. […] Well, it's getting late, but your explanation seems reasonable and there's only one string with a nice comment for translators, so here's my +1 for i18n. Cheers. -- Alexandre Franke ___ gnome-i18n mailing list gnome-i...@gnome.org mailto:gnome-i...@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Orca: String-freeze break request
On 09/08/2014 06:31 AM, Frederic Peters wrote: Piñeiro wrote: On 09/07/2014 12:07 PM, Alexandre Franke wrote: On Sun, Sep 7, 2014 at 3:43 AM, Piotr Drąg piotrd...@gmail.com wrote: 2014-09-07 2:45 GMT+02:00 Joanmarie Diggs jdi...@igalia.com: TL;DR: No good deed goes unpunished. Please, please grant this request. https://bugzilla.gnome.org/show_bug.cgi?id=736214 1/2 from i18n. 2/2. 1/2 from release-team For the record approval from the i18n coordination team is enough for string breaks; a notification to the release team is enough. Oops. sheepish grin In that case, consider this notice that I've pushed the change. ;) Thanks guys! And sorry this wasn't caught before the freeze. --joanie ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Orca: String-freeze break request
TL;DR: No good deed goes unpunished. Please, please grant this request. https://bugzilla.gnome.org/show_bug.cgi?id=736214 Proposed strings (3): +# Translators: Orca's verbosity levels control how much (or how little) +# Orca will speak when presenting objects as the user navigates within +# applications and reads content. The levels can be toggled via command. +# This string describes that command. +TOGGLE_SPEECH_VERBOSITY = _(Toggles speech verbosity level.) +# Translators: Orca's verbosity levels control how much (or how little) +# Orca will speak when presenting objects as the user navigates within +# applications and reads content. The two levels are brief and verbose. +# The following string is a message spoken to the user upon toggling +# this setting via command. +SPEECH_VERBOSITY_BRIEF = C_(Speech, Verbosity level: brief) +# Translators: Orca's verbosity levels control how much (or how little) +# Orca will speak when presenting objects as the user navigates within +# applications and reads content. The two levels are brief and verbose. +# The following string is a message spoken to the user upon toggling +# this setting via command. +SPEECH_VERBOSITY_VERBOSE = C_(Speech, Verbosity level: verbose) Detailed explanation: Clickable elements are those which have an onClick handler. Sadly, these elements tend to be text spans that are not focusable, not discoverable, and thus inaccessible. Orca now announces their presence and provides means to navigate to them and activate them. As a result, these formerly inaccessible elements are now accessible. This new feature was added during the 3.13/3.14 release cycle. And there was much rejoicing. Until From user testing, I've recently learned that certain sites, see Voice of America's learn english content as an example, makes pretty much EVERY word clickable so that (sighted, mouse-using) learners can click on a word and have that word's definition pop up. This unfortunately makes the content unreadable at Orca's verbose level of speech verbosity. (This clickable makes clickable the content clickable unreadable clickable at Orca clickable 's level clickable of speech clickable verbosity clickable .). :( Such sites indicate that it is no longer the case that there is a single verbosity level that should JustWork(tm) for the user. It needs to be toggle-able. I've made this change and committed it to master. I'd really (really, really, really) like to commit it to the 3.14 branch. Please and thank you. :) --joanie ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-14
The branch 'gnome-3-14' was created pointing to: a8d9eff... Updated Spanish Translation ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-12
The branch 'gnome-3-12' was created pointing to: a49b816... Post-release version bump ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Scheduling an IRC Foundation Meeting
Hey all. Now that 3.10 is out the door, ping? :) Thanks in advance for your time. --joanie On 08/21/2013 07:41 AM, Joanmarie Diggs wrote: Greetings, Release Team. One of the topics at our most recent Board meeting [1] was: * Scheduling an IRC Foundation meeting * At the Board QA the board promised to do a Foundation IRC meeting. * Needs an agenda and a date. Given the recent discussion about decision making and direction w.r.t. GNOME modules, we are considering including that topic on the agenda. We'd very much like your input, especially regarding how you all view your role with respect to this matter. We have not yet determined the date for the meeting, as we want to be sure you had plenty of time to discuss this issue amongst yourselves and also to choose a meeting date and time that suits your collective schedule, should this be a key agenda item. Thank you in advance for your time, and for all the work you do! --joanie, on behalf of the Board [1] https://mail.gnome.org/archives/foundation-list/2013-August/msg00056.html ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Orca code freeze break request (yeah, one more)
Greetings release team! I have been testing our shiny new gnome-software with Orca and filing bugs based on my findings for Matthias. Turns out one of the bugs was mine. (Oops). It's another one-line safe fix which causes Orca to present the presence of a necessary GtkButton so users know they can remove/install the selected item. If y'all would be so kind as to grant me a(nother) freeze break, I'd appreciate it. https://bugzilla.gnome.org/show_bug.cgi?id=708497 --joanie ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-8
The branch 'gnome-3-8' was created pointing to: ace8ad6... Updated Russian translation ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Orca: Code Freeze Break Request
Hey Release Team. I'm afraid a regression snuck into Orca. The impact is that when a braille user is using Orca's Flat Review feature and encounters a check box or radio button, Orca spits up. The bug, along with its three-line patch which was tested by the reporter: https://bugzilla.gnome.org/show_bug.cgi?id=696334 Thanks in advance! --joanie ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Is Python 3 migration a feature?
Hi Release Team. The other day at the Foundation irc meeting, Matthias mentioned to me that now would be a great time to set up a feature planning page for python3 migration. Before I do so, I wanted to double-check that this migration indeed qualifies as a feature. Currently it is a proposed-but-not-approved GNOME Goal [1]. From this branch [2] of my original thread [3] I am not seeing community-wide embracing or rejecting of the migration as part of the work targeted for 3.8. Since the community seems to lack a definitive opinion on this matter, perhaps this is an instance where the Release Team evaluates the feasibility of accomplishing this in time for 3.8, and if it is deemed feasible approves the Goal. Secondly, if this is a feature on top of a Goal, task owners are mandatory [4] for features. Who shall the owner be? (She says whistling innocently, looking around at others, and taking a giant step back.) ;) Since I have been one of the few more active proponents of getting this task done, I am willing to co-own it with Javier or some other Release Team member. But I don't see myself as qualified or having sufficient time to own this one alone. S As always, whatever you all decide is fine with me. Please let me know how you would like me to proceed. Thanks guys! --joanie [1] https://live.gnome.org/GnomeGoals/Python3Porting [2] https://mail.gnome.org/archives/desktop-devel-list/2012-July/msg00031.html [3] https://mail.gnome.org/archives/desktop-devel-list/2012-June/msg00056.html [4] https://live.gnome.org/ThreePointSeven/Features ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Is Python 3 migration a feature?
On 09/15/2012 01:09 PM, Matthias Clasen wrote: Hey Joanie, setting this up as a goal is fine; it is probably a better fit, in fact. I'm not too concerned whether we call it a goal or a feature. The point I wanted to get across that we should start planning and scoping it out now, so we have enough time to get it done for 3.8. Makes a lot of sense. So what is the next step? How exactly does a proposed Goal become an actual Goal? Take care. --joanie ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-6
The branch 'gnome-3-6' was created pointing to: 092b1d3... Fix for bug 677748 - Launcher icon needs 256x256 variant ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Another Orca code-freeze-break request
Hi Release Team. I'm afraid we have one more code-freeze-break to request. Alas, we are still catching the occasional post-introspection, post-Gtk3-migration bug. :-/ The proposed patch (below) is both a fix for bug 660163 along with a way to make bug 660099 far less painful for the user until we can properly sort out the latter bug out. Ale and I have both beaten on it quite a bit and feel it is sound. With apologies. --The Orca team From 85b90021d9275a1d51a86a8af8363d9eecd03f6d Mon Sep 17 00:00:00 2001 From: Alejandro Leiva ale...@emergya.es Date: Mon, 26 Sep 2011 20:40:49 +0200 Subject: [PATCH] Fix for #660163 - Traceback when try to edit a keybinding. --- src/orca/keybindings.py |5 - src/orca/orca.py|9 - 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/orca/keybindings.py b/src/orca/keybindings.py index 3bbc438..7d4d63c 100644 --- a/src/orca/keybindings.py +++ b/src/orca/keybindings.py @@ -73,7 +73,10 @@ def getAllKeysyms(keysym): # we are looking for. # if keycode != 0: -success, entries = keymap.get_entries_for_keycode(keycode) +entries_for_keycode = keymap.get_entries_for_keycode(keycode) +success = entries_for_keycode[0] +entries = entries_for_keycode[1] + for entry in entries: keyval = entry[0] name = Gdk.keyval_name(keyval) diff --git a/src/orca/orca.py b/src/orca/orca.py index 05033fb..ecd57cd 100644 --- a/src/orca/orca.py +++ b/src/orca/orca.py @@ -1150,8 +1150,15 @@ def _processKeyCaptured(event): # character. (i.e. 1 instead of !) # keymap = Gdk.Keymap.get_default() -success, entries = keymap.get_entries_for_keycode(event.hw_code) +entries_for_keycode = keymap.get_entries_for_keycode(event.hw_code) +success = entries_for_keycode[0] +entries = entries_for_keycode[1] event.event_string = Gdk.keyval_name(entries[0].keycode) + +if not event.event_string: +orca_state.capturingKeys = False +return False + if event.event_string.startswith(KP) and \ event.event_string != KP_Enter: name = Gdk.keyval_name(entries[1].keycode) -- 1.7.6.2 ___ release-team@gnome.org http://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[orca] Created branch gnome-3-2
The branch 'gnome-3-2' was created pointing to: 7f6755d... Fix for bug 660091 - Unbound alternative keybindings in use ___ release-team@gnome.org http://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Approved GUI Freeze break change committed to Orca
Hi folks. Having received the two requisite approvals from the Release Team, I have just committed a small change/correction to Orca's Preferences dialog. The details can be found here: https://bugzilla.gnome.org/show_bug.cgi?id=658993 My apologies for any inconvenience. Take care. --joanie ___ release-team@gnome.org http://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
