Re: Second Epiphany freeze break request
On , mcatanz...@gnome.org wrote: On Thu, Sep 5, 2019 at 6:14 PM, Javier Jardón wrote: One approval for you Any seconds? I thought I sent mine, but it seems I left it in the drafts. 2/2 approval. Ciao, Emmanuele. ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Second Epiphany freeze break request
On Thu, Sep 5, 2019 at 6:14 PM, Javier Jardón wrote: One approval for you Any seconds? ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Third Epiphany freeze break request
On , Andre Klapper wrote: On Fri, 2019-09-06 at 08:41 -0500, mcatanz...@gnome.org wrote: Adrian found an integer underflow that breaks the adblocker in incognito mode: https://gitlab.gnome.org/GNOME/epiphany/merge_requests/423/diffs Would be great to have another freeze exception to fix this. r-t approval 1 of 2. And 2/2. Ciao, Emmanuele. ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Third Epiphany freeze break request
On Fri, 2019-09-06 at 08:41 -0500, mcatanz...@gnome.org wrote: > Adrian found an integer underflow that breaks the adblocker in > incognito mode: > > https://gitlab.gnome.org/GNOME/epiphany/merge_requests/423/diffs > > Would be great to have another freeze exception to fix this. r-t approval 1 of 2. andre -- Andre Klapper | ak...@gmx.net https://blogs.gnome.org/aklapper/ ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Third Epiphany freeze break request
Hi, Adrian found an integer underflow that breaks the adblocker in incognito mode: https://gitlab.gnome.org/GNOME/epiphany/merge_requests/423/diffs Would be great to have another freeze exception to fix this. Michael ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Second Epiphany freeze break request
One approval for you On Thu, 5 Sep 2019, 21:22 , wrote: > Hi, > > Due to some changes in WebKit, some code that could previously be > reached only once is now run multiple times. So Epiphany needs to be > more careful about not doing one-time things there, like connecting to > signals. > > This commit: > > https://gitlab.gnome.org/GNOME/epiphany/merge_requests/421/diffs > > just moves the signal connections to a safer place. > > Michael > > > ___ > release-team@gnome.org > https://mail.gnome.org/mailman/listinfo/release-team > Release-team lurker? Do NOT participate in discussions. > ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Second Epiphany freeze break request
Hi, Due to some changes in WebKit, some code that could previously be reached only once is now run multiple times. So Epiphany needs to be more careful about not doing one-time things there, like connecting to signals. This commit: https://gitlab.gnome.org/GNOME/epiphany/merge_requests/421/diffs just moves the signal connections to a safer place. Michael ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany freeze break request: incognito mode tab style
Hi, Le mer. 13 févr. 2019 à 21:49, a écrit : > On Mon, Feb 11, 2019 at 3:44 AM, Javier Jardón > wrote: > > Thanks for the screenshots > > > > 1/2 for release team > > Anyone else? 2/2 for release team. ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany Freeze Break request
Hi, Le jeu. 14 févr. 2019 à 14:52, Alexander via release-team a écrit : > On Wed, 13 Feb 2019, 20:59 Alexander via release-team wrote: >> >> Hi, >> >> I would like to ask for a freeze break request to improve navigation >> gestures in Epiphany by using gesture from WebKit instead of a custom >> implementation. >> >> The MR[1] removes custom gesture implementation, toggles WebKit settings >> property to enable the gesture, and adds it to shortcuts dialog. Finally, it >> reduces shortcuts dialog height because of the added gesture, going from [2] >> to [3]. >> >> The MR introduces no new strings. >> >> The feature has not been introduced before because the corresponding WebKit >> release (2.23.90) is not yet out as of the time of writing. > > > If the webkitgtk release is now available, 1/2 for release team 2/2 for release team. But please wait until WebKit 2.23.90 is merged in gnome-build-meta [1] before merging. Abderrahim [1] https://gitlab.gnome.org/GNOME/gnome-build-meta/merge_requests/223 ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany Freeze Break request
Err, I didn't reply to the mailing list itself accidentally. :( It wasn't released at the time of the reply, but it is now[1] [1] https://lists.webkit.org/pipermail/webkit-gtk/2019-February/003457.html On Thu, Feb 14, 2019 at 2:07 PM, Javier Jardón wrote: On Wed, 13 Feb 2019, 20:59 Alexander via release-team Hi, I would like to ask for a freeze break request to improve navigation gestures in Epiphany by using gesture from WebKit instead of a custom implementation. The MR[1] removes custom gesture implementation, toggles WebKit settings property to enable the gesture, and adds it to shortcuts dialog. Finally, it reduces shortcuts dialog height because of the added gesture, going from [2] to [3]. The MR introduces no new strings. The feature has not been introduced before because the corresponding WebKit release (2.23.90) is not yet out as of the time of writing. If the webkitgtk release is now available, 1/2 for release team Cheers, Javier ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany Freeze Break request
On Wed, 13 Feb 2019, 20:59 Alexander via release-team < release-team@gnome.org wrote: > Hi, > > I would like to ask for a freeze break request to improve navigation > gestures in Epiphany by using gesture from WebKit instead of a custom > implementation. > > The MR[1] removes custom gesture implementation, toggles WebKit settings > property to enable the gesture, and adds it to shortcuts dialog. Finally, > it reduces shortcuts dialog height because of the added gesture, going from > [2] to [3]. > > The MR introduces no new strings. > > The feature has not been introduced before because the corresponding > WebKit release (2.23.90) is not yet out as of the time of writing. > If the webkitgtk release is now available, 1/2 for release team Cheers, Javier ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Epiphany Freeze Break request
Hi, I would like to ask for a freeze break request to improve navigation gestures in Epiphany by using gesture from WebKit instead of a custom implementation. The MR[1] removes custom gesture implementation, toggles WebKit settings property to enable the gesture, and adds it to shortcuts dialog. Finally, it reduces shortcuts dialog height because of the added gesture, going from [2] to [3]. The MR introduces no new strings. The feature has not been introduced before because the corresponding WebKit release (2.23.90) is not yet out as of the time of writing. [1] https://gitlab.gnome.org/GNOME/epiphany/merge_requests/183 [2] https://imgur.com/a/gYeITyQ [3] https://imgur.com/a/QvWEv46 ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany freeze break request: incognito mode tab style
On Mon, Feb 11, 2019 at 3:44 AM, Javier Jardón wrote: Thanks for the screenshots 1/2 for release team Anyone else? Feels like cheating to give the second approval myself. Michael ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany freeze break request: incognito mode tab style
On Sun, 10 Feb 2019 at 22:56, Michael Catanzaro wrote: > > Hi, > > I'd like to request a UI freeze break for Epiphany's tab bar. In > incognito mode, they tabs are currently gray, but this doesn't look > good with the new version of Adwaita. We've changed the tab bar to be > blue in master. This request is to backport the change to 3.32. > > Before: > https://gitlab.gnome.org/GNOME/epiphany/merge_requests/184#note_433819 > > After: https://gitlab.gnome.org/GNOME/epiphany/merge_requests/184 > (first comment) Thanks for the screenshots 1/2 for release team Cheers, Javier ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Epiphany freeze break request: incognito mode tab style
Hi, I'd like to request a UI freeze break for Epiphany's tab bar. In incognito mode, they tabs are currently gray, but this doesn't look good with the new version of Adwaita. We've changed the tab bar to be blue in master. This request is to backport the change to 3.32. Before: https://gitlab.gnome.org/GNOME/epiphany/merge_requests/184#note_433819 After: https://gitlab.gnome.org/GNOME/epiphany/merge_requests/184 (first comment) Thanks, Michael ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Another Epiphany freeze break request
I must say that the commit you want to revert doesn't make sense to me anyway - in my opinion, a search provider should launch the application it belongs to, nothing else. So, +1 for the release team from me for reverting it. ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Another Epiphany freeze break request
Matthias Clasen wrote: I must say that the commit you want to revert doesn't make sense to me anyway - in my opinion, a search provider should launch the application it belongs to, nothing else. So, +1 for the release team from me for reverting it. yeah, 2 of 2. Fred ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Epiphany freeze break request
Hi, I'd like to commit two simple patches that change the UI before 3.6: - https://bugzilla.gnome.org/show_bug.cgi?id=683966 Changes the close button in the downloads bar to use symbolic style icons, trivial. Design Team is OK with it. - https://bugzilla.gnome.org/show_bug.cgi?id=683967 Adds a close button to the find bar, which didn't have any (annoying). Design Team is OK with it. Cheers, Xan ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany freeze break request
On Thu, Sep 13, 2012 at 12:15 PM, Xan Lopez x...@gnome.org wro Hi, I'd like to commit two simple patches that change the UI before 3.6: - https://bugzilla.gnome.org/show_bug.cgi?id=683966 Changes the close button in the downloads bar to use symbolic style icons, trivial. Design Team is OK with it. - https://bugzilla.gnome.org/show_bug.cgi?id=683967 Adds a close button to the find bar, which didn't have any (annoying). Design Team is OK with it. Both of these look fine to me. +1 for the release team. ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany freeze break request
On 14 September 2012 01:29, Matthias Clasen matthias.cla...@gmail.com wrote: On Thu, Sep 13, 2012 at 12:15 PM, Xan Lopez x...@gnome.org wro Hi, I'd like to commit two simple patches that change the UI before 3.6: - https://bugzilla.gnome.org/show_bug.cgi?id=683966 Changes the close button in the downloads bar to use symbolic style icons, trivial. Design Team is OK with it. - https://bugzilla.gnome.org/show_bug.cgi?id=683967 Adds a close button to the find bar, which didn't have any (annoying). Design Team is OK with it. Both of these look fine to me. +1 for the release team. Both patches are small and fix an important visual issue 2/2 for r-t -- Javier Jardón Cabezas ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany freeze break request
On Fri, 2012-03-02 at 01:07 +0100, Xan Lopez wrote: On Thu, Mar 1, 2012 at 10:23 AM, Frederic Peters fpet...@gnome.org wrote: About translation work, I guess there not many new strings? There should not be any new string. In that case approval 2 of 2 from release-team. I don't expect that documentation team input is needed as 1) the Epiphany user documentation is extremely outdated (last commit in 2009, see http://git.gnome.org/browse/epiphany/log/help/C ), and 2) as http://git.gnome.org/browse/gnome-user-docs/tree/gnome-help/C/figures/ does not include any pictures that show Epiphany. andre -- mailto:ak...@gmx.net | failed http://blogs.gnome.org/aklapper ___ release-team@gnome.org http://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Epiphany freeze break request
Hi, We are at last finishing up the long-in-the-works rewrite of the epiphany history backend (see http://git.gnome.org/browse/epiphany/log/?h=history-rewrite-second). This will make epiphany able to store history indefinitely, make searching epiphany's history faster in general and fix a number of bugs along the way. So here's where we are standing right now: - The backend has been done for some time now, full with tests and migration code for the old format. - The URL completion in the entry is now working. - We are finishing the history viewer window, should be done by this week. There are almost no UI changes (small tweaks in the completion list, mostly changes in order and getting rid of duplicates that used to show up), but this is a big change, so it comes with some risk. What we would like is: - Land this ASAP. - Test it thoroughly before 3.4, of course. - Use the 3.4 feedback to fix any bugs we might have introduced. - By 3.4.x users should not notice anything but increased responsiveness and the ability to store their history forever. - For 3.6 we'll do bigger changes, like showing recent history in the overview, and possibly and all-new detailed history view. With all that being said, I'm formally requesting to break the freeze and land this in time for 3.3.91. Thanks, Xan ___ release-team@gnome.org http://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany freeze break request
Xan Lopez wrote: With all that being said, I'm formally requesting to break the freeze and land this in time for 3.3.91. The UI changes are really minor, and I will help in making sure this is solid before 3.4.0, so +1 from my side. About translation work, I guess there not many new strings? Fred ___ release-team@gnome.org http://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Epiphany freeze break request
On Thu, Mar 1, 2012 at 10:23 AM, Frederic Peters fpet...@gnome.org wrote: About translation work, I guess there not many new strings? There should not be any new string. Xan ___ release-team@gnome.org http://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
