Re: [akonadi/Applications/19.04] src/core: Fix a regression when updating attributes

2019-03-22 Thread Daniel Vrátil
Sorry for the delay. It is OK to do a release, the fix is a hack, but it will 
do for 19.04. Proper fix is more invasive, so we will do it on master for 
19.08.

Dan

On Thursday, March 21, 2019 6:13:09 PM CET Christoph Feck wrote:
> On 03/21/19 15:51, Daniel Vrátil wrote:
> > On Thursday, March 21, 2019 2:06:09 PM CET David Faure wrote:
> >> I'll look at the const fixing that you suggest so that we can do this
> >> properly.
> > 
> > I have a patch for Akonadi itself, I'll put it on Phab. Before applying
> > tat we need to fix all components that use this API otherwise it won't
> > build.
> Does this mean we cannot create tarballs today from the 19.04 branch for
> the beta release?
> 
> https://community.kde.org/Schedules/Applications/19.04_Release_Schedule
> 
> Please reply to release-team if additional time is needed.


-- 
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

signature.asc
Description: This is a digitally signed message part.


Re: [akonadi/Applications/19.04] src/core: Fix a regression when updating attributes

2019-03-21 Thread Daniel Vrátil
You can release. The fix is a bit of a hack, but it will do for 19.04 just 
fine. Proper fix requires touching almost all PIM components and can wait till 
19.08.

Dan

On Thursday, 21 March 2019, Christoph Feck wrote:
> On 03/21/19 15:51, Daniel Vrátil wrote:
> > On Thursday, March 21, 2019 2:06:09 PM CET David Faure wrote:
> >> I'll look at the const fixing that you suggest so that we can do this
> >> properly.
> >
> > I have a patch for Akonadi itself, I'll put it on Phab. Before applying tat 
> > we
> > need to fix all components that use this API otherwise it won't build.
> 
> Does this mean we cannot create tarballs today from the 19.04 branch for 
> the beta release?
> 
> https://community.kde.org/Schedules/Applications/19.04_Release_Schedule
> 
> Please reply to release-team if additional time is needed.
> 
> -- 
> Christoph Feck
> KDE Release Team
> 
>

-- 
Sent from my Sailfish device

Re: [akonadi/Applications/19.04] src/core: Fix a regression when updating attributes

2019-03-21 Thread Christoph Feck

On 03/21/19 15:51, Daniel Vrátil wrote:

On Thursday, March 21, 2019 2:06:09 PM CET David Faure wrote:

I'll look at the const fixing that you suggest so that we can do this
properly.


I have a patch for Akonadi itself, I'll put it on Phab. Before applying tat we
need to fix all components that use this API otherwise it won't build.


Does this mean we cannot create tarballs today from the 19.04 branch for 
the beta release?


https://community.kde.org/Schedules/Applications/19.04_Release_Schedule

Please reply to release-team if additional time is needed.

--
Christoph Feck
KDE Release Team