Re: KDE Frameworks 5.94.0

2022-05-21 Thread Albert Astals Cid
El dissabte, 21 de maig de 2022, a les 12:02:29 (CEST), Ben Cooksley va 
escriure:
> On Sat, May 21, 2022 at 8:38 PM Albert Astals Cid  wrote:
> 
> > El dimarts, 17 de maig de 2022, a les 8:53:16 (CEST), Ben Cooksley va
> > escriure:
> > > On Tue, May 17, 2022 at 10:10 AM Albert Astals Cid 
> > wrote:
> > >
> > > > El dilluns, 16 de maig de 2022, a les 11:50:13 (CEST), Ben Cooksley va
> > > > escriure:
> > > > > On Mon, May 16, 2022 at 9:39 AM Albert Astals Cid 
> > wrote:
> > > > >
> > > > > > El diumenge, 15 de maig de 2022, a les 23:03:27 (CEST), David
> > Faure va
> > > > > > escriure:
> > > > > > > On samedi 14 mai 2022 20:48:55 CEST Albert Astals Cid wrote:
> > > > > > > > El diumenge, 8 de maig de 2022, a les 0:11:35 (CEST), David
> > Faure
> > > > va
> > > > > > escriure:
> > > > > > > > > On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> > > > > > > > > > El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure
> > > > escribió:
> > > > > > > > > > > Dear packagers,
> > > > > > > > > > >
> > > > > > > > > > > KDE Frameworks 5.94.0 has been uploaded to the usual
> > place.
> > > > > > > > > > >
> > > > > > > > > > > New frameworks: none this time.
> > > > > > > > > >
> > > > > > > > > > This should have been a reply to this mail of course
> > > > > > > > > >
> > > > > > > > > > >  tr tt ug uk and uz translations are missing from all
> > > > tarballs.
> > > > > > > > >
> > > > > > > > > Thanks for noticing. My "update l10n" script did show an
> > error
> > > > about
> > > > > > that
> > > > > > > > > but I didn't see that error and moved on. I have now improved
> > > > things
> > > > > > so I
> > > > > > > > > can't launch the next step if this step failed.
> > > > > > > > >
> > > > > > > > > I now uploaded new tarballs (also including
> > > > > > > > > https://invent.kde.org/frameworks/
> > > > > > plasma-framework/-/merge_requests/523)
> > > > > > > > >
> > > > > > > > > I hope it's all fine now, let me know otherwise.
> > > > > > > >
> > > > > > > > I've just realized that the packages dependencies have not been
> > > > > > increased to
> > > > > > > > 5.94 and they are just at 5.93. I guess that's not that bad,
> > but
> > > > just
> > > > > > want
> > > > > > > > to make sure that doesn't mean some other change may be also
> > > > missing?
> > > > > > >
> > > > > > > Good catch. Fortunately nothing else should be missing. The
> > reason
> > > > this
> > > > > > didn't happen is that I run
> > > > > > >
> > > > > > > cd ../src && ./kdesrc-build --src-only && cd ../release-tools &&
> > > > > > ./list_frameworks.sh && ./update_l10n.sh &&
> > > > > > ./increase_frameworks_version.sh step2
> > > > > > >
> > > > > > > and update_l10n failed because anonsvn threw me out in the
> > middle of
> > > > it.
> > > > > > > I didn't notice, ran the next step (./make_rc_tag.sh) and this is
> > > > how we
> > > > > > got tags with missing languages.
> > > > > > > Then I fixed l10n and tagged again, completely missing that
> > > > > > "increase_frameworks_version.sh step2" was never done.
> > > > > > >
> > > > > > > Sigh, I wish svn.kde.org would work for the way we're using it
> > at
> > > > > > release time.
> > > > > >
> > > > > > One thing we may try is moving Frameworks to the "po injection"
> > test
> > > > group.
> > > > > >
> > > > > > "po injection" = scripty commits po files back to git
> > > > > >
> > > > > > Plasma Mobile Gear has been using it and as far as I understand it
> > is
> > > > > > working relatively well.
> > > > > >
> > > > > > Example:
> > > > > > https://invent.kde.org/plasma-mobile/alligator/-/commits/master/po
> > > > > >
> > > > > > This way you can remove any special handling of l10n altogether
> > from
> > > > the
> > > > > > KDE Frameworks release scripts
> > > > > >
> > > > >
> > > > > Is there any particular reason why we can't rollout po injection to
> > all
> > > > > repositories?
> > > >
> > > > We need to adapt the release scripts not to fetch l10n, we also have
> > > > various release scripts that inject ki18n_install/kdoctools_install
> > when
> > > > they do the fecth, so we need to properly add those calls to the root
> > > > CMakeLists.txt
> > >
> > >
> > > > Not a huge blocker, but it needs to be decided that we should do it and
> > > > then do it.
> > > >
> > >
> > > Given the number of benefits it has to release managers (no more tooling
> > > needed to download translations and integrate them), as well as build
> > > processes for nightly builds and for builds on developer systems I think
> > > we've a fairly compelling reason to switch it on globally.
> >
> > I am not disagreeing and that's always been the plan, but someone needs to
> > do the work for that to be possible :)
> >
> > I can only do so much, so help always welcome :)
> >
> 
> What sort of work is required here?

Copy and pasting from two messages ago in the thread

"
We need to adapt the release scripts not to fetch l10n, we also have various 
release scripts that inject 

Re: KDE Frameworks 5.94.0

2022-05-21 Thread Ben Cooksley
On Sat, May 21, 2022 at 8:38 PM Albert Astals Cid  wrote:

> El dimarts, 17 de maig de 2022, a les 8:53:16 (CEST), Ben Cooksley va
> escriure:
> > On Tue, May 17, 2022 at 10:10 AM Albert Astals Cid 
> wrote:
> >
> > > El dilluns, 16 de maig de 2022, a les 11:50:13 (CEST), Ben Cooksley va
> > > escriure:
> > > > On Mon, May 16, 2022 at 9:39 AM Albert Astals Cid 
> wrote:
> > > >
> > > > > El diumenge, 15 de maig de 2022, a les 23:03:27 (CEST), David
> Faure va
> > > > > escriure:
> > > > > > On samedi 14 mai 2022 20:48:55 CEST Albert Astals Cid wrote:
> > > > > > > El diumenge, 8 de maig de 2022, a les 0:11:35 (CEST), David
> Faure
> > > va
> > > > > escriure:
> > > > > > > > On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> > > > > > > > > El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure
> > > escribió:
> > > > > > > > > > Dear packagers,
> > > > > > > > > >
> > > > > > > > > > KDE Frameworks 5.94.0 has been uploaded to the usual
> place.
> > > > > > > > > >
> > > > > > > > > > New frameworks: none this time.
> > > > > > > > >
> > > > > > > > > This should have been a reply to this mail of course
> > > > > > > > >
> > > > > > > > > >  tr tt ug uk and uz translations are missing from all
> > > tarballs.
> > > > > > > >
> > > > > > > > Thanks for noticing. My "update l10n" script did show an
> error
> > > about
> > > > > that
> > > > > > > > but I didn't see that error and moved on. I have now improved
> > > things
> > > > > so I
> > > > > > > > can't launch the next step if this step failed.
> > > > > > > >
> > > > > > > > I now uploaded new tarballs (also including
> > > > > > > > https://invent.kde.org/frameworks/
> > > > > plasma-framework/-/merge_requests/523)
> > > > > > > >
> > > > > > > > I hope it's all fine now, let me know otherwise.
> > > > > > >
> > > > > > > I've just realized that the packages dependencies have not been
> > > > > increased to
> > > > > > > 5.94 and they are just at 5.93. I guess that's not that bad,
> but
> > > just
> > > > > want
> > > > > > > to make sure that doesn't mean some other change may be also
> > > missing?
> > > > > >
> > > > > > Good catch. Fortunately nothing else should be missing. The
> reason
> > > this
> > > > > didn't happen is that I run
> > > > > >
> > > > > > cd ../src && ./kdesrc-build --src-only && cd ../release-tools &&
> > > > > ./list_frameworks.sh && ./update_l10n.sh &&
> > > > > ./increase_frameworks_version.sh step2
> > > > > >
> > > > > > and update_l10n failed because anonsvn threw me out in the
> middle of
> > > it.
> > > > > > I didn't notice, ran the next step (./make_rc_tag.sh) and this is
> > > how we
> > > > > got tags with missing languages.
> > > > > > Then I fixed l10n and tagged again, completely missing that
> > > > > "increase_frameworks_version.sh step2" was never done.
> > > > > >
> > > > > > Sigh, I wish svn.kde.org would work for the way we're using it
> at
> > > > > release time.
> > > > >
> > > > > One thing we may try is moving Frameworks to the "po injection"
> test
> > > group.
> > > > >
> > > > > "po injection" = scripty commits po files back to git
> > > > >
> > > > > Plasma Mobile Gear has been using it and as far as I understand it
> is
> > > > > working relatively well.
> > > > >
> > > > > Example:
> > > > > https://invent.kde.org/plasma-mobile/alligator/-/commits/master/po
> > > > >
> > > > > This way you can remove any special handling of l10n altogether
> from
> > > the
> > > > > KDE Frameworks release scripts
> > > > >
> > > >
> > > > Is there any particular reason why we can't rollout po injection to
> all
> > > > repositories?
> > >
> > > We need to adapt the release scripts not to fetch l10n, we also have
> > > various release scripts that inject ki18n_install/kdoctools_install
> when
> > > they do the fecth, so we need to properly add those calls to the root
> > > CMakeLists.txt
> >
> >
> > > Not a huge blocker, but it needs to be decided that we should do it and
> > > then do it.
> > >
> >
> > Given the number of benefits it has to release managers (no more tooling
> > needed to download translations and integrate them), as well as build
> > processes for nightly builds and for builds on developer systems I think
> > we've a fairly compelling reason to switch it on globally.
>
> I am not disagreeing and that's always been the plan, but someone needs to
> do the work for that to be possible :)
>
> I can only do so much, so help always welcome :)
>

What sort of work is required here?

My understanding is everything on the scripty/infrastructure side is in
place?


>
> Cheers,
>   Albert
>

Thanks,
Ben


>
> > It will also
> > ensure good CI coverage of the CMake files which should stop issues
> around
> > ki18n_install macros which have happened a few times.
> >
> > It'll also reduce the load on Leptone (the server for invent.kde.org and
> > svn.kde.org) at release time.
> >
> > Cheers,
> > Ben
> >
> >
> > >
> > > Cheers,
> > >   Albert
> > >
> > > >
> > > >
> > > > >
> > > > > Cheers,
> > > > 

Re: KDE Frameworks 5.94.0

2022-05-21 Thread Albert Astals Cid
El dimarts, 17 de maig de 2022, a les 8:53:16 (CEST), Ben Cooksley va escriure:
> On Tue, May 17, 2022 at 10:10 AM Albert Astals Cid  wrote:
> 
> > El dilluns, 16 de maig de 2022, a les 11:50:13 (CEST), Ben Cooksley va
> > escriure:
> > > On Mon, May 16, 2022 at 9:39 AM Albert Astals Cid  wrote:
> > >
> > > > El diumenge, 15 de maig de 2022, a les 23:03:27 (CEST), David Faure va
> > > > escriure:
> > > > > On samedi 14 mai 2022 20:48:55 CEST Albert Astals Cid wrote:
> > > > > > El diumenge, 8 de maig de 2022, a les 0:11:35 (CEST), David Faure
> > va
> > > > escriure:
> > > > > > > On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> > > > > > > > El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure
> > escribió:
> > > > > > > > > Dear packagers,
> > > > > > > > >
> > > > > > > > > KDE Frameworks 5.94.0 has been uploaded to the usual place.
> > > > > > > > >
> > > > > > > > > New frameworks: none this time.
> > > > > > > >
> > > > > > > > This should have been a reply to this mail of course
> > > > > > > >
> > > > > > > > >  tr tt ug uk and uz translations are missing from all
> > tarballs.
> > > > > > >
> > > > > > > Thanks for noticing. My "update l10n" script did show an error
> > about
> > > > that
> > > > > > > but I didn't see that error and moved on. I have now improved
> > things
> > > > so I
> > > > > > > can't launch the next step if this step failed.
> > > > > > >
> > > > > > > I now uploaded new tarballs (also including
> > > > > > > https://invent.kde.org/frameworks/
> > > > plasma-framework/-/merge_requests/523)
> > > > > > >
> > > > > > > I hope it's all fine now, let me know otherwise.
> > > > > >
> > > > > > I've just realized that the packages dependencies have not been
> > > > increased to
> > > > > > 5.94 and they are just at 5.93. I guess that's not that bad, but
> > just
> > > > want
> > > > > > to make sure that doesn't mean some other change may be also
> > missing?
> > > > >
> > > > > Good catch. Fortunately nothing else should be missing. The reason
> > this
> > > > didn't happen is that I run
> > > > >
> > > > > cd ../src && ./kdesrc-build --src-only && cd ../release-tools &&
> > > > ./list_frameworks.sh && ./update_l10n.sh &&
> > > > ./increase_frameworks_version.sh step2
> > > > >
> > > > > and update_l10n failed because anonsvn threw me out in the middle of
> > it.
> > > > > I didn't notice, ran the next step (./make_rc_tag.sh) and this is
> > how we
> > > > got tags with missing languages.
> > > > > Then I fixed l10n and tagged again, completely missing that
> > > > "increase_frameworks_version.sh step2" was never done.
> > > > >
> > > > > Sigh, I wish svn.kde.org would work for the way we're using it at
> > > > release time.
> > > >
> > > > One thing we may try is moving Frameworks to the "po injection" test
> > group.
> > > >
> > > > "po injection" = scripty commits po files back to git
> > > >
> > > > Plasma Mobile Gear has been using it and as far as I understand it is
> > > > working relatively well.
> > > >
> > > > Example:
> > > > https://invent.kde.org/plasma-mobile/alligator/-/commits/master/po
> > > >
> > > > This way you can remove any special handling of l10n altogether from
> > the
> > > > KDE Frameworks release scripts
> > > >
> > >
> > > Is there any particular reason why we can't rollout po injection to all
> > > repositories?
> >
> > We need to adapt the release scripts not to fetch l10n, we also have
> > various release scripts that inject ki18n_install/kdoctools_install when
> > they do the fecth, so we need to properly add those calls to the root
> > CMakeLists.txt
> 
> 
> > Not a huge blocker, but it needs to be decided that we should do it and
> > then do it.
> >
> 
> Given the number of benefits it has to release managers (no more tooling
> needed to download translations and integrate them), as well as build
> processes for nightly builds and for builds on developer systems I think
> we've a fairly compelling reason to switch it on globally. 

I am not disagreeing and that's always been the plan, but someone needs to do 
the work for that to be possible :)

I can only do so much, so help always welcome :)

Cheers,
  Albert

> It will also
> ensure good CI coverage of the CMake files which should stop issues around
> ki18n_install macros which have happened a few times.
> 
> It'll also reduce the load on Leptone (the server for invent.kde.org and
> svn.kde.org) at release time.
> 
> Cheers,
> Ben
> 
> 
> >
> > Cheers,
> >   Albert
> >
> > >
> > >
> > > >
> > > > Cheers,
> > > >   Albert
> > > >
> > >
> > > Cheers,
> > > Ben
> > >
> > >
> > > >
> > > > >
> > > > > I have now added more error checking, including at the beginning of
> > > > make_rc_tag.sh,
> > > > > as well as a reminder to run "step2" after fixing the l10n problems.
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> >
> >
> >
> >
> >
> 






Re: KDE Frameworks 5.94.0

2022-05-19 Thread David Faure
Yes you need to update `plasma-wayland-protocols` to the latest release.

Cheers,
David.

On jeudi 19 mai 2022 16:38:07 CEST Bernhard Rosenkraenzer wrote:
> Hi,
> finally getting around to updating this...
> 
> kwayland fails to build here.
> 
> /media/space/repos/kde-packaging-tools/kwayland/BUILD/kwayland-5.94.0/src/cl
> ient/plasmashell.cpp:244:5: error: use of undeclared identifier
> 'org_kde_plasma_surface_open_under_cursor'; did you mean
> 'org_kde_plasma_surface_get_user_data'?
> 
> Everything else looks good.
> 
> Has anyone else run into this? Probably some dependency is not at the
> version 5.94 expects.
> 
> ttyl
> bero
> 
> On Saturday, May 07, 2022 15:31 CEST, David Faure  wrote:
> > Dear packagers,
> > 
> > KDE Frameworks 5.94.0 has been uploaded to the usual place.
> > 
> > New frameworks: none this time.
> > 
> > Public release next Saturday.
> > 
> > Thanks for the packaging work!


-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5





Re: KDE Frameworks 5.94.0

2022-05-17 Thread Ben Cooksley
On Tue, May 17, 2022 at 10:10 AM Albert Astals Cid  wrote:

> El dilluns, 16 de maig de 2022, a les 11:50:13 (CEST), Ben Cooksley va
> escriure:
> > On Mon, May 16, 2022 at 9:39 AM Albert Astals Cid  wrote:
> >
> > > El diumenge, 15 de maig de 2022, a les 23:03:27 (CEST), David Faure va
> > > escriure:
> > > > On samedi 14 mai 2022 20:48:55 CEST Albert Astals Cid wrote:
> > > > > El diumenge, 8 de maig de 2022, a les 0:11:35 (CEST), David Faure
> va
> > > escriure:
> > > > > > On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> > > > > > > El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure
> escribió:
> > > > > > > > Dear packagers,
> > > > > > > >
> > > > > > > > KDE Frameworks 5.94.0 has been uploaded to the usual place.
> > > > > > > >
> > > > > > > > New frameworks: none this time.
> > > > > > >
> > > > > > > This should have been a reply to this mail of course
> > > > > > >
> > > > > > > >  tr tt ug uk and uz translations are missing from all
> tarballs.
> > > > > >
> > > > > > Thanks for noticing. My "update l10n" script did show an error
> about
> > > that
> > > > > > but I didn't see that error and moved on. I have now improved
> things
> > > so I
> > > > > > can't launch the next step if this step failed.
> > > > > >
> > > > > > I now uploaded new tarballs (also including
> > > > > > https://invent.kde.org/frameworks/
> > > plasma-framework/-/merge_requests/523)
> > > > > >
> > > > > > I hope it's all fine now, let me know otherwise.
> > > > >
> > > > > I've just realized that the packages dependencies have not been
> > > increased to
> > > > > 5.94 and they are just at 5.93. I guess that's not that bad, but
> just
> > > want
> > > > > to make sure that doesn't mean some other change may be also
> missing?
> > > >
> > > > Good catch. Fortunately nothing else should be missing. The reason
> this
> > > didn't happen is that I run
> > > >
> > > > cd ../src && ./kdesrc-build --src-only && cd ../release-tools &&
> > > ./list_frameworks.sh && ./update_l10n.sh &&
> > > ./increase_frameworks_version.sh step2
> > > >
> > > > and update_l10n failed because anonsvn threw me out in the middle of
> it.
> > > > I didn't notice, ran the next step (./make_rc_tag.sh) and this is
> how we
> > > got tags with missing languages.
> > > > Then I fixed l10n and tagged again, completely missing that
> > > "increase_frameworks_version.sh step2" was never done.
> > > >
> > > > Sigh, I wish svn.kde.org would work for the way we're using it at
> > > release time.
> > >
> > > One thing we may try is moving Frameworks to the "po injection" test
> group.
> > >
> > > "po injection" = scripty commits po files back to git
> > >
> > > Plasma Mobile Gear has been using it and as far as I understand it is
> > > working relatively well.
> > >
> > > Example:
> > > https://invent.kde.org/plasma-mobile/alligator/-/commits/master/po
> > >
> > > This way you can remove any special handling of l10n altogether from
> the
> > > KDE Frameworks release scripts
> > >
> >
> > Is there any particular reason why we can't rollout po injection to all
> > repositories?
>
> We need to adapt the release scripts not to fetch l10n, we also have
> various release scripts that inject ki18n_install/kdoctools_install when
> they do the fecth, so we need to properly add those calls to the root
> CMakeLists.txt


> Not a huge blocker, but it needs to be decided that we should do it and
> then do it.
>

Given the number of benefits it has to release managers (no more tooling
needed to download translations and integrate them), as well as build
processes for nightly builds and for builds on developer systems I think
we've a fairly compelling reason to switch it on globally. It will also
ensure good CI coverage of the CMake files which should stop issues around
ki18n_install macros which have happened a few times.

It'll also reduce the load on Leptone (the server for invent.kde.org and
svn.kde.org) at release time.

Cheers,
Ben


>
> Cheers,
>   Albert
>
> >
> >
> > >
> > > Cheers,
> > >   Albert
> > >
> >
> > Cheers,
> > Ben
> >
> >
> > >
> > > >
> > > > I have now added more error checking, including at the beginning of
> > > make_rc_tag.sh,
> > > > as well as a reminder to run "step2" after fixing the l10n problems.
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> >
>
>
>
>
>


Re: KDE Frameworks 5.94.0

2022-05-16 Thread Albert Astals Cid
El dilluns, 16 de maig de 2022, a les 11:50:13 (CEST), Ben Cooksley va escriure:
> On Mon, May 16, 2022 at 9:39 AM Albert Astals Cid  wrote:
> 
> > El diumenge, 15 de maig de 2022, a les 23:03:27 (CEST), David Faure va
> > escriure:
> > > On samedi 14 mai 2022 20:48:55 CEST Albert Astals Cid wrote:
> > > > El diumenge, 8 de maig de 2022, a les 0:11:35 (CEST), David Faure va
> > escriure:
> > > > > On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> > > > > > El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure escribió:
> > > > > > > Dear packagers,
> > > > > > >
> > > > > > > KDE Frameworks 5.94.0 has been uploaded to the usual place.
> > > > > > >
> > > > > > > New frameworks: none this time.
> > > > > >
> > > > > > This should have been a reply to this mail of course
> > > > > >
> > > > > > >  tr tt ug uk and uz translations are missing from all tarballs.
> > > > >
> > > > > Thanks for noticing. My "update l10n" script did show an error about
> > that
> > > > > but I didn't see that error and moved on. I have now improved things
> > so I
> > > > > can't launch the next step if this step failed.
> > > > >
> > > > > I now uploaded new tarballs (also including
> > > > > https://invent.kde.org/frameworks/
> > plasma-framework/-/merge_requests/523)
> > > > >
> > > > > I hope it's all fine now, let me know otherwise.
> > > >
> > > > I've just realized that the packages dependencies have not been
> > increased to
> > > > 5.94 and they are just at 5.93. I guess that's not that bad, but just
> > want
> > > > to make sure that doesn't mean some other change may be also missing?
> > >
> > > Good catch. Fortunately nothing else should be missing. The reason this
> > didn't happen is that I run
> > >
> > > cd ../src && ./kdesrc-build --src-only && cd ../release-tools &&
> > ./list_frameworks.sh && ./update_l10n.sh &&
> > ./increase_frameworks_version.sh step2
> > >
> > > and update_l10n failed because anonsvn threw me out in the middle of it.
> > > I didn't notice, ran the next step (./make_rc_tag.sh) and this is how we
> > got tags with missing languages.
> > > Then I fixed l10n and tagged again, completely missing that
> > "increase_frameworks_version.sh step2" was never done.
> > >
> > > Sigh, I wish svn.kde.org would work for the way we're using it at
> > release time.
> >
> > One thing we may try is moving Frameworks to the "po injection" test group.
> >
> > "po injection" = scripty commits po files back to git
> >
> > Plasma Mobile Gear has been using it and as far as I understand it is
> > working relatively well.
> >
> > Example:
> > https://invent.kde.org/plasma-mobile/alligator/-/commits/master/po
> >
> > This way you can remove any special handling of l10n altogether from the
> > KDE Frameworks release scripts
> >
> 
> Is there any particular reason why we can't rollout po injection to all
> repositories?

We need to adapt the release scripts not to fetch l10n, we also have various 
release scripts that inject ki18n_install/kdoctools_install when they do the 
fecth, so we need to properly add those calls to the root CMakeLists.txt

Not a huge blocker, but it needs to be decided that we should do it and then do 
it.

Cheers,
  Albert

> 
> 
> >
> > Cheers,
> >   Albert
> >
> 
> Cheers,
> Ben
> 
> 
> >
> > >
> > > I have now added more error checking, including at the beginning of
> > make_rc_tag.sh,
> > > as well as a reminder to run "step2" after fixing the l10n problems.
> > >
> > >
> >
> >
> >
> >
> >
> 






Re: KDE Frameworks 5.94.0

2022-05-16 Thread Ben Cooksley
On Mon, May 16, 2022 at 9:39 AM Albert Astals Cid  wrote:

> El diumenge, 15 de maig de 2022, a les 23:03:27 (CEST), David Faure va
> escriure:
> > On samedi 14 mai 2022 20:48:55 CEST Albert Astals Cid wrote:
> > > El diumenge, 8 de maig de 2022, a les 0:11:35 (CEST), David Faure va
> escriure:
> > > > On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> > > > > El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure escribió:
> > > > > > Dear packagers,
> > > > > >
> > > > > > KDE Frameworks 5.94.0 has been uploaded to the usual place.
> > > > > >
> > > > > > New frameworks: none this time.
> > > > >
> > > > > This should have been a reply to this mail of course
> > > > >
> > > > > >  tr tt ug uk and uz translations are missing from all tarballs.
> > > >
> > > > Thanks for noticing. My "update l10n" script did show an error about
> that
> > > > but I didn't see that error and moved on. I have now improved things
> so I
> > > > can't launch the next step if this step failed.
> > > >
> > > > I now uploaded new tarballs (also including
> > > > https://invent.kde.org/frameworks/
> plasma-framework/-/merge_requests/523)
> > > >
> > > > I hope it's all fine now, let me know otherwise.
> > >
> > > I've just realized that the packages dependencies have not been
> increased to
> > > 5.94 and they are just at 5.93. I guess that's not that bad, but just
> want
> > > to make sure that doesn't mean some other change may be also missing?
> >
> > Good catch. Fortunately nothing else should be missing. The reason this
> didn't happen is that I run
> >
> > cd ../src && ./kdesrc-build --src-only && cd ../release-tools &&
> ./list_frameworks.sh && ./update_l10n.sh &&
> ./increase_frameworks_version.sh step2
> >
> > and update_l10n failed because anonsvn threw me out in the middle of it.
> > I didn't notice, ran the next step (./make_rc_tag.sh) and this is how we
> got tags with missing languages.
> > Then I fixed l10n and tagged again, completely missing that
> "increase_frameworks_version.sh step2" was never done.
> >
> > Sigh, I wish svn.kde.org would work for the way we're using it at
> release time.
>
> One thing we may try is moving Frameworks to the "po injection" test group.
>
> "po injection" = scripty commits po files back to git
>
> Plasma Mobile Gear has been using it and as far as I understand it is
> working relatively well.
>
> Example:
> https://invent.kde.org/plasma-mobile/alligator/-/commits/master/po
>
> This way you can remove any special handling of l10n altogether from the
> KDE Frameworks release scripts
>

Is there any particular reason why we can't rollout po injection to all
repositories?


>
> Cheers,
>   Albert
>

Cheers,
Ben


>
> >
> > I have now added more error checking, including at the beginning of
> make_rc_tag.sh,
> > as well as a reminder to run "step2" after fixing the l10n problems.
> >
> >
>
>
>
>
>


Re: KDE Frameworks 5.94.0

2022-05-15 Thread Albert Astals Cid
El diumenge, 15 de maig de 2022, a les 23:03:27 (CEST), David Faure va escriure:
> On samedi 14 mai 2022 20:48:55 CEST Albert Astals Cid wrote:
> > El diumenge, 8 de maig de 2022, a les 0:11:35 (CEST), David Faure va 
> > escriure:
> > > On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> > > > El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure escribió:
> > > > > Dear packagers,
> > > > > 
> > > > > KDE Frameworks 5.94.0 has been uploaded to the usual place.
> > > > > 
> > > > > New frameworks: none this time.
> > > > 
> > > > This should have been a reply to this mail of course
> > > > 
> > > > >  tr tt ug uk and uz translations are missing from all tarballs.
> > > 
> > > Thanks for noticing. My "update l10n" script did show an error about that
> > > but I didn't see that error and moved on. I have now improved things so I
> > > can't launch the next step if this step failed.
> > > 
> > > I now uploaded new tarballs (also including
> > > https://invent.kde.org/frameworks/ plasma-framework/-/merge_requests/523)
> > > 
> > > I hope it's all fine now, let me know otherwise.
> > 
> > I've just realized that the packages dependencies have not been increased to
> > 5.94 and they are just at 5.93. I guess that's not that bad, but just want
> > to make sure that doesn't mean some other change may be also missing?
> 
> Good catch. Fortunately nothing else should be missing. The reason this 
> didn't happen is that I run
> 
> cd ../src && ./kdesrc-build --src-only && cd ../release-tools && 
> ./list_frameworks.sh && ./update_l10n.sh && ./increase_frameworks_version.sh 
> step2
> 
> and update_l10n failed because anonsvn threw me out in the middle of it.
> I didn't notice, ran the next step (./make_rc_tag.sh) and this is how we got 
> tags with missing languages.
> Then I fixed l10n and tagged again, completely missing that 
> "increase_frameworks_version.sh step2" was never done.
> 
> Sigh, I wish svn.kde.org would work for the way we're using it at release 
> time.

One thing we may try is moving Frameworks to the "po injection" test group.

"po injection" = scripty commits po files back to git

Plasma Mobile Gear has been using it and as far as I understand it is working 
relatively well.

Example: https://invent.kde.org/plasma-mobile/alligator/-/commits/master/po

This way you can remove any special handling of l10n altogether from the KDE 
Frameworks release scripts

Cheers,
  Albert

> 
> I have now added more error checking, including at the beginning of 
> make_rc_tag.sh,
> as well as a reminder to run "step2" after fixing the l10n problems.
> 
> 






Re: KDE Frameworks 5.94.0

2022-05-15 Thread David Faure
On samedi 14 mai 2022 20:48:55 CEST Albert Astals Cid wrote:
> El diumenge, 8 de maig de 2022, a les 0:11:35 (CEST), David Faure va escriure:
> > On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> > > El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure escribió:
> > > > Dear packagers,
> > > > 
> > > > KDE Frameworks 5.94.0 has been uploaded to the usual place.
> > > > 
> > > > New frameworks: none this time.
> > > 
> > > This should have been a reply to this mail of course
> > > 
> > > >  tr tt ug uk and uz translations are missing from all tarballs.
> > 
> > Thanks for noticing. My "update l10n" script did show an error about that
> > but I didn't see that error and moved on. I have now improved things so I
> > can't launch the next step if this step failed.
> > 
> > I now uploaded new tarballs (also including
> > https://invent.kde.org/frameworks/ plasma-framework/-/merge_requests/523)
> > 
> > I hope it's all fine now, let me know otherwise.
> 
> I've just realized that the packages dependencies have not been increased to
> 5.94 and they are just at 5.93. I guess that's not that bad, but just want
> to make sure that doesn't mean some other change may be also missing?

Good catch. Fortunately nothing else should be missing. The reason this didn't 
happen is that I run

cd ../src && ./kdesrc-build --src-only && cd ../release-tools && 
./list_frameworks.sh && ./update_l10n.sh && ./increase_frameworks_version.sh 
step2

and update_l10n failed because anonsvn threw me out in the middle of it.
I didn't notice, ran the next step (./make_rc_tag.sh) and this is how we got 
tags with missing languages.
Then I fixed l10n and tagged again, completely missing that 
"increase_frameworks_version.sh step2" was never done.

Sigh, I wish svn.kde.org would work for the way we're using it at release time.

I have now added more error checking, including at the beginning of 
make_rc_tag.sh,
as well as a reminder to run "step2" after fixing the l10n problems.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5





Re: KDE Frameworks 5.94.0

2022-05-14 Thread Albert Astals Cid
El diumenge, 8 de maig de 2022, a les 0:11:35 (CEST), David Faure va escriure:
> On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> > El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure escribió:
> > > Dear packagers,
> > > 
> > > KDE Frameworks 5.94.0 has been uploaded to the usual place.
> > > 
> > > New frameworks: none this time.
> > 
> > This should have been a reply to this mail of course
> >
> > >  tr tt ug uk and uz translations are missing from all tarballs.
> 
> Thanks for noticing. My "update l10n" script did show an error about that but 
> I didn't see that error and moved on. I have now improved things so I can't 
> launch the next step if this step failed.
> 
> I now uploaded new tarballs (also including https://invent.kde.org/frameworks/
> plasma-framework/-/merge_requests/523)
> 
> I hope it's all fine now, let me know otherwise.

I've just realized that the packages dependencies have not been increased to 
5.94 and they are just at 5.93. I guess that's not that bad, but just want to 
make sure that doesn't mean some other change may be also missing?

Cheers,
  Albert

> 
> 






Re: KDE Frameworks 5.94.0

2022-05-07 Thread David Faure
On samedi 7 mai 2022 18:38:44 CEST Antonio Rojas wrote:
> El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure escribió:
> > Dear packagers,
> > 
> > KDE Frameworks 5.94.0 has been uploaded to the usual place.
> > 
> > New frameworks: none this time.
> 
> This should have been a reply to this mail of course
>
> >  tr tt ug uk and uz translations are missing from all tarballs.

Thanks for noticing. My "update l10n" script did show an error about that but 
I didn't see that error and moved on. I have now improved things so I can't 
launch the next step if this step failed.

I now uploaded new tarballs (also including https://invent.kde.org/frameworks/
plasma-framework/-/merge_requests/523)

I hope it's all fine now, let me know otherwise.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
attica v5.94.0-rc1
58790916f93c89a7cb1fa938a6e982502d4f75df
f6293699da5794812080ba2d41b4ea05e830532678af324d8e852f508f2def65  
sources/attica-5.94.0.tar.xz
baloo v5.94.0-rc1
a7e9ec6dff35ca83043c92daff95f0a062b767f2
ffbf6289dae908094f8ee73f184b589c4a15b23a2e4e7939da0c540e6ab5e59e  
sources/baloo-5.94.0.tar.xz
bluez-qt v5.94.0-rc1
f6f50a202052a062205365c52f1e892f939e21ed
7e776feb095e727abea0fec4b3ae3c81d704a0527b8ff3257d799feee2cc0632  
sources/bluez-qt-5.94.0.tar.xz
breeze-icons v5.94.0-rc1
4629bec205f991239f3795626dfcfd61cf44147b
3e0b3fd2374dba82ca304c066938345f25b0eb85dca7169267c84f62bfb3a3bb  
sources/breeze-icons-5.94.0.tar.xz
extra-cmake-modules v5.94.0-rc1
6f36ce60e2b1f40302bd12db93ef5f0232e52235
23548a8ce2b998cfa675fc00112bf93914ee25194f0bfdf832d283c8d678d279  
sources/extra-cmake-modules-5.94.0.tar.xz
frameworkintegration v5.94.0-rc1
23d246aad4752cdbb02b7ad675e6fd105040c6db
9a64abebf8d242765ae759611fc9819a03403047ed56b8dd71aba7a0bbb4faa6  
sources/frameworkintegration-5.94.0.tar.xz
kactivities v5.94.0-rc1
9b4fa8d34cebc8017fd17e554626c9d77ef1d201
52dd5eba3daeb2a9bbb3a1865b3219277b3ca6357c2870c3570dfac10f445adf  
sources/kactivities-5.94.0.tar.xz
kactivities-stats v5.94.0-rc1
a036664e5e9d469cb041380d0c02a7911a060be6
83fe7d109d830f348f18432949902700ee8a6a934cbaf3f89ae7bbfb28ef2340  
sources/kactivities-stats-5.94.0.tar.xz
kapidox v5.94.0-rc1
88e6d65ac4d0e3634718c202c6963b0ed2da694e
1ca7520539bfe3179ae8b50b9a7c381478080d520a68f9fbb7e73b5946e55577  
sources/kapidox-5.94.0.tar.xz
karchive v5.94.0-rc1
f9d6a24343af3ea5cdff9d20ef95ff63b50246f8
55cd87a5437a649c168efbce4af132b992aa67dd9a3a8ced7cff0144f155e1e4  
sources/karchive-5.94.0.tar.xz
kauth v5.94.0-rc1
08cfc82c37fcf68158d980653dde3ffb4428f258
e1876dc1b4226ba7fed2aeb5c328ec7021ef91d26fb89d8b2ff403c24a4a5fe6  
sources/kauth-5.94.0.tar.xz
kbookmarks v5.94.0-rc1
2e3146ae1933c6410d912d97b99adfc463fded79
e0f418338ac5f9604d7b87f4bb25049573c0405708a0a8c5995c5c26bd4faff2  
sources/kbookmarks-5.94.0.tar.xz
kcalendarcore v5.94.0-rc1
0b9eb121f199ba419a2ab8f088d10320ee920d16
3bab1ae2e8214fb889b742d4a4f2c6acfd0bf40a4c4933cc91c66d21d77c042b  
sources/kcalendarcore-5.94.0.tar.xz
kcmutils v5.94.0-rc1
9ba785c7057dc7f5af429fb663dfaeea011ce3c9
2d2237b9ba4f28397f395d02f290b41156b150446a1067371d99e12760bf7d36  
sources/kcmutils-5.94.0.tar.xz
kcodecs v5.94.0-rc1
e33bc30a40ed5a22a543907f863d9c108f6591a4
24bac49edd6dcb23626357739ec97104c4bf73393fdfdc79232b6af89b541c7b  
sources/kcodecs-5.94.0.tar.xz
kcompletion v5.94.0-rc1
b8ff60ebb11f99e9978190019313137dada1b09c
82644e0841918ddd3feff930bab0e44e8c8f8a641c8e60b504c30abe407cd714  
sources/kcompletion-5.94.0.tar.xz
kconfig v5.94.0-rc1
3ee4cebff239e3b04d52bb1d3ef29a10367679c1
090319cc44f94e60e35437440cd9e65a9728137d35e4e361d6503c38e109ffef  
sources/kconfig-5.94.0.tar.xz
kconfigwidgets v5.94.0-rc1
c1cc807f0b1c2f0cdf79c52c1855e9b5361f4467
ac4f84f0694d3d3548d6b03f3f9324335bd64b5f76bf937384aa03ee7e79c8d2  
sources/kconfigwidgets-5.94.0.tar.xz
kcontacts v5.94.0-rc1
7b14b11bcf3745121006952d0cf79640da496ca0
16db668f8276bdb726a16d35ec356d16d53b5e87bf8a4b67f392038cafb45f85  
sources/kcontacts-5.94.0.tar.xz
kcoreaddons v5.94.0-rc1
09cde2ef0a09035b978c64ef987c35360b7cf252
ad8fad5a1446ccb02c1f7695e2b858439aa2c8591cdfd5c0ac1830cdef652f35  
sources/kcoreaddons-5.94.0.tar.xz
kcrash v5.94.0-rc1
4ae282862f01fe9f6fe2a1a2117ce3babdd85e9f
48c7792ca8c2ad6e9b6c8e9a260cdfcee5ed8d8769c4a8a199de7bf671f03cf5  
sources/kcrash-5.94.0.tar.xz
kdav v5.94.0-rc1
5eea50d68ca093262b85958f98f5f6470691062f
249a40a7c01abeb1483bd313c9feaa9f390de1d7e4368b79aca495ad4753fc97  
sources/kdav-5.94.0.tar.xz
kdbusaddons v5.94.0-rc1
0c58a95e3be4c94f54631a2949972d41d6598202
d5da073988b4bf97c5c0ec1bde72f2991685f098084afd038c6b16a4f54f272c  
sources/kdbusaddons-5.94.0.tar.xz
kdeclarative v5.94.0-rc1
32761fbc6878863c2e8c11746104f53d4f22953c
89f9d54659aff08b891e9d525a38b69a494372471597e2c130c599eda96760db  
sources/kdeclarative-5.94.0.tar.xz
kded v5.94.0-rc1
058a1ccf94247fb47a198fe76773e8330fdfc0d8
e6a18cfa531321535425ee00ee8247a58ce1a9d81c4bf5e9a4581721ec27c01c  
sources/kded-5.94.0.tar.xz
kdelibs4support v5.94.0-rc1
4d14fe4a5e5a1ad47288002ff85e34db4432fd1c

Re: KDE Frameworks 5.94.0

2022-05-07 Thread Antonio Rojas

El sábado, 7 de mayo de 2022 15:31:17 (CEST), David Faure escribió:

Dear packagers,

KDE Frameworks 5.94.0 has been uploaded to the usual place.

New frameworks: none this time.


This should have been a reply to this mail of course


Hi,
 tr tt ug uk and uz translations are missing from all tarballs.