date:20150720

[Reproducible-builds] [PATCH] Reproducible U-Boot build support, using SOURCE_DATE_EPOCH

2015-07-20 Thread Paul Kocialkowski

In order to achieve reproducible builds in U-Boot, timestamps that are defined
at build-time have to be somewhat eliminated. The SOURCE_DATE_EPOCH environment
variable allows setting a fixed value for those timestamps.

Simply by setting SOURCE_DATE_EPOCH to a fixed value, a number of targets can be
built reproducibly. This is the case for e.g. sunxi devices.

However, some other devices might need some more tweaks, especially regarding
the image generation tools.

Signed-off-by: Paul Kocialkowski cont...@paulk.fr
---
 Makefile  |  7 ---
 tools/default_image.c | 21 -
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 37cc4c3..71aeac7 100644
--- a/Makefile
+++ b/Makefile
@@ -1231,9 +1231,10 @@ define filechk_version.h
 endef
 
 define filechk_timestamp.h
-   (LC_ALL=C date +'#define U_BOOT_DATE %b %d %C%y'; \
-   LC_ALL=C date +'#define U_BOOT_TIME %T'; \
-   LC_ALL=C date +'#define U_BOOT_TZ %z')
+   (SOURCE_DATE=$${SOURCE_DATE_EPOCH:+@$$SOURCE_DATE_EPOCH}; \
+   LC_ALL=C date -u -d $${SOURCE_DATE:-now} +'#define U_BOOT_DATE %b %d 
%C%y'; \
+   LC_ALL=C date -u -d $${SOURCE_DATE:-now} +'#define U_BOOT_TIME %T'; 
\
+   LC_ALL=C date -u -d $${SOURCE_DATE:-now} +'#define U_BOOT_TZ %z' )
 endef
 
 $(version_h): include/config/uboot.release FORCE
diff --git a/tools/default_image.c b/tools/default_image.c
index cf5c0d4..18940af 100644
--- a/tools/default_image.c
+++ b/tools/default_image.c
@@ -88,6 +88,9 @@ static void image_set_header(void *ptr, struct stat *sbuf, 
int ifd,
struct image_tool_params *params)
 {
uint32_t checksum;
+   char *source_date_epoch;
+   struct tm *time_universal;
+   time_t time;
 
image_header_t * hdr = (image_header_t *)ptr;
 
@@ -96,9 +99,25 @@ static void image_set_header(void *ptr, struct stat *sbuf, 
int ifd,
sizeof(image_header_t)),
sbuf-st_size - sizeof(image_header_t));
 
+   source_date_epoch = getenv(SOURCE_DATE_EPOCH);
+   if (source_date_epoch != NULL) {
+   time = (time_t) strtol(source_date_epoch, NULL, 10);
+
+   time_universal = gmtime(time);
+   if (time_universal == NULL) {
+   fprintf(stderr, %s: SOURCE_DATE_EPOCH is not valid\n,
+   __func__);
+   time = 0;
+   } else {
+   time = mktime(time_universal);
+   }
+   } else {
+   time = sbuf-st_mtime;
+   }
+
/* Build new header */
image_set_magic(hdr, IH_MAGIC);
-   image_set_time(hdr, sbuf-st_mtime);
+   image_set_time(hdr, time);
image_set_size(hdr, sbuf-st_size - sizeof(image_header_t));
image_set_load(hdr, params-addr);
image_set_ep(hdr, params-ep);
-- 
1.9.1


___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Re: [Reproducible-builds] [U-Boot] [PATCH] build: create time and date independent binary

2015-07-20 Thread Heiko Schocher

Hello Vagrant,

Am 19.07.2015 um 15:14 schrieb Vagrant Cascadian:

On 2015-07-19, Holger Levsen wrote:

All this said, if you send me patches, I will probably deploy them as I'm
very curious and more reproducibility efforts are good :-) We can can
always decide to remove or move them later.

I wish to make all contributions upstream. What would really help at
first would be to have all targets built regularly to see where work is
needed. This is where I think the Debian infrastructure could help, in a
similar way as what was started for Coreboot.

FWIW, I was planning on including this patch to u-boot in the next
upload to Debian:

https://anonscm.debian.org/cgit/collab-maint/u-boot.git/tree/debian/patches/use-date-from-debian-changelog.patch?h=experimental-2015.07

I *think* that actually makes u-boot build reproducibly with Debian's
reproducible builds toolchain when SOURCE_DATE_EPOCH is set, but I
haven't tested it fully. I might have missed some other sources of
non-determinism...

Hoping to get some armhf buildd nodes up an running soonish... although
it should also be buildable with the cross-toolchains, if the
reproducible buildds coulld be made to support that.

Did you see my v2 patch [1] for u-boot?

It also builds now u-boot images created with mkimage reproducible ...

If I interpret your patch from above correct, you add with
SOURCE_DATE_EPOCH a specific fix timestamp?

I think, this could be included to my approach too ...

If SOURCE_DATE_EPOCH is defined, use it, fi not defined
define U_BOOT_DATE, U_BOOT_TIME and U_BOOT_TZ
with my default settings from [1] ...

All only if CONFIG_SYS_EXACT_BINARY is set in the u-boot
config of course ...

What do you think?

bye,
Heiko
[1] http://patchwork.ozlabs.org/patch/487530/
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#792937: cpl-plugin-kmos: please make the build reproducible

2015-07-20 Thread Chris Lamb

Source: cpl-plugin-kmos
Version: 1.3.12+dfsg-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the reproducible builds effort [1], we have noticed
that cpl-plugin-kmos could not be built reproducibly.

The attached patch removes randomness from the build system. Once
applied, cpl-plugin-kmos can be built reproducibly in our reproducible
toolchain.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/debian/create_sphinx.py b/debian/create_sphinx.py
index 9107b16..e7bf499 100644
--- a/debian/create_sphinx.py
+++ b/debian/create_sphinx.py
@@ -146,7 +146,7 @@ index = [ oca.find(recipe.__name__) for recipe in 
recipes_oca ]
 recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
 
 recipes_x = [recipe for recipe in recipes if not recipe.__name__ in oca]
-recipes_x.sort()
+recipes_x.sort(lambda x: x.__name__)
 
 def par(recipe, template, delimiter = , count = None):
 return delimiter.join(template.format(
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#792933: cpl-plugin-fors: please make the build reproducible

2015-07-20 Thread Chris Lamb

Source: cpl-plugin-fors
Version: 5.0.11+dfsg-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the reproducible builds effort [1], we have noticed
that cpl-plugin-fors could not be built reproducibly.

The attached patch removes randomness from the build system. Once
applied, cpl-plugin-fors can be built reproducibly in our reproducible
toolchain.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/debian/create_sphinx.py b/debian/create_sphinx.py
index b9f9096..9272342 100644
--- a/debian/create_sphinx.py
+++ b/debian/create_sphinx.py
@@ -146,7 +146,7 @@ index = [ oca.find(recipe.__name__) for recipe in 
recipes_oca ]
 recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
 
 recipes_x = [recipe for recipe in recipes if not recipe.__name__ in oca]
-recipes_x.sort()
+recipes_x.sort(lambda x: x.__name__)
 
 def par(recipe, template, delimiter = , count = None):
 return delimiter.join(template.format(
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#792935: cpl-plugin-giraf: please make the build reproducible

2015-07-20 Thread Chris Lamb

Source: cpl-plugin-giraf
Version: 2.14+dfsg-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the reproducible builds effort [1], we have noticed
that cpl-plugin-giraf could not be built reproducibly.

The attached patch removes randomness from the build system. Once
applied, cpl-plugin-giraf can be built reproducibly in our reproducible
toolchain.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/debian/create_sphinx.py b/debian/create_sphinx.py
index 3c283da..0336111 100644
--- a/debian/create_sphinx.py
+++ b/debian/create_sphinx.py
@@ -146,7 +146,7 @@ index = [ oca.find(recipe.__name__) for recipe in 
recipes_oca ]
 recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
 
 recipes_x = [recipe for recipe in recipes if not recipe.__name__ in oca]
-recipes_x.sort()
+recipes_x.sort(lambda x: x.__name__)
 
 def par(recipe, template, delimiter = , count = None):
 return delimiter.join(template.format(
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#792938: cpl-plugin-muse: please make the build reproducible

2015-07-20 Thread Chris Lamb

Source: cpl-plugin-muse
Version: 1.0.4+dfsg-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the reproducible builds effort [1], we have noticed
that cpl-plugin-muse could not be built reproducibly.

The attached patch removes randomness from the build system. Once
applied, cpl-plugin-muse can be built reproducibly in our reproducible
toolchain.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/debian/create_sphinx.py b/debian/create_sphinx.py
index 03a56b0..a94cf81 100644
--- a/debian/create_sphinx.py
+++ b/debian/create_sphinx.py
@@ -150,7 +150,7 @@ index = [ oca.find(recipe.__name__) for recipe in 
recipes_oca ]
 recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
 
 recipes_x = [recipe for recipe in recipes if not recipe.__name__ in oca]
-recipes_x.sort()
+recipes_x.sort(lambda x: x.__name__)
 
 def par(recipe, template, delimiter = , count = None):
 return delimiter.join(template.format(
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#792942: cpl-plugin-visir: please make the build reproducible

2015-07-20 Thread Chris Lamb

Source: cpl-plugin-visir
Version: 3.5.1+dfsg-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the reproducible builds effort [1], we have noticed
that cpl-plugin-visir could not be built reproducibly.

The attached patch removes randomness from the build system. Once
applied, cpl-plugin-visir can be built reproducibly in our reproducible
toolchain.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/debian/create_sphinx.py b/debian/create_sphinx.py
index a694f8a..f132ea8 100644
--- a/debian/create_sphinx.py
+++ b/debian/create_sphinx.py
@@ -146,7 +146,7 @@ index = [ oca.find(recipe.__name__) for recipe in 
recipes_oca ]
 recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
 
 recipes_x = [recipe for recipe in recipes if not recipe.__name__ in oca]
-recipes_x.sort()
+recipes_x.sort(lambda x: x.__name__)
 
 def par(recipe, template, delimiter = , count = None):
 return delimiter.join(template.format(
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#792940: cpl-plugin-uves: please make the build reproducible

2015-07-20 Thread Chris Lamb

Source: cpl-plugin-uves
Version: 5.5.2+dfsg-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the reproducible builds effort [1], we have noticed
that cpl-plugin-uves could not be built reproducibly.

The attached patch removes randomness from the build system. Once
applied, cpl-plugin-uves can be built reproducibly in our reproducible
toolchain.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/debian/create_sphinx.py b/debian/create_sphinx.py
index 558a57c..a04e821 100644
--- a/debian/create_sphinx.py
+++ b/debian/create_sphinx.py
@@ -146,7 +146,7 @@ index = [ oca.find(recipe.__name__) for recipe in 
recipes_oca ]
 recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
 
 recipes_x = [recipe for recipe in recipes if not recipe.__name__ in oca]
-recipes_x.sort()
+recipes_x.sort(lambda x: x.__name__)
 
 def par(recipe, template, delimiter = , count = None):
 return delimiter.join(template.format(
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#792941: cpl-plugin-vimos: please make the build reproducible

2015-07-20 Thread Chris Lamb

Source: cpl-plugin-vimos
Version: 2.9.15+dfsg-4
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the reproducible builds effort [1], we have noticed
that cpl-plugin-vimos could not be built reproducibly.

The attached patch removes randomness from the build system. Once
applied, cpl-plugin-vimos can be built reproducibly in our reproducible
toolchain.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/debian/create_sphinx.py b/debian/create_sphinx.py
index 3a9492a..fd87529 100644
--- a/debian/create_sphinx.py
+++ b/debian/create_sphinx.py
@@ -145,7 +145,7 @@ recipes_oca = [name for name in recipes if name in oca]
 index = [ oca.find(name) for name in recipes_oca ]
 recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
 recipes_x = [name for name in recipes if not name in oca]
-recipes_x.sort()
+recipes_x.sort(lambda x: x.__name__)
 
 def par(recipe, template, delimiter = , count = None):
 return delimiter.join(template.format(
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#792939: cpl-plugin-sinfo: please make the build reproducible

2015-07-20 Thread Chris Lamb

Source: cpl-plugin-sinfo
Version: 2.6.0+dfsg-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the reproducible builds effort [1], we have noticed
that cpl-plugin-sinfo could not be built reproducibly.

The attached patch removes randomness from the build system. Once
applied, cpl-plugin-sinfo can be built reproducibly in our reproducible
toolchain.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/debian/create_sphinx.py b/debian/create_sphinx.py
index 170b470..96d7a04 100644
--- a/debian/create_sphinx.py
+++ b/debian/create_sphinx.py
@@ -146,7 +146,7 @@ index = [ oca.find(recipe.__name__) for recipe in 
recipes_oca ]
 recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
 
 recipes_x = [recipe for recipe in recipes if not recipe.__name__ in oca]
-recipes_x.sort()
+recipes_x.sort(lambda x: x.__name__)
 
 def par(recipe, template, delimiter = , count = None):
 return delimiter.join(template.format(
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Re: [Reproducible-builds] Bug#791823: debhelper: set SOURCE_DATE_EPOCH env var for reproducible builds

2015-07-20 Thread Ximin Luo

On 12/07/15 12:03, Jérémy Bobbio wrote:
 Hi!
 
 Dhole:
 Also, in order to help reproducible builds, a fixed timezone is exported
 (TZ=UTC).
 
 I am not convinced this change is a good idea. While reviewing new uploads
 to the Debian archive, I have at least spotted these lines in
 exim4/4.86~RC4-1 changelog [1]:
 
   * unexport/undefine TZ in debian/rules for reproducible build. It
 would be used as default value for TIMEZONE_DEFAULT.
 
 The `TZ` environment variable is not usually set in a build environment.
 It is a reproducibility problem if a package produce different binaries
 when it is, but that's all. I am afraid that some packages, like exim4,
 would silently start behaving differently if we set `TZ` in debhelper.
 
 If we don't set the variable in debhelper, we can use the
 reproducibility tests to spot packages who are building differently
 depending on the timezone or the value of TZ and propose fixes to
 maintainers. This enables them to review their impact. It is indeed more
 work, but it's less likely to unknowingly introduce any weird behavior.
 
  [1]: https://tracker.debian.org/news/694090
 

I also had some reservations about setting TZ in this way, but wasn't quite 
sure how to express it. But here's a more general, abstract version of the 
scenario Lunar pointed out.

- Imagine that upstream thinks it's reasonable to e.g. generate certain locale 
data based on the TZ variable at build time.
- Setting TZ=UTC would make the build appear reproducible, and the package 
maintainer may not even realise that there's something missing, especially if 
this locales thing is buried deep in the build scripts.
- The correct solution would be for upstream to generate such data for all TZs. 
For sure, setting TZ=UTC would not interfere with this fix, but it makes such 
issues harder to detect.

I suggest we drop this particular aspect from this patch and just focus on 
SOURCE_DATE_EPOCH instead.

X

-- 
GPG: 4096R/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git



signature.asc
Description: OpenPGP digital signature
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#792932: cpl-plugin-amber: please make the build reproducible

2015-07-20 Thread Chris Lamb

Source: cpl-plugin-amber
Version: 4.3.3+dfsg-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the reproducible builds effort [1], we have noticed
that cpl-plugin-amber could not be built reproducibly.

The attached patch removes randomness from the build system. Once
applied, cpl-plugin-amber can be built reproducibly in our reproducible
toolchain.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/debian/create_sphinx.py b/debian/create_sphinx.py
index d9ece20..65bb6ff 100644
--- a/debian/create_sphinx.py
+++ b/debian/create_sphinx.py
@@ -146,7 +146,7 @@ index = [ oca.find(recipe.__name__) for recipe in 
recipes_oca ]
 recipes_oca = [r for (i, r) in sorted(zip(index, recipes_oca))]
 
 recipes_x = [recipe for recipe in recipes if not recipe.__name__ in oca]
-recipes_x.sort()
+recipes_x.sort(lambda x: x.__name__)
 
 def par(recipe, template, delimiter = , count = None):
 return delimiter.join(template.format(
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] reminder: Next IRC meeting: 2015-07-21 17:00 UTC

2015-07-20 Thread Holger Levsen

Hi,

quoting https://wiki.debian.org/ReproducibleBuilds/Meetings

Agenda for the fifth meeting, 2015-07-21 17:00 UTC

discuss todays agenda
go though last meetings summary and look for unactioned action items
package/issue updates + r.a.d.o repo state
can we move old unneeded packages out of the way? (a /old/ directory?) 
rp.d.n updates+issues
GSoC updates
any other business
announce next meeting 


See you on #debian-reproducible on irc.oftc.net!


cheers,
Holger


signature.asc
Description: This is a digitally signed message part.
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

62 matches

Mail list logo