Bug#850730: diffoscope: ImageFile can't deal with .ico even if it claims so

2017-01-10 Thread Chris Lamb
tags 850730 + pending
thanks

Hi,

> diffoscope: ImageFile can't deal with .ico even if it claims so

Fixed in:

 
https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=f311a6df28230be7d7afe0aadfd371471c392ccf


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds


Bug#850730: diffoscope: ImageFile can't deal with .ico even if it claims so

2017-01-09 Thread Mattia Rizzolo
package: diffoscope
version: 67

mattia@warren ..vel/reproducible/diffoscope/diffoscope (git)-[master] % 
bin/diffoscope --text /dev/null --debug $(find /usr/share -name '*.ico' | head 
-n 2 | xargs)
2017-01-09 19:45:35,380 D: diffoscope.main: Starting diffoscope 68
2017-01-09 19:45:35,381 D: diffoscope.locale: Normalising locale, timezone, etc.
2017-01-09 18:45:35,381 D: diffoscope.main: Starting comparison
2017-01-09 18:45:35,383 D: diffoscope.comparators.utils.specialize: Using 
ImageFile for /usr/share/calibre/content-server/favicon.ico
2017-01-09 18:45:35,383 D: diffoscope.comparators.utils.specialize: Using 
ImageFile for /usr/share/pyshared/subdownloader/gui/images/icon32.ico
2017-01-09 18:45:35,383 D: diffoscope.comparators.utils.compare: Comparing 
files < /usr/share/calibre/content-server/favicon.ico> 
and < 
/usr/share/pyshared/subdownloader/gui/images/icon32.ico>
2017-01-09 18:45:35,384 D: diffoscope.comparators.utils.file: 
Binary.has_same_content: < 
/usr/share/calibre/content-server/favicon.ico> < 
/usr/share/pyshared/subdownloader/gui/images/icon32.ico>
2017-01-09 18:45:35,387 D: diffoscope.comparators.utils.command: Executing 
img2txt --width 60 --format utf8 /usr/share/calibre/content-server/favicon.ico
2017-01-09 18:45:35,388 D: diffoscope.comparators.utils.command: Executing 
img2txt --width 60 --format utf8 
/usr/share/pyshared/subdownloader/gui/images/icon32.ico
2017-01-09 18:45:35,392 D: diffoscope.comparators.utils.command: img2txt 
--width 60 --format utf8 /usr/share/calibre/content-server/favicon.ico returned 
(exit code: 1)
2017-01-09 18:45:35,392 D: diffoscope.comparators.utils.command: Executing xxd 
/usr/share/calibre/content-server/favicon.ico
2017-01-09 18:45:35,394 D: diffoscope.comparators.utils.command: Executing xxd 
/usr/share/pyshared/subdownloader/gui/images/icon32.ico
2017-01-09 18:45:35,402 D: diffoscope.comparators.utils.command: xxd 
/usr/share/calibre/content-server/favicon.ico returned (exit code: 0)
2017-01-09 18:45:35,402 D: diffoscope.comparators.utils.command: xxd 
/usr/share/pyshared/subdownloader/gui/images/icon32.ico returned (exit code: 0)
2017-01-09 18:45:35,402 D: diffoscope.diff: Running diff -aU7 
/tmp/tmp377w3zwg/f1 /tmp/tmp377w3zwg/f2
2017-01-09 18:45:35,411 D: diffoscope.diff: diff -aU7 /tmp/tmp377w3zwg/f1 
/tmp/tmp377w3zwg/f2: returncode 1, parsed True
2017-01-09 18:45:35,412 D: diffoscope.presenters.utils: Generating 'text' 
output at '/dev/null'
1 mattia@warren ..vel/reproducible/diffoscope/diffoscope (git)-[master] %   

   :(

As you can see it does a useless binary comparison of 2 .ico

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds