Re: Search Error: DLL load failed: The specified module could not be found
re-installing pylucene solved the problem. Best, Kaan --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: email not working
This is usually due to the specified mail server not being configured correctly. I would look at the mail server's log files and see what it's saying. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Sun, Jul 19, 2009 at 3:59 PM, pouakai68 ch...@thebayleys.net wrote: I have hit a dead end trying to enable email notifications for our RB site. My users have an email address specified in Auth/Users. My users are part of a review group. The review group has no mailing list specified. In Settings/E-Mail Send e-mails for review requests and reviews is checked and a verified server is specified. When I submit a review to the group there is no email activity. I cannot find anything in the log file nor is there any error message. Cheers, Pouakai --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Comments disappear from the Diff view
On Thu, Jul 16, 2009 at 5:49 AM, John Szakmeisterj...@szakmeister.net wrote: On Thu, Jul 16, 2009 at 5:22 AM, Christian Hammondchip...@chipx86.com wrote: What we need to know is what's common between all occurrences in your setup. Are these all comments on the first page in the diff viewer, or latter pages? They're all on the first page. In fact, I don't think we have any that currently span multiple pages at the moment (I *just* got RB setup recently). Are these near a collapsed region? The ones that disappear are *in* the collapsed region. One of the devs was commenting on something a number of lines away from the diff, because he thought it would be affected. How many lines do they span? 1 or 2. Does it span over a collapsed region? See above. Are you certain when clicking View Diff that you're looking at the same revision as the comment? I believe so, but I'll check again. I could be stupid user error. :-) I double checked, we are looking at the right revision. :-( -John --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ClearCase and Reviewboard setup.
Hi Dan,
I have done the changes to make it work with Clearcase. I have
followed all the steps you have mentioned. I am using dynamic
clearcase view only. When I run the post-review script, it hangs when
it tries to post the diff content. But I can see the diff content if I
use output-diff option for post-review. Following are the output taken
from post-review script.
karthik-wx ct lsco -cview -me -short -rec | sed s//\//g | xargs
python C:/Python25/Scripts/post-review --server=http://localhost:
8082 --submit-as=karthik --password=mywork –d
C:\Python25\lib\site-packages\rbtools-0.2beta1-py2.5.egg\EGG-INFO
\scripts\post-review
cleartool pwv -short
repository info: Path: /sw0, Base path: /sw0, Supports changesets: False
cleartool desc -pre K:\sw0\software\code\include\techMgr.h
Looking for 'localhost /' cookie in C:\Documents and Settings\karthik\Local
Settings\Application Data\.post-review-cookies.txt
Cookie file loaded, but no cookie for this server
== Review Board Login Required
Enter username and password for Review Board at http://localhost:8082/
Logging in with username karthik
HTTP POSTing to http://localhost:8082/api/json/accounts/login/:
{'username': 'karthik', 'password': '**'}
Logged in.
Attempting to create review request for None
Submitting the review request as karthik
HTTP POSTing to http://localhost:8082/api/json/reviewrequests/new/:
{'repository_path': '/sw0',
'submit_as': 'karthik'}
Review request created
Attempting to set field 'description' to 'karthik_view_9.0BugFix
VIEWTYPE: dynamic
' for review request '6'
HTTP POSTing to http://localhost:8082/api/json/reviewrequests/6/draft/set/:
{'description': 'karthik_view_9.0BugFix\nVIEWTYPE: dynamic\n'}
HTTP POSTing to
http://localhost:8082/api/json/reviewrequests/6/draft/save/: {}
Review request draft saved
Uploading diff, size: 548
HTTP POSTing to http://localhost:8082/api/json/reviewrequests/6/diff/new/:
{'basedir': '/sw0'}
It hangs after this line ---
Please let me know If I miss any configuration or something.
Thanks,
Karthik
On Jul 18, 6:05 am, Dan Savilonis d...@n-cube.org wrote:
The requirements to use post-review with clearcase are the same as
with any other version control system. The only difference is you pass
a list of filenames as arguments to the script that you want to
review:
python post-review --server=http://example.com/file1.c file2.c
file3.c
If post-review doesn't work, easy_install rbtools should install the
python dependencies.
Dan
On Jul 17, 8:11 pm, 吴开春 wukaic...@gmail.com wrote:
请教一下，你装起来用了没有？
On Jul 17, 10:23 pm, Dan Savilonis d...@n-cube.org wrote:
It is not required. post-review simply includes support for cygwin
(i.e. path translation since cleartool does not understand cygwin
paths). My example used sed and xargs to make it easier, so that's the
only reason I suggested having the tools in your path. This feature
can eventually be added to post-review to automatically collect
checked out files.
Dan
On Jul 17, 6:50 am, 夏勇杰 notox...@gmail.com wrote:
Hi Dan,
I have some questions about post review.
Should we install cygwin for post-review in order to make it work with
Clearcase?
On Jul 17, 9:32 am, Dan Savilonis d...@n-cube.org wrote:
I went through a fresh installation of reviewboard withClearcase
today and recorded the steps.
Here's what you need to do to get up and running. For the purpose of
this test, I used a dynamic view and was running the server on the
same machine as I had the view and did a review of checked out files.
1) Add reviewboard.scmtools.clearcase.ClearCaseTool in the admin
interface (Home Scmtools Tools), if using ReviewBoard 1.0. This
step is not necessary if you're running svn revision = r2041.
2) Add aClearCaserepository via the admin interface, and specify a
path to your view (I used the top of the view, not the vob).
3) Apply the patch fromhttp://reviews.review-board.org/r/906/toyour
post-review script.
4) Edit post-review ClearCaseClient class. Change cc_rootpath to be
identical to what you typed into the admin interface, change viewtype
to 'dynamic' (if you're trying this with a dynamic view, of course)
4) Check out a file in the view and make a change
4) Run post-review in your view and pass a list of the files that
you've checked out after the options. Alternatively if you're lazy
like me, you can do something like (on windows, with cygwin, msys,
etc, in your vob directory):
cleartool lsco -cview -me -recurse -short | sed s//\//g | xargs
python post-review --server=http://example.com/
I tried using a snapshot view but it didn't work immediately for me
and I haven't debugged it. It looked like it was trying to use a
clearcaseextended path. I assumed you could only use that notation
within a dynamic view, but I'm probably
Re: Problem submitting review with post-review
Hi Oliver,
Looks like I am also facing the same problem. It is not able to
post the diff content to the reviewboard server. It hangs when it
tries to post it. Is the problem resolved? Please let me know.
--Karthik
On Jul 15, 11:06 am, Christian Hammond chip...@chipx86.com wrote:
Hi Oliver,
Off-hand, I don't know. One common reason for that hanging is that the URL
is actually a redirect, which by default urllib2 does not handle. Another
possibility is that it's going through a proxy and something's getting
stuck.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Tue, Jul 14, 2009 at 9:56 PM, Oliver Jones orjo...@gmail.com wrote:
I'm currently having a problem with post-review where it hangs waiting on a
response from a reviewboard json request.
The code where it hangs is in http_post method.
r = urllib2.Request(url, body, headers)
data = urllib2.urlopen(r).read() # --- hangs here
I'm using reviewboard 1.0 and the post-review script from
RBTools-0.2beta1-py2.5.egg
I've applied a patch against post-review to solve some bugs I encountered
(which is attached).
I'm running/debugging post-review and reviewboard on the same machine which
is a Windows server.
Any hints on why this would be the case would be helpful.
Debug output:
Y:\Order_Management_Products_VOB\TraderWorkstationMS\Devd:\rb\post-review.py
-d --summary=Test summary --description=Test desc update_paraffin.cmd
cleartool pwv -short
repository info: Path: Y:\, Base path: Y:\, Supports changesets: False
cleartool desc -pre
Y:\Order_Management_Products_VOB\TraderWorkstationMS\Dev\update_paraffin.cmd
cleartool desc -fmt %Vn Y:\
cleartool desc -fmt %Vn Y:\Order_Management_Products_VOB
cleartool desc -fmt %Vn
Y:\Order_Management_Products_VOB\TraderWorkstationMS
cleartool desc -fmt %Vn
Y:\Order_Management_Products_VOB\TraderWorkstationMS\Dev
cleartool desc -fmt %Vn Y:\
cleartool desc -fmt %Vn Y:\Order_Management_Products_VOB
cleartool desc -fmt %Vn
Y:\Order_Management_Products_VOB\TraderWorkstationMS
cleartool desc -fmt %Vn
Y:\Order_Management_Products_VOB\TraderWorkstationMS\Dev
Looking for 'mdsbu01.fw.gsjbw.com /reviewboard/' cookie in
C:\WINNT\Profiles\bldjb001\Local Settings\Application
Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing to
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/new/:
{'repository_path': 'Y:\\'}
url:
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/new/
body: --172.18.240.42.1.3628.1247633073.176.1
Content-Disposition: form-data; name=repository_path
Y:\
--172.18.240.42.1.3628.1247633073.176.1--
body: {'Content-Length': '149', 'Content-Type': 'multipart/form-data;
boundary=172.18.240.42.1.3628.1247633073.176.1'}
Review request created
Attempting to set field 'summary' to 'Test summary' for review request
'10'
HTTP POSTing to
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/10/dr...
{'summary': 'Test summary'}
url:
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/10/dr...
body: --172.18.240.42.1.3628.1247633073.223.2
Content-Disposition: form-data; name=summary
Test summary
--172.18.240.42.1.3628.1247633073.223.2--
body: {'Content-Length': '150', 'Content-Type': 'multipart/form-data;
boundary=172.18.240.42.1.3628.1247633073.223.2'}
Attempting to set field 'description' to 'VIEW: bldjb001_view3
VIEWTYPE: dynamic
Test desc' for review request '10'
HTTP POSTing to
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/10/dr...
{'description': 'VIEW: bldjb001_view3\nVIEWTYPE: dynamic\nTest desc'}
url:
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/10/dr...
body: --172.18.240.42.1.3628.1247633073.301.3
Content-Disposition: form-data; name=description
VIEW: bldjb001_view3
VIEWTYPE: dynamic
Test desc
--172.18.240.42.1.3628.1247633073.301.3--
body: {'Content-Length': '190', 'Content-Type': 'multipart/form-data;
boundary=172.18.240.42.1.3628.1247633073.301.3'}
HTTP POSTing to
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/10/dr...
{}
url:
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/10/dr...
body: --172.18.240.42.1.3628.1247633073.363.4--
body: {'Content-Length': '45', 'Content-Type': 'multipart/form-data;
boundary=172.18.240.42.1.3628.1247633073.363.4'}
Review request draft saved
Uploading diff, size: 481
HTTP POSTing to
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/10/di...
{'basedir': 'Y:\\'}
url:
http://mdsbu01.fw.gsjbw.com/reviewboard/api/json/reviewrequests/10/di...
body: --172.18.240.42.1.3628.1247633073.426.5
Content-Disposition: form-data; name=basedir
Y:\
Re: About post-review and mercurial
Hi Christian!
First at all thanks for your reply.
Here the command with --debug and yes, hg is in my path, I type hg
and all if fine(I have hg installed using distro binaries, ubuntu 9.04
in my case), I even type hg root and all is fine, but what I see is
that svn(see below) isn't a hg command and not have idea of what is
cleartool pwv -short.
$ post-review --debug --server=https://frankabel.cujae.edu.cu/
reviewboard/ reviewboard/ --username=frankabel --password=PpMeOv606 --
revision-range=35:38
hg root
hg svn info
cleartool pwv -short
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2254, in main
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2206, in
determine_client
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 744, in
get_repository_info
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 1898, in execute
File /usr/lib/python2.6/subprocess.py, line 595, in __init__
errread, errwrite)
File /usr/lib/python2.6/subprocess.py, line 1092, in
_execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
Cheers
Frank Abel
On Jul 20, 2:57 am, Christian Hammond chip...@chipx86.com wrote:
Hi Frank,
It seems the line numbers have changed quite a bit between that version and
SVN HEAD, but the first thing to check is that hg is in your path.
If you run with --debug, you'll get more information about what command it's
trying to execute.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Jul 19, 2009 at 12:07 PM, frankabel frank.abel...@gmail.com wrote:
Hi all,
Here what I get while trying uses post-review command inside a
mercurial repo:
$ post-review --server=https://frankabel.cujae.edu.cu/reviewboard/
reviewboard/
https://frankabel.cujae.edu.cu/reviewboard/%0Areviewboard/--username=frankabel
--password=PpMeOv606 --revision-
range=35:38
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2254, in main
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2206, in
determine_client
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 744, in
get_repository_info
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 1898, in execute
File /usr/lib/python2.6/subprocess.py, line 595, in __init__
errread, errwrite)
File /usr/lib/python2.6/subprocess.py, line 1092, in
_execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
$
Any help? What I'm doing wrong? If anybody have experience with
reviewboard and mercurial, would be nice see what about http://
groups.google.com/group/mercurial_general/browse_thread/thread/
b53558ae8182ba8chttp://groups.google.com/group/mercurial_general/browse_thread/thread...
too.
Cheers
Frank Abel
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: problems running rb 1.0 in an apache subdir
Just out of curiosity, does anyone on this list successfully use a RB install deployed in a subdir like http://www.mysite.com/reviewboard ? Should I just give up and use a subdomain? Paolo Il giorno mer, 15/07/2009 alle 23.06 +0200, Paolo Borelli ha scritto: Il giorno mer, 15/07/2009 alle 13.39 -0700, Christian Hammond ha scritto: Hmm, I'm not aware of anything changing between RC2 and 1.0 that would affect this. Did you by any chance upgrade Django in the process? Or anything else? I think a bunch of ubuntu package updates (including python and apache) could have been installed since I last looked, but django was installed with rb not using a distro package. Also, just to make sure, did you run rb-site upgrade /path/to/site? Yes, I did. Paolo Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Jul 15, 2009 at 11:17 AM, Paolo Borelli paolo.bore...@gmail.com wrote: Hi, I am trying to install reviewboard so that pages get served from something like http://dev.mycompany.com/reviews And when I installed rc2 some time ago it was working correctly. Today I upgraded to 1.0 after the machine running rb was brought back up (it was down for some days) and rb does not work anymore: rb is up, but I get the following message If you're pretty sure this page does exist, try logging in and trying again. If you click on logging in you are directed to http://dev.mycompany.com/reviews/reviews/account/login/ (note the double 'reviews') As far as I know nothing else changed on the machine. Do you have any suggestion on how to achieve that and on why this stopped working after the upgrade? here is the relevant apache config I am using: ... # ReviewBoard customization # Serve django pages Location /reviews/ PythonPath ['/var/www/reviews/conf'] + sys.path SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetEnv PYTHON_EGG_CACHE /var/www/reviews/tmp/egg_cache SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_reviewboard /Location # Serve static media without running it through mod_python # (overrides the above) Location /reviews/media SetHandler None /Location Location /reviews/errordocs SetHandler None /Location Directory /var/www/reviews/htdocs AllowOverride All /Directory # Alias static media requests to filesystem Alias /reviews/media /var/www/reviews/htdocs/media Alias /reviews/errordocs /var/www/reviews/htdocs/errordocs ... and in settings_local.py I have SITE_ROOT = '/reviews/' Thanks Paolo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: problems running rb 1.0 in an apache subdir
Yes. I blogged about it here: http://www.thecrumb.com/2009/07/03/review-board-code-reviews-made-easy-installation/ I'm a bit stuck now however because the diff tool doesn't support ColdFusion so reviews work but the diff view is a bit off. Jim On Mon, Jul 20, 2009 at 8:24 AM, Paolo Borellipaolo.bore...@gmail.com wrote: Just out of curiosity, does anyone on this list successfully use a RB install deployed in a subdir like http://www.mysite.com/reviewboard ? Should I just give up and use a subdomain? Paolo Il giorno mer, 15/07/2009 alle 23.06 +0200, Paolo Borelli ha scritto: Il giorno mer, 15/07/2009 alle 13.39 -0700, Christian Hammond ha scritto: Hmm, I'm not aware of anything changing between RC2 and 1.0 that would affect this. Did you by any chance upgrade Django in the process? Or anything else? I think a bunch of ubuntu package updates (including python and apache) could have been installed since I last looked, but django was installed with rb not using a distro package. Also, just to make sure, did you run rb-site upgrade /path/to/site? Yes, I did. Paolo Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Jul 15, 2009 at 11:17 AM, Paolo Borelli paolo.bore...@gmail.com wrote: Hi, I am trying to install reviewboard so that pages get served from something like http://dev.mycompany.com/reviews And when I installed rc2 some time ago it was working correctly. Today I upgraded to 1.0 after the machine running rb was brought back up (it was down for some days) and rb does not work anymore: rb is up, but I get the following message If you're pretty sure this page does exist, try logging in and trying again. If you click on logging in you are directed to http://dev.mycompany.com/reviews/reviews/account/login/ (note the double 'reviews') As far as I know nothing else changed on the machine. Do you have any suggestion on how to achieve that and on why this stopped working after the upgrade? here is the relevant apache config I am using: ... # ReviewBoard customization # Serve django pages Location /reviews/ PythonPath ['/var/www/reviews/conf'] + sys.path SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetEnv PYTHON_EGG_CACHE /var/www/reviews/tmp/egg_cache SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_reviewboard /Location # Serve static media without running it through mod_python # (overrides the above) Location /reviews/media SetHandler None /Location Location /reviews/errordocs SetHandler None /Location Directory /var/www/reviews/htdocs AllowOverride All /Directory # Alias static media requests to filesystem Alias /reviews/media /var/www/reviews/htdocs/media Alias /reviews/errordocs /var/www/reviews/htdocs/errordocs ... and in settings_local.py I have SITE_ROOT = '/reviews/' Thanks Paolo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: email not working
I would test smtp via telnet from the review board server. Try sending mail that way. Many companies may restrict use of smtp to certain hosts to avoid it being used for spam. http://www.messagingtalk.org/content/470.html On Jul 20, 3:35 am, chris ch...@thebayleys.net wrote: Thanks for your reply Christian The mail server concerned is the company's central mail server and it cooperates well with 'Trac' when trac is configured with no more than the server's ip:port When you say configured correctly do you mean that there is any greater requirement than smtp on 25 ? I have no administration over that server but I do have an exim instance that I could test against. Is there no logging at all of email activity/connections etc within the RB/django logging subsystems ? Thanks and Kind regards, Chris BAYLEY --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ClearCase and Reviewboard setup.
Well, it looks like you are having the same problem as in another
thread, however both have Clearcase in common. Everything is working
okay in the post-review half of things, so my guess is something is
going wrong trying to access the base files from Clearcase on the
server side.
It looks like you are running Windows, but your basedir and
repository_path are '/sw0' which looks unix-like. Are you sure you
have the repository path configured correctly on the server? If it's a
dynamic view, it ought to just be a root drive letter like X:/.
Dan
On Jul 20, 6:37 am, Karthik karthikeyan1...@gmail.com wrote:
Hi Dan,
I have done the changes to make it work with Clearcase. I have
followed all the steps you have mentioned. I am using dynamic
clearcase view only. When I run the post-review script, it hangs when
it tries to post the diff content. But I can see the diff content if I
use output-diff option for post-review. Following are the output taken
from post-review script.
karthik-wx ct lsco -cview -me -short -rec | sed s//\//g | xargs
python C:/Python25/Scripts/post-review --server=http://localhost:
8082 --submit-as=karthik --password=mywork –d
C:\Python25\lib\site-packages\rbtools-0.2beta1-py2.5.egg\EGG-INFO
\scripts\post-review cleartool pwv -short
repository info: Path: /sw0, Base path: /sw0, Supports changesets: False
cleartool desc -pre K:\sw0\software\code\include\techMgr.h
Looking for 'localhost /' cookie in C:\Documents and
Settings\karthik\Local Settings\Application Data\.post-review-cookies.txt
Cookie file loaded, but no cookie for this server
== Review Board Login Required
Enter username and password for Review Board athttp://localhost:8082/
Logging in with username karthik
HTTP POSTing
tohttp://localhost:8082/api/json/accounts/login/:{'username': 'karthik',
'password': '**'}
Logged in.
Attempting to create review request for None
Submitting the review request as karthik
HTTP POSTing
tohttp://localhost:8082/api/json/reviewrequests/new/:{'repository_path':
'/sw0',
'submit_as': 'karthik'} Review request created
Attempting to set field 'description' to 'karthik_view_9.0BugFix
VIEWTYPE: dynamic
' for review request '6' HTTP POSTing
tohttp://localhost:8082/api/json/reviewrequests/6/draft/set/:{'description':
'karthik_view_9.0BugFix\nVIEWTYPE: dynamic\n'}
HTTP POSTing
tohttp://localhost:8082/api/json/reviewrequests/6/draft/save/:{}
Review request draft saved
Uploading diff, size: 548
HTTP POSTing
tohttp://localhost:8082/api/json/reviewrequests/6/diff/new/:{'basedir':
'/sw0'}
It hangs after this line ---
Please let me know If I miss any configuration or something.
Thanks,
Karthik
On Jul 18, 6:05 am, Dan Savilonis d...@n-cube.org wrote:
The requirements to use post-review with clearcase are the same as
with any other version control system. The only difference is you pass
a list of filenames as arguments to the script that you want to
review:
python post-review --server=http://example.com/file1.cfile2.c
file3.c
If post-review doesn't work, easy_install rbtools should install the
python dependencies.
Dan
On Jul 17, 8:11 pm, 吴开春 wukaic...@gmail.com wrote:
请教一下，你装起来用了没有？
On Jul 17, 10:23 pm, Dan Savilonis d...@n-cube.org wrote:
It is not required. post-review simply includes support for cygwin
(i.e. path translation since cleartool does not understand cygwin
paths). My example used sed and xargs to make it easier, so that's the
only reason I suggested having the tools in your path. This feature
can eventually be added to post-review to automatically collect
checked out files.
Dan
On Jul 17, 6:50 am, 夏勇杰 notox...@gmail.com wrote:
Hi Dan,
I have some questions about post review.
Should we install cygwin for post-review in order to make it work with
Clearcase?
On Jul 17, 9:32 am, Dan Savilonis d...@n-cube.org wrote:
I went through a fresh installation of reviewboard withClearcase
today and recorded the steps.
Here's what you need to do to get up and running. For the purpose of
this test, I used a dynamic view and was running the server on the
same machine as I had the view and did a review of checked out
files.
1) Add reviewboard.scmtools.clearcase.ClearCaseTool in the admin
interface (Home Scmtools Tools), if using ReviewBoard 1.0. This
step is not necessary if you're running svn revision = r2041.
2) Add aClearCaserepository via the admin interface, and specify a
path to your view (I used the top of the view, not the vob).
3) Apply the patch fromhttp://reviews.review-board.org/r/906/toyour
post-review script.
4) Edit post-review ClearCaseClient class. Change cc_rootpath to be
identical to what you typed into the admin interface, change
viewtype
to 'dynamic' (if you're trying this with a dynamic
Re: About post-review and mercurial
Friendly reminder: please don't post passwords or other sensitive
information on the mailing list.
What's happening is that it's falling through mercurial detection into
clearcase, and it fails to detect any vcs. It will test for a
mercurial-svn repository first, so you should expect that to fail
before it tries to detect a pure mercurial repo.
One thing to check:
run hg svn info
Does the response start with 'abort:'? If not, the script is looking
for this, and will assume it IS an hg-svn repo otherwise. This
actually looks like the only codepath that is possible (that I see)
given the debug trace you provided.
Dan
On Jul 20, 7:34 am, frankabel frank.abel...@gmail.com wrote:
Hi Christian!
First at all thanks for your reply.
Here the command with --debug and yes, hg is in my path, I type hg
and all if fine(I have hg installed using distro binaries, ubuntu 9.04
in my case), I even type hg root and all is fine, but what I see is
that svn(see below) isn't a hg command and not have idea of what is
cleartool pwv -short.
revision-range=35:38 hg root
hg svn info
cleartool pwv -short
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2254, in main
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2206, in
determine_client
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 744, in
get_repository_info
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 1898, in execute
File /usr/lib/python2.6/subprocess.py, line 595, in __init__
errread, errwrite)
File /usr/lib/python2.6/subprocess.py, line 1092, in
_execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
Cheers
Frank Abel
On Jul 20, 2:57 am, Christian Hammond chip...@chipx86.com wrote:
Hi Frank,
It seems the line numbers have changed quite a bit between that version and
SVN HEAD, but the first thing to check is that hg is in your path.
If you run with --debug, you'll get more information about what command it's
trying to execute.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Jul 19, 2009 at 12:07 PM, frankabel frank.abel...@gmail.com wrote:
Hi all,
Here what I get while trying uses post-review command inside a
mercurial repo:
$ post-review --server=https://frankabel.cujae.edu.cu/reviewboard/
reviewboard/
https://frankabel.cujae.edu.cu/reviewboard/%0Areviewboard/--username=frankabel
--password=PpMeOv606 --revision-
range=35:38
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2254, in main
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2206, in
determine_client
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 744, in
get_repository_info
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 1898, in execute
File /usr/lib/python2.6/subprocess.py, line 595, in __init__
errread, errwrite)
File /usr/lib/python2.6/subprocess.py, line 1092, in
_execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
$
Any help? What I'm doing wrong? If anybody have experience with
reviewboard and mercurial, would be nice see what about http://
groups.google.com/group/mercurial_general/browse_thread/thread/
b53558ae8182ba8chttp://groups.google.com/group/mercurial_general/browse_thread/thread...
Re: Perforce server security level error when post a review
Thansk, Tom.
Just as what you said, I need to modify the perforce.py and add run_login()
just behind self.p4.connect() in function _connect().
I tried the p4.run_login() but it didn't work.
So I wrote my own run_login() as:
===
def run_login(self):
os.popen('echo %s | p4 -p %s -u %s login -a' % (self.p4.password,
self.p4.port, self.p4.user))
===
Then everything is OK! RB is great!
Hope it's useful for other guys who have the same problem.
Regards,
Yongqiang
On Mon, Jun 29, 2009 at 8:34 AM, Tom Sakkos nasis...@gmail.com wrote:
I wouldn't know where to put this in ReviewBoard, but it's probably
necessary to run run_login() on the p4 object immediately after running
connect().
-Tom
On Mon, Jun 29, 2009 at 2:13 AM, Jason Lee jasonleeh...@gmail.com wrote:
Hi guys,
I met another problem when post a perforce review.
I install the RB on Windows.
The command is : post-review.py -d 118527
And then I met a perforce exception.
The logs are below:
P4Exception at /api/json/reviewrequests/new/
[P4#run] Errors during command execution( p4 describe -s 118527 )
[Error]: Password not allowed at this server security level, use
'p4
login'.
Request Method: POST
Request URL:http://127.0.0.1:80/api/json/reviewrequests/new/
Exception Type: P4Exception
Exception Value:
[P4#run] Errors during command execution( p4 describe -s 118527 )
[Error]: Password not allowed at this server security level, use
'p4
login'.
Exception Location: C:\Python25\lib\site-packages\P4.py in run, line
284
Python Executable: D:\Program Files\Apache Software Foundation
\Apache2.2\bin\httpd.exe
Python Version: 2.5.4
Python Path:
Server time:Fri, 26 Jun 2009 17:56:01 +0800
===
I think that's because of the higher P4 server security level. Because
when I use my own perforce server with default security level, I can
post the review successfully.
Anyone knows how to fix this problem?
Thanks.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Issue 1228 in reviewboard: Support to upload description, test report to review board.
Updates: Status: NeedInfo Comment #1 on issue 1228 by chipx86: Support to upload description, test report to review board. http://code.google.com/p/reviewboard/issues/detail?id=1228 I'm a little confused by the description. Are you saying you want to be able to attach a file containing the test information, rather than putting it in the Testing Done? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1228 in reviewboard: Support to upload description, test report to review board.
Comment #2 on issue 1228 by praveenlh: Support to upload description, test report to review board. http://code.google.com/p/reviewboard/issues/detail?id=1228 Yes, sometimes the testing output obtained will be very huge. Pasting that in Test Done box will not looks good. So if there is option of uploading the test report file then it will be good ( Both options can be given, putting in Test Done or uploading the file). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1228 in reviewboard: Support to upload description, test report to review board.
Updates: Status: Duplicate Mergedinto: 239 Comment #3 on issue 1228 by chipx86: Support to upload description, test report to review board. http://code.google.com/p/reviewboard/issues/detail?id=1228 Okay, makes sense. This would be handled then by bug #239. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
