Download diff
Is there a way to download a diff through the formal JSON api? I realize the diff could be downloaded through a GET call to http://reviewboard/r/id/diff/raw But given that all of the REST API URLs begin with /api/json/, I'm wondering if there is something I'm missing. H.M. --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How to confiure EMAILS for Reviews
THANKS...It started working now. One issue I see is this For the existing review, If I add more people and click on Publish changes, I get below error. What is this regarding? SMTPException at /api/json/reviewrequests/9/publish/ SMTP AUTH extension not supported by server.Request Method: POST Request URL: http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/9/publish/ Exception Type: SMTPException Exception Value: SMTP AUTH extension not supported by server. Exception Location: /opt/lampp/lib/python2.5/smtplib.py in login, line 554 Python Executable: /tools/bin/python Python Version: 2.5.2 Python Path: ['/opt/lampp/htdocs/reviewboard/conf', '/opt/lampp/lib/ python2.5/site-packages/django', '/opt/lampp/lib/python2.5/site- packages/reviewboard', '/opt/lampp/lib/python2.5/site-packages/ MySQL_python-1.2.2-py2.5-linux-i686.egg', '/opt/lampp/lib/python2.5/ site-packages/setuptools-0.6c9-py2.5.egg', '/opt/lampp/lib/python2.5/ site-packages/ReviewBoard-1.0.3.1-py2.5.egg', '/opt/lampp/lib/ python2.5/site-packages/pytz-2009l-py2.5.egg', '/opt/lampp/lib/ python2.5/site-packages/flup-1.0.3.dev_20090716-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/Pygments-1.1.1-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/Djblets-0.5.3-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/django_evolution-0.0.0-py2.5.egg', '/ opt/lampp/lib/python2.5/site-packages/Django-1.1-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/PIL-1.1.6-py2.5-linux-i686.egg', '/ opt/lampp/lib/python2.5/site-packages/RBTools-0.2beta2-py2.5.egg', '/ opt/lampp/lib/python2.5/site-packages/simplejson-2.0.9-py2.5-linux- i686.egg', '/opt/lampp/lib/python2.5/site-packages/python_ldap-2.3.9- py2.5-linux-i686.egg', '/opt/lampp/lib/python25.zip', '/opt/lampp/lib/ python2.5', '/opt/lampp/lib/python2.5/plat-linux2', '/opt/lampp/lib/ python2.5/lib-tk', '/opt/lampp/lib/python2.5/lib-dynload', '/opt/lampp/ lib/python2.5/site-packages'] Server time: Wed, 4 Nov 2009 09:19:16 -0800 On Nov 3, 11:20 pm, Christian Hammond chip...@chipx86.com wrote: What mail server do you use? Also, give this a try: rb-site manage /path/to/site shell At the prompt: from django.core.mail import send_mail send_mail(Test Subject, This is a test, youraddr...@yourdomain.com, [youraddr...@yourdomain.com], fail_silently=False) That *should* send an e-mail to the address you specify, using the e-mail settings in Review Board. If that fails, hopefully you'll see why. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Nov 3, 2009 at 5:04 PM, Kunjal kunjal.par...@gmail.com wrote: Chris, I have set the correct smtp host/port etc. but I still do not get email. Do I need to modify email.py file to get the email? Thanks Kunjal On Nov 2, 3:47 pm, Christian Hammond chip...@chipx86.com wrote: You should be able to configure that in the E-mail Settings part of the Admin UI. If e-mail is not working correctly, then it's an issue talking to the mail server. Unfortunately, going through Django's e-mail infrastructure means that we don't get any detailed error logging. Assuming the mail server is under your control, you may want to check your mail server logs if your e-mail is enabled/configured properly and you're still not seeing anything. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Nov 2, 2009 at 4:05 PM, Kunjal kunjal.par...@gmail.com wrote: We have RB 1.0.3 with Perforce integration. We have set up Apache server and everything works fine like posting review, publshing review, updating diff etc. We do not get any emails though once the review is posted etc. how to configure email settings? Thanks Kunjal To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~ Hide quoted text - - Show quoted text - To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~ Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this
Re: How to confiure EMAILS for Reviews
Sounds like you specified a username/password for the mail server, but the mail server doesn't support authentication. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Nov 4, 2009 at 9:20 AM, Kunjal kunjal.par...@gmail.com wrote: THANKS...It started working now. One issue I see is this For the existing review, If I add more people and click on Publish changes, I get below error. What is this regarding? SMTPException at /api/json/reviewrequests/9/publish/ SMTP AUTH extension not supported by server.Request Method: POST Request URL: http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/9/publish/ Exception Type: SMTPException Exception Value: SMTP AUTH extension not supported by server. Exception Location: /opt/lampp/lib/python2.5/smtplib.py in login, line 554 Python Executable: /tools/bin/python Python Version: 2.5.2 Python Path: ['/opt/lampp/htdocs/reviewboard/conf', '/opt/lampp/lib/ python2.5/site-packages/django', '/opt/lampp/lib/python2.5/site- packages/reviewboard', '/opt/lampp/lib/python2.5/site-packages/ MySQL_python-1.2.2-py2.5-linux-i686.egg', '/opt/lampp/lib/python2.5/ site-packages/setuptools-0.6c9-py2.5.egg', '/opt/lampp/lib/python2.5/ site-packages/ReviewBoard-1.0.3.1-py2.5.egg', '/opt/lampp/lib/ python2.5/site-packages/pytz-2009l-py2.5.egg', '/opt/lampp/lib/ python2.5/site-packages/flup-1.0.3.dev_20090716-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/Pygments-1.1.1-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/Djblets-0.5.3-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/django_evolution-0.0.0-py2.5.egg', '/ opt/lampp/lib/python2.5/site-packages/Django-1.1-py2.5.egg', '/opt/ lampp/lib/python2.5/site-packages/PIL-1.1.6-py2.5-linux-i686.egg', '/ opt/lampp/lib/python2.5/site-packages/RBTools-0.2beta2-py2.5.egg', '/ opt/lampp/lib/python2.5/site-packages/simplejson-2.0.9-py2.5-linux- i686.egg', '/opt/lampp/lib/python2.5/site-packages/python_ldap-2.3.9- py2.5-linux-i686.egg', '/opt/lampp/lib/python25.zip', '/opt/lampp/lib/ python2.5', '/opt/lampp/lib/python2.5/plat-linux2', '/opt/lampp/lib/ python2.5/lib-tk', '/opt/lampp/lib/python2.5/lib-dynload', '/opt/lampp/ lib/python2.5/site-packages'] Server time: Wed, 4 Nov 2009 09:19:16 -0800 On Nov 3, 11:20 pm, Christian Hammond chip...@chipx86.com wrote: What mail server do you use? Also, give this a try: rb-site manage /path/to/site shell At the prompt: from django.core.mail import send_mail send_mail(Test Subject, This is a test, youraddr...@yourdomain.com, [youraddr...@yourdomain.com], fail_silently=False) That *should* send an e-mail to the address you specify, using the e-mail settings in Review Board. If that fails, hopefully you'll see why. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Nov 3, 2009 at 5:04 PM, Kunjal kunjal.par...@gmail.com wrote: Chris, I have set the correct smtp host/port etc. but I still do not get email. Do I need to modify email.py file to get the email? Thanks Kunjal On Nov 2, 3:47 pm, Christian Hammond chip...@chipx86.com wrote: You should be able to configure that in the E-mail Settings part of the Admin UI. If e-mail is not working correctly, then it's an issue talking to the mail server. Unfortunately, going through Django's e-mail infrastructure means that we don't get any detailed error logging. Assuming the mail server is under your control, you may want to check your mail server logs if your e-mail is enabled/configured properly and you're still not seeing anything. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Nov 2, 2009 at 4:05 PM, Kunjal kunjal.par...@gmail.com wrote: We have RB 1.0.3 with Perforce integration. We have set up Apache server and everything works fine like posting review, publshing review, updating diff etc. We do not get any emails though once the review is posted etc. how to configure email settings? Thanks Kunjal To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~ Hide quoted text - - Show quoted text - To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit
Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Comment #3 on issue 1382 by robert.munteanu: Inline review comments are not saved with Firefox 3.6 http://code.google.com/p/reviewboard/issues/detail?id=1382 1. It is the big review dialog. The comments are present in the diff viewer, even if I go to the View reviews page and then come back to the diff viewer. But once I go to 'Edit review' to publish the review, the inline comments are empty, but the lines they are attached to are listed as expected. 2.Shift-reload does not change anything. This was working properly on Firefox 3.5 FWIW. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Comment #4 on issue 1382 by robert.munteanu: Inline review comments are not saved with Firefox 3.6 http://code.google.com/p/reviewboard/issues/detail?id=1382 This is how the comments section of the review dialog appears. The comment line ( 22 here ) is attached, with the proper contents, but the comment text ( 'Sample comment' ) is instead empty. Attachments: review-board-missing-comment.jpg 14.1 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Comment #5 on issue 1382 by robert.munteanu: Inline review comments are not
saved with Firefox 3.6
http://code.google.com/p/reviewboard/issues/detail?id=1382
Firebug does not catch any errors, and I got the following XMLHttpRequest
message:
pre
div id=review-form-comments class=review
pinput id=id_shipit class=recommendation type=checkbox / label
for=id_shipitShip It/label/p
pre class=body-top editable/pre
div class=comments
dl class=diff-comments
dt
div id=review_draft_comment_container_191
table class=sidebyside loading
thead
tr
th class=filename
a name=/r/47/diff/5/?file=312#file312line22/xxxfile/a
span class=diffrevision
(Diff revision 5)
/span
/th
/tr
/thead
tbody
trtdprenbsp;/pre/th/tr
/tbody
/table
/div
/dt
dd
pre class=editable comment-editable id=diff-comment-191Sample
comment./pre
script type=text/javascript
var editor = $(#diff-comment-191).reviewFormCommentEditor({
path: getDiffAPIPath(5,
312,
null, null,
22),
data: {
action: set,
num_lines: 1
}
});
$(#edit-diff-comment-191).click(function() {
editor.inlineEditor(startEdit);
});
queueLoadDiffFragment(review_draft_diff_comments, 191,
312
);
/script
/dd
/dl
/div
pre class=body-bottom editable/pre
/div
/pre
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Re: Issue 1382 in reviewboard: Inline review comments are not saved with Firefox 3.6
Comment #6 on issue 1382 by robert.munteanu: Inline review comments are not
saved with Firefox 3.6
http://code.google.com/p/reviewboard/issues/detail?id=1382
Firebug does not catch any errors, and I got the following XMLHttpRequest
message:
div id=review-form-comments class=review
pinput id=id_shipit class=recommendation type=checkbox / label
for=id_shipitShip It/label/p
pre class=body-top editable/pre
div class=comments
dl class=diff-comments
dt
div id=review_draft_comment_container_191
table class=sidebyside loading
thead
tr
th class=filename
a name=/r/47/diff/5/?file=312#file312line22/xxxfile/a
span class=diffrevision
(Diff revision 5)
/span
/th
/tr
/thead
tbody
trtdprenbsp;/pre/th/tr
/tbody
/table
/div
/dt
dd
pre class=editable comment-editable id=diff-comment-191Sample
comment./pre
script type=text/javascript
var editor = $(#diff-comment-191).reviewFormCommentEditor({
path: getDiffAPIPath(5,
312,
null, null,
22),
data: {
action: set,
num_lines: 1
}
});
$(#edit-diff-comment-191).click(function() {
editor.inlineEditor(startEdit);
});
queueLoadDiffFragment(review_draft_diff_comments, 191,
312
);
/script
/dd
/dl
/div
pre class=body-bottom editable/pre
/div
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
