Re: RBTools 0.5.3 is released!
On 01/01/2014 11:58 PM, Christian Hammond wrote: Hey everyone, Happy New Year! We have a new RBTools release out that fixes a number of bugs and greatly enhances rbt post and rbt patch. It also introduces a new rbt setup-repo for more easily setting up a repository. We have more details in the news post at http://www.reviewboard.org/news/2014/01/01/rbtools-0-5-3-released/ Builds for Fedora and EPEL are now ready and will be hitting the updates-testing repositories within 48 hours. Sorry for the delay! You can download the updated packages manually from: https://admin.fedoraproject.org/updates/search/RBTools -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: rbt status not working with perforce
Done:
https://code.google.com/p/reviewboard/issues/detail?id=3184
Thanks
--Steve
On Saturday, December 28, 2013 1:37:27 PM UTC-8, David Trowbridge wrote:
Would you mind filing a bug?
Thanks!
On Fri, Dec 27, 2013 at 1:06 PM, Steve seide...@gmail.com
javascript:wrote:
I see it in 0.5.2 on CentOS 6 and in 0.5.2.dev on my Mac. Our ReviewBoard
server is 1.7.14. Here's the debug output:
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: ['redacted'], Base path: None, Supports
changesets: True
Traceback (most recent call last):
File /Users/sallan/envs/rbtools-master-2.6/bin/rbt, line 8, in
module
load_entry_point('RBTools==0.5.2.dev', 'console_scripts', 'rbt')()
File /Users/sallan/PycharmProjects/rbtools/rbtools/commands/main.py,
line 113, in main
command.run_from_argv([RB_MAIN] + args)
File
/Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py, line
157, in run_from_argv
exit_code = self.main(*args) or 0
File
/Users/sallan/PycharmProjects/rbtools/rbtools/commands/status.py, line
60, in main
client_name=self.options.repository_type)
File
/Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py, line
188, in initialize_scm_tool
tool.check_options()
File
/Users/sallan/PycharmProjects/rbtools/rbtools/clients/perforce.py, line
298, in check_options
if self.options.revision_range:
AttributeError: Values instance has no attribute 'revision_range'
--Steve
On Friday, December 27, 2013 12:17:10 PM UTC-8, David Trowbridge wrote:
I don't think we've seen this particular issue before. What version of
rbtools are you using?
-David
On Fri, Dec 27, 2013 at 12:13 PM, Steve seide...@gmail.com wrote:
I didn't see an issue for this in buzilla, but before I post a bug I
thought I'd check here. I'm using perforce, and when I run 'rbt status' I
get an error. If I simply create an empty git repository, it choses that
instead of perforce, and then it returns the expected results:
% rbt status
CRITICAL:root:Values instance has no attribute 'revision_range'
% git init
Initialized empty Git repository in /home/sallan/cmscripts/.git/
% rbt status
WARNING:root:The repository detected in the current directory was not
found on
the Review Board server. Displaying review requests from all
repositories.
r/79412 - Try with a smaller set of files.
snip remaining list
Is this already a know issue?
--Steve
--
Get the Review Board Power Pack at http://www.reviewboard.org/
powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google
Groups reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send
an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard...@googlegroups.com javascript:.
For more options, visit https://groups.google.com/groups/opt_out.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
How to auto fill 'Branch' valune by post-review?
I mean the branch displayed on the left-up of web interface, I'm using git and post-review, I'd like rb can detect which branch for the posted commit, thanks. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: How to auto fill 'Branch' valune by post-review?
You can use the --branch parameter, or add a BRANCH definition to a .reviewboardrc file which is been added to the repository. -David On Mon, Jan 6, 2014 at 10:03 PM, Qi Luo qilu...@gmail.com wrote: I mean the branch displayed on the left-up of web interface, I'm using git and post-review, I'd like rb can detect which branch for the posted commit, thanks. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3184 in reviewboard: rbt status fails with perforce repository
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3184 by seide.al...@gmail.com: rbt status fails with perforce
repository
http://code.google.com/p/reviewboard/issues/detail?id=3184
What version are you running?
RBTools 0.5.2 and 0.5.2.dev
ReviewBoard 1.7.14
What's the URL of the page containing the problem?
NA
What steps will reproduce the problem?
1. Attempt to list pending reviews from a ReviewBoard server using
perforce as the repository.
What is the expected output? What do you see instead?
% rbt status -d
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info --non-interactive
DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: '/Users/sallan/PycharmProjects/rb_reports' is not a working
copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Running: hg showconfig
DEBUG:root:Running: hg root
DEBUG:root:Command exited with rc 255: ['hg', 'root']
abort: no repository found in '/Users/sallan/PycharmProjects/rb_reports'
(.hg not found)!
---
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: ['redacted'], Base path: None, Supports
changesets: True
Traceback (most recent call last):
File /Users/sallan/envs/rbtools-master-2.6/bin/rbt, line 8, in module
load_entry_point('RBTools==0.5.2.dev', 'console_scripts', 'rbt')()
File /Users/sallan/PycharmProjects/rbtools/rbtools/commands/main.py,
line 113, in main
command.run_from_argv([RB_MAIN] + args)
File /Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py,
line 157, in run_from_argv
exit_code = self.main(*args) or 0
File /Users/sallan/PycharmProjects/rbtools/rbtools/commands/status.py,
line 60, in main
client_name=self.options.repository_type)
File /Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py,
line 188, in initialize_scm_tool
tool.check_options()
File /Users/sallan/PycharmProjects/rbtools/rbtools/clients/perforce.py,
line 298, in check_options
if self.options.revision_range:
AttributeError: Values instance has no attribute 'revision_range'
What operating system are you using? What browser?
Tested on MacOS X and CentOS6.
Please provide any additional information below.
If I create an emtpy git repository, it uses that instead of perforce and
works as expected:
% git init
Initialized empty Git repository in
/Users/sallan/PycharmProjects/rb_reports/.git/
(rbtools-master-2.6)[sallan@buffy]~/PycharmProjects/rb_reports% rbt status
-d
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info --non-interactive
DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: '/Users/sallan/PycharmProjects/rb_reports' is not a working
copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Running: git config core.bare
DEBUG:root:Running: git rev-parse --show-toplevel
DEBUG:root:Running: git symbolic-ref -q HEAD
DEBUG:root:Running: git config --get git-p4.port
DEBUG:root:Command exited with rc 1:
['git', 'config', '--get', 'git-p4.port']
---
DEBUG:root:Running: git config --get branch.master.merge
DEBUG:root:Command exited with rc 1:
['git', 'config', '--get', 'branch.master.merge']
---
DEBUG:root:Running: git config --get branch.master.remote
DEBUG:root:Command exited with rc 1:
['git', 'config', '--get', 'branch.master.remote']
---
DEBUG:root:Running: git config --get remote.origin.url
DEBUG:root:Command exited with rc 1:
['git', 'config', '--get', 'remote.origin.url']
---
DEBUG:root:Running: git config --get remote.origin.url
DEBUG:root:Command exited with rc 1:
['git', 'config', '--get', 'remote.origin.url']
---
DEBUG:root:repository info: Path:
/Users/sallan/PycharmProjects/rb_reports/.git, Base path: , Supports
changesets: False
DEBUG:root:Making HTTP GET request to http://giles/api/
DEBUG:root:Making HTTP GET request to http://giles/api/info/
DEBUG:root:Making HTTP GET request to http://giles/api/session/
DEBUG:root:Making HTTP GET request to http://giles/api/users/sallan/
DEBUG:root:Making HTTP GET request to http://giles/api/repositories/
WARNING:root:The repository detected in the current directory was not found
on
the Review Board server. Displaying review requests from all repositories.
DEBUG:root:Making HTTP GET request to
http://giles/api/review-requests/?status=pendingfrom-user=sallanexpand=draft
r/148 - Put this in a numbered CL, then try 'post edit' without first
creating a review.
* r/149 - Make post Python 2.5 compatible.
snip
Re: Issue 3184 in reviewboard: rbt status fails with perforce repository
Updates: Status: NeedInfo Comment #1 on issue 3184 by chip...@gmail.com: rbt status fails with perforce repository http://code.google.com/p/reviewboard/issues/detail?id=3184 Does this still happen with 0.5.3? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3184 in reviewboard: rbt status fails with perforce repository
Comment #2 on issue 3184 by seide.al...@gmail.com: rbt status fails with perforce repository http://code.google.com/p/reviewboard/issues/detail?id=3184 Yes, same error with 0.5.3. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3184 in reviewboard: rbt status fails with perforce repository
Updates: Labels: EasyFix Comment #3 on issue 3184 by trowb...@gmail.com: rbt status fails with perforce repository http://code.google.com/p/reviewboard/issues/detail?id=3184 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3123 in reviewboard: rbt status crashes when run outside of a versioned directory
Updates: Labels: EasyFix Comment #2 on issue 3123 by trowb...@gmail.com: rbt status crashes when run outside of a versioned directory http://code.google.com/p/reviewboard/issues/detail?id=3123 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3078 in reviewboard: Incorrect column sort icon (triangle)
Updates: Labels: EasyFix Comment #1 on issue 3078 by trowb...@gmail.com: Incorrect column sort icon (triangle) http://code.google.com/p/reviewboard/issues/detail?id=3078 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3168 in reviewboard: Next/previous hunk keyboard shortcuts not respecting selected file
Updates: Labels: EasyFix Comment #1 on issue 3168 by trowb...@gmail.com: Next/previous hunk keyboard shortcuts not respecting selected file http://code.google.com/p/reviewboard/issues/detail?id=3168 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3185 in reviewboard: Review request dashboard always makes the third column wide
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3185 by jamesd...@gmail.com: Review request dashboard always makes the third column wide http://code.google.com/p/reviewboard/issues/detail?id=3185 What version are you running? 2.0 beta 2 (dev) What's the URL of the page containing the problem? http://demo.reviewboard.org/dashboard/ What steps will reproduce the problem? 1. Drag a column from the right of the Summary column to the left of it. What is the expected output? What do you see instead? I expect that the Summary column always should be the widest column. Instead, it seems that whatever column happens to be the third column from the left becomes the widest column. What operating system are you using? What browser? Firefox 26.0 on Windows 7 x64 SP1 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3185 in reviewboard: Review request dashboard always makes the third column wide
Updates: Status: Confirmed Labels: Milestone-Release2.0 Component-Dashboard Djblets Comment #1 on issue 3185 by chip...@gmail.com: Review request dashboard always makes the third column wide http://code.google.com/p/reviewboard/issues/detail?id=3185 We're probably failing to readjust the colspans with the new code. Thanks, I'll poke at this. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3185 in reviewboard: Review request dashboard always makes the third column wide
Comment #2 on issue 3185 by jamesd...@gmail.com: Review request dashboard always makes the third column wide http://code.google.com/p/reviewboard/issues/detail?id=3185 I just noticed that the problem goes away when I reload the page. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2457 in reviewboard: Add Tooltips to Icons in Column Header
Comment #2 on issue 2457 by jamesd...@gmail.com: Add Tooltips to Icons in Column Header http://code.google.com/p/reviewboard/issues/detail?id=2457 This looks mostly fixed to me. I see tooltips on demo.reviewboard.org now for the icon-based column headers (e.g. Starred, New Updates, Edit columns). The to-me column (which uses raquo; instead of a graphical icon) could use a tooltip, though. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
