Re: Launchpad support ?

[Christian Hammond]

Hi Florent,

It should work by just configuring a repository on Review Board and
providing the bzr URL. I don't believe we need specific support for
Launchpad for this. An SSH key can n generated by Review Board for use with
this repository as well.

If you try it and it doesn't work, though, please let me know and I'll see
what we can do. Bazaar is not often used these days, so it sees less
attention.

Christian


On Sun, Mar 12, 2017 at 09:55 Florent Gallaire  wrote:

> Hello everybody,
>
> Is it possible to add a Launchpad hosted bazaar repository in Review Board
> ?
>
> Cheers
>
> Florent
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review groups UI not letting me delete users....

['Eric Johnson' via reviewboard]

Perfect! Thanks for letting me know!

On Thu, Mar 16, 2017 at 12:37 PM, David Trowbridge 
wrote:

> Eric,
>
> This is a known bug where some of the existing users in the group have
> since been marked "inactive". If you remove those users, you should be able
> to save it.
>
> We're getting a fix in for 2.5.10.
>
> -David
>
> On Thu, Mar 16, 2017 at 9:39 AM eric via reviewboard <
> reviewboard@googlegroups.com> wrote:
>
>> I recently upgraded our deployment of ReviewBoard from 2.0.X to 2.5.9.
>> Now, some of my reviewboard instance owners are reporting that they cannot
>> edit review groups.
>>
>> Specifically, on this page: ${server_root_path}/admin/db/reviews/group/1/
>>
>> the UI for removing users from the a review group doesn't seem to work.
>> When I tried it myself, as superuser, I also ran into problems.
>>
>> In the "ACCESS CONTROL" area of the page, in the box listing the users,
>> the "x" on the right side of each row listing a user - it doesn't highlight
>> for me when I mouse-over the "x". Clicking on the "x" has no effect. I was
>> able to get it to work briefly by adding a user to the group, and then the
>> "x" controls would highlight. However, as soon as I clicked one, they
>> stopped working again.
>>
>> Is this a general problem with the software, or something about our
>> deployment?
>>
>> Thanks!
>>
>> Eric.
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "reviewboard" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/reviewboard/as3plUll1OE/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4532: Long comment hover at the end of a diff causes flickering

[Joshua Olson]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4532/
--

New ticket #4532 by solarmist
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * rb_rave_small.mov
   



--
Long comment hover at the end of a diff causes flickering
==

# What version are you running?
2.5.6.1

# What's the URL of the page containing the problem?
In the diff view of an review request

# What steps will reproduce the problem?
1. Attached video
2. 
3. 


# What is the expected output? What do you see instead?


# What operating system are you using? What browser?
Mac os using Chrome

# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: diffviewer_filediffdata table after 1.7.27 to 2.5.9 upgrade

[Christian Hammond]

Hi Daniel,

You can't get rid of the table (Review Board will break), but you can have
MySQL optimize the table, which should bring the size down:

OPTIMIZE TABLE diffviewer_filediffdata;

Christian


On Thu, Mar 16, 2017 at 09:00 Daniel Kuecker  wrote:

> I recently moved our RB 1.7.27 instance to a 2.5.9 instance.  I restored a
> backup of the 1.7.27 db to the 2.5.9 instance and ran rb-site install and
> waited and waited.  Everything converted successfully and we are now
> running 2.5.9 (our users love it! yay!)
>
> NOTE:  Before the restore, to avoid the InnoDB conversion evolution, I
> manually edited the sql dump, changed the table engines to InnoDB and the
> charset to UTF8 for all tables.
>
> I noticed I still have a diffviewer_filediffdata table that is the same
> size as the original but has zero records.  Is that table needed anymore?
> I'd like to get rid of it as it is 28GB in size.
>
> Thanks!
>
> --DK
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4084: Users without editing rights on a review request do not see the onbeforeunload dialog

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4084/
--

New update by mconley
For Beanbag, Inc. > Review Board > Ticket #4084


Reply:

Fixed in release-2.5.x (176916d). This will ship in 2.5.10.


Status:
- New
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review groups UI not letting me delete users....

[David Trowbridge]

Eric,

This is a known bug where some of the existing users in the group have
since been marked "inactive". If you remove those users, you should be able
to save it.

We're getting a fix in for 2.5.10.

-David

On Thu, Mar 16, 2017 at 9:39 AM eric via reviewboard <
reviewboard@googlegroups.com> wrote:

> I recently upgraded our deployment of ReviewBoard from 2.0.X to 2.5.9.
> Now, some of my reviewboard instance owners are reporting that they cannot
> edit review groups.
>
> Specifically, on this page: ${server_root_path}/admin/db/reviews/group/1/
>
> the UI for removing users from the a review group doesn't seem to work.
> When I tried it myself, as superuser, I also ran into problems.
>
> In the "ACCESS CONTROL" area of the page, in the box listing the users,
> the "x" on the right side of each row listing a user - it doesn't highlight
> for me when I mouse-over the "x". Clicking on the "x" has no effect. I was
> able to get it to work briefly by adding a user to the group, and then the
> "x" controls would highlight. However, as soon as I clicked one, they
> stopped working again.
>
> Is this a general problem with the software, or something about our
> deployment?
>
> Thanks!
>
> Eric.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4513: User selector in the Group configuration breaks for non-active users

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4513/
--

New update by chipx86
For Beanbag, Inc. > Review Board > Ticket #4513


Status:
- Confirmed
+ PendingReview


Assigned to:
+ david

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4516: Invalid utf8 character error when DEBUG = True

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4516/
--

New update by mpaniet
For Beanbag, Inc. > Review Board > Ticket #4516


Reply:

This was fixed in 2.5.8


Status:
- New
+ Duplicate


Duplicate of:
+ 4007


Summary:
-  Invalid utf8 character error when DEBUG = True
+ Invalid utf8 character error when DEBUG = True

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4531: RBTools uses multiple requests to create and publish a review causing submit-as to fail to fully create reviews.

[Joshua Olson]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4531/
--

New ticket #4531 by solarmist
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
RBTools uses multiple requests to create and publish a review causing submit-as 
to fail to fully create reviews.
==

# What version are you running?
2.5.6.1

# What's the URL of the page containing the problem?
N/A

# What steps will reproduce the problem?
1. Create a user 'blah'
2. Give blah permission "reviews | review request | Can submit as another user"
3. rbtools post --submit-as USERNAME
4. View review request in Review Board


# What is the expected output? What do you see instead?
A completely empty review is created with no diff. And RBTools errors out when 
trying to do those steps.  

We expect to be able to fully create a review with only the "Can submit as 
another user" permission.

# What operating system are you using? What browser?
RHEL 6.6 and Mac OS

# Please provide any additional information below.
We have an automated account that should be able to create fully populated 
including attachments reviews as another user and publish that review, but once 
it is posted (either draft or published) that automated user should no longer 
be able to modify that review.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review groups UI not letting me delete users....

[eric via reviewboard]

I recently upgraded our deployment of ReviewBoard from 2.0.X to 2.5.9. Now, 
some of my reviewboard instance owners are reporting that they cannot edit 
review groups.

Specifically, on this page: ${server_root_path}/admin/db/reviews/group/1/

the UI for removing users from the a review group doesn't seem to work. 
When I tried it myself, as superuser, I also ran into problems.

In the "ACCESS CONTROL" area of the page, in the box listing the users, the 
"x" on the right side of each row listing a user - it doesn't highlight for 
me when I mouse-over the "x". Clicking on the "x" has no effect. I was able 
to get it to work briefly by adding a user to the group, and then the "x" 
controls would highlight. However, as soon as I clicked one, they stopped 
working again.

Is this a general problem with the software, or something about our 
deployment?

Thanks!

Eric.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

diffviewer_filediffdata table after 1.7.27 to 2.5.9 upgrade

[Daniel Kuecker]

I recently moved our RB 1.7.27 instance to a 2.5.9 instance.  I restored a 
backup of the 1.7.27 db to the 2.5.9 instance and ran rb-site install and 
waited and waited.  Everything converted successfully and we are now 
running 2.5.9 (our users love it! yay!)

NOTE:  Before the restore, to avoid the InnoDB conversion evolution, I 
manually edited the sql dump, changed the table engines to InnoDB and the 
charset to UTF8 for all tables. 

I noticed I still have a diffviewer_filediffdata table that is the same 
size as the original but has zero records.  Is that table needed anymore? 
 I'd like to get rid of it as it is 28GB in size.

Thanks!

--DK

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.