Re: How to Get the user from the current session.

[Christian Hammond]

You can perform some modifications to the code to turn off caching. You'll
have to do this for file-based caching and all aspects of diff generation.
Your Review Board server may become very slow if you have any real usage of
it, depending on the load, the server, and the repository's response times.
I don't recommend it, and it's not an option we'll ever include in the
product.

The correct solution is to introduce support for optional additional
methods in the SCMTools that would let the diff viewer and API say "Can
this user access this file?", separately from actually fetching the file.
This would let the caching continue to work as-is, but would restrict
access of the files at the correct moments, based on the user and HTTP
request. If designed well, I'd be okay accepting a patch for this, if you
wanted to work on one. We could discuss the design in more detail.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Tue, Mar 21, 2017 at 3:53 PM, Vanaja Narayanaswamy 
wrote:

> Also,  is there a way to  turn off caching and force reviewboard  go to
> the repository every time?
>
> Thanks,
> Vanaja
>
>
> On Tue, Mar 21, 2017 at 3:44 PM, Vanaja Narayanaswamy  > wrote:
>
>> >>Files are also not fetched by that user's account. They're fetched
>> using the credentials set up when configuring the >>repository.
>>
>> We know this. That's why we want to check the user's access first and
>> then fetch.  I thought the get_file method in myscm.py  can first do the
>> check for loggedin user's access in our scm/repo and then fetch if user has
>> access.
>>
>> >>Are your permissions set up per-file, or is it more that they can't
>> access certain hierarchies of the tree?
>> The access rule can be on a file or on  hierarchies.
>>
>> Thanks,
>> Vanaja
>>
>> On Tue, Mar 21, 2017 at 3:34 PM, Christian Hammond 
>> wrote:
>>
>>> You won't be able to solve this the way you're wanting. We aggressively
>>> cache the contents from repositories, and that will happen the first time
>>> the file is requested (if not in cache), meaning that if a user has already
>>> viewed a diff or posted a change against a given file + revision, it will
>>> already be in cache and the SCMTool will not have an ability to weigh in on
>>> whether the file can be accessed.
>>>
>>> Files are also not fetched by that user's account. They're fetched using
>>> the credentials set up when configuring the repository.
>>>
>>> Are your permissions set up per-file, or is it more that they can't
>>> access certain hierarchies of the tree?
>>>
>>> Christian
>>>
>>> --
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>>> On Tue, Mar 21, 2017 at 3:29 PM, Vanaja Narayanaswamy <
>>> vanaja...@gmail.com> wrote:
>>>
 Hi,

 To make sure that user has read access(in our scm)  on the file that is
 being diffed.

 Thanks,
 Vanaja

 On Tue, Mar 21, 2017 at 1:38 PM, Christian Hammond <
 christ...@beanbaginc.com> wrote:

> Hi Vanaja,
>
> SCMTools don't have access to the current HTTP request or user, and we
> can't provide it. What do you need the user for?
>
> Christian
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Tue, Mar 21, 2017 at 11:11 AM, Vanaja Narayanaswamy <
> vanaja...@gmail.com> wrote:
>
>> Hi,
>>
>> When the user is logged into the reviewboard via the browser, I would
>> like to get user info(loginId) to pass it on to my scmtool.  How do I
>> achieve that in scmtools/myscm.py module?
>>
>> Thanks,
>> Vanaja
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google
>> Groups "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "reviewboard" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/to

Re: How to Get the user from the current session.

[Vanaja Narayanaswamy]

Also,  is there a way to  turn off caching and force reviewboard  go to the
repository every time?

Thanks,
Vanaja

On Tue, Mar 21, 2017 at 3:44 PM, Vanaja Narayanaswamy 
wrote:

> >>Files are also not fetched by that user's account. They're fetched using
> the credentials set up when configuring the >>repository.
>
> We know this. That's why we want to check the user's access first and then
> fetch.  I thought the get_file method in myscm.py  can first do the check
> for loggedin user's access in our scm/repo and then fetch if user has
> access.
>
> >>Are your permissions set up per-file, or is it more that they can't
> access certain hierarchies of the tree?
> The access rule can be on a file or on  hierarchies.
>
> Thanks,
> Vanaja
>
> On Tue, Mar 21, 2017 at 3:34 PM, Christian Hammond 
> wrote:
>
>> You won't be able to solve this the way you're wanting. We aggressively
>> cache the contents from repositories, and that will happen the first time
>> the file is requested (if not in cache), meaning that if a user has already
>> viewed a diff or posted a change against a given file + revision, it will
>> already be in cache and the SCMTool will not have an ability to weigh in on
>> whether the file can be accessed.
>>
>> Files are also not fetched by that user's account. They're fetched using
>> the credentials set up when configuring the repository.
>>
>> Are your permissions set up per-file, or is it more that they can't
>> access certain hierarchies of the tree?
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Tue, Mar 21, 2017 at 3:29 PM, Vanaja Narayanaswamy <
>> vanaja...@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> To make sure that user has read access(in our scm)  on the file that is
>>> being diffed.
>>>
>>> Thanks,
>>> Vanaja
>>>
>>> On Tue, Mar 21, 2017 at 1:38 PM, Christian Hammond <
>>> christ...@beanbaginc.com> wrote:
>>>
 Hi Vanaja,

 SCMTools don't have access to the current HTTP request or user, and we
 can't provide it. What do you need the user for?

 Christian

 --
 Christian Hammond
 President/CEO of Beanbag 
 Makers of Review Board 

 On Tue, Mar 21, 2017 at 11:11 AM, Vanaja Narayanaswamy <
 vanaja...@gmail.com> wrote:

> Hi,
>
> When the user is logged into the reviewboard via the browser, I would
> like to get user info(loginId) to pass it on to my scmtool.  How do I
> achieve that in scmtools/myscm.py module?
>
> Thanks,
> Vanaja
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google
> Groups "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

 --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to a topic in the
 Google Groups "reviewboard" group.
 To unsubscribe from this topic, visit https://groups.google.com/d/to
 pic/reviewboard/UFIkl3Hxr1Y/unsubscribe.
 To unsubscribe from this group and all its topics, send an email to
 reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to a topic in the
>> Google Groups "reviewboard" group.
>> To unsubscribe from this topic, visit 

Re: How to Get the user from the current session.

[Vanaja Narayanaswamy]

>>Files are also not fetched by that user's account. They're fetched using
the credentials set up when configuring the >>repository.

We know this. That's why we want to check the user's access first and then
fetch.  I thought the get_file method in myscm.py  can first do the check
for loggedin user's access in our scm/repo and then fetch if user has
access.

>>Are your permissions set up per-file, or is it more that they can't
access certain hierarchies of the tree?
The access rule can be on a file or on  hierarchies.

Thanks,
Vanaja

On Tue, Mar 21, 2017 at 3:34 PM, Christian Hammond 
wrote:

> You won't be able to solve this the way you're wanting. We aggressively
> cache the contents from repositories, and that will happen the first time
> the file is requested (if not in cache), meaning that if a user has already
> viewed a diff or posted a change against a given file + revision, it will
> already be in cache and the SCMTool will not have an ability to weigh in on
> whether the file can be accessed.
>
> Files are also not fetched by that user's account. They're fetched using
> the credentials set up when configuring the repository.
>
> Are your permissions set up per-file, or is it more that they can't access
> certain hierarchies of the tree?
>
> Christian
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Tue, Mar 21, 2017 at 3:29 PM, Vanaja Narayanaswamy  > wrote:
>
>> Hi,
>>
>> To make sure that user has read access(in our scm)  on the file that is
>> being diffed.
>>
>> Thanks,
>> Vanaja
>>
>> On Tue, Mar 21, 2017 at 1:38 PM, Christian Hammond <
>> christ...@beanbaginc.com> wrote:
>>
>>> Hi Vanaja,
>>>
>>> SCMTools don't have access to the current HTTP request or user, and we
>>> can't provide it. What do you need the user for?
>>>
>>> Christian
>>>
>>> --
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>>> On Tue, Mar 21, 2017 at 11:11 AM, Vanaja Narayanaswamy <
>>> vanaja...@gmail.com> wrote:
>>>
 Hi,

 When the user is logged into the reviewboard via the browser, I would
 like to get user info(loginId) to pass it on to my scmtool.  How do I
 achieve that in scmtools/myscm.py module?

 Thanks,
 Vanaja

 --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to a topic in the
>>> Google Groups "reviewboard" group.
>>> To unsubscribe from this topic, visit https://groups.google.com/d/to
>>> pic/reviewboard/UFIkl3Hxr1Y/unsubscribe.
>>> To unsubscribe from this group and all its topics, send an email to
>>> reviewboard+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "reviewboard" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/reviewboard/UFIkl3Hxr1Y/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us 

Re: How to Get the user from the current session.

[Vanaja Narayanaswamy]

Hi,

To make sure that user has read access(in our scm)  on the file that is
being diffed.

Thanks,
Vanaja

On Tue, Mar 21, 2017 at 1:38 PM, Christian Hammond  wrote:

> Hi Vanaja,
>
> SCMTools don't have access to the current HTTP request or user, and we
> can't provide it. What do you need the user for?
>
> Christian
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Tue, Mar 21, 2017 at 11:11 AM, Vanaja Narayanaswamy <
> vanaja...@gmail.com> wrote:
>
>> Hi,
>>
>> When the user is logged into the reviewboard via the browser, I would
>> like to get user info(loginId) to pass it on to my scmtool.  How do I
>> achieve that in scmtools/myscm.py module?
>>
>> Thanks,
>> Vanaja
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "reviewboard" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/reviewboard/UFIkl3Hxr1Y/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4513: User selector in the Group configuration breaks for non-active users

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4513/
--

New update by chipx86
For Beanbag, Inc. > Review Board > Ticket #4513


Reply:

Fixed in release-2.5.x (6897531). This will ship in 2.5.10. Thanks!


Status:
- PendingReview
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: How to Get the user from the current session.

[Christian Hammond]

Hi Vanaja,

SCMTools don't have access to the current HTTP request or user, and we
can't provide it. What do you need the user for?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Tue, Mar 21, 2017 at 11:11 AM, Vanaja Narayanaswamy 
wrote:

> Hi,
>
> When the user is logged into the reviewboard via the browser, I would like
> to get user info(loginId) to pass it on to my scmtool.  How do I achieve
> that in scmtools/myscm.py module?
>
> Thanks,
> Vanaja
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Python API: How to modify submitter on draft

[Christian Hammond]

Yep, this is what you need. You'll need your automation user to have the
"can_submit_as" permission enabled as well.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Tue, Mar 21, 2017 at 1:35 PM, Erik Johansson  wrote:

> Hi,
>
> Without knowing much about this I would guess you need to set submit_as
> when creating the review request. See https://www.reviewboard.org/
> docs/manual/2.5/webapi/2.0/resources/review-request-list/#POST
>
> // Erik
>
> On 21 March 2017 at 10:21, mav14117  wrote:
>
>> Hi there,
>>
>> I am using the Python API to create a new review.
>>
>> My main goal is to create a review with an automation user, eg, jenkins,
>> but make the submitter and the reviewers real users.
>>
>> I was following the tutorial and I thought I could do something like this:
>>
>> # Modify the review
>> draft = review_request.get_draft()
>> draft = draft.update(
>> summary='API tutorial request',
>> description='This request was created in the API tutorial.',
>> submitter='real_user1',
>> target_people='real_user2')
>>
>> draft.update(public=True)
>>
>> However this seems not to have any effect, since the reviews are created
>> with my "jenkins" user instead.
>>
>> I tried searching for different terms, including "python submitter" and
>> "python api submitter" but this did not throw back any relevant threads.
>>
>> Can anyone offer some directions on how could I achieve this?
>>
>> Many thanks!
>>
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> Erik Johansson
> Home Page: http://ejohansson.se/
> PGP Key: http://ejohansson.se/erik.asc
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Python API: How to modify submitter on draft

[Erik Johansson]

Hi,

Without knowing much about this I would guess you need to set submit_as
when creating the review request. See
https://www.reviewboard.org/docs/manual/2.5/webapi/2.0/resources/review-request-list/#POST

// Erik

On 21 March 2017 at 10:21, mav14117  wrote:

> Hi there,
>
> I am using the Python API to create a new review.
>
> My main goal is to create a review with an automation user, eg, jenkins,
> but make the submitter and the reviewers real users.
>
> I was following the tutorial and I thought I could do something like this:
>
> # Modify the review
> draft = review_request.get_draft()
> draft = draft.update(
> summary='API tutorial request',
> description='This request was created in the API tutorial.',
> submitter='real_user1',
> target_people='real_user2')
>
> draft.update(public=True)
>
> However this seems not to have any effect, since the reviews are created
> with my "jenkins" user instead.
>
> I tried searching for different terms, including "python submitter" and
> "python api submitter" but this did not throw back any relevant threads.
>
> Can anyone offer some directions on how could I achieve this?
>
> Many thanks!
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Erik Johansson
Home Page: http://ejohansson.se/
PGP Key: http://ejohansson.se/erik.asc

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Python API: How to modify submitter on draft

[mav14117]

Hi there,

I am using the Python API to create a new review. 

My main goal is to create a review with an automation user, eg, jenkins, 
but make the submitter and the reviewers real users.

I was following the tutorial and I thought I could do something like this:

# Modify the review
draft = review_request.get_draft()
draft = draft.update(
summary='API tutorial request',
description='This request was created in the API tutorial.',
submitter='real_user1',
target_people='real_user2')

draft.update(public=True)

However this seems not to have any effect, since the reviews are created 
with my "jenkins" user instead.

I tried searching for different terms, including "python submitter" and 
"python api submitter" but this did not throw back any relevant threads. 

Can anyone offer some directions on how could I achieve this?

Many thanks!


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

How to Get the user from the current session.

[Vanaja Narayanaswamy]

Hi, 

When the user is logged into the reviewboard via the browser, I would like 
to get user info(loginId) to pass it on to my scmtool.  How do I achieve 
that in scmtools/myscm.py module?

Thanks,
Vanaja

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4398: Make date of review / change description / status an anchor link to that item

[Daniel Kuecker]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4398/
--

New update by mconley
For Beanbag, Inc. > Review Board > Ticket #4398


Reply:

Can we get this change added to 2.5.10?  My users are asking for it.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Unable to use rbt tools with svn-git

[Oriol Odena]

Hi Christian.

that's the 'rbt post' with debug from 
commit e2e8497c3c34a88ef1b726f60f3724ccef1ca385:

*oodena@linux-oodena:~/workspace/trunk_git> rbt post --debug 
e2e8497c3c34a88ef1b726f60f3724ccef1ca385*
*>>> RBTools 0.7.9*
*>>> Python 2.6.9 (unknown, Apr  7 2015, 08:28:12) *
*[GCC 4.3.4 [gcc-4_3-branch revision 152973]]*
*>>> Running on Linux-3.0.101-63-default-x86_64-with-SuSE-11-x86_64*
*>>> Home = /home/oodena*
*>>> Current directory = /home/oodena/workspace/trunk_git*
*>>> Command line: rbt post --debug 
e2e8497c3c34a88ef1b726f60f3724ccef1ca385*
*>>> Checking for a Subversion repository...*
*>>> Running: svn --non-interactive info*
*>>> Command exited with rc 1: ['svn', '--non-interactive', u'info']*
*svn: '.' is not a working copy*
*---*
*>>> Checking for a Git repository...*
*>>> Running: git rev-parse --git-dir*
*>>> Running: git config core.bare*
*>>> Running: git rev-parse --show-toplevel*
*>>> Running: git symbolic-ref -q HEAD*
*>>> Running: git svn info*
*>>> Running: git svn rebase -n*
*>>> repository info: Path: svn://obiwan/code, Base path: /zl/trunk, 
Supports changesets: False*
*>>> Making HTTP GET request to http://machinesmith.zhilabs.net/api/*
*>>> Making HTTP GET request to 
http://machinesmith.zhilabs.net/api/repositories/?tool=Subversion*
*>>> Cached response for HTTP GET 
http://machinesmith.zhilabs.net/api/repositories/?tool=Subversion expired 
and was modified*
*>>> Running: git rev-parse e2e8497c3c34a88ef1b726f60f3724ccef1ca385*
*>>> Running: git rev-parse e2e8497c3c34a88ef1b726f60f3724ccef1ca385^*
*>>> Running: git merge-base 2fe6e080b88131c88a29d5340381534ccc44a3de 
refs/remotes/trunk*
*>>> Running: git rev-parse --git-dir*
*>>> Running: git version*
*>>> Running: git diff --no-color --no-prefix -r -u --no-ext-diff 
2fe6e080b88131c88a29d5340381534ccc44a3de..e2e8497c3c34a88ef1b726f60f3724ccef1ca385*
*>>> Running: git svn find-rev 2fe6e080b88131c88a29d5340381534ccc44a3de*
*>>> Making HTTP GET request to 
http://machinesmith.zhilabs.net/api/validation/diffs/*
*>>> Cached response for HTTP GET 
http://machinesmith.zhilabs.net/api/validation/diffs/ expired and was 
modified*
*>>> Making HTTP POST request to 
http://machinesmith.zhilabs.net/api/validation/diffs/*
*>>> Got API Error 219 (HTTP code 400): The specified diff file is empty.*
*>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'The specified diff 
file is empty.', u'code': 219}}*
*Traceback (most recent call last):*
*  File "/usr/local/bin/rbt", line 8, in *
*load_entry_point('RBTools==0.7.9.dev', 'console_scripts', 'rbt')()*
*  File 
"/usr/local/lib64/python2.6/site-packages/RBTools-0.7.9.dev-py2.6.egg/rbtools/commands/main.py",
 
line 133, in main*
*command.run_from_argv([RB_MAIN, command_name] + args)*
*  File 
"/usr/local/lib64/python2.6/site-packages/RBTools-0.7.9.dev-py2.6.egg/rbtools/commands/__init__.py",
 
line 664, in run_from_argv*
*exit_code = self.main(*args) or 0*
*  File 
"/usr/local/lib64/python2.6/site-packages/RBTools-0.7.9.dev-py2.6.egg/rbtools/commands/post.py",
 
line 811, in main*
*(msg_prefix, e))*
*rbtools.commands.CommandError: Error validating diff*

*The specified diff file is empty. (HTTP 400, API Error 219)*

And here you have the rbt diff from same commit:

*oodena@linux-oodena:~/workspace/trunk_git> rbt diff --debug 
e2e8497c3c34a88ef1b726f60f3724ccef1ca385*
*>>> RBTools 0.7.9*
*>>> Python 2.6.9 (unknown, Apr  7 2015, 08:28:12) *
*[GCC 4.3.4 [gcc-4_3-branch revision 152973]]*
*>>> Running on Linux-3.0.101-63-default-x86_64-with-SuSE-11-x86_64*
*>>> Home = /home/oodena*
*>>> Current directory = /home/oodena/workspace/trunk_git*
*>>> Command line: rbt diff --debug 
e2e8497c3c34a88ef1b726f60f3724ccef1ca385*
*>>> Checking for a Subversion repository...*
*>>> Running: svn --non-interactive info*
*>>> Command exited with rc 1: ['svn', '--non-interactive', u'info']*
*svn: '.' is not a working copy*
*---*
*>>> Checking for a Git repository...*
*>>> Running: git rev-parse --git-dir*
*>>> Running: git config core.bare*
*>>> Running: git rev-parse --show-toplevel*
*>>> Running: git symbolic-ref -q HEAD*
*>>> Running: git svn info*
*>>> Running: git svn rebase -n*
*>>> repository info: Path: svn://obiwan/code, Base path: /zl/trunk, 
Supports changesets: False*
*>>> Making HTTP GET request to http://machinesmith.zhilabs.net/api/*
*>>> Running: git rev-parse e2e8497c3c34a88ef1b726f60f3724ccef1ca385*
*>>> Running: git rev-parse e2e8497c3c34a88ef1b726f60f3724ccef1ca385^*
*>>> Running: git merge-base 2fe6e080b88131c88a29d5340381534ccc44a3de 
refs/remotes/trunk*
*>>> Running: git rev-parse --git-dir*
*>>> Running: git version*
*>>> Running: git diff --no-color --no-prefix -r -u --no-ext-diff 
2fe6e080b88131c88a29d5340381534ccc44a3de..e2e8497c3c34a88ef1b726f60f3724ccef1ca385*
*>>> Running: git svn find-rev 2fe6e080b88131c88a29d5340381534ccc44a3de*
*Index: src/net/test/DashTest.cc*
*===*
*--- src/net/test/DashTest.cc (revision