Re: Long lines get cut off in diff view

2017-11-23 Thread Christian Hammond 
Looks like the lines are missing a character or two. I have seen this once,
and when I looked, it was a quirk with how the browser chose to wrap vs.
extend the container for the line. I’ll keep my eye open and see if I can
reproduce and figure out the issue, but it was non-obvious last time.

What I did find was resizing the window would trigger a relayout, resolving
the problem. I’d be curious if this works around the issue for you.

Christian



On Thu, Nov 23, 2017 at 16:24 Rob Petti  wrote:

> That's odd... Here's the attachment again.
>
> On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond <
> christ...@beanbaginc.com> wrote:
>
>> Hi Rob,
>>
>> Unfortunately that screenshot didn’t go through for me. Looks like it’s
>> some inline thing instead of an attachment. Can you try re-attaching?
>>
>> Christian
>>
>>
>> On Thu, Nov 23, 2017 at 10:09 Rob Petti  wrote:
>>
>>> Hi all,
>>>
>>> One of my users is having a strange issue with the diff viewer in
>>> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of
>>> the view gets cut off.
>>>
>>> They claim it happens in Chrome 62 and Firefox 57, but I was only able
>>> to reproduce the problem in IE 11.
>>>
>>> Any ideas on what the issue might be, or how to resolve it?
>>>
>>> [image: image001.jpg]
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> --
>> Christian Hammond
>> President/CEO of Beanbag
>> Makers of Review Board
>>
> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>>
> You received this message because you are subscribed to a topic in the
>> Google Groups "reviewboard" group.
>> To unsubscribe from this topic, visit
>> https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to
>> reviewboard+unsubscr...@googlegroups.com.
>>
>
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Long lines get cut off in diff view

2017-11-23 Thread Rob Petti 
That's odd... Here's the attachment again.

On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond  wrote:

> Hi Rob,
>
> Unfortunately that screenshot didn’t go through for me. Looks like it’s
> some inline thing instead of an attachment. Can you try re-attaching?
>
> Christian
>
>
> On Thu, Nov 23, 2017 at 10:09 Rob Petti  wrote:
>
>> Hi all,
>>
>> One of my users is having a strange issue with the diff viewer in
>> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of
>> the view gets cut off.
>>
>> They claim it happens in Chrome 62 and Firefox 57, but I was only able to
>> reproduce the problem in IE 11.
>>
>> Any ideas on what the issue might be, or how to resolve it?
>>
>> [image: image001.jpg]
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> --
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to a topic in the
> Google Groups "reviewboard" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/reviewboard/E_QhfFCtm0Q/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Long lines get cut off in diff view

2017-11-23 Thread Christian Hammond 
Hi Rob,

Unfortunately that screenshot didn’t go through for me. Looks like it’s
some inline thing instead of an attachment. Can you try re-attaching?

Christian


On Thu, Nov 23, 2017 at 10:09 Rob Petti  wrote:

> Hi all,
>
> One of my users is having a strange issue with the diff viewer in
> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of
> the view gets cut off.
>
> They claim it happens in Chrome 62 and Firefox 57, but I was only able to
> reproduce the problem in IE 11.
>
> Any ideas on what the issue might be, or how to resolve it?
>
> [image: image001.jpg]
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard migrating issues

2017-11-23 Thread Christian Hammond 
You can’t downgrade to older versions. You’ll need to use 2.0.15 or newer
on this server.

Christian


On Thu, Nov 23, 2017 at 03:59 RB_user  wrote:

> Hi,
>
> [root@banvmlin01 site-packages]# sudo rb-site upgrade /var/www/newmachine/
> Rebuilding directory structure
> Updating database. This may take a while.
>
> The log output below, including warnings and errors,
> can be ignored unless upgrade fails.
>
> --  --
> Creating tables ...
> Upgrading Review Board from 2.0.15 to 1.7.27
>
> [!] Unable to execute the manager command syncdb: No module named
> db.fields
>
> [!] Unable to execute the manager command evolve: No module named
> db.fields
> ---  ---
>
> Resetting in-database caches.
>
> Upgrade complete!
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Posting a review against multiple repositories.

2017-11-23 Thread Eric Chamberland 
Hi,

I just jump into this conversation to say that we have the same problem 
here: we have to manage a "review" as a set of changes across multiple 
repositories.

So +1 for this feature to be implemented.

Thanks,

Eric

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Long lines get cut off in diff view

2017-11-23 Thread Rob Petti 
Hi all,

One of my users is having a strange issue with the diff viewer in 
ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of 
the view gets cut off.

They claim it happens in Chrome 62 and Firefox 57, but I was only able to 
reproduce the problem in IE 11.

Any ideas on what the issue might be, or how to resolve it?

[image: image001.jpg]

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard migrating issues

2017-11-23 Thread RB_user 
Hi,

[root@banvmlin01 site-packages]# sudo rb-site upgrade /var/www/newmachine/
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
Upgrading Review Board from 2.0.15 to 1.7.27

[!] Unable to execute the manager command syncdb: No module named
db.fields

[!] Unable to execute the manager command evolve: No module named
db.fields
---  ---

Resetting in-database caches.

Upgrade complete!

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.