Re: Error With Windows

[Akshay Agarwal]

Hi,

Yes I am the employee for the company doing the setup for the clients. I
know the repository typr and it is theire on the UI. Yet the error that no
repsitory found or created is there. Could you reply with a sample
.reviewboardrc file so i know what to write in it.

Thank you

On Tue, 29 Jan 2019 at 6:29 AM, Christian Hammond 
wrote:

> Hi Akshay,
>
> Are you the administrator on this Review Board server? Do you have a
> matching repository entry in the administration UI? That's going to be
> where the repository information must be stored. The .reviewboardrc is
> meant to reference the name of that repository.
>
> Christian
>
> On Tue, Jan 22, 2019 at 12:54 AM Akshay Agarwal 
> wrote:
>
>> Hi,
>>
>> When I am trying to post something to the reviewboard server using rbt
>> post, I am receiving the error: 'Unable to find a Review Board server for
>> this source code tree.' I tried to automatically create a .reviewboardrc
>> file using rbt setup-repo but I am receiving the error: 'No Perforce
>> repository found or selected for reviewboard.citrite.net. .reviewboardrc
>> not created.' after entering the reviewboard server. I have tried creating
>> the reviewboardrc file manually but I am not sure about what to include in
>> it and where to store it. I tried several alternate ways of creating the
>> reviewboardrc file manually but the errors are not going away. Please help
>> asap.
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Error With Windows

[Christian Hammond]

Hi Akshay,

Are you the administrator on this Review Board server? Do you have a
matching repository entry in the administration UI? That's going to be
where the repository information must be stored. The .reviewboardrc is
meant to reference the name of that repository.

Christian

On Tue, Jan 22, 2019 at 12:54 AM Akshay Agarwal 
wrote:

> Hi,
>
> When I am trying to post something to the reviewboard server using rbt
> post, I am receiving the error: 'Unable to find a Review Board server for
> this source code tree.' I tried to automatically create a .reviewboardrc
> file using rbt setup-repo but I am receiving the error: 'No Perforce
> repository found or selected for reviewboard.citrite.net. .reviewboardrc
> not created.' after entering the reviewboard server. I have tried creating
> the reviewboardrc file manually but I am not sure about what to include in
> it and where to store it. I tried several alternate ways of creating the
> reviewboardrc file manually but the errors are not going away. Please help
> asap.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Posting a review against multiple repositories.

[Christian Hammond]

Hi Radek,

This is really a lot more work than it seems like it'll be.

Diff files themselves have no concept of a repository they're associated
with. We do have a repository reference for DiffSet model entries, but
you're not going to squeeze multiple concurrent DiffSets onto a review
request. We'd need a lot of work on the schema, the UI, and the API to make
all this work, and it's a huge project that will leave you unable to
cleanly upgrade in the future.

There may be another approach, which is to create a sort of "proxy" hosting
service that wraps your other repositories. So basically, one repository
pretending to be multiple ones. The problem then has to do with file
lookups. You'd need a custom diffs generated by custom tools that, for
instance, prefixes file paths with a repository identifier, so the hosting
service can know where to look up the files. For instance, a diff
containing /repo123/absolute/path/to/file could be handled by the hosting
service by stripping off that first bit, looking up the correct backing
repository, and then passing the rest of the path to it.

That's probably the least-invasive way of handling this. The client-side
tooling might be the biggest part of this.

Christian

On Fri, Jan 18, 2019 at 8:04 AM rchmielarz 
wrote:

> Hi all,
>
> I'm also interested in this feature since the group I'm working with uses
> git submodules and we are interested in a coherent review. But since there
> was no interest from review board developers so far I wanted to ask: where
> should I start to implement a proof of concept for git? I'm interested only
> to extend it for patches.
>
> A single review can have only one associated repository in the sql schema
> it seems, this can probably be easily changed. But then I would have to
> create a special format of patches so that each file is attributed to a
> repository so that the review board could show the differences. Is such a
> patch format already available by some tools? And let's say I manage all
> that: review has multiple repositories and I have a patch which has them
> associacted with each of those repositories. Is there anything else that
> should be taken care of?
>
> Cheers,
> Radek
>
> On Thursday, 23 November 2017 20:15:14 UTC+1, Eric Chamberland wrote:
>>
>> Hi,
>>
>> I just jump into this conversation to say that we have the same problem
>> here: we have to manage a "review" as a set of changes across multiple
>> repositories.
>>
>> So +1 for this feature to be implemented.
>>
>> Thanks,
>>
>> Eric
>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Slow requests, due to new apache processes

[Christian Hammond]

We find that mod_wsgi daemon mode works well for us. It won't solve the
template rendering issue, but template structures are cached after their
first parse (the cache is local per-process), so long as DEBUG=False. If
you're seeing this on every page load, it could be due to DEBUG being set
to True (if you're running django_debug_toolbar, this very likely may be
happening), or you're just seeing new threads/processes loading initial
state on first request.

The URLResolver structure does have to be built for each new process as
well, and there's no getting around that, but this is a first-time startup
cost, and users shouldn't be seeing it on-going unless processes are
frequently being re-launched.

You'll also see some slowdown if using a network filesystem to store the
Python packages (rare, but we've seen this happen). Those should always be
local. As should the site directory.

Running daemon mode with a multi-threaded setup should minimize these. Most
of the data will be loaded either immediately on startup or on first
request (per process), and shared amongst all threads. The processes should
rarely recycle as well, as it's mostly the threads that will be discarded
and re-created periodically.

We used to only recommend single-threaded setups before, due to some bugs
in third-party libraries and a couple in ours, but that hasn't been an
issue in a long while. Do we have some stale docs still recommending this
that you saw?

Christian

On Mon, Jan 28, 2019 at 3:13 PM Joshua Cannon  wrote:

> Howdy folks!
>
> My users were complaining about slow performance after we re-provisioned
> our VM from scratch.
>
> After doing some sleuthing using django_debug_toolbar, I found a couple of
> templates were taking a significant amount of time. The first was
> "base/_mobile_navbar.html". After some profiling of rendering the template,
> I found out the time is spent populating the URLResolver's internal data
> structure for all the regular expressions. Every time I refresh the page, I
> see the same template take the same amount of time, which tells me apache
> isn't re-using the processes between requests (or something, I'm not really
> a good sysadmin).
>
> I found that Django recommends deploying using mod_wsgi in daemon mode
> .
> But I also noticed our previous incarnation of the server didn't have this
> enabled.
>
> What settings do y'all suggest to ensure each request isn't spending lots
> of time rendering templates? I see y'all recommned using the
> single-threaded Prefork MPM, should I configure WSGI daemon to also be
> single-threaded?
>
> Thanks!
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Power Pack Exception

[Christian Hammond]

Hi Josh,

We'll need to poke around for this in our code. It's going to be entirely
within Power Pack code. Can you tell me if User #2128 is in the database,
and whether there's anything special about it (is it an active user?)

Christian

On Mon, Jan 28, 2019 at 11:40 AM Joshua Cannon 
wrote:

> Howdy folks!
>
>
> I'm seeing the following exceptions from a user using Power Pack. I'd
> usually debug this kind of thing myself, but I see that rbpowerpack is
> closed source (only ships .pyc files).
>
> I'm gonna guess the missing key is the ID of something in the database,
> but that's just a guess.
>
>
> Below is the stack trace. What area of RB should I be poking around in for
> the source of this issue?
>
>
>
> Traceback (most recent call last):
>
>
>
>   File
> "/opt/apps/reviewboard/venv/lib/python2.7/site-packages/django/core/handlers/base.py",
> line 112, in get_response
>
> response = wrapped_callback(request, *callback_args, **callback_kwargs)
>
>
>
>   File
> "/opt/apps/reviewboard/venv/lib/python2.7/site-packages/reviewboard/accounts/decorators.py",
> line 23, in _check
>
> return login_required(view_func)(*args, **kwargs)
>
>
>
>   File
> "/opt/apps/reviewboard/venv/lib/python2.7/site-packages/django/contrib/auth/decorators.py",
> line 22, in _wrapped_view
>
> return view_func(request, *args, **kwargs)
>
>
>
>   File
> "/opt/apps/reviewboard/venv/lib/python2.7/site-packages/reviewboard/site/decorators.py",
> line 35, in _check
>
> return view_func(request, local_site=local_site, *args, **kwargs)
>
>
>
>   File "/rbpowerpack/reports/decorators.py", line 29, in _check
>
>
>
>   File "/rbpowerpack/reports/views.py", line 58, in report_data
>
>
>
>   File "/rbpowerpack/reports/reports.py", line 1192, in get_csv
>
>
>
> KeyError: 2128L
>
>
>
>
>
> 
> path:/reports/review-relationships/data/,
>
> GET: [u'2019-01-26'], u'users': [u''], u'groups':
> [u'group1,group2,group3,group4,group5']}>,
>
> ...
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Slow requests, due to new apache processes

[Joshua Cannon]

Howdy folks!

My users were complaining about slow performance after we re-provisioned 
our VM from scratch. 

After doing some sleuthing using django_debug_toolbar, I found a couple of 
templates were taking a significant amount of time. The first was 
"base/_mobile_navbar.html". After some profiling of rendering the template, 
I found out the time is spent populating the URLResolver's internal data 
structure for all the regular expressions. Every time I refresh the page, I 
see the same template take the same amount of time, which tells me apache 
isn't re-using the processes between requests (or something, I'm not really 
a good sysadmin).

I found that Django recommends deploying using mod_wsgi in daemon mode 
.
 
But I also noticed our previous incarnation of the server didn't have this 
enabled.

What settings do y'all suggest to ensure each request isn't spending lots 
of time rendering templates? I see y'all recommned using the 
single-threaded Prefork MPM, should I configure WSGI daemon to also be 
single-threaded?

Thanks!

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4769: UnicodeDecodeError from svn_info() method in rbtools/clients/svn.py

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4769/
--

New update by j2sdk
For Beanbag, Inc. > RBTools > Ticket #4769


Reply:

This was fixed in release-1.0.x (a9305e7, and will ship in 1.0.2. Thanks!


Status:
- New
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4737: Adding Gitlab Repository fails with Gitlab 11.x

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4737/
--

New update by mckownam
For Beanbag, Inc. > Review Board > Ticket #4737


Reply:

This fix shipped in 3.0.11.


Status:
- New
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4782: Unable to view SVN files in past RBs

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4782/
--

New update by sshimizu
For Beanbag, Inc. > Review Board > Ticket #4782


Reply:

You'll need to talk to the administrators at LinkedIn. It sounds like 
perhaps an old repository was moved or decommissioned without updating the 
configuration in Review Board.


Status:
- New
+ SetupIssue

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Power Pack Exception

[Joshua Cannon]

Howdy folks!


I'm seeing the following exceptions from a user using Power Pack. I'd 
usually debug this kind of thing myself, but I see that rbpowerpack is 
closed source (only ships .pyc files).

I'm gonna guess the missing key is the ID of something in the database, but 
that's just a guess.


Below is the stack trace. What area of RB should I be poking around in for 
the source of this issue?



Traceback (most recent call last):

 

  File 
"/opt/apps/reviewboard/venv/lib/python2.7/site-packages/django/core/handlers/base.py",
 
line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)

 

  File 
"/opt/apps/reviewboard/venv/lib/python2.7/site-packages/reviewboard/accounts/decorators.py",
 
line 23, in _check

return login_required(view_func)(*args, **kwargs)

 

  File 
"/opt/apps/reviewboard/venv/lib/python2.7/site-packages/django/contrib/auth/decorators.py",
 
line 22, in _wrapped_view

return view_func(request, *args, **kwargs)

 

  File 
"/opt/apps/reviewboard/venv/lib/python2.7/site-packages/reviewboard/site/decorators.py",
 
line 35, in _check

return view_func(request, local_site=local_site, *args, **kwargs)

 

  File "/rbpowerpack/reports/decorators.py", line 29, in _check

 

  File "/rbpowerpack/reports/views.py", line 58, in report_data

 

  File "/rbpowerpack/reports/reports.py", line 1192, in get_csv

 

KeyError: 2128L

 

 

,

...

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4785: On diffviewer page comment dialog shows up at the wrong place in Chrome browser

[M B]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4785/
--

New ticket #4785 by mykhailo.bloshko
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * image-2019-01-28-08-50-57-740.png
   



--
On diffviewer page comment dialog shows up at the wrong place in Chrome browser
==

# What version are you running?
3.0.11

# What's the URL of the page containing the problem?
//diff/

# What steps will reproduce the problem?
1. Open reviewboard in Chrome
2. Open Diff tab in large review request
3. Click on line of code to open comment dialog


# What is the expected output? What do you see instead?
Expected: Comment dialog shows up near line of code 
Actual: Page is scrolled up and comment dialogue shows up at the top of the page

# What Coperating system are you using? What browser?
Linux, Google Chrome Version 71.0.3578.98 (Official Build) (64-bit)

# Please provide any additional information below.
Issue is not persistente, sometimes it works fine.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.