Re: Long lines get cut off in diff view
I have good news on this subject. A customer we’re working with got us a really solid report case, and we’ve solved it. The fix is going to be going into 3.0.18. Aiming for next week for that release. Christian On Tue, May 26, 2020 at 20:50 Tyler Wright wrote: > I have users hitting this too, unfortunately. We're on the latest version > of Review Board and are using the latest version of Firefox (stable). It's > making people think about switching over to GitLab merge requests for > reviews since we use GitLab for version control anyway. > > On Friday, November 24, 2017 at 10:40:15 AM UTC-5, Rob Petti wrote: >> >> The user reports that they can work-around it by zooming out and in with >> CTRL and -, then CTRL and 0, or by maximizing and restoring. So it would >> seem that triggering a relayout fixes it for them. >> >> Thanks for looking into it! >> >> On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < >> chri...@beanbaginc.com> wrote: >> >>> Looks like the lines are missing a character or two. I have seen this >>> once, and when I looked, it was a quirk with how the browser chose to wrap >>> vs. extend the container for the line. I’ll keep my eye open and see if I >>> can reproduce and figure out the issue, but it was non-obvious last time. >>> >>> What I did find was resizing the window would trigger a relayout, >>> resolving the problem. I’d be curious if this works around the issue for >>> you. >>> >>> Christian >>> >>> >>> >>> On Thu, Nov 23, 2017 at 16:24 Rob Petti wrote: >>> That's odd... Here's the attachment again. On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < chri...@beanbaginc.com> wrote: > Hi Rob, > > Unfortunately that screenshot didn’t go through for me. Looks like > it’s some inline thing instead of an attachment. Can you try re-attaching? > > Christian > > > On Thu, Nov 23, 2017 at 10:09 Rob Petti wrote: > >> Hi all, >> >> One of my users is having a strange issue with the diff viewer in >> ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge >> of >> the view gets cut off. >> >> They claim it happens in Chrome 62 and Firefox 57, but I was only >> able to reproduce the problem in IE 11. >> >> Any ideas on what the issue might be, or how to resolve it? >> >> [image: image001.jpg] >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google >> Groups "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, >> send an email to revie...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > Christian Hammond > President/CEO of Beanbag > Makers of Review Board > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to a topic in the > Google Groups "reviewboard" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > revie...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >>> -- >>> -- >>> Christian Hammond >>> President/CEO of Beanbag >>> Makers of Review Board >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "reviewboard" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. >>> To unsubscribe from this group
Re: Long lines get cut off in diff view
I have users hitting this too, unfortunately. We're on the latest version of Review Board and are using the latest version of Firefox (stable). It's making people think about switching over to GitLab merge requests for reviews since we use GitLab for version control anyway. On Friday, November 24, 2017 at 10:40:15 AM UTC-5, Rob Petti wrote: > > The user reports that they can work-around it by zooming out and in with > CTRL and -, then CTRL and 0, or by maximizing and restoring. So it would > seem that triggering a relayout fixes it for them. > > Thanks for looking into it! > > On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond < > chri...@beanbaginc.com > wrote: > >> Looks like the lines are missing a character or two. I have seen this >> once, and when I looked, it was a quirk with how the browser chose to wrap >> vs. extend the container for the line. I’ll keep my eye open and see if I >> can reproduce and figure out the issue, but it was non-obvious last time. >> >> What I did find was resizing the window would trigger a relayout, >> resolving the problem. I’d be curious if this works around the issue for >> you. >> >> Christian >> >> >> >> On Thu, Nov 23, 2017 at 16:24 Rob Petti > >> wrote: >> >>> That's odd... Here's the attachment again. >>> >>> On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond < >>> chri...@beanbaginc.com > wrote: >>> Hi Rob, Unfortunately that screenshot didn’t go through for me. Looks like it’s some inline thing instead of an attachment. Can you try re-attaching? Christian On Thu, Nov 23, 2017 at 10:09 Rob Petti >>> > wrote: > Hi all, > > One of my users is having a strange issue with the diff viewer in > ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge > of > the view gets cut off. > > They claim it happens in Chrome 62 and Firefox 57, but I was only able > to reproduce the problem in IE 11. > > Any ideas on what the issue might be, or how to resolve it? > > [image: image001.jpg] > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to revie...@googlegroups.com . > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board >>> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- >>> You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. To unsubscribe from this group and all its topics, send an email to revie...@googlegroups.com . >>> For more options, visit https://groups.google.com/d/optout. >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to revie...@googlegroups.com . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to a topic in the >> Google Groups "reviewboard" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> revie...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know!
NIS authentication
Hi all, Is it supposed to be working? The settings page only allows "E-Mail Domain". No matter what I provide when I attempt to log in I always get: AttributeError at /account/login/ 'module' object has no attribute 'error' Request Method: POST Request URL: http://rb-test.matrixscience.co.uk/account/login/ Django Version: 1.6.11 Exception Type: AttributeError Exception Value: 'module' object has no attribute 'error' Exception Location: /usr/local/lib/python2.7/dist-packages/reviewboard/ accounts/backends/nis.py in authenticate, line 40 Python Executable: /usr/bin/python Python Version: 2.7.13 Python Path: ['/var/www/rb-test.domain.co.uk/conf', '/usr/lib/python2.7', '/usr/lib/python2.7/plat-x86_64-linux-gnu', '/usr/lib/python2.7/lib-tk', '/usr/lib/python2.7/lib-old', '/usr/lib/python2.7/lib-dynload', '/usr/local/lib/python2.7/dist-packages', '/usr/lib/python2.7/dist-packages'] Thanks, Adam -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/68c5ca8d-f8cd-46b5-a45c-c41ef8fffb43%40googlegroups.com.
Re: LDAP authentication error
> > ldbmodify -H /var/lib/samba/private/sam.ldb dummy2.ldif -U admin > My bad editing post. I actually executed -U dummy2 and it got updated successfully and as intended. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/bd4e944c-f3f5-4b9e-9e3c-f548c578ca98%40googlegroups.com.
Re: LDAP authentication error
One problem was my LDAP connection settings.
This is almost working for me (thanks to Paul Mansfield):
-> Authentication Method: LDAP
-> LDAP Server: ldap://192.168.x.x:389
-> Review Board LDAP Bind Account: cn=auth,cn=Users,dc=domain,dc=co,dc=uk
-> Review Board LDAP Bind Password:
-> LDAP Base DN: cn=Users,dc=domain,dc=co,dc=uk
-> Username Attribute: uid
-> Given Name Attribute: givenName
-> Surname Attribute: sn
-> Full Name Attribute: cn
-> E-Mail LDAP Attribute: mail
-> E-Mail Domain: (blank)
-> Custom LDAP User Search Filter: (blank)
Now I have a weird problem with about half of users being able to log in:
2020-05-26 11:32:07,623 - DEBUG - - root - Attempting to authenticate user
DN "CN=dummy1,CN=Users,DC=domain,DC=co,DC=uk" (username dummy1) in LDAP
and half unable:
2020-05-26 11:40:57,671 - ERROR - - root - Unexpected error authenticating
user "dummy2" in LDAP: 'NoneType' object has no attribute 'decode'
Traceback (most recent call last):
File
"/usr/local/lib/python2.7/dist-packages/reviewboard/accounts/backends/ldap.py"
, line 146, in authenticate
userdn.decode('utf-8'), username)
AttributeError: 'NoneType' object has no attribute 'decode'
After ruling out the obvious such as AD groups membership and primary
groups I compared ldapsearch dumps:
ldapsearch -D 'ad...@domain.co.uk' -b 'cn=Users,dc=domain,dc=co,dc=uk' -H
ldap://192.168.x.x -W sAMAccountName=dummy
I've noticed that all of those who cannot log in are missing msSFU30Name
and msDS-SupportedEncryptionTypes attributes.
I've added them to match settings for the successful users as below:
dummy2.ldif
dn: CN=dummy2,CN=Users,DC=domain,DC=co,DC=uk
changetype: modify
add: msSFU30Name
msSFU30Name: dummy2
add: msDS-SupportedEncryptionTypes
msDS-SupportedEncryptionTypes: 0
ldbmodify -H /var/lib/samba/private/sam.ldb dummy2.ldif -U admin
Modified 1 records successfully
Unfortunately it didn't help and I really don't get why.
TBH I haven't been able to find any failed login attempts logged on the
samba4 LDAP/DC server.
Any ideas?
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/reviewboard/f3533015-6f9d-4596-912c-28502ec69381%40googlegroups.com.
