Re: ClearCase and Reviewboard setup.
Hi Dan, We did have to modify one line of code in post-review to get it to run Could you check if those changes are not similar to mine (http://reviews.review-board.org/r/906/)? I know I had difficulties submitting a diff for a clearcase repo and those changes fixed it. I think that we should also make a hard-coded part configurable. Thanks, Bartek --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review under clearcase / HOW TO ?
I had this problem as well few months ago. Following patch to
post-review should resolve it (attached).
I had to fix some permissions in order to get rid of temp files + the
'\n' (or \r?) was not stripped from the argument and also split_lines
option was needed in a execute call. I don't remember if I reached the
point of actually posting a review though as I had not much time to
play with clearcase+reviewboard :)
Regards,
Bartek Celary
2009/5/25 mahesh forvai...@gmail.com:
post-review under clearcase / HOW TO ?
Hi, I have set up a django based review-board (i.e. without apache /
mod_python) and it came up well. I would like to post-review from
another client where I've installed RBTools (latest version_
I am in clearcase dynamic view and in vob path .. example
/vobs/src/tmp_vob/tools and checked out build.ksh
and I am issuing following command to make it diff from predecessor
version and CHECKEDOUT version to RB as if posted by an admin user.
Command -
post-review --server=http://mvaidya-inl:8000 --username=admin --
password=admin build.ksh
Please advise me if command usage is correct and I am getting this
errors for now
File /home/mvaidya/EGG-INFO/scripts/post-review, line 938, in diff
return self.do_diff(self.get_extended_namespace(files))
File /home/mvaidya/EGG-INFO/scripts/post-review, line 802, in
get_extended_namespace
versions = self.get_previous_version(files)
File /home/mvaidya/EGG-INFO/scripts/post-review, line 781, in
get_previous_version
[cleartool, desc, -pre, elem_path])
ValueError: too many values to unpack
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Index: post-review
===
--- post-review (revision 1980)
+++ post-review (working copy)
@@ -1,4 +1,5 @@
#!/usr/bin/env python
+import stat
import cookielib
import difflib
import getpass
@@ -781,7 +782,7 @@
# Call cleartool to get this version and the previous version
# of the element.
curr_version, pre_version = execute(
-[cleartool, desc, -pre, elem_path])
+[cleartool, desc, -pre, elem_path], split_lines=True)
curr_version = cpath.normpath(curr_version)
pre_version = pre_version.split(':')[1].strip()
@@ -899,8 +900,9 @@
tf = cpath.normpath(cpath.join(td, name))
if cpath.exists(tf):
debug(WARNING: FILE EXISTS)
-os.unlink(tf)
-execute([cleartool, get, -to, tf, normkey])
+os.chmod(tf, stat.S_IWRITE | stat.S_IREAD)
+os.remove(tf)
+execute([cleartool, get, -to, tf, normkey.strip(\n)])
else:
die(ERROR: FILE NOT FOUND : %s % epstr)
@@ -995,7 +997,8 @@
file_data.append(fdata)
# If the file was temp, it should be removed.
if do_rem:
-os.remove(filenam)
+os.chmod(fn, stat.S_IWRITE | stat.S_IREAD)
+os.remove(fn)
modi = file_data.pop()
orig = file_data.pop()
Re: Unable to use ImageFields even though PIL is installed
I did easy_install indeed. It worked when I installed it via .exe installer. Thanks! Bartek Celary 2009/5/22 Christian Hammond chip...@chipx86.com: How did you install PIL? easy_install, or the PIL setup.exe? If you're getting that error, then PIL is definitely not installed where Python can see it. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, May 21, 2009 at 9:10 AM, Bartlomiej Celary bartlomiej.cel...@gmail.com wrote: Hi, I have installed a rc2 reviewboard version via easy_install on Windows. I am using python2.5 + PIL, Pygments, python-memcached. When running rb-site install \dir\path I got following error: Creating database ... Error: One or more models did not validate: reviews.screenshot: image: To use ImageFields, you need to install the Python Imaging Library. Get it at http://www.pythonware.com/products/pil/ . What could be the problem here? is it a known bug? Or am I missing some dependencies? Thanks, Bartek Celary --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Unable to use ImageFields even though PIL is installed
Hi, I have installed a rc2 reviewboard version via easy_install on Windows. I am using python2.5 + PIL, Pygments, python-memcached. When running rb-site install \dir\path I got following error: Creating database ... Error: One or more models did not validate: reviews.screenshot: image: To use ImageFields, you need to install the Python Imaging Library. Get it at http://www.pythonware.com/products/pil/ . What could be the problem here? is it a known bug? Or am I missing some dependencies? Thanks, Bartek Celary --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Cleartool missing + Svn access issue ?
Are you using a Clear Case SCM? Cleartool is the tool needed to manage this kind of repo. If not that means the post-review gives a false positive for a clearcase repo instead of detecting subversion (I presume this is what you actually need). Are you sure you are in a subversion repository? Bartek 2009/3/20 laurent.dufrec...@gmail.com laurent.dufrec...@gmail.com: Hello , in my quest to make reviewboard i've got these issues: 1)using post-review.py under windows got this: cleartool pwv -short Traceback (most recent call last): File C:\Users\ldufrechou\Desktop\post-review.py, line 2312, in module main(sys.argv[1:]) File C:\Users\ldufrechou\Desktop\post-review.py, line 2253, in main repository_info, tool = determine_client() File C:\Users\ldufrechou\Desktop\post-review.py, line 2205, in determine_client repository_info = tool.get_repository_info() File C:\Users\ldufrechou\Desktop\post-review.py, line 744, in get_repository_info self.viewinfo = execute([cleartool, pwv, -short]) File C:\Users\ldufrechou\Desktop\post-review.py, line 1888, in execute env=env) File C:\python25\lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\python25\lib\subprocess.py, line 816, in _execute_child startupinfo) WindowsError: [Error 2] Le fichier spÚcifiÚ est introuvable It don't know where is cleartool and I also don't get any idea too. Do I missed to install something? Looking on google I've something related to rational rose 2) I've posted a review directly via the web interface giving a .diff file. Clicking on view diff, I get a blank page. I suspect that review board could not connect to svn repos. How can I check communication? Is there any log somewhere to see authentication failure? Does it support svn acces via : svn://svn.mycompany.com/xxx/ ? Thx for any help :) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
