Re: Error uploading new diff: fatal: Not a git repository: 'None'
On Feb 2, 10:47 pm, Christopher Orr wrote: > Is there any chance of an option that just allows the full local clone > to be done over git (if the user says that's fine)? > Or would that be too strenuous on Review Board, as it would > (presumably) have to call "git clone" any time someone hits "Upload > diff"? Oops, I meant "git pull", not a full "clone" each time. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading new diff: fatal: Not a git repository: 'None'
Thanks for the confirmation. Is there any chance of an option that just allows the full local clone to be done over git (if the user says that's fine)? Or would that be too strenuous on Review Board, as it would (presumably) have to call "git clone" any time someone hits "Upload diff"? Chris On Feb 2, 10:18 pm, Christian Hammond wrote: > Yeah, unfortunately, Git provides no way to access individual files from a > remote repository without a full local clone, which is why the only two > options are having that clone or accessing over gitweb or a similar service. > > We should definitely do better validation to make sure you can never enter a > remote URL without the raw file mask. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > On Wed, Feb 2, 2011 at 11:42 AM, Stephen Gallagher < > > > > > > > > step...@gallagherhome.com> wrote: > > On 02/02/2011 08:12 AM, Christopher Orr wrote: > > > I just reproduced this while trying to use RB 1.5.2 with a custom > > > remote repository (git+ssh://). > > > By trial-and-error, it seems the 'None' error occurs if the "Raw file > > > URL mask" field is empty. > > > > Is it correct to say there's no way to set up a git repository in > > > Review Board, if the git server is remote and you have no web-based > > > access to it? > > > In that situation, I think what you would want to do is clone the git > > repository locally and use a cron job to keep it up to date with the > > remote repository. That's probably the only way around this. > > > Or, if you have control of the remote repository, add a post-commit hook > > that notifies your clone to update itself (this would be less wasteful > > of network resources). > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > oups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading new diff: fatal: Not a git repository: 'None'
I just reproduced this while trying to use RB 1.5.2 with a custom
remote repository (git+ssh://).
By trial-and-error, it seems the 'None' error occurs if the "Raw file
URL mask" field is empty.
Is it correct to say there's no way to set up a git repository in
Review Board, if the git server is remote and you have no web-based
access to it?
Regards,
Chris
On Jan 26, 6:02 am, Christian Hammond wrote:
> Honestly, I have no idea where None is coming from.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Tue, Jan 25, 2011 at 8:25 AM, mhoydis wrote:
> > Sure. I think the notable clues here are...
>
> > >>> Attempting to create review request on git@server:my_project.git for
> > None
>
> > and...
>
> > >>> Error data: {u'fields': {u'path': [u"fatal: Not a git repository:
> > 'None'\n"]}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
> > errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
>
> > and...
>
> > ERROR:root:Error uploading new diff: fatal: Not a git repository:
> > 'None'
>
> > -
>
> > What value is "None" referring to, here?
>
> > -Michael
>
> > On Jan 24, 7:11 pm, Christian Hammond wrote:
> > > Hi Michael,
>
> > > Would you mind (privately, if you like) showing me the repository
> > > configuration on the server?
>
> > > Christian
>
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.reviewboard.org
> > > VMware, Inc. -http://www.vmware.com
>
> > > On Mon, Jan 24, 2011 at 2:58 PM, mhoydis
> > wrote:
> > > > Trying to use post-review with our custom git setup. My repository is
> > > > configured in ReviewBoard with the path being
> > > > git@server:my_project.git. I've setup the SSH key in ReviewBoard to
> > > > use that git URL, and confirmed that's working. ReviewBoard 1.6
> > > > alpha 0 (dev)
>
> > > > I'm running this command on my Mac desktop:
> > > > git config reviewboard.urlhttp://reviewboard.mydomain.com
> > > > post-review --parent=aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee --
> > > > revision-range=aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee:
> > > > 1015d188c7d28c3b543b1e528ab34e8ee2a62cdf --guess-summary --guess-
> > > > description --publish --debug
>
> > > > -
>
> > > > This is the error I'm getting from post-review on my Mac desktop:
>
> > > > >>> svn info
> > > > >>> git rev-parse --git-dir
> > > > >>> git symbolic-ref -q HEAD
> > > > >>> git svn info
> > > > >>> git svn --version
> > > > >>> git config --get svn-remote.svn.url
> > > > >>> git config --get branch.master.merge
> > > > >>> git config --get branch.master.remote
> > > > >>> git config remote.origin.url
> > > > >>> repository info: Path: git@server:my_project.git, Base path: ,
> > > > Supports changesets: False
> > > > >>> git config --get reviewboard.url
> > > > >>> git log --pretty=format:%s
>
> > aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee..1015d188c7d28c3b543b1e528ab34e8ee2a62cdf
> > > > >>> git log --pretty=format:%s%n%n%b
>
> > aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee..1015d188c7d28c3b543b1e528ab34e8ee2a62cdf
> > > > >>> git diff --no-color --full-index
>
> > aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee..1015d188c7d28c3b543b1e528ab34e8ee2a62cdf
> > > > >>> Looking for 'reviewboard.mydomain.com /' cookie in
> > > > /Users/myuser/.post-review-cookies.txt
> > > > >>> Loaded valid cookie -- no login required
> > > > >>> Attempting to create review request on git@server:my_project.git
> > for
> > > > None
> > > > >>> HTTP POSTing to
> > > >http://reviewboard.mydomain.com/api/json/reviewrequests/new/:
> > > > {'repository_path': 'git@server:my_project.git'}
> > > > >>> Review request created
> > > > >>> Attempting to set field 'summary' to 'Blah Blah #3135 - Blah blah
> > blah
> > > > yadayadaydada * blH, BAH, bah, New(template) added * blah written
> > for
> > > > model, controller(blah, hey), and New hey * Refactored component and
> > blah
> > > > authorization specs into seperate files * Added Administration
> > namespace'
> > > > for review request '48'
> > > > >>> HTTP POSTing to
> > > >http://reviewboard.mydomain.com/api/json/reviewrequests/48/draft/set/:
> > > > {'summary': 'Blah Blah #3135 - Blah blah blah yadayadaydada * blH,
> > BAH,
> > > > bah, New(template) added * blah written for model, controller(blah,
> > hey),
> > > > and New hey * Refactored component and blah authorization specs into
> > > > seperate files * Added Administration namespace'}
> > > > >>> Attempting to set field 'description' to 'Blah Blah #3135 - Blah
> > blah
> > > > blah yadayadaydada * blH, BAH, bah, New(template) added * blah
> > written
> > > > for model, controller(blah, hey), and New hey * Refactored component
> > and
> > > > blah authorization specs into seperate files * Added Administration
> > > > namespace' for review request '48'
> > > > >>> HTTP POSTing to
> > > >http://reviewboard.mydom
Fwd: Google Summer of Code
Begin forwarded message: > From: Alejandro Cadavid > Date: 20 March 2009 02:34:24 GMT > To: Christopher Orr > Subject: Re: Google Summer of Code > X-Spam-Status: No, score=0.6 required=3.9 tests=BAYES_00,X_IP > autolearn=no version=3.2.5 > > I never heard about this project before, it was just checking the list > of mentoring organizations that i found it.. it's a pretty good tool > to keep code organized and develope good ideas around it. > Congratulations for being accepted on Google Summer of Code!. > > I was just wondering, i'm not Eclipse user, I use Emacs to write my > code. I know that Emacs it's not used so widely used as IDEs like > Eclipse or NetBeans in the software industry (I think it's due to the > lazyness of developers to work a little bit on learning how to use > Emacs).. But anyway I would like to ask.. do people show any interest > on an emacs mode for Review board? Would it be a cool propouse for an > application to the project? Or the "Eclipse Plugin" would be more > imperative? > > Thanks for any comments about it! > > On 19 mar, 18:22, Christopher Orr wrote: >> Hi all, >> >> I just saw that Review Board got accepted for Google Summer of Code >> this year. Great news! >> >> The ideas page is looking >> good:http://code.google.com/p/reviewboard/wiki/Summer_of_Code_Ideas >> >> Just in case any potential students are reading, Eclipse integration >> would be an excellent choice! ;) >> >> Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Google Summer of Code
Hi all, I just saw that Review Board got accepted for Google Summer of Code this year. Great news! The ideas page is looking good: http://code.google.com/p/reviewboard/wiki/Summer_of_Code_Ideas Just in case any potential students are reading, Eclipse integration would be an excellent choice! ;) Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard integration with Apache
If you're using "reviews.example.com" rather than using a hostname you can reach, then you appear to have a typo in your hosts file. >> 172.0.0.1reviews.example.com The 172 should be 127. Chris On 28 Feb 2009, at 21:17, Gary M. Josack wrote: > reviews.example.com is just an example... you either need your own > hostname or you can use localhost. > > sctopia wrote: >> I am a newbie with Django, ReviewBoard and Apache and I am clueless >> on >> getting Apache to serve up ReviewBoard site. I followed the basic >> installation on my Ubuntu Hardy machine. Everything seemed well >> except http://reviews.example.com timed out. The following are my >> configurations. >> >> (1) Django and ReviewBoard installations. >> >> ./usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/ >> django/ >> conf/project_template/manage.py >> ./usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4-py2.5.egg/ >> reviewboard/manage.py >> >> (2) ReviewBoard apache directory >> >> /var/www/reviews.example.com. >> >> (3) Apache set up. >> >> I added the following configure to /etc/apache2/sites-available/ >> apache- >> modpython.conf and made a symlink to it in /etc/apache2/sites- >> enabled. >> >> >> ServerName reviews.example.com >> DocumentRoot /var/www/reviews.example.com/htdocs >> >> # Error handlers >> ErrorDocument 500 /errordocs/500.html >> >> # Serve django pages >> >> PythonPath "['/usr//lib/python2.5/site-packages/','/var/www/ >> reviews.example.com/conf'] + sys.p >> ath" >> SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings >> SetEnv PYTHON_EGG_CACHE >> /var/www/reviews.example.com/tmp/egg_cache >> SetHandler mod_python >> PythonHandler django.core.handlers.modpython >> PythonAutoReload Off >> PythonDebug Off >> # Used to run multiple mod_python sites in the same apache >> PythonInterpreter reviewboard_reviews_example_com >> >> >> # Serve static media without running it through mod_python >> # (overrides the above) >> >> SetHandler None >> >> >> SetHandler None >> >> >> >> AllowOverride All >> >> >> # Alias static media requests to filesystem >> Alias /media /var/www/reviews.example.com/htdocs/media >> Alias /errordocs /var/www/reviews.example.com/htdocs/errordocs >> >> >> (4) I edited /etc/hosts >> >> 172.0.0.1reviews.example.com >> >> At this point, I had no idea how to access ReviewBoard's site. >> >> Thanks in advance for all suggestions. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: View Diff is broken: Diff currently unavailable.
Sounds like the Perforce SCM backend is saying it can't find the Perforce program. Do you have the "p4" binary available in the server's PATH? Regards, Chris On 3 Feb 2009, at 23:38, Cong Do wrote: > Hi Christian, > We are still trying to use post-review for P4. After running post- > review, > we get the following error when we try to view the diff. Any idea? > Posting the review was successful. > Cong. > > [Errno 2] No such file or directory > > Traceback (most recent call last): > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/views.py", line 86, in view_diff > files = get_diff_files(diffset, None, interdiffset, highlighting) > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 660, in > get_diff_files > enable_syntax_highlighting) > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 579, in > generate_files > large_data=True) > File "/usr/lib/python2.4/site-packages/Djblets-0.5alpha1-py2.4.egg/ > djblets/util/misc.py", line 142, in cache_memoize > data = lookup_callable() > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 578, in > enable_syntax_highlighting), > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 339, in > get_chunks > old = get_original_file(filediff) > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 246, in > get_original_file > large_data=True)[0] > File "/usr/lib/python2.4/site-packages/Djblets-0.5alpha1-py2.4.egg/ > djblets/util/misc.py", line 142, in cache_memoize > data = lookup_callable() > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 245, in > data = cache_memoize(key, lambda: [fetch_file(file, revision)], > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 225, in > fetch_file > data = tool.get_file(file, revision) > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/scmtools/perforce.py", line 92, in get_file > p = subprocess.Popen(cmdline, stdout=subprocess.PIPE, > stderr=subprocess.PIPE) > File "/usr/lib64/python2.4/subprocess.py", line 542, in __init__ > errread, errwrite) > File "/usr/lib64/python2.4/subprocess.py", line 975, in > _execute_child > raise child_exception > OSError: [Errno 2] No such file or directory > > > From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com > ] On Behalf Of Christian Hammond > Sent: Tuesday, February 03, 2009 2:53 PM > To: reviewboard@googlegroups.com > Subject: Re: View Diff is broken: Diff currently unavailable. > > It wouldn't have with last night's build. I didn't update the > dependency for the new nightly. > > Do an upgrade of Djblets as well and it should work. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > VMware, Inc. > > On Tue, Feb 3, 2009 at 2:43 PM, Matthew Von Bargen > wrote: > > I don't know... > > If running "sudo easy_install --upgrade ReviewBoard" upgrades Djblets > then I upgraded it. If not, then I did not. > > On Tue, Feb 3, 2009 at 2:38 PM, Christian Hammond > wrote: > > Er, yeah, key.. I'm a bit out of it today. > > > > Did you upgrade Djblets as well? > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > VMware, Inc. > > > > > > On Tue, Feb 3, 2009 at 2:35 PM, Matthew Von Bargen > > > wrote: > >> > >> Okay. Thanks. > >> > >> Did you mean: > >> > >> key += "-%s" % settings.AJAX_SERIAL > >> > >> instead of : > >> > >> str += "-%s" % settings.AJAX_SERIAL > >> > >> ? > >> > >> If I do what you say, but assign to +key+ instead of +str+, then > >> things mostly work. But I am still seeing one "Diff currently > >> unavailable." error: > >> > >> Diff currently unavailable. > >> Error: 'Settings' object has no attribute 'AJAX_SERIAL' > >> Details > >> Traceback (most recent call last): > >> File > >> "/usr/lib/python2.5/site-packages/ > ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > views.py", > >> line 193, in view_diff_fragment > >>context, template_name)) > >> File > >> "/usr/lib/python2.5/site-packages/ > ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > views.py", > >> line 53, in build_diff_fragment > >>key += "-%s" % settings.AJAX_SERIAL > >> File > >> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/ > django/conf/__init__.py", > >> line 32, in __getattr__ > >>return getattr(self._target, name) > >> AttributeError: 'Settings' object has no attribute 'AJAX_SERIAL' > >> > >> > >> > >> On Tue, Feb 3, 2009 at 2:05
Miscellaneous notes
Hi all, Just a few minor notes: Firstly, I discovered today that you'll probably need to clear your cache to fully support the new AJAXified loading of diffs. Revision 1726 introduced some new JavaScript to the bottom of the diff_file_fragment.html template. I found that this affected some already-cached fragments meaning that the file anchor spinners never got replaced (e.g. http://reviews.review-board.org/r/731/diff/#index_header). Secondly, good job with the new web Review Board site! Finally, I noticed the new documentation the other day (and I learned that Google Code now has a docs reader!). Very nice. Thanks, Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
review-board.org unavailable
Hi there, Things may well be fixed by the time Christian sees this, but I just wanted to note that review-board.org currently appears to be unavailable. easy_install appeared to be hanging when doing an upgrade, so I checked out the site but something must be awry behind the scenes, as port 80 on the server is reachable but no response is forthcoming. Regards, Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
