Re: post-review: failed to execute command: svn diff

2014-06-27 Thread James Oravec
Hi Christian,

We've upgrade one of our source repositories from CVS to SVN. I'm trying to 
post to reviewboard and am getting a similar issue as what is stated in 
this thread. I'm hoping you might be able to give me some suggestions. I've 
posted the question to stack overflow too.

I'm trying to use reviewboard with SVN. Others in the office have got their 
system setup and are able to post (copies of a VM that got it working the 
first time). I've compared my system setup against theirs and things look 
the same, as far as I can tell.

When I run the rbt post command I get:

Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', 
'--notice-ancestry ', '-r', 'BASE'] ['Index: main.cpp\n', 
'= ==\n', 
'Usage: diff [OPTIONS] \n', '\n', 'Display the dif ferences between and in 
unified diff\n', format. OPTIONS are d iff extensions as described by 'svn 
help diff'.\n, Use '--' alone to indicate that no more options 
follow.\n, svn: E200012: 'diff' returned 2\n]

I've made my svn client and gnu diff the first two things in my system 
path: C:\Program Files (x86)\GnuWin32\bin;C:\Program Files (x86)\CollabNet

I'm running Windows 8 machine.

Some detail. svn --version gives:

svn, version 1.8.9 (r1591380) compiled Jun 6 2014, 03:53:07 on 
x86-microsoft-windows5.1.2600

Copyright (C) 2014 The Apache Software Foundation. This software consists 
of contributions made by many people; see the NOTICE file for more 
information. Subversion is open source software, see
http://subversion.apache.org/

The following repository access (RA) modules are available:

   - ra_svn : Module for accessing a repository using the svn network 
   protocol.
  - with Cyrus SASL authentication
  - handles 'svn' scheme
   - ra_local : Module for accessing a repository on local disk.
  - handles 'file' scheme
   - ra_serf : Module for accessing a repository via WebDAV protocol using 
   serf.
  - using serf 1.3.4
  - handles 'http' scheme
  - handles 'https' scheme
   
diff --version gives:

diff (GNU diffutils) 2.8.7 Written by Paul Eggert, Mike Haertel, David 
Hayes, Richard Stallman, and Len Tower.

Copyright (C) 2004 Free Software Foundation, Inc. This is free software; 
see the source for copying conditions. There is NO warranty; not even for 
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Any thoughts or ideas on what I should check or what I'm missing? I'm going 
to post to the google group too to see if they have any ideas, if they have 
a solution I'll update this post too.
Thanks,
James







On Tuesday, November 13, 2012 12:03:38 PM UTC-8, Christian Hammond wrote:

 It's just possible svn diff no longer supports the --diff option. I'm not 
 at a computer right now, but does it appear at all in the help output? 

 Christian 


 On Nov 13, 2012, at 11:40, rb revie...@srmstar.net javascript: 
 wrote: 

  
  We have another user with this strange svn diff issue with post-review. 
 I 
  somehow got past this issue, completely by accident. Any help on 
 resolution 
  would be appreciated. 
  
  Mark 
  
  On Tue, October 30, 2012 9:49 am, rb wrote: 
  On Tue, October 30, 2012 3:40 am, Christian Hammond wrote: 
  What happens if you run: 
  
 svn diff --diff-cmd=diff 
  
  directly? 
  
  Christian 
  
  -- 
  Christian Hammond - chi...@chipx86.com javascript: 
  Review Board - http://www.reviewboard.org 
  VMware, Inc. - http://www.vmware.com 
  
  
  Christian, 
  
  It is the same as the output from post-review debug. If I remove GNU 
 diff from 
  first in the path, post-review complains about not having GNU diff. 
  
  Mark 
  
  +++= 
  
  
  C:\workareas\svn\test\rb-test  svn up 
  
  Updating '.': 
  
  At revision 83. 
  
  
  C:\workareas\svn\test\rb-test  svn stat -u 
  
  M   83   test.txt 
  
  Status against revision: 83 
  
  
  C:\workareas\svn\test\rb-test  svn diff test.txt 
  
  Index: test.txt 
  
  === 
  
  --- test.txt(revision 83) 
  
  +++ test.txt(working copy) 
  
  @@ -1,3 +1,4 @@ 
  
  +test test 
  
  save this cahnge 
  
  nire 
  
  owewew 
  
  
  C:\workareas\svn\test\rb-test  post-review --debug 
  
  RBTools 0.4.2 
  
  Python 2.7.3 (default, Apr 10 2012, 23:31:26) [MSC v.1500 32 bit 
 (Intel)] 
  
  Running on Windows-7-6.1.7601-SP1 
  
  Home = C:\Users\user1\AppData\Roaming 
  
  Current Directory = C:\workareas\svn\test\rb-test 
  
  Checking the repository type. Errors shown below are mostly 
 harmless. 
  
  DEBUG:root:Checking for a CVS repository... 
  
  DEBUG:root:Checking for a ClearCase repository... 
  
  DEBUG:root:Checking for a Git repository... 
  
  DEBUG:root:Checking for a Mercurial repository... 
  
  DEBUG:root:Checking for a Perforce repository... 
  
  DEBUG:root:Checking for a Plastic repository... 
  
  DEBUG:root:Checking for a Subversion 

Re: Post-review thinks CVS diff file is empty

2013-07-02 Thread James Oravec
Hi Christian,

Did you guys ever figure out the issue with this? I'm receiving the same 
errors both on the client and server side. Any help would be greatly 
appreciated.

Thanks,
James



On Monday, September 26, 2011 4:59:39 PM UTC-7, Christian Hammond wrote:

 Hi Matthew,

 So I've seen this issue mentioned before with Review Board, but also with 
 CVS in general. It's possible it's us. Can you perhaps privately e-mail me 
 with the Path and Mirror Path field info on your Repository entry?

 Here's a link to someone who's hit it with just plain ol' CVS and has some 
 workaround (though it's not very detailed):

 http://devnet.jetbrains.net/thread/158342

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Mon, Sep 26, 2011 at 4:26 PM, Matthew matt...@gmail.com 
 javascript:wrote:

 I appreciate the quick help.

 After enabling logging and running the commands again I get the output
 below. I notice the absolute module reference points into the cvs
 repository. After checking in the repository, there is no
 Version.java, although there is Version.java,v. I don't know if
 it's significant that this repository is a new import of the WorldWind
 code for Review Board testing purposes, the only file that has ever
 been checked out is Version.java, and it has never been checked back
 in.

 Matt (log follows)

 [lihm@rbvm3 WorldWind]$ more /var/www/myserver.com/logs/
 reviewboard.log
 2011-09-26 16:12:33,711 - DEBUG - DiffParser.parse: Beginning parse of
 diff, size = 2741
 2011-09-26 16:12:33,712 - DEBUG - DiffParser.parse: Finished parsing
 diff.
 2011-09-26 16:12:33,832 - ERROR - Error uploading new diff: cvs
 [checkout aborted]: Absolute module reference invalid: `/usr/local/c
 vsroot/WorldWind/src/gov/nasa/worldwind/Version.java'
 Traceback (most recent call last):
  File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
 reviewboard/webapi/resources.py, line 1478, in create
request.FILES.get('parent_diff_path'))
  File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
 reviewboard/reviews/forms.py, line 286, in create
history)
  File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
 reviewboard/diffviewer/forms.py, line 62, in create
files = list(self._process_files(
  File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
 reviewboard/diffviewer/forms.py, line 144, in _process_files
if (revision != PRE_CREATION and
  File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
 reviewboard/scmtools/core.py, line 70, in file_exists
self.get_file(path, revision)
  File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
 reviewboard/scmtools/cvs.py, line 48, in get_file
return self.client.cat_file(path, revision)
  File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
 reviewboard/scmtools/cvs.py, line 248, in cat_file
return self._cat_specific_file(filename, revision)
  File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
 reviewboard/scmtools/cvs.py, line 299, in _cat_specific_file
raise SCMError(errmsg)
 SCMError: cvs [checkout aborted]: Absolute module reference invalid: `/
 usr/local/cvsroot/WorldWind/src/gov/nasa/worldwind/Version.ja
 va'



 On Sep 26, 4:05 pm, Christian Hammond chip...@chipx86.com wrote:
  Hi Matthew,
 
  It's entirely possible that that error is misleading. Looking at the 
 code,
  it's possible that the same error code could be generated when there's 
 also
  an unexpected error on Review Board's end.
 
  If you have access to the reviewboard server logs, look for a line 
 starting
  with Error uploading new diff:
 
  That might give a better idea as to what's going on. Let me know what it
  says.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.reviewboard.org
  VMware, Inc. -http://www.vmware.com
 
 
 
 
 
 
 
  On Mon, Sep 26, 2011 at 3:57 PM, Matthew matt@gmail.com wrote:
   The cvs command issued by post-review executes, but post-review
   doesn't seem to think there are any diffs to upload. I'll include the
   result of post-review --output-diff --debug at the end of this message
 
   Although I have a software background it has been a long time since
   I've done any sort of sysadmin work, and I'm not familiar with cvs or
   python. So please use small words.
 
   Any help would be appreciated.
 
   Matt (post-review session below, had to change the server name, but
   everything else is copied from xterm)
 
   [lihm@rbvm3 WorldWind]$ post-review --output-diff --debug
RBTools 0.3.3
Home = /home/lihm
svn info
repository info: Path: myserver.com:8080/usr/local/cvsroot, Base 
 path:
   None, Supports changesets: False
HTTP GETting api/
HTTP GETtinghttp://myserver.com/rbmain/api/info/
Using the new web API
cvs diff -uN
   cvs diff: Diffing .
   cvs diff: Diffing src
   cvs