------------------------------------------------------------------------------ To reply, visit https://hellosplat.com/s/beanbag/tickets/4623/ ------------------------------------------------------------------------------
New ticket #4623 by retinkab For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Defect File attachments: * CMakeLists.txt.diff <https://hellosplat.com/s/beanbag/attachments/1266/> * CMakeLists.txt.rej <https://hellosplat.com/s/beanbag/attachments/1267/> ------------------------------------------------------------------------------ Change in newline at end of file provokes patch rejection / error ============================================================================== # What version are you running? Reviewboard 3.0.1 # What steps will reproduce the problem? 1. Upload patch 2. Upload updated patch to same review Consider a patch, generated on Linux. Someone adds a newline to the end of the file. You get in the patch file, (from the .diff file) -) \ No newline at end of file +) Reviewboard seems to be unaware of how to handle this, and tries to apply a patch that looks like: (from the .rej file) -)+) This results in a rejection being created, and a message allowing you to view or download the results of the rejected patch. # What operating system are you using? Linux. ------------------------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
