RE: Realized web-based post-commit reviews
Good work! How about CVS? From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Martin Sent: Thursday, April 07, 2011 11:53 AM To: reviewboard@googlegroups.com Subject: Re: Realized web-based post-commit reviews Congratulations, I saw you customization and is great. Do you know if there is something like that for git? Thanks in advance. Martin. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or more fields had errors
That's the trick... in /usr/bin/
Thx
Vincent
-Original Message-
From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian
Hammond
Sent: Wednesday, March 30, 2011 9:51 PM
To: Vincent Yee
Cc: Christian Hammond; reviewboard@googlegroups.com
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or
more fields had errors
Hi,
They're both in /usr/local/bin, which is certainly in your user's
path, but is it in Apache's?
You may want to see what happens if you move those to /usr/bin.
Alternatively, you can SetEnv PATH in your web server's config.
Christian
On Wednesday, March 30, 2011, Vincent Yee v...@sendmail.com wrote:
We do have p4 and patch on the client system:
$ which p4
/usr/local/bin/p4
$ /usr/local/bin/p4 -V
Perforce - The Fast Software Configuration Management System.
Copyright 1995-2011 Perforce Software. All rights reserved.
Rev. P4/LINUX26X86/2010.2/279478 (2011/01/03).
[build@vmtemp01 ~]$ ls -al /usr/local/bin/p4
-rwxr-xr-x 1 root root 777172 Mar 22 14:02 /usr/local/bin/p4
$ which patch
/usr/bin/patch
$ /usr/bin/patch -v
patch 2.5.4
Copyright 1984-1988 Larry Wall
Copyright 1989-1999 Free Software Foundation, Inc.
$ ls -al /usr/bin/patch
-rwxr-xr-x 1 root wheel 91476 Aug 11 2008 /usr/bin/patch
From: chip...@gmail.com
[mailto:chip...@gmail.com] On Behalf Of Christian Hammond
Sent: Wednesday, March 30, 2011 5:19 PM
To: Vincent Yee
Cc: reviewboard@googlegroups.com
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200):
One or more fields had errors
Okay, the No such file or
directory indicates a configuration problem, but is a step in the right
direction. Some program you need is missing, and Review Board's initial checks
didn't catch it. Can you make sure that both p4 and patch are both available
on
that system and accessible/executable?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Mar 30, 2011 at 4:59 PM, Vincent Yee v...@sendmail.com wrote:
I tried
with both in Mirror path:
perforce.example:1666
è
Error data: {u'fields': {u'path': [u'[Errno 2] No such file or
directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
:1666 è
Error data: {u'fields': {u'path': [u'[P4.connect()] Connect to
server failed; check $P4PORT.\nTCP connect to :1666 failed.\nconnect: :1666:
Connection refused\n']}, u'stat': u'fail', u'err': {u'msg': u'One or more
fields had errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
From: chip...@gmail.com [mailto:chip...@gmail.com] On
Behalf Of Christian Hammond
Sent: Wednesday, March 30, 2011 4:42 PM
To: Vincent Yee
Cc: reviewboard@googlegroups.com
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200):
One or more fields had errors
The
error message says you're just using :1666.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On
Wed, Mar 30, 2011 at 4:38 PM, Vincent Yee v...@sendmail.com wrote:
Ok now
it’s a different error with
Mirror
path: perforce.example.com:1666
HTTP POSTing to
http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/20/draft/set/:
{'summary': 'p4-testing-change'}
Uploading diff, size: 361
--
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
RE: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or more fields had errors
On my client I have set
export P4PORT=perforce.example.com:1666
Ping perforce.example.com works
PING repoman.example.com (x.y.z.a) 56(84) bytes of data.
64 bytes from repoman.example.com (x.y.z.a): icmp_seq=1 ttl=63 time=0.504 ms
64 bytes from repoman.example.com (x.y.z.a): icmp_seq=2 ttl=63 time=0.335 ms
$ telnet perforce.example.com 1666
Trying x.y.z.a...
Connected to perforce.example.com (x.y.z.a).
Escape character is '^]'.
;;xfiles5server3server217funprotocol^]
telnet
From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian
Hammond
Sent: Wednesday, March 30, 2011 3:41 PM
To: reviewboard@googlegroups.com
Cc: Vincent Yee
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or
more fields had errors
Sounds like the Review Board server isn't able to contact your Perforce server
for some reason. Might want to try SSHing into that server, temporarily setting
P4PORT in your session, and accessing the server. Or try pinging it for an
initial test.
Christian
--
Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Mar 30, 2011 at 3:36 PM, storms
v...@sendmail.commailto:v...@sendmail.com wrote:
trying to setup post-review with perforce got the following error.
I am able to ping and telnet to the perforce server from my
client my repository setting is:
Hosting service: Custom
Repository type: Perforce
Path: perforce.example.comhttp://perforce.example.com
Username: useranme
Password: password
$ post-review --debug --summary=p4-testing-change
RBTools 0.3.2
Home = /home/build
svn info
p4 info
repository info: Path:
repoman.example.com:1666http://repoman.example.com:1666, Base path: None,
Supports changesets: True
HTTP GETting api/
HTTP GETting http://vmreviews.lab-example.com/reviews/api/info/
Using the new web API
Generating diff for changenum default
p4 opened -c default
Processing edit of //depot/Iocaine/main/Product/build.xml
Writing //depot/Iocaine/main/Product/build.xml#197 to /tmp/tmpzT7Exi
p4 print -o /tmp/tmpzT7Exi -q //depot/Iocaine/main/Product/build.xml#197
diff -urNp /tmp/tmpzT7Exi
/home/build/build_client/Iocaine/main/Product/build.xml
Using changenums on Review Board 1.5.2. Falling back to the deprecated 1.0
API
== Review Board Login Required
Enter username and password for Review Board at
http://vmreviews.lab-example.com/reviews/
Looking for 'vmreviews.lab-example /reviews/' cookie in
/home/build/.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request on
perforce.example.comhttp://perforce.example.com for None
HTTP POSTing to
http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/new/:
{'repository_path': 'perforce.example.comhttp://perforce.example.com'}
Review request created
Attempting to set field 'summary' to 'p4-testing-change' for review request
'12'
HTTP POSTing to
http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/12/draft/set/:
{'summary': 'p4-testing-change'}
Uploading diff, size: 361
HTTP POSTing to
http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/12/diff/new/:
{}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'[P4.connect()] Connect to server
failed; check $P4PORT.\nTCP connect to
perforce.example.comhttp://perforce.example.com
failed.\nperforce.example.comhttp://nperforce.example.com: service
unknown.\n']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
$ post-review --debug --summary=p4-testing-change --output-diff
RBTools 0.3.2
Home = /home/build
svn info
p4 info
repository info: Path:
repoman.example.com:1666http://repoman.example.com:1666, Base path: None,
Supports changesets: True
HTTP GETting api/
HTTP GETting http://vmreviews.lab-example.com/reviews/api/info/
Using the new web API
Generating diff for changenum default
p4 opened -c default
Processing edit of //depot/Iocaine/main/Product/build.xml
Writing //depot/Iocaine/main/Product/build.xml#197 to /tmp/tmpDCtOBl
p4 print -o /tmp/tmpDCtOBl -q //depot/Iocaine/main/Product/build.xml#197
diff -urNp /tmp/tmpDCtOBl
/home/build/build_client/Iocaine/main/Product/build.xml
Using changenums on Review Board 1.5.2. Falling back to the deprecated 1.0
API
--- //depot/Iocaine/main/Product/build.xml //depot/Iocaine/main/
Product/build.xml#197
+++ //depot/Iocaine/main/Product/build.xml 2011-03-30 06:09:25
@@ -1,4 +1,5 @@
project name=Iocaine default=all-nodist basedir=.
+project name=Iocaine
RE: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or more fields had errors
Ok now it's a different error with
Mirror path: perforce.example.com:1666
HTTP POSTing to
http://vmreviews.lab-example.com/reviews/api/json/reviewrequests/20/draft/set/:
{'summary': 'p4-testing-change'}
Uploading diff, size: 361
HTTP POSTing to
http://vmreviews.qa-lab.sendmail.com/reviews/api/json/reviewrequests/20/diff/new/:
{}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'[Errno 2] No such file or
directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
[build@vmtemp01 Product]$
If putting jsut :1666 in Mirror path,
It returns the original error:
Error data: {u'fields': {u'path': [u'[P4.connect()] Connect to server
failed; check $P4PORT.\nTCP connect to :1666 failed.\nconnect: :1666:
Connection refused\n']}, u'stat': u'fail', u'err': {u'msg': u'One or more
fields had errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian
Hammond
Sent: Wednesday, March 30, 2011 4:23 PM
To: Vincent Yee
Cc: reviewboard@googlegroups.com
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or
more fields had errors
Try putting the :1666 one in Mirror Path.
Christian
--
Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Mar 30, 2011 at 4:19 PM, Vincent Yee
v...@sendmail.commailto:v...@sendmail.com wrote:
I get a different error message if I have :1666 on my repository entry (Got API
Error 206 (HTTP code 200)
$ post-review --debug --summary=p4-testing-change
RBTools 0.3.2
Home = /home/build
svn info
p4 info
repository info: Path:
repoman.smi.sendmail.com:1666http://repoman.smi.sendmail.com:1666, Base
path: None, Supports changesets: True
HTTP GETting api/
HTTP GETting http://vmreviews.lab-example.com/reviews/api/info/
Using the new web API
Generating diff for changenum default
p4 opened -c default
Processing edit of //depot/Iocaine/main/Product/build.xml
Writing //depot/Iocaine/main/Product/build.xml#197 to /tmp/tmpIdYR5a
p4 print -o /tmp/tmpIdYR5a -q //depot/Iocaine/main/Product/build.xml#197
diff -urNp /tmp/tmpIdYR5a
/home/build/build_client/Iocaine/main/Product/build.xml
Using changenums on Review Board 1.5.2. Falling back to the deprecated 1.0
API
== Review Board Login Required
Enter username and password for Review Board at
http://vmreviews.lab-example.com/reviews/
Looking for
'vmreviews.qa-lab.sendmail.comhttp://vmreviews.qa-lab.sendmail.com
/reviews/' cookie in /home/build/.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request on
perforce.example.comhttp://perforce.example.com for None
HTTP POSTing to
http://vmreviews.qa-lab.sendmail.com/reviews/api/json/reviewrequests/new/:
{'repository_path':
'perforce.smi.sendmail.comhttp://perforce.smi.sendmail.com'}
Got API Error 206 (HTTP code 200): The repository path specified is not in
the list of known repositories
Error data: {u'repository_path':
u'perforce.example.comhttp://perforce.example.com', u'stat': u'fail',
u'err': {u'msg': u'The repository path specified is not in the list of
known repositories', u'code': 206}, u'deprecated': {u'in_version': u'1.5'}}
There was an error creating this review request.
The repository path repoman.example.com:1666http://repoman.example.com:1666
is not in the
list of known repositories on the server.
Ask the administrator to add this repository to the Review Board server.
For information on adding repositories, please read
http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/
From: chip...@gmail.commailto:chip...@gmail.com
[mailto:chip...@gmail.commailto:chip...@gmail.com] On Behalf Of Christian
Hammond
Sent: Wednesday, March 30, 2011 4:08 PM
To: Vincent Yee
Cc: reviewboard@googlegroups.commailto:reviewboard@googlegroups.com
Subject: Re: post-review w/ p4 error: Got API Error 105 (HTTP code 200): One or
more fields had errors
The repository entry you showed doesn't seem to have :1666? Try adding the port.
Christian
--
Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Mar 30, 2011 at 4:00 PM, Vincent Yee
v...@sendmail.commailto:v...@sendmail.com wrote:
On my client I have set
export P4PORT=perforce.example.com:1666http://perforce.example.com:1666
Ping perforce.example.comhttp://perforce.example.com works
PING
RE: 500 - Internal Server Error | Review Board
Thanks... That fix the problem now I am able to see the login and registration GUI etc... Vincent From: chip...@gmail.com [mailto:chip...@gmail.com] On Behalf Of Christian Hammond Sent: Thursday, March 24, 2011 5:28 PM To: reviewboard@googlegroups.com Cc: Vincent Yee Subject: Re: 500 - Internal Server Error | Review Board Hi, Looks like a new python-dateutil was just released today that only works with Python 3, and it's being fetched. That's not good. We'll have to get out an update to be more specific about the version needed. Try getting rid of the old version (rm -rf /usr/lib/python2.4/site-packages/python_dateutil-2.0-py2.4.egg/) Then: easy_install -U python_dateutil==1.5 Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Mar 24, 2011 at 5:24 PM, storms v...@sendmail.commailto:v...@sendmail.com wrote: Just installed 1.5.4 with Apache + mod_python started apache, and try to access web and got the following and got the following error via browser: 500 - Internal Server Error | Review Board - Mozilla Firefox Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. here's the log file: [Thu Mar 24 17:10:53 2011] [notice] suEXEC mechanism enabled (wrapper: /usr/sbin/suexec) [Thu Mar 24 17:10:53 2011] [notice] Digest: generating secret for digest authentication ... [Thu Mar 24 17:10:53 2011] [notice] Digest: done [Thu Mar 24 17:10:53 2011] [notice] mod_python: Creating 4 session mutexes based on 256 max processes and 0 max threads. [Thu Mar 24 17:10:53 2011] [notice] Apache/2.2.3 (Red Hat) configured -- resuming normal operations /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/ __init__.py:19: DeprecationWarning: settings.DATABASE_* is deprecated; use settings.DATABASES instead. DeprecationWarning /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/ __init__.py:60: DeprecationWarning: Short names for ENGINE in database configurations are deprecated. Prepend default.ENGINE with 'django.db.backends.' DeprecationWarning /usr/lib/python2.4/site-packages/pycrypto-2.3-py2.4-linux-i686.egg/ Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning: This application uses RandomPool, which is BROKEN in older releases. See http://www.pycrypto.org/randpool-broken /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/ context_processors.py:27: DeprecationWarning: The context processor at `django.core.context_processors.auth` is deprecated; use the path `django.contrib.auth.context_processors.auth` instead. DeprecationWarning /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/ loaders/filesystem.py:58: DeprecationWarning: 'django.template.loaders.filesystem.load_template_source' is deprecated; use 'django.template.loaders.filesystem.Loader' instead. DeprecationWarning ERROR:root:Exception thrown for user AnonymousUser at http://vmreviews.qa-lab.sendmail.com/reviews/account/login/?next_page=/reviews/dashboard/ invalid syntax (parser.py, line 23) Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/auth/views.py, line 80, in login return render_to_response(template_name, context) File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ shortcuts/__init__.py, line 20, in render_to_response return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs) File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/loader.py, line 183, in render_to_string return t.render(Context(dictionary)) File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py, line 123, in render return self._render(context) File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py, line 117, in _render return self.nodelist.render(context) File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py, line 744, in render bits.append(self.render_node(node, context)) File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py, line 757, in render_node return node.render(context) File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/loader_tags.py, line 127, in render return compiled_parent._render(context) File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py, line 117, in _render return self.nodelist.render(context) File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ template/base.py, line 744, in render
