Re: Multiple ShipIt from same user counted in dashboard tally

[Christian Hammond]

Hi Vince,

Right now, yes, it is. We count the total filed, not the total number of
users who have filed one.

We made the first steps in 3.0 to change Ship It logic (letting you remove
them), but want to work toward a better model for invalidating older Ship
Its on updates and to better exposer the behind-the-scenes concept of
approval. For now, though, what you're seeing is expected behavior.

Christian

On Wed, Feb 21, 2018 at 2:34 PM, Vince Thyng  wrote:

> Version 3.0.2
> A user has pointed out that a developer gave a ShipIt for 2 different
> diffs in a review.  Both are being counted in the dashboard tally.  Is this
> expected behavior?
>
> Vince
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Multiple ShipIt from same user counted in dashboard tally

[Vince Thyng]

Version 3.0.2
A user has pointed out that a developer gave a ShipIt for 2 different diffs 
in a review.  Both are being counted in the dashboard tally.  Is this 
expected behavior?

Vince

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.