Re: With git, why does `rbt post` send a cumulative diff of the branch heads?

2021-11-08 Thread Michael van der Kamp
Nevermind, I found 
https://groups.google.com/g/reviewboard/c/_drAGy5jhzs/m/oKWCGdlwEQAJ

On Monday, November 8, 2021 at 5:05:52 PM UTC-6 Michael van der Kamp wrote:

> I noticed that `rbt post` sends a cumulative diff along with the 
> individual commit diffs, and this diff is generated using the syntax `git 
> diff A..B`. I have a couple questions:
>
>1. What is the purpose of this cumulative diff?
>2. This generates a diff between the current state of `A` against the 
>current state of `B`, which can extremely large if `A` has progressed 
> since 
>`B` was branched off of it. Why is this needed? Why not just compare 
>against the merge-base of `A` and `B`, e.g. by doing `git diff A...B` 
>instead?
>
> Cheers!
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/b15181da-3e7e-4c33-a965-c86c547e1188n%40googlegroups.com.


With git, why does `rbt post` send a cumulative diff of the branch heads?

2021-11-08 Thread Michael van der Kamp
I noticed that `rbt post` sends a cumulative diff along with the individual 
commit diffs, and this diff is generated using the syntax `git diff A..B`. 
I have a couple questions:

   1. What is the purpose of this cumulative diff?
   2. This generates a diff between the current state of `A` against the 
   current state of `B`, which can extremely large if `A` has progressed since 
   `B` was branched off of it. Why is this needed? Why not just compare 
   against the merge-base of `A` and `B`, e.g. by doing `git diff A...B` 
   instead?

Cheers!

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/8d833f20-d3f8-4305-8ff8-a922cb59e30an%40googlegroups.com.