Re: exception after publishing review
I believe I have found the problem: @'s in the user name.
Our LDAP sever is setup in such a way that it has your primary email
address in the uid: j...@foo.com, not just john.
@'s in user ids breaks reviewboard in more than one place, though such
a user is able to log in and create reviews. But
as soon as you add such a user as a reviewer, the review breaks with
the exception above.
Also if you click on the users name in a review, that will break it.
Accessing the this url causes an exception:
http://ilmwiki0.cup.hp.com:8080/users/f...@bar.com/
I was able to get around this by changing the LDAP filter to be (uid=
%...@mycompany.com). This way the @domain name is not included in their
domain name.
But this is probably a bug that should be fixedshould I file it?
Regards,
Kimon
On Mar 16, 10:16 pm, Christian Hammond chip...@chipx86.com wrote:
This is not an error you should encounter unless you had a very broken
install or had modified the code. What system was this installed on, how did
you install it, and can you show me your web server configuration?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Mon, Mar 16, 2009 at 5:20 PM, Kimon kim...@gmail.com wrote:
(strange...did not seem to post the first time so I'm trying to post
again)
I've created a number of reviews with post-review and svn. This
seemed to work fine. Then I added a review group and and additional
reviewer and tried to post the review. In at least one instance, it
said it failed to post the review (no sure it happened both times).
Anyway, now when I try to look at either review I get the following
exception:
Environment:
Request Method: GET
Request URL: http://hostname:8080/r/10/
Django Version: 1.0.2 final
Python Version: 2.6.0
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.iphone',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.webapi',
'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
Template error:
In template /usr/local/lib64/python2.6/site-packages/
ReviewBoard-1.0alpha4-py2.6.egg/reviewboard/templates/reviews/
review_request_box.html, error at line 47
Caught an exception while rendering: Reverse for 'reviewboard.user'
with arguments '(User: kimonp,)' and keyword arguments '{}' not
found.
37 : /tr
38 : tr
39 : td class=labellabel for=bugs_closed{% trans Bugs
%}:/label/td
40 : td class=valuespan id=bugs_closed class=editable
comma-editable{% spaceless %}
41 : {% for bug in review_request_details.get_bug_list %}
42 : {% if review_request.repository.bug_tracker %}a href={{bug|
bug_url:review_request}}{{bug}}/a{% else %}{{bug}}{% endif %}{% if
not forloop.last %}, {% endif %}
43 : {% endfor %}
44 : {% endspaceless %}/span/td
45 : td class=indented labellabel for=target_people{%
trans People %}:/label/td
46 : td class=valuespan id=target_people class=editable
comma-editable{% spaceless %}
47 : {% for person in review_request_details.target_people.all
%}
48 : a href={% url user person %}{% if not person.is_active %}
class=inactive{% endif %}{{person}}/a{% if not forloop.last %},
{% endif %}
49 : {% endfor %}
50 : {% endspaceless %}/span/td
51 : /tr
52 : tr
53 : td class=labellabel for=changenum{% trans Change
Number %}:/label/td
54 : td class=valuespan id=changenum
{{review_request.changenum}}/span/td
55 : td class=labellabel for=repository{% trans
Repository %}:/label/td
56 : td class=valuespan id=repository
{{review_request.repository}}/span/td
57 : /tr
Traceback:
File /usr/local/lib64/python2.6/site-packages/django/core/handlers/
base.py in get_response
86. response = callback(request, *callback_args,
**callback_kwargs)
File
Re: exception after publishing review
Hi Cristian,
Server version: Apache/2.2.10 (Linux/SUSE)
Server built: Dec 3 2008 13:33:50
After a few fits and starts, the install was pretty straightforward.
Almost by the book I think. At first I was trying to put reviewboard
in a subdirectory, but I backed off of that and ran rb-site install
from scratch (after dropping and re-creating the database).
I did three things out of the ordinary that I know of:
1. I have it running on port 8080. I'm running on a test system
right now and I did not want to get an additional IP, so I just put it
on a different port.
2. I modified pysvn/__init__.py to recognize python 2.6
3. I modified accounts/backends.py to support our LDAP Schema (minor
change: changed the scope from one level to subtree)
I'll attach my apache conf files, but I did not modify them much at
all.
Request Method: GET
Request URL:http://host:8080/r/2/
Exception Type: TemplateSyntaxError
Exception Value:
Caught an exception while rendering: Reverse for 'reviewboard.user'
with arguments '(User: kimonp,)' and keyword arguments '{}' not
found.
Exception Location: /usr/local/lib64/python2.6/site-packages/django/
template/debug.py in render_node, line 81
Python Executable: /usr/bin/python
Python Version: 2.6.0
Python Path:['/srv/www/reviews/conf', '/usr/local/lib64/python2.6/
site-packages/ReviewBoard-1.0alpha4-py2.6.egg', '/usr/local/lib64/
python2.6/site-packages/flup-1.0.1-py2.6.egg', '/usr/local/lib64/
python2.6/site-packages/Djblets-0.5alpha3-py2.6.egg', '/usr/local/
lib64/python2.6/site-packages/django_evolution-0.0.0-py2.6.egg', '/usr/
local/lib64/python2.6/site-packages/python_memcached-1.43-py2.6.egg',
'/usr/local/lib64/python2.6/site-packages/Pygments-1.0-py2.6.egg', '/
usr/local/lib64/python2.6/site-packages/simplejson-2.0.9-py2.6-linux-
x86_64.egg', '/usr/lib/python26.zip', '/usr/lib64/python2.6', '/usr/
lib64/python2.6/plat-linux2', '/usr/lib64/python2.6/lib-tk', '/usr/
lib64/python2.6/lib-old', '/usr/lib64/python2.6/lib-dynload', '/usr/
lib64/python2.6/site-packages', '/usr/lib64/python2.6/site-packages/
Numeric', '/usr/local/lib64/python2.6/site-packages', '/usr/local/
lib64/python2.6/site-packages/PIL', '/usr/lib64/python2.6/site-
packages/gtk-2.0']
On Mar 16, 10:16 pm, Christian Hammond chip...@chipx86.com wrote:
This is not an error you should encounter unless you had a very broken
install or had modified the code. What system was this installed on, how did
you install it, and can you show me your web server configuration?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Mon, Mar 16, 2009 at 5:20 PM, Kimon kim...@gmail.com wrote:
(strange...did not seem to post the first time so I'm trying to post
again)
I've created a number of reviews with post-review and svn. This
seemed to work fine. Then I added a review group and and additional
reviewer and tried to post the review. In at least one instance, it
said it failed to post the review (no sure it happened both times).
Anyway, now when I try to look at either review I get the following
exception:
Environment:
Request Method: GET
Request URL: http://hostname:8080/r/10/
Django Version: 1.0.2 final
Python Version: 2.6.0
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.iphone',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.webapi',
'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
Template error:
In template /usr/local/lib64/python2.6/site-packages/
ReviewBoard-1.0alpha4-py2.6.egg/reviewboard/templates/reviews/
review_request_box.html, error at line 47
Caught an exception while rendering: Reverse for 'reviewboard.user'
with arguments '(User: kimonp,)' and keyword arguments '{}' not
found.
37 : /tr
38 : tr
39 : td class=labellabel for=bugs_closed{% trans Bugs
%}:/label/td
40 : td class=valuespan id=bugs_closed
Re: exception after publishing review
Here is my reviewboard.conf file. The only modification that I know
if is that its running on port 8080. Let me know if there is another
configuration file that would illuminating.
VirtualHost *:8080
ServerName ilmwiki0.cup.hp.com
DocumentRoot /srv/www/reviews/htdocs
# Error handlers
ErrorDocument 500 /errordocs/500.html
# Serve django pages
Location /
PythonPath ['/srv/www/reviews/conf'] + sys.path
SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings
SetEnv PYTHON_EGG_CACHE /srv/www/reviews/tmp/egg_cache
SetHandler mod_python
PythonHandler django.core.handlers.modpython
PythonAutoReload Off
PythonDebug Off
# Used to run multiple mod_python sites in the same
apache
PythonInterpreter reviewboard_reviews
/Location
# Serve static media without running it through mod_python
# (overrides the above)
Location /media
SetHandler None
/Location
Location /errordocs
SetHandler None
/Location
Directory /srv/www/reviews/htdocs
AllowOverride All
/Directory
# Alias static media requests to filesystem
Alias /media /srv/www/reviews/htdocs/media
Alias /errordocs /srv/www/reviews/htdocs/errordocs
/VirtualHost
On Mar 17, 9:16 am, Kimon kim...@gmail.com wrote:
Hi Cristian,
Server version: Apache/2.2.10 (Linux/SUSE)
Server built: Dec 3 2008 13:33:50
After a few fits and starts, the install was pretty straightforward.
Almost by the book I think. At first I was trying to put reviewboard
in a subdirectory, but I backed off of that and ran rb-site install
from scratch (after dropping and re-creating the database).
I did three things out of the ordinary that I know of:
1. I have it running on port 8080. I'm running on a test system
right now and I did not want to get an additional IP, so I just put it
on a different port.
2. I modified pysvn/__init__.py to recognize python 2.6
3. I modified accounts/backends.py to support our LDAP Schema (minor
change: changed the scope from one level to subtree)
I'll attach my apache conf files, but I did not modify them much at
all.
Request Method: GET
Request URL: http://host:8080/r/2/
Exception Type: TemplateSyntaxError
Exception Value:
Caught an exception while rendering: Reverse for 'reviewboard.user'
with arguments '(User: kimonp,)' and keyword arguments '{}' not
found.
Exception Location: /usr/local/lib64/python2.6/site-packages/django/
template/debug.py in render_node, line 81
Python Executable: /usr/bin/python
Python Version: 2.6.0
Python Path: ['/srv/www/reviews/conf', '/usr/local/lib64/python2.6/
site-packages/ReviewBoard-1.0alpha4-py2.6.egg', '/usr/local/lib64/
python2.6/site-packages/flup-1.0.1-py2.6.egg', '/usr/local/lib64/
python2.6/site-packages/Djblets-0.5alpha3-py2.6.egg', '/usr/local/
lib64/python2.6/site-packages/django_evolution-0.0.0-py2.6.egg', '/usr/
local/lib64/python2.6/site-packages/python_memcached-1.43-py2.6.egg',
'/usr/local/lib64/python2.6/site-packages/Pygments-1.0-py2.6.egg', '/
usr/local/lib64/python2.6/site-packages/simplejson-2.0.9-py2.6-linux-
x86_64.egg', '/usr/lib/python26.zip', '/usr/lib64/python2.6', '/usr/
lib64/python2.6/plat-linux2', '/usr/lib64/python2.6/lib-tk', '/usr/
lib64/python2.6/lib-old', '/usr/lib64/python2.6/lib-dynload', '/usr/
lib64/python2.6/site-packages', '/usr/lib64/python2.6/site-packages/
Numeric', '/usr/local/lib64/python2.6/site-packages', '/usr/local/
lib64/python2.6/site-packages/PIL', '/usr/lib64/python2.6/site-
packages/gtk-2.0']
On Mar 16, 10:16 pm, Christian Hammond chip...@chipx86.com wrote:
This is not an error you should encounter unless you had a very broken
install or had modified the code. What system was this installed on, how did
you install it, and can you show me your web server configuration?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Mon, Mar 16, 2009 at 5:20 PM, Kimon kim...@gmail.com wrote:
(strange...did not seem to post the first time so I'm trying to post
again)
I've created a number of reviews with post-review and svn. This
seemed to work fine. Then I added a review group and and additional
reviewer and tried to post the review. In at least one instance, it
said it failed to post the review (no sure it happened both times).
Anyway, now when I try to look at either review I get the following
exception:
Environment:
Request Method: GET
Request URL: http://hostname:8080/r/10/
Django Version: 1.0.2 final
Python Version: 2.6.0
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
exception after publishing review
I've created a number of reviews with post-review and svn. This
seemed to work fine. Then I added a review group and and additional
reviewer and tried to post the review. In at least one instance, it
said it failed to post the review (no sure it happened both times).
Anyway, now when I try to look at either review I get the following
exception:
Environment:
Request Method: GET
Request URL: http://hostname:8080/r/10/
Django Version: 1.0.2 final
Python Version: 2.6.0
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.iphone',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.webapi',
'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
Template error:
In template /usr/local/lib64/python2.6/site-packages/
ReviewBoard-1.0alpha4-py2.6.egg/reviewboard/templates/reviews/
review_request_box.html, error at line 47
Caught an exception while rendering: Reverse for 'reviewboard.user'
with arguments '(User: kimonp,)' and keyword arguments '{}' not
found.
37 : /tr
38 : tr
39 :td class=labellabel for=bugs_closed{% trans Bugs
%}:/label/td
40 :td class=valuespan id=bugs_closed class=editable
comma-editable{% spaceless %}
41 : {% for bug in review_request_details.get_bug_list %}
42 : {% if review_request.repository.bug_tracker %}a href={{bug|
bug_url:review_request}}{{bug}}/a{% else %}{{bug}}{% endif %}{% if
not forloop.last %}, {% endif %}
43 : {% endfor %}
44 : {% endspaceless %}/span/td
45 :td class=indented labellabel for=target_people{%
trans People %}:/label/td
46 :td class=valuespan id=target_people class=editable
comma-editable{% spaceless %}
47 : {% for person in review_request_details.target_people.all
%}
48 : a href={% url user person %}{% if not person.is_active %}
class=inactive{% endif %}{{person}}/a{% if not forloop.last %},
{% endif %}
49 : {% endfor %}
50 : {% endspaceless %}/span/td
51 : /tr
52 : tr
53 :td class=labellabel for=changenum{% trans Change
Number %}:/label/td
54 :td class=valuespan id=changenum
{{review_request.changenum}}/span/td
55 :td class=labellabel for=repository{% trans
Repository %}:/label/td
56 :td class=valuespan id=repository
{{review_request.repository}}/span/td
57 : /tr
Traceback:
File /usr/local/lib64/python2.6/site-packages/django/core/handlers/
base.py in get_response
86. response = callback(request, *callback_args,
**callback_kwargs)
File /usr/local/lib64/python2.6/site-packages/ReviewBoard-1.0alpha4-
py2.6.egg/reviewboard/accounts/decorators.py in _check
27. return view_func(*args, **kwargs)
File /usr/local/lib64/python2.6/site-packages/ReviewBoard-1.0alpha4-
py2.6.egg/reviewboard/reviews/views.py in review_detail
200. 'PRE_CREATION': PRE_CREATION,
File /usr/local/lib64/python2.6/site-packages/django/shortcuts/
__init__.py in render_to_response
18. return HttpResponse(loader.render_to_string(*args,
**kwargs), **httpresponse_kwargs)
File /usr/local/lib64/python2.6/site-packages/django/template/
loader.py in render_to_string
107. return t.render(context_instance)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
176. return self.nodelist.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
768. bits.append(self.render_node(node, context))
File /usr/local/lib64/python2.6/site-packages/django/template/
debug.py in render_node
71. result = node.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
loader_tags.py in render
97. return compiled_parent.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
176. return self.nodelist.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
768. bits.append(self.render_node(node, context))
File
exception after publishing review
(strange...did not seem to post the first time so I'm trying to post
again)
I've created a number of reviews with post-review and svn. This
seemed to work fine. Then I added a review group and and additional
reviewer and tried to post the review. In at least one instance, it
said it failed to post the review (no sure it happened both times).
Anyway, now when I try to look at either review I get the following
exception:
Environment:
Request Method: GET
Request URL: http://hostname:8080/r/10/
Django Version: 1.0.2 final
Python Version: 2.6.0
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.iphone',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.webapi',
'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
Template error:
In template /usr/local/lib64/python2.6/site-packages/
ReviewBoard-1.0alpha4-py2.6.egg/reviewboard/templates/reviews/
review_request_box.html, error at line 47
Caught an exception while rendering: Reverse for 'reviewboard.user'
with arguments '(User: kimonp,)' and keyword arguments '{}' not
found.
37 : /tr
38 : tr
39 :td class=labellabel for=bugs_closed{% trans Bugs
%}:/label/td
40 :td class=valuespan id=bugs_closed class=editable
comma-editable{% spaceless %}
41 : {% for bug in review_request_details.get_bug_list %}
42 : {% if review_request.repository.bug_tracker %}a href={{bug|
bug_url:review_request}}{{bug}}/a{% else %}{{bug}}{% endif %}{% if
not forloop.last %}, {% endif %}
43 : {% endfor %}
44 : {% endspaceless %}/span/td
45 :td class=indented labellabel for=target_people{%
trans People %}:/label/td
46 :td class=valuespan id=target_people class=editable
comma-editable{% spaceless %}
47 : {% for person in review_request_details.target_people.all
%}
48 : a href={% url user person %}{% if not person.is_active %}
class=inactive{% endif %}{{person}}/a{% if not forloop.last %},
{% endif %}
49 : {% endfor %}
50 : {% endspaceless %}/span/td
51 : /tr
52 : tr
53 :td class=labellabel for=changenum{% trans Change
Number %}:/label/td
54 :td class=valuespan id=changenum
{{review_request.changenum}}/span/td
55 :td class=labellabel for=repository{% trans
Repository %}:/label/td
56 :td class=valuespan id=repository
{{review_request.repository}}/span/td
57 : /tr
Traceback:
File /usr/local/lib64/python2.6/site-packages/django/core/handlers/
base.py in get_response
86. response = callback(request, *callback_args,
**callback_kwargs)
File /usr/local/lib64/python2.6/site-packages/ReviewBoard-1.0alpha4-
py2.6.egg/reviewboard/accounts/decorators.py in _check
27. return view_func(*args, **kwargs)
File /usr/local/lib64/python2.6/site-packages/ReviewBoard-1.0alpha4-
py2.6.egg/reviewboard/reviews/views.py in review_detail
200. 'PRE_CREATION': PRE_CREATION,
File /usr/local/lib64/python2.6/site-packages/django/shortcuts/
__init__.py in render_to_response
18. return HttpResponse(loader.render_to_string(*args,
**kwargs), **httpresponse_kwargs)
File /usr/local/lib64/python2.6/site-packages/django/template/
loader.py in render_to_string
107. return t.render(context_instance)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
176. return self.nodelist.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
768. bits.append(self.render_node(node, context))
File /usr/local/lib64/python2.6/site-packages/django/template/
debug.py in render_node
71. result = node.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
loader_tags.py in render
97. return compiled_parent.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
176. return self.nodelist.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
768.
