Re: rb-extension-pack Compability with Review Board 3.0

2017-11-19 Thread Christian Hammond 
The extension won't be getting patched. At least not right away, but it
won't need to be. The existing version will work with the 3.0 release. It
was just using a deprecated attribute that got left out of a new
implementation.

Christian

On Sun, Nov 19, 2017 at 4:59 PM, Daniel Morgan <
daniel.kenji.mor...@gmail.com> wrote:

> Christian,
>
> Thank you for the reply.
> I will wait for the patch to be applied and check again.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: rb-extension-pack Compability with Review Board 3.0

2017-11-19 Thread Daniel Morgan 
Christian,

Thank you for the reply.
I will wait for the patch to be applied and check again.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: rb-extension-pack Compability with Review Board 3.0

2017-11-19 Thread Daniel Morgan 
David,

Thank you for the reply.
I will check again once the Extensions get updated.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: rb-extension-pack Compability with Review Board 3.0

2017-11-17 Thread Christian Hammond 
This particular issue will be fixed by release. It's a regression in
Djblets that I'll have a patch for.

Christian

On Thu, Nov 16, 2017 at 2:40 PM, David Trowbridge 
wrote:

> Daniel,
>
> I'm not sure we'll have time before the release but we'll definitely be
> making sure that everything gets updated asap.
>
> -David
>
> On Wed, Nov 15, 2017 at 7:20 PM Daniel Morgan <
> daniel.kenji.mor...@gmail.com> wrote:
>
>> Are there any plans to check the compatibility for the Extensions
>> contained in rb-extension-pack with Review Board 3.0?
>> I am using a few of the Extensions there and have encountered errors
>> using Review Board 3.0 RC1.
>>
>> For example, when configuring the message for the "Message of the Day"
>> Extension, I get the following error.
>> The log output is as follows (sensitive details edited):
>>
>> None - User1 - /admin/extensions/rbmotd.extension.MotdExtension/config/
>> - djblets.log.middleware - Exception thrown for user User1 at
>> http://x.x.x.x/admin/extensions/rbmotd.extension.MotdExtension/config/
>>
>> 'MotdSettingsForm' object has no attribute 'siteconfig'
>> Traceback (most recent call last):
>>   File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py",
>> line 112, in get_response
>> response = wrapped_callback(request, *callback_args,
>> **callback_kwargs)
>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>> line 99, in _wrapped_view
>> response = view_func(request, *args, **kwargs)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/reviewboard/extensions/views.py",
>> line 15, in configure_extension
>> template_name)
>>   File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py",
>> line 99, in _wrapped_view
>> response = view_func(request, *args, **kwargs)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
>> line 17, in _checklogin
>> return view_func(request, *args, **kwargs)
>>   File "/usr/local/lib/python2.7/dist-packages/djblets/extensions/views.py",
>> line 64, in configure_extension
>> form.save()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/rbmotd-1.0-py2.7.egg/rbmotd/forms.py",
>> line 22, in save
>> self.siteconfig.set(
>> AttributeError: 'MotdSettingsForm' object has no attribute 'siteconfig'
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: rb-extension-pack Compability with Review Board 3.0

2017-11-16 Thread David Trowbridge 
Daniel,

I'm not sure we'll have time before the release but we'll definitely be
making sure that everything gets updated asap.

-David

On Wed, Nov 15, 2017 at 7:20 PM Daniel Morgan 
wrote:

> Are there any plans to check the compatibility for the Extensions
> contained in rb-extension-pack with Review Board 3.0?
> I am using a few of the Extensions there and have encountered errors using
> Review Board 3.0 RC1.
>
> For example, when configuring the message for the "Message of the Day"
> Extension, I get the following error.
> The log output is as follows (sensitive details edited):
>
> None - User1 - /admin/extensions/rbmotd.extension.MotdExtension/config/ -
> djblets.log.middleware - Exception thrown for user User1 at
> http://x.x.x.x/admin/extensions/rbmotd.extension.MotdExtension/config/
>
> 'MotdSettingsForm' object has no attribute 'siteconfig'
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line
> 112, in get_response
> response = wrapped_callback(request, *callback_args, **callback_kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 99, in _wrapped_view
> response = view_func(request, *args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/reviewboard/extensions/views.py",
> line 15, in configure_extension
> template_name)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 99, in _wrapped_view
> response = view_func(request, *args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
> line 17, in _checklogin
> return view_func(request, *args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/djblets/extensions/views.py", line
> 64, in configure_extension
> form.save()
>   File
> "/usr/local/lib/python2.7/dist-packages/rbmotd-1.0-py2.7.egg/rbmotd/forms.py",
> line 22, in save
> self.siteconfig.set(
> AttributeError: 'MotdSettingsForm' object has no attribute 'siteconfig'
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

rb-extension-pack Compability with Review Board 3.0

2017-11-15 Thread Daniel Morgan 
Are there any plans to check the compatibility for the Extensions contained 
in rb-extension-pack with Review Board 3.0?
I am using a few of the Extensions there and have encountered errors using 
Review Board 3.0 RC1.

For example, when configuring the message for the "Message of the Day" 
Extension, I get the following error.
The log output is as follows (sensitive details edited):

None - User1 - /admin/extensions/rbmotd.extension.MotdExtension/config/ - 
djblets.log.middleware - Exception thrown for user User1 at 
http://x.x.x.x/admin/extensions/rbmotd.extension.MotdExtension/config/

'MotdSettingsForm' object has no attribute 'siteconfig'
Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 
112, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", 
line 99, in _wrapped_view
response = view_func(request, *args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/reviewboard/extensions/views.py", 
line 15, in configure_extension
template_name)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", 
line 99, in _wrapped_view
response = view_func(request, *args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/django/contrib/admin/views/decorators.py",
 
line 17, in _checklogin
return view_func(request, *args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/djblets/extensions/views.py", line 
64, in configure_extension
form.save()
  File 
"/usr/local/lib/python2.7/dist-packages/rbmotd-1.0-py2.7.egg/rbmotd/forms.py", 
line 22, in save
self.siteconfig.set(
AttributeError: 'MotdSettingsForm' object has no attribute 'siteconfig'

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.