Re: reviewboard and clearcase problem
Ok, i got to spend a little time at this today.
looks like postreview has support for clearcase on windows without
cygwin.
Ans so the posted diff looks fine.
Sorry my mistake.
But thats not the case on the server side.
It fails on the file_exists and then trying to view the diff it
uses a different clearcaseclient than postreview.
Now the next question is there a way to plug in a postreview like
clearcaseclient on the server side that can fetch the proper versions
using cleartool
and thus apply the patch..?
sorry for my previous posts if they were a bit naive but I didnt get
much time
to study the code.
If i get time I might have a go at this.
On Feb 16, 10:55 am, eeiths eei...@gmail.com wrote:
i've got a bit further with this...it looks like the
tool.file_exists(filename, revision) on the server side fails
It tries to parse a file name form the clearcase extended name i.e.
the one with the versions and @@ char sequences
included in the path. e.g Y:/wran_cm_cms/@@/main/22/src/@@/main/3/com/
@@/main/1/..etc
There is a comment on the post-review.py
class ClearCaseClient(SCMClient):
A wrapper around the clearcase tool that fetches repository
information and generates compatible diffs.
This client assumes that cygwin is installed on windows.
I'm not sure then if the post-review worked as expected .
What exactly is cygwin's role in this process.
I do'nt have it installed ...do I need it.
I think I'm almost there ..!
Thanks
T
On Feb 12, 12:19 pm, eeiths eei...@gmail.com wrote:
I'm trying the post-review tool on windows env but i get the following
error ...wondering is this a clearcase issue or reviewboard.
is the a command to create the diff in isolation ..so I can see or
upload it via the GUI.
How can i debug the server side ..?
Any help appreciated .
C:\python25\Scriptscleartool lsco -me -cview -recurse -short X:\ |
sed s/\\/\//g | xargs post-review -d
--server=http://ev001f29a331be/ cleartool pwv -short
repository info: Path: X:/, Base path: X:/, Supports changesets: False
cleartool desc -pre X:\wran_cm_cms\PlannedAreaUpdator.java
cleartool desc -fmt %Vn X:\
cleartool desc -fmt %Vn X:\wran_cm_cms
:
:
cleartool get -to
c:\users\etomhar\appdata\local\temp\ae893516429051478f79222898e00140
X:\wran_cm_cms\PlannedAreaUpdator.java@@\main\at_ossrc_dev\at_ossrc_r7_inc70.26\4
Looking for 'ev001f29a331be /reviews/' cookie in C:\Users\etomhar\Local
Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/new/:{'repository_path':
'X:/'}
Review request created
Attempting to set field 'description' to '** NONE **
VIEWTYPE: dynamic
' for review request '6' HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/set/:{'description':
'** NONE **\nVIEWTYPE: dynamic\n'}
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/save/:{}
Review request draft saved
Uploading diff, size: 29
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/diff/new/:{'basedir':
'X:/'}
Error uploading diff: One or more fields had errors (105) {'fields':
{'path': ['The diff file is empty']}, 'stat': 'fail', 'err': {'msg': 'One
or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: reviewboard and clearcase problem
How do you have the server configured? The server needs to point to a
dynamic view where it will be able to access the file revisions
specified via extended path notation.
Dan
On Feb 17, 10:15 am, eeiths eei...@gmail.com wrote:
Ok, i got to spend a little time at this today.
looks like postreview has support for clearcase on windows without
cygwin.
Ans so the posted diff looks fine.
Sorry my mistake.
But thats not the case on the server side.
It fails on the file_exists and then trying to view the diff it
uses a different clearcaseclient than postreview.
Now the next question is there a way to plug in a postreview like
clearcaseclient on the server side that can fetch the proper versions
using cleartool
and thus apply the patch..?
sorry for my previous posts if they were a bit naive but I didnt get
much time
to study the code.
If i get time I might have a go at this.
On Feb 16, 10:55 am, eeiths eei...@gmail.com wrote:
i've got a bit further with this...it looks like the
tool.file_exists(filename, revision) on the server side fails
It tries to parse a file name form the clearcase extended name i.e.
the one with the versions and @@ char sequences
included in the path. e.g Y:/wran_cm_cms/@@/main/22/src/@@/main/3/com/
@@/main/1/..etc
There is a comment on the post-review.py
class ClearCaseClient(SCMClient):
A wrapper around the clearcase tool that fetches repository
information and generates compatible diffs.
This client assumes that cygwin is installed on windows.
I'm not sure then if the post-review worked as expected .
What exactly is cygwin's role in this process.
I do'nt have it installed ...do I need it.
I think I'm almost there ..!
Thanks
T
On Feb 12, 12:19 pm, eeiths eei...@gmail.com wrote:
I'm trying the post-review tool on windows env but i get the following
error ...wondering is this a clearcase issue or reviewboard.
is the a command to create the diff in isolation ..so I can see or
upload it via the GUI.
How can i debug the server side ..?
Any help appreciated .
C:\python25\Scriptscleartool lsco -me -cview -recurse -short X:\ |
sed s/\\/\//g | xargs post-review -d
--server=http://ev001f29a331be/ cleartool pwv -short
repository info: Path: X:/, Base path: X:/, Supports changesets: False
cleartool desc -pre X:\wran_cm_cms\PlannedAreaUpdator.java
cleartool desc -fmt %Vn X:\
cleartool desc -fmt %Vn X:\wran_cm_cms
:
:
cleartool get -to
c:\users\etomhar\appdata\local\temp\ae893516429051478f79222898e00140
X:\wran_cm_cms\PlannedAreaUpdator.java@@\main\at_ossrc_dev\at_ossrc_r7_inc70.26\4
Looking for 'ev001f29a331be /reviews/' cookie in
C:\Users\etomhar\Local Settings\Application
Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/new/:{'repository_path':
'X:/'}
Review request created
Attempting to set field 'description' to '** NONE **
VIEWTYPE: dynamic
' for review request '6' HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/set/:{'description':
'** NONE **\nVIEWTYPE: dynamic\n'}
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/save/:{}
Review request draft saved
Uploading diff, size: 29
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/diff/new/:{'basedir':
'X:/'}
Error uploading diff: One or more fields had errors (105) {'fields':
{'path': ['The diff file is empty']}, 'stat': 'fail', 'err': {'msg': 'One
or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: reviewboard and clearcase problem
i've got a bit further with this...it looks like the
tool.file_exists(filename, revision) on the server side fails
It tries to parse a file name form the clearcase extended name i.e.
the one with the versions and @@ char sequences
included in the path. e.g Y:/wran_cm_cms/@@/main/22/src/@@/main/3/com/
@@/main/1/..etc
There is a comment on the post-review.py
class ClearCaseClient(SCMClient):
A wrapper around the clearcase tool that fetches repository
information and generates compatible diffs.
This client assumes that cygwin is installed on windows.
I'm not sure then if the post-review worked as expected .
What exactly is cygwin's role in this process.
I do'nt have it installed ...do I need it.
I think I'm almost there ..!
Thanks
T
On Feb 12, 12:19 pm, eeiths eei...@gmail.com wrote:
I'm trying the post-review tool on windows env but i get the following
error ...wondering is this a clearcase issue or reviewboard.
is the a command to create the diff in isolation ..so I can see or
upload it via the GUI.
How can i debug the server side ..?
Any help appreciated .
C:\python25\Scriptscleartool lsco -me -cview -recurse -short X:\ |
sed s/\\/\//g | xargs post-review -d
--server=http://ev001f29a331be/ cleartool pwv -short
repository info: Path: X:/, Base path: X:/, Supports changesets: False
cleartool desc -pre X:\wran_cm_cms\PlannedAreaUpdator.java
cleartool desc -fmt %Vn X:\
cleartool desc -fmt %Vn X:\wran_cm_cms
:
:
cleartool get -to
c:\users\etomhar\appdata\local\temp\ae893516429051478f79222898e00140
X:\wran_cm_cms\PlannedAreaUpdator.java@@\main\at_ossrc_dev\at_ossrc_r7_inc70.26\4
Looking for 'ev001f29a331be /reviews/' cookie in C:\Users\etomhar\Local
Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/new/:{'repository_path':
'X:/'}
Review request created
Attempting to set field 'description' to '** NONE **
VIEWTYPE: dynamic
' for review request '6' HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/set/:{'description':
'** NONE **\nVIEWTYPE: dynamic\n'}
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/save/:{}
Review request draft saved
Uploading diff, size: 29
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/diff/new/:{'basedir':
'X:/'}
Error uploading diff: One or more fields had errors (105) {'fields':
{'path': ['The diff file is empty']}, 'stat': 'fail', 'err': {'msg': 'One or
more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: reviewboard and clearcase problem
I guess You are using 1.0.x ReviewBoard. I had similar problem last
time but my version was 1.1.x alpha which return additional
informations. My error while uploading diff looks like:
{'fields': {'path': ['The diff file is empty']}, 'stat': 'fail', 'err':
{'msg': 'One or more fields had errors', 'code': 105, 'error': 'Permission
Denied'}}
It is really not important how message looks like but i get that
additional information permission or access denied. I don't have
enough time to back to this issue but I guess that ReviewBoard from
the server side try read (or something) from repository and they
don't have enough privileges. Probably Apache / Lighttpd user doesn't
have permissions to read dynamic views. This is only my assumption -
that this is the problem which could happen.
On Feb 12, 10:18 pm, Christian Hammond chip...@chipx86.com wrote:
You can use post-review --output-diff to generate the diff without pushing
it to the server.
What version is running on the server? You may be able to find some data in
the log files, if you turn logging on.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Fri, Feb 12, 2010 at 4:19 AM, eeiths eei...@gmail.com wrote:
I'm trying the post-review tool on windows env but i get the following
error ...wondering is this a clearcase issue or reviewboard.
is the a command to create the diff in isolation ..so I can see or
upload it via the GUI.
How can i debug the server side ..?
Any help appreciated .
C:\python25\Scriptscleartool lsco -me -cview -recurse -short X:\ |
sed s/\\/\//g | xargs post-review -d
--server=http://ev001f29a331be/
cleartool pwv -short
repository info: Path: X:/, Base path: X:/, Supports changesets: False
cleartool desc -pre X:\wran_cm_cms\PlannedAreaUpdator.java
cleartool desc -fmt %Vn X:\
cleartool desc -fmt %Vn X:\wran_cm_cms
:
:
cleartool get -to
c:\users\etomhar\appdata\local\temp\ae893516429051478f79222898e00140
X:\wran_cm_cms\PlannedAreaUpdator.java@
@\main\at_ossrc_dev\at_ossrc_r7_inc70.26\4
Looking for 'ev001f29a331be /reviews/' cookie in C:\Users\etomhar\Local
Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing to
http://ev001f29a331be/reviews/api/json/reviewrequests/new/:
{'repository_path': 'X:/'}
Review request created
Attempting to set field 'description' to '** NONE **
VIEWTYPE: dynamic
' for review request '6'
HTTP POSTing to
http://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/set/:
{'description': '** NONE **\nVIEWTYPE: dynamic\n'}
HTTP POSTing to
http://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/save/:{}
Review request draft saved
Uploading diff, size: 29
HTTP POSTing to
http://ev001f29a331be/reviews/api/json/reviewrequests/6/diff/new/:
{'basedir': 'X:/'}
Error uploading diff: One or more fields had errors (105)
{'fields': {'path': ['The diff file is empty']}, 'stat': 'fail', 'err':
{'msg': 'One or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr
oups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: reviewboard and clearcase problem
You can use post-review --output-diff to generate the diff without pushing
it to the server.
What version is running on the server? You may be able to find some data in
the log files, if you turn logging on.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Feb 12, 2010 at 4:19 AM, eeiths eei...@gmail.com wrote:
I'm trying the post-review tool on windows env but i get the following
error ...wondering is this a clearcase issue or reviewboard.
is the a command to create the diff in isolation ..so I can see or
upload it via the GUI.
How can i debug the server side ..?
Any help appreciated .
C:\python25\Scriptscleartool lsco -me -cview -recurse -short X:\ |
sed s/\\/\//g | xargs post-review -d
--server=http://ev001f29a331be/
cleartool pwv -short
repository info: Path: X:/, Base path: X:/, Supports changesets: False
cleartool desc -pre X:\wran_cm_cms\PlannedAreaUpdator.java
cleartool desc -fmt %Vn X:\
cleartool desc -fmt %Vn X:\wran_cm_cms
:
:
cleartool get -to
c:\users\etomhar\appdata\local\temp\ae893516429051478f79222898e00140
X:\wran_cm_cms\PlannedAreaUpdator.java@
@\main\at_ossrc_dev\at_ossrc_r7_inc70.26\4
Looking for 'ev001f29a331be /reviews/' cookie in C:\Users\etomhar\Local
Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing to
http://ev001f29a331be/reviews/api/json/reviewrequests/new/:
{'repository_path': 'X:/'}
Review request created
Attempting to set field 'description' to '** NONE **
VIEWTYPE: dynamic
' for review request '6'
HTTP POSTing to
http://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/set/:
{'description': '** NONE **\nVIEWTYPE: dynamic\n'}
HTTP POSTing to
http://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/save/: {}
Review request draft saved
Uploading diff, size: 29
HTTP POSTing to
http://ev001f29a331be/reviews/api/json/reviewrequests/6/diff/new/:
{'basedir': 'X:/'}
Error uploading diff: One or more fields had errors (105)
{'fields': {'path': ['The diff file is empty']}, 'stat': 'fail', 'err':
{'msg': 'One or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
