Issue 804 in reviewboard: Diff viewer dies when a git diff contains removed files
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 804 by jeff.hammerbacher: Diff viewer dies when a git diff contains removed files http://code.google.com/p/reviewboard/issues/detail?id=804 *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? https://example.com/reviewboard/r/rnum/diff/ What steps will reproduce the problem? 1. Remove a file 2. git add -A 3. git diff HEAD What is the expected output? What do you see instead? I expect to see my diff; instead, I get the following stack trace: The file '4377b00' could not be found in the repository Traceback (most recent call last): File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/diffviewer/views.py, line 86, in view_diff files = get_diff_files(diffset, None, interdiffset, highlighting) File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 659, in get_diff_files enable_syntax_highlighting) File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 578, in generate_files large_data=True) File /usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081231-py2.5.egg/djblets/util/misc.py, line 142, in cache_memoize data = lookup_callable() File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 577, in lambda enable_syntax_highlighting), File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 338, in get_chunks old = get_original_file(filediff) File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 245, in get_original_file large_data=True)[0] File /usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081231-py2.5.egg/djblets/util/misc.py, line 142, in cache_memoize data = lookup_callable() File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 244, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/diffviewer/diffutils.py, line 224, in fetch_file data = tool.get_file(file, revision) File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/scmtools/git.py, line 33, in get_file return self.client.cat_file(self._resolve_head(revision, path)) File /usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081231-py2.5.egg/reviewboard/scmtools/git.py, line 192, in cat_file raise FileNotFoundError(commit) FileNotFoundError: The file '4377b00' could not be found in the repository What operating system are you using? What browser? OS X 10.5 FF 3.0 Please provide any additional information below. This looks a lot like issues #394 (for cvs) and #442 (for svn). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 666 in reviewboard: view diff causes Error - cvs.py
Comment #7 on issue 666 by onkarshinde: view diff causes Error - cvs.py http://code.google.com/p/reviewboard/issues/detail?id=666 I saw same problem on my Ubuntu machine. The cause was that cvs was not installed. See of that is the problem in your case. Check if cvs binary is in path on your Windows machine. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 806 in reviewboard: Description box
Comment #2 on issue 806 by jefflamb: Description box http://code.google.com/p/reviewboard/issues/detail?id=806 Oops, sorry. Wasn't thinking. We just updated yesterday. It's rev 1668. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 806 in reviewboard: Description box
Updates: Status: Confirmed Labels: Component-Reviews Milestone-Release1.0 Browser Comment #3 on issue 806 by chipx86: Description box http://code.google.com/p/reviewboard/issues/detail?id=806 Okay. Interesting.. I'll try to get a copy of Chrome installed on here when I get time and figure it out. Nothing stands out as obvious, since it's just a textarea with the ability to expand its height on every new line. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 806 in reviewboard: Description box
Comment #5 on issue 806 by chipx86: Description box http://code.google.com/p/reviewboard/issues/detail?id=806 That's definitely good to know. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 807 in reviewboard: Links from reviews do not link to the corresponding line in the diff properly.
Comment #1 on issue 807 by jefflamb: Links from reviews do not link to the corresponding line in the diff properly. http://code.google.com/p/reviewboard/issues/detail?id=807 Can you please edit the above to remove my company name and delete this comment as well? Thanks. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 807 in reviewboard: Links from reviews do not link to the corresponding line in the diff properly.
Comment #3 on issue 807 by jefflamb: Links from reviews do not link to the corresponding line in the diff properly. http://code.google.com/p/reviewboard/issues/detail?id=807 Lame. Oh well. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 807 in reviewboard: Links from reviews do not link to the corresponding line in the diff properly.
Comment #4 on issue 807 by jefflamb: Links from reviews do not link to the corresponding line in the diff properly. http://code.google.com/p/reviewboard/issues/detail?id=807 By the way, this is severely annoying when you want a little context for the comment, but your diff is HUGE. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 807 in reviewboard: Links from reviews do not link to the corresponding line in the diff properly.
Updates: Status: Confirmed Owner: chipx86 Labels: Component-DiffViewer Component-Reviews Comment #5 on issue 807 by chipx86: Links from reviews do not link to the corresponding line in the diff properly. http://code.google.com/p/reviewboard/issues/detail?id=807 A new UI rewrite went in just recently, so there's some things that are still a little broken. This appears to be one of them. We'll get it fixed. As for comments on the review request page, this is due to the progressive loading of the page. Hard to do much about that, but we're looking into it. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
