Issue 1318 in reviewboard: one comment unexpectedly overwrites another

2009-09-17 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1318 by mattginzton: one comment unexpectedly overwrites another
http://code.google.com/p/reviewboard/issues/detail?id=1318

*NOTE: Do not post confidential information in this bug report.*

What version are you running?

Hhh, beta?  Where does it show that?  whichever version VMware has  
deployed.

What's the URL of the page containing the problem?

Any reviewboard diff page.

What steps will reproduce the problem?
1. View a reviewboard diff.
2. Click on a code line number to add a comment (use the right side line
number in the middle of the page, not the left side number at the left of
the page).  The add-comment form will pop up.  Type This is a really long
important comment that I spent 10 minutes typing.  Click Save.
3. Click on the same code line number as you clicked on before.  The
add-comment form will pop up (empty).  Type Oh this is some quicky
afterthought I also had.  Click Save.
4. Either go looking for the first more expensive and thought-through
comment, or publish the review.  Either way you'll find only the second
comment.

What is the expected output? What do you see instead?

Expected output: both comments survive.
Actual result: only the second one.

What operating system are you using? What browser?

Firefox 3.5 on Win2K8 x64.

Please provide any additional information below.

Hi.  This is MattG.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 1281 in reviewboard: Adding comments in diff viewer can delete or overwrite existing comments.

2009-09-17 Thread codesite-noreply


Comment #1 on issue 1281 by chipx86: Adding comments in diff viewer can  
delete or overwrite existing comments.
http://code.google.com/p/reviewboard/issues/detail?id=1281

Issue 1318 has been merged into this issue.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 1318 in reviewboard: one comment unexpectedly overwrites another

2009-09-17 Thread codesite-noreply

Updates:
Status: Duplicate
Mergedinto: 1281

Comment #4 on issue 1318 by chipx86: one comment unexpectedly overwrites  
another
http://code.google.com/p/reviewboard/issues/detail?id=1318

(No comment was entered for this change.)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 46 in reviewboard: 80-column indicator in diff view

2009-09-17 Thread codesite-noreply


Comment #6 on issue 46 by gic...@gmail.com: 80-column indicator in diff view
http://code.google.com/p/reviewboard/issues/detail?id=46

Maybe the background color could be different for characters after the  
boundary.
Example:
div class=linespan class=first-80first 80 chars.../spantrailing  
chars.../div
div class=linespan class=first-80only 50 chars here...(30 chars
spaces)/span/div

div.line {background-color: blue}
div.line .first-80 {background-color: white}

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---