Re: Issue 1191 in reviewboard: post-review with no arguments generated an empty review request

2010-03-02 Thread reviewboard


Comment #4 on issue 1191 by jamesdlin: post-review with no arguments  
generated an empty review request

http://code.google.com/p/reviewboard/issues/detail?id=1191

BTW, similar stuff happens if I make a typo in the Perforce change number  
and no such

changeset exists.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1524 in reviewboard: postreview.py should ignore user configuration when generating diffs.

2010-03-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1524 by emil.sit: postreview.py should ignore user configuration  
when generating diffs.

http://code.google.com/p/reviewboard/issues/detail?id=1524

*NOTE: Do not post confidential information in this bug report.*

What version are you running?

postreview 0.8.

What steps will reproduce the problem?
1. git config diff.external /bin/does-not-exist
2. postreview.py

What is the expected output? What do you see instead?

Expect that a normal diff should be produced and uploaded.
However,

$ postreview.py -d --guess-description --guess-summary

svn info
git rev-parse --git-dir
git symbolic-ref -q HEAD
git svn info
git svn --version
git config --get svn-remote.svn.url
git config --get branch.for-review.merge
git config --get branch.for-review.remote
git config remote.origin.url
repository info: Path: git://internal/test.git, Base path: , Supports

changesets: False

git config --get reviewboard.url
git merge-base origin/master refs/heads/for-review
git diff --no-color --full-index

b79bcb4c0c838df4406c01c59370977a53da5425..refs/heads/for-review
Failed to execute command: ['git', 'diff', '--no-color', '--full-index',
'b79bcb4c0c838df4406c01c59370977a53da5425..refs/heads/for-review']
error: cannot run /bin/does-not-exist: No such file or directory
external diff died, stopping at test/a.txt.

[This log was manually edited diff; real results may vary.]

What operating system are you using? What browser?

Linux.

Please provide any additional information below.

Probably the best solution is to set GIT_CONFIG_NOSYSTEM and
GIT_CONFIG_NOGLOBAL to insulate usage of git from any system/user/repo-
specific settings.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1523 in reviewboard: SCMTool for Subversion fail to collapse 'keyword' correctly

2010-03-02 Thread reviewboard


Comment #1 on issue 1523 by trowbrds: SCMTool for Subversion fail to  
collapse 'keyword' correctly

http://code.google.com/p/reviewboard/issues/detail?id=1523

Issue 1522 has been merged into this issue.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1522 in reviewboard: SCMTool for Subversion fail to collapse 'keyword' correctly

2010-03-02 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 1523

Comment #1 on issue 1522 by trowbrds: SCMTool for Subversion fail to  
collapse 'keyword' correctly

http://code.google.com/p/reviewboard/issues/detail?id=1522

(No comment was entered for this change.)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.