Issue 1560 in reviewboard: post-review: password should be configurable via a config file instead of the command line
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1560 by nahor.j: post-review: password should be configurable via a config file instead of the command line http://code.google.com/p/reviewboard/issues/detail?id=1560 What version are you running? post-review 0.8 Please provide any additional information below. When using the --password parameter, the password for that user is visible to everybody on the machine (e.g. with ps ax on Linux). One should be able to set the password in configuration file, which then can be configured to be readable only by the user running post-review. That way there is no password leak. I put that has a defect because it can be a big security leak, especially when post-review is run by an automated tool like a post-commit hook. In this setup, post-review needs to have access to the whole repository/repositories on the server so if a user can get hold of this password, he can circumvent any read limitation in the SCM. This bug can be mitigated with the cookie (but then it means that every year, the admin must remember to renew it) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1562 in reviewboard: Merge Reviews
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1562 by 12gaugemedia: Merge Reviews http://code.google.com/p/reviewboard/issues/detail?id=1562 It'd be helpful to be allowed to merge reviews in the case that multiple reviews are created (instead of updated) but related. The case this may happen might be through an automated tool that creates post-review reviews and the user forgot to check-in changes the first time, so upon checking-in a second change, an additional review is created when they were related to the first review. Another alternative would be to allow the post-review to take an additional external ID (such as a JIRA issue number) during creation. Then we can update reviews based upon the external ID instead of merging (but that may be helpful regardless). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1558 in reviewboard: Expand for single line doesn't work
Comment #1 on issue 1558 by nahor.j: Expand for single line doesn't work http://code.google.com/p/reviewboard/issues/detail?id=1558 I see the same problem on my install (RB 1.5b1) and on the RB's own install as well: - go to http://reviews.reviewboard.org/r/1472/diff/#0; - click expand on the line 2158 lines hidden [Expand] However, the link Expand changes at the bottom of the header box, which expand the whole diff, works fine. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1500 in reviewboard: xx lines hidden [Expand] link stopped working
Comment #7 on issue 1500 by chipx86: xx lines hidden [Expand] link stopped working http://code.google.com/p/reviewboard/issues/detail?id=1500 Issue 1558 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
