Issue 1567 in reviewboard: The ReviewBoard stoped to work suddenly.

2010-03-24 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1567 by yunshan.di: The ReviewBoard stoped to work suddenly.
http://code.google.com/p/reviewboard/issues/detail?id=1567

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
ReviewBoard1.5Beta1_Python2.6

What's the URL of the page containing the problem?
Unable to visit ReviewBoard site.

What steps will reproduce the problem?
The ReviewBoard stoped to work suddenly.

What is the expected output? What do you see instead?
MOD_PYTHON ERROR

ProcessId:  12138
Interpreter:'reviewboard_reviewboard'

ServerName: 'cr.wsd.com'
DocumentRoot:   '/data/reviewboard/htdocs'

URI:'/'
Location:   '/'
Directory:  None
Filename:   '/data/reviewboard/htdocs/'
PathInfo:   ''

Phase:  'PythonHandler'
Handler:'django.core.handlers.modpython'

Traceback (most recent call last):

  File /usr/local/lib/python2.6/site-packages/mod_python/importer.py,
line 1537, in HandlerDispatch
default=default_handler, arg=req, silent=hlist.silent)

  File /usr/local/lib/python2.6/site-packages/mod_python/importer.py,
line 1229, in _process_target
result = _execute_target(config, req, object, arg)

  File /usr/local/lib/python2.6/site-packages/mod_python/importer.py,
line 1128, in _execute_target
result = object(arg)

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/core/handlers/modpython.py, line 228, in handler
return ModPythonHandler()(req)

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/core/handlers/modpython.py, line 191, in __call__
self.load_middleware()

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/core/handlers/base.py, line 40, in load_middleware
mod = import_module(mw_module)

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/utils/importlib.py, line 35, in import_module
__import__(name)

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/middleware/gzip.py, line 4, in module
from django.utils.cache import patch_vary_headers

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/utils/cache.py, line 28, in module
from django.core.cache import cache

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/core/cache/__init__.py, line 68, in module
cache = get_cache(settings.CACHE_BACKEND)

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/core/cache/__init__.py, line 66, in get_cache
return getattr(module, 'CacheClass')(host, params)

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/core/cache/backends/filebased.py, line 31, in __init__
self._createdir()

  File /usr/local/lib/python2.6/site-packages/Django-1.1.1-
py2.6.egg/django/core/cache/backends/filebased.py, line 132, in _createdir
raise EnvironmentError, Cache directory '%s' does not exist and could
not be created' % self._dir

EnvironmentError: Cache directory '/tmp/reviewboard_cache' does not exist
and could not be created'


What operating system are you using? What browser?
Linux,IE

Please provide any additional information below.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1567 in reviewboard: The ReviewBoard stoped to work suddenly.

2010-03-24 Thread reviewboard


Comment #1 on issue 1567 by yunshan.di: The ReviewBoard stoped to work  
suddenly.

http://code.google.com/p/reviewboard/issues/detail?id=1567

Please help!

Thanks!

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1567 in reviewboard: The ReviewBoard stoped to work suddenly.

2010-03-24 Thread reviewboard


Comment #4 on issue 1567 by yunshan.di: The ReviewBoard stoped to work  
suddenly.

http://code.google.com/p/reviewboard/issues/detail?id=1567

Thanks!

This problem was solved by grant the directory permission the apache user.

Another problem rised when view diffs:
The patch to 'xxx/IMEngine.h' didn't apply cleanly. The temporary files  
have been
left in '/var/tmp/reviewboard.u23uyk' for debugging purposes. `patch`  
returned:

patch:  mktemp : Permission denied

Traceback (most recent call last):
  File /usr/local/lib/python2.6/site-packages/ReviewBoard-1.5beta1-
py2.6.egg/reviewboard/diffviewer/views.py, line 153, in view_diff
interdiffset, highlighting, True)
  File /usr/local/lib/python2.6/site-packages/ReviewBoard-1.5beta1-
py2.6.egg/reviewboard/diffviewer/diffutils.py, line 887, in get_diff_files
large_data=True)
  File /usr/local/lib/python2.6/site-packages/Djblets-0.5.7-
py2.6.egg/djblets/util/misc.py, line 162, in cache_memoize
data = lookup_callable()
  File /usr/local/lib/python2.6/site-packages/ReviewBoard-1.5beta1-
py2.6.egg/reviewboard/diffviewer/diffutils.py, line 886, in lambda
enable_syntax_highlighting)),
  File /usr/local/lib/python2.6/site-packages/ReviewBoard-1.5beta1-
py2.6.egg/reviewboard/diffviewer/diffutils.py, line 537, in get_chunks
new = get_patched_file(old, filediff)
  File /usr/local/lib/python2.6/site-packages/ReviewBoard-1.5beta1-
py2.6.egg/reviewboard/diffviewer/diffutils.py, line 362, in  
get_patched_file

return patch(filediff.diff, buffer, filediff.dest_file)
  File /usr/local/lib/python2.6/site-packages/ReviewBoard-1.5beta1-
py2.6.egg/reviewboard/diffviewer/diffutils.py, line 224, in patch
(filename, tempdir, patch_output))
Exception: The patch
to 'xxx/IMEngine.h' didn't apply
cleanly. The temporary files have been left  
in '/var/tmp/reviewboard.u23uyk' for

debugging purposes.
`patch` returned: patch:  mktemp : Permission denied


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1567 in reviewboard: The ReviewBoard stoped to work suddenly.

2010-03-24 Thread reviewboard


Comment #5 on issue 1567 by chipx86: The ReviewBoard stoped to work  
suddenly.

http://code.google.com/p/reviewboard/issues/detail?id=1567

This is the same issue. It can't write to your /var/tmp.

This sounds like a very messed up configuration. All users should be able  
to write to
/tmp without problems, and many other applications can mess up if they  
can't. /tmp

really should be world-writable.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1567 in reviewboard: The ReviewBoard stoped to work suddenly.

2010-03-24 Thread reviewboard


Comment #6 on issue 1567 by yunshan.di: The ReviewBoard stoped to work  
suddenly.

http://code.google.com/p/reviewboard/issues/detail?id=1567

Thanks! ReviewBoard works now!

It was strange, the directory permission of apache user was been removed.
I was only installed another software package, maybe it caused the problem.

Thanks again!
yunshan

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1567 in reviewboard: The ReviewBoard stoped to work suddenly.

2010-03-24 Thread reviewboard


Comment #7 on issue 1567 by chipx86: The ReviewBoard stoped to work  
suddenly.

http://code.google.com/p/reviewboard/issues/detail?id=1567

Glad it's fixed!

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1568 in reviewboard: Customize when emails are sent

2010-03-24 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 1568 by stephen.alan.connolly: Customize when emails are sent
http://code.google.com/p/reviewboard/issues/detail?id=1568

What version are you running?
1.0.5.1

What's the URL of the page this enhancement relates to, if any?


Describe the enhancement and the motivation for it.
At the moment emails are sent for _every_ action that takes place.
It would be great if you could configure the operations which will trigger
emails

What operating system are you using? What browser?
N/A

Please provide any additional information below.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 477 in reviewboard: Per reviewer email control

2010-03-24 Thread reviewboard


Comment #10 on issue 477 by o3sisqa: Per reviewer email control
http://code.google.com/p/reviewboard/issues/detail?id=477

Reviewboard could become a little noisy depending on usage patterns. I  
think some

controlls would be usefull:
 * send notifications to groups / not (this would probably allow to use  
groups for

selecting / grouping bugs)
 * bcc me on my own Publish events / not
 * or something like just mail me if I'm assigned a review

If a team-manager is to track and distribute reviews, RB currently  
doesn't offer a

good way here;
Maybe the User ACL thing could be a good place to configure/store this?

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1477 in reviewboard: Something broke when publishing a review request

2010-03-24 Thread reviewboard


Comment #2 on issue 1477 by o3sisqa: Something broke when publishing a  
review request

http://code.google.com/p/reviewboard/issues/detail?id=1477

I had similar problems with two cases:

 * the 'Base Directory' being empty, though the diff references the full  
subversion

URL (without leading /)


Traceback (most recent call last):

File
/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py,
line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)

File 
/usr/lib/python2.5/site-packages/Djblets-0.5.7-py2.5.egg/djblets/auth/util.py,
line 46, in _checklogin
return view_func(request, *args, **kwargs)

File
/home/reviewboard/site_packages/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/reviews/views.py,
line 69, in new_review_request
parent_diff_file=request.FILES.get('parent_diff_path'))

File
/home/reviewboard/site_packages/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/reviews/forms.py,
line 183, in create
attach_to_history=True)

File
/home/reviewboard/site_packages/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/reviews/forms.py,
line 235, in create
history)

File
/home/reviewboard/site_packages/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/diffviewer/forms.py,
line 57, in create
raise NoBaseDirError(_('The Base Diff Path field is required'))

NoBaseDirError: The Base Diff Path field is required


  * the path not filling the gap between the patch and the repository URL:
there is /foo/bar/blub/bla.cpp
Base Diff Path: /foo
Path in Patch: blub/bla.cpp

File
/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py,
line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)

File 
/usr/lib/python2.5/site-packages/Djblets-0.5.7-py2.5.egg/djblets/auth/util.py,
line 46, in _checklogin
return view_func(request, *args, **kwargs)

File
/home/reviewboard/site_packages/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/reviews/views.py,
line 69, in new_review_request
parent_diff_file=request.FILES.get('parent_diff_path'))

File
/home/reviewboard/site_packages/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/reviews/forms.py,
line 183, in create
attach_to_history=True)

File
/home/reviewboard/site_packages/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/reviews/forms.py,
line 235, in create
history)

File
/home/reviewboard/site_packages/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/diffviewer/forms.py,
line 63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))

File
/home/reviewboard/site_packages/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/diffviewer/forms.py,
line 143, in _process_files
raise FileNotFoundError(filename, revision)

FileNotFoundError: The file 'blub/bla.cpp' (r2509) could not be found in  
the repository


The error shown to the user is similar to the first.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1509 in reviewboard: Throws an exception upon a click on review request

2010-03-24 Thread reviewboard


Comment #2 on issue 1509 by dchenbecker: Throws an exception upon a click  
on review request

http://code.google.com/p/reviewboard/issues/detail?id=1509

I have a traceback. We've been getting a lot of these on  
reviewboard.liftweb.net.

Whenever this happens people report that RB times out on them:

Traceback (most recent call last):

 File
/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py,
line 92, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File
/usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/accounts/decorators.py,
line 27, in _check
   return view_func(*args, **kwargs)

 File
/usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/reviews/views.py,
line 118, in review_detail
   visited.save()

 File
/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/models/base.py,
line 410, in save
   self.save_base(force_insert=force_insert, force_update=force_update)

 File
/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/models/base.py,
line 474, in save_base
   rows = manager.filter(pk=pk_val)._update(values)

 File
/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/models/query.py,
line 444, in _update
   return query.execute_sql(None)

 File
/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/models/sql/subqueries.py,
line 120, in execute_sql
   cursor = super(UpdateQuery, self).execute_sql(result_type)

 File
/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/models/sql/query.py,
line 2369, in execute_sql
   cursor.execute(sql, params)

 File
/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/backends/sqlite3/base.py,
line 193, in execute
   return Database.Cursor.execute(self, query, params)

OperationalError: database is locked


WSGIRequest
GET:QueryDict: {},
POST:QueryDict: {},
COOKIES:{'collapsediffs': 'True', 'rbsessionid': 
'a09c96867f083371a0185bd517611e64'},
META:{'DOCUMENT_ROOT': '/home/scalatools/reviewboard/htdocs',
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT':
'application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5',
 'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
 'HTTP_ACCEPT_ENCODING': 'gzip,deflate,sdch',
 'HTTP_ACCEPT_LANGUAGE': 'ro-RO,ro;q=0.8,en-US;q=0.6,en;q=0.4',
 'HTTP_CONNECTION': 'close',
 'HTTP_COOKIE': 'rbsessionid=a09c96867f083371a0185bd517611e64;  
collapsediffs=True',

 'HTTP_HOST': 'reviewboard.liftweb.net',
 'HTTP_IF_NONE_MATCH': 'marius:2010-03-23 16:33:20.089036:0:1258039150',
 'HTTP_REFERER': 'http://reviewboard.liftweb.net/dashboard/',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US)
AppleWebKit/532.5 (KHTML, like Gecko) Chrome/4.1.249.1036 Safari/532.5',
 'HTTP_X_FORWARDED_FOR': '188.24.32.7',
 'HTTP_X_REAL_IP': '188.24.32.7',
 'PATH_INFO': u'/r/300/',
 'PATH_TRANSLATED': '/home/scalatools/reviewboard/htdocs/r/300/',
 'QUERY_STRING': '',
 'REDIRECT_STATUS': '200',
 'REDIRECT_URI': '/reviewboard.fcgi/r/300/',
 'REMOTE_ADDR': '127.0.0.1',
 'REMOTE_PORT': '32973',
 'REQUEST_METHOD': 'GET',
 'REQUEST_URI': '/r/300/',
 'SCRIPT_FILENAME': '/home/scalatools/reviewboard/htdocs/reviewboard.fcgi',
 'SCRIPT_NAME': u'',
 'SERVER_ADDR': '127.0.0.1',
 'SERVER_NAME': 'reviewboard.liftweb.net',
 'SERVER_PORT': '8085',
 'SERVER_PROTOCOL': 'HTTP/1.0',
 'SERVER_SOFTWARE': 'lighttpd/1.4.19',
 'wsgi.errors': flup.server.fcgi_base.OutputStream object at 0x19b7150,
 'wsgi.input': flup.server.fcgi_base.InputStream object at 0x1973a10,
 'wsgi.multiprocess': False,
 'wsgi.multithread': True,
 'wsgi.run_once': False,
 'wsgi.url_scheme': 'http',
 'wsgi.version': (1, 0)}

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1477 in reviewboard: Something broke when publishing a review request

2010-03-24 Thread reviewboard


Comment #3 on issue 1477 by chipx86: Something broke when publishing a  
review request

http://code.google.com/p/reviewboard/issues/detail?id=1477

Can you show an example of what the configured repository URL looks like,  
what the
filename in the diff looks like, and what the base path was? (And whether  
it worked

when using /?)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1570 in reviewboard: Diff-Upload UI: Usability Enhancement

2010-03-24 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 1570 by fbeachler: Diff-Upload UI:  Usability Enhancement
http://code.google.com/p/reviewboard/issues/detail?id=1570

*NOTE: If you have a patch, please submit it to http://reviews.review-
board.org/


What version are you running?
1.0.1rc3


What's the URL of the page this enhancement relates to, if any?
New Review Request (step 1)/Upload Diff UIs

Describe the enhancement and the motivation for it.
I'm not sure if this enhancement is already planned for 1.5. I apologize if
this is a duplicate.

Stories:
1. As a user I want the order of the fields arranged in the DIFF upload
interface so the priority is presented as A) upload file, B) choose repo,
C) enter base path; so the priority of the fields reflects the priority of
the majority of use-cases (see motivation).
2. As a user I want the DIFF upload interface to be show me a list
(summary) of the file-paths in the patch as soon as enter a file for upload
so I can see if I'm choosing the right patch file and help me to calculate
the base path.
3. As a user I want the summary list in #2 to update dynamically as I make
choices from the Repository dropdown and enter text into the base path
field so I can see what the final calculated base path will be.

Motivation:
For a ReviewBoard user (who creates a new review request, or modifies the
DIFF of an existing one) - my first concern is choosing the patch file I
just created manually (e.g. 'what did I name it', 'where did I save
it'...).  My next concern is choosing the repository from the dropdown, and
then entering the Base Path for my DIFF.


What operating system are you using? What browser?
Mac/Windows, Firefox 3.5+/Safari 3+

Please provide any additional information below.

I'm not sure how to do provide the file summary feature with AJAX (I'm not
considering Flash/Silverlight here).  I think the file could be posted to
the server and expect a response that supports the functionality stated
above (i.e. a summary of the files in the patch).

This would have a positive impact on user experience regardless of what
technologies were used to build the UI.  For example, the user will wait
for the upload/summary process to complete, see if the file-path list looks
correct, choose the repo  enter the base path, and submit the form.  If
the base path is incorrect or files are not present in the repo (or another
error occurs trying to validate/generate the side-by-side) - the server
response can be much quicker and the summary of what may have caused the
error is in front of them.  As another example of improvement - if the
server dies before the user can submit their DIFF they'll know before even
trying to calculate or enter any other fields.  I believe more error
handling improvements could be realized but perhaps the repository value
must be known first...

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1570 in reviewboard: Diff-Upload UI: Usability Enhancement

2010-03-24 Thread reviewboard

Updates:
Status: Confirmed
Labels: Component-Reviews Usability

Comment #1 on issue 1570 by chipx86: Diff-Upload UI:  Usability Enhancement
http://code.google.com/p/reviewboard/issues/detail?id=1570

These are very good ideas. I think we should certainly provide this  
feedback.


It's unlikely that it can happen for 1.5. Probably not for 1.6 either, but  
if we do a

1.7 then maybe.

You may want to use post-review, which will help avoid the whole issue.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1570 in reviewboard: Diff-Upload UI: Usability Enhancement

2010-03-24 Thread reviewboard


Comment #2 on issue 1570 by fbeachler: Diff-Upload UI:  Usability  
Enhancement

http://code.google.com/p/reviewboard/issues/detail?id=1570

When we started using RB that script worked for us.  For some reason when  
we started
using ssh+kerberos the script stopped working.  I'll check it again and  
either
refresh my team on the script or see if there's a reproducible and  
unreported issue.
 Anyway, now all users are very familiar with the manual process.  Finally,  
there's
the use-case of splitting a patch into multiple reviews.  Does post-review  
support that?


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.