Issue 1581 in reviewboard: Diff veivew error on RBTools 0.2rc1
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1581 by seagle0128: Diff veivew error on RBTools 0.2rc1 http://code.google.com/p/reviewboard/issues/detail?id=1581 What version are you running? Reviewboard 1.0.6 RBTools 0.2rc1 What's the URL of the page containing the problem? Internal URL What steps will reproduce the problem? 1.Create a pending chagnelist on Perforce 2.post review quest with the change number What is the expected output? What do you see instead? On the review page, I get these errors. Diff currently unavailable. Error: The patch to '//depot/xxx.cpp' didn't apply cleanly. The temporary files have been left in 'c:\windows\temp\reviewboard.n2gz7y' for debugging purposes. `patch` returned: patching file c:\windows\temp\reviewboard.n2gz7y\tmpgzs27h Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file c:\windows\temp\reviewboard.n2gz7y\tmpgzs27h-new.rej Details Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0.6-py2.5.egg\reviewboard\diffviewer\views.py, line 214, in view_diff_fragment file = get_requested_diff_file() File c:\python25\lib\site-packages\ReviewBoard-1.0.6-py2.5.egg\reviewboard\diffviewer\views.py, line 190, in get_requested_diff_file get_chunks) File c:\python25\lib\site-packages\ReviewBoard-1.0.6-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5.9-py2.5.egg\djblets\util\misc.py, line 166, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0.6-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0.6-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0.6-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0.6-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to '//depot/xxx.cpp' didn't apply cleanly. The temporary files have been left in 'c:\windows\temp\reviewboard.n2gz7y' for debugging purposes. `patch` returned: patching file c:\windows\temp\reviewboard.n2gz7y\tmpgzs27h Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file c:\windows\temp\reviewboard.n2gz7y\tmpgzs27h-new.rej What operating system are you using? What browser? Windows Vista/7, IE8/Firefox 3.6.2 Please provide any additional information below. Even I upgrade RBTools to the latest version on GitHub, it doesn't work. But RBTools 0.2beta2 works well. I believe the postreview.py cause the issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1348 in reviewboard: Expanding hidden lines broken by the 1.0.3 update
Comment #21 on issue 1348 by mate.szalay: Expanding hidden lines broken by the 1.0.3 update http://code.google.com/p/reviewboard/issues/detail?id=1348 Having the same problem. It was a clean install, rb-site upgrade does nothing (and odes not fix it). What version are you running? 1.5beta1 What steps will reproduce the problem? 1. open a review request with a diff (not covering all the lines of a file) 2. view the diff 3. click on the Expand link next to a Hidden lines bar inside the diff What is the expected output? What do you see instead? The hidden lines should show up. Instead, I have Loading... for a while, then nothing happens. What operating system are you using? What browser? Host: Debian Sarge, python 2.4 Client: Windows XP + Firefox 3.5, Windows 7 + Firefox 3.6, Windows 7 + Chrome, works in none of these. Please provide any additional information below. Debian Sarge, python 2.4, apache2, everything stock, clean install, 100% reproducible. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1581 in reviewboard: Diff veivew error on RBTools 0.2rc1
Updates: Status: NeedInfo Comment #1 on issue 1581 by chipx86: Diff veivew error on RBTools 0.2rc1 http://code.google.com/p/reviewboard/issues/detail?id=1581 Can you run with --output-diff and see if it looks as you'd expect? Also look in that temp directory on the server (if you have access) to see what the .rej file looks like. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1580 in reviewboard: mysqld hogging cpu on our reviewboard instance.
Comment #4 on issue 1580 by jtsharma: mysqld hogging cpu on our reviewboard instance. http://code.google.com/p/reviewboard/issues/detail?id=1580 Thanks for the quick response. Would upgrade to 1.0.6 version improve diffs display times, too? That's another major painpoint for developers here. It takes a while to load up the diffs and folks are not happy about it. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
