Issue 1896 in reviewboard: Omitting the git repo path throws 500 error
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1896 by Karrde712: Omitting the git repo path throws 500 error http://code.google.com/p/reviewboard/issues/detail?id=1896 *NOTE: Do not post confidential information in this bug report.* What version are you running? ReviewBoard 1.5.1 What's the URL of the page containing the problem? New repo creation What steps will reproduce the problem? 1. Create a custom git repo 2. Fill in the raw file URL and remote path 3. Click save What is the expected output? What do you see instead? I expect to see a warning that the repo path is mandatory, but not specified. Instead, I get a 500 error, and this appears in the Apache error_log: [Tue Nov 23 11:46:28 2010] [error] ERROR:root:Exception thrown for user admin at http://publictest4.fedoraproject.org/reviewboard/admin/db/scmtools/repository/1/ [Tue Nov 23 11:46:28 2010] [error] [Tue Nov 23 11:46:28 2010] [error] 'path' [Tue Nov 23 11:46:28 2010] [error] Traceback (most recent call last): [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/django/core/handlers/base.py, line 99, in get_response [Tue Nov 23 11:46:28 2010] [error] response = callback(request, *callback_args, **callback_kwargs) [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/django/contrib/admin/options.py, line 225, in wrapper [Tue Nov 23 11:46:28 2010] [error] return self.admin_site.admin_view(view)(*args, **kwargs) [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/django/views/decorators/cache.py, line 44, in _wrapped_view_func [Tue Nov 23 11:46:28 2010] [error] response = view_func(request, *args, **kwargs) [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/django/contrib/admin/sites.py, line 186, in inner [Tue Nov 23 11:46:28 2010] [error] return view(request, *args, **kwargs) [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/django/db/transaction.py, line 240, in _commit_on_success [Tue Nov 23 11:46:28 2010] [error] res = func(*args, **kw) [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/django/contrib/admin/options.py, line 827, in change_view [Tue Nov 23 11:46:28 2010] [error] if form.is_valid(): [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/reviewboard/scmtools/forms.py, line 578, in is_valid [Tue Nov 23 11:46:28 2010] [error] return (super(RepositoryForm, self).is_valid() and [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/django/forms/forms.py, line 119, in is_valid [Tue Nov 23 11:46:28 2010] [error] return self.is_bound and not bool(self.errors) [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/django/forms/forms.py, line 110, in _get_errors [Tue Nov 23 11:46:28 2010] [error] self.full_clean() [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/reviewboard/scmtools/forms.py, line 500, in full_clean [Tue Nov 23 11:46:28 2010] [error] return super(RepositoryForm, self).full_clean() [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/django/forms/forms.py, line 249, in full_clean [Tue Nov 23 11:46:28 2010] [error] self.cleaned_data = self.clean() [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/reviewboard/scmtools/forms.py, line 520, in clean [Tue Nov 23 11:46:28 2010] [error] self._verify_repository_path() [Tue Nov 23 11:46:28 2010] [error] File /usr/lib/python2.4/site-packages/reviewboard/scmtools/forms.py, line 643, in _verify_repository_path [Tue Nov 23 11:46:28 2010] [error] path = self.cleaned_data['path'] [Tue Nov 23 11:46:28 2010] [error] KeyError: 'path' What operating system are you using? What browser? Red Hat Enterprise Linux 5.5 Firefox 3.6.12 and Chromium 8.0.560.0 both experience this. Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1897 in reviewboard: The Posted Time should be the time of publish
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1897 by jamesdlin: The Posted Time should be the time of publish http://code.google.com/p/reviewboard/issues/detail?id=1897 What version are you running? 1.0.9 What's the URL of the page containing the problem? https://reviewboard/dashboard/?view=incoming What steps will reproduce the problem? 1. Add a review request. 2. Wait for a while before publishing it. 3. Publish it. 4. Look at the Posted Time in the dashboard. What is the expected output? What do you see instead? The Posted Time currently shows the time when the review request was created, not the time when it was published. The latter is a more useful metric for determining which review requests have fallen through the cracks and haven't been getting their fair share of attention. (This admittedly is a pretty minor distinction since the two events usually would happen around the same time.) What operating system are you using? What browser? Windows XP x64 SP3, Firefox 3.6.12 Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1898 in reviewboard: Bugs in release spreadsheet marks
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1898 by byronweberbecker: Bugs in release spreadsheet marks http://code.google.com/p/reviewboard/issues/detail?id=1898 *NOTE: Do not post confidential information in this bug report.* What version are you running? v0.9.2 What's the URL of the page containing the problem? https://markus002.student.cs.uwaterloo.ca/cs135/main/grade_entry_forms/grades/1 What steps will reproduce the problem? 1. Manage marks for a spreadsheet page starts by displaying 15 students. Click Select: All. 2. Display area pops up asking if you would like to select all 560 students, with a link. Click the link. 3. Release marks What is the expected output? What do you see instead? I expect all 560 students with marks in the spreadsheet to have their marks released. Instead, only the 15 shown on the original page have their marks released. The same bug exists in releasing marks for an assignment. I think it would be much cleaner to just have Select: All Students, All on this page, None What operating system are you using? What browser? OS X Safari 4.x Please provide any additional information below. I like the Jump To drop-down on this page! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1899 in reviewboard: Display update after releasing marks in a spreadsheet
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1899 by byronweberbecker: Display update after releasing marks in a spreadsheet http://code.google.com/p/reviewboard/issues/detail?id=1899 *NOTE: Do not post confidential information in this bug report.* What version are you running? v0.9.2 What's the URL of the page containing the problem? https://markus002.student.cs.uwaterloo.ca/cs135/main/grade_entry_forms/grades/1 What steps will reproduce the problem? 1. Release some marks for the spreadsheet. 2. 3. What is the expected output? What do you see instead? The page displays the first 15 students. It would be really nice if it: -- kept all the same settings (filters, page size, etc) -- went to the same page as you were viewing (ie: if you were displaying 100 students at a time and looking at students 201-300, it should display students 201-300 after you click Release Marks. What operating system are you using? What browser? Max OS X, Safari Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1900 in reviewboard: Add filters to Manage Marks Spreadsheet
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1900 by byronweberbecker: Add filters to Manage Marks Spreadsheet http://code.google.com/p/reviewboard/issues/detail?id=1900 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? v0.9.2 What's the URL of the page this enhancement relates to, if any? https://markus002.student.cs.uwaterloo.ca/cs135/main/grade_entry_forms/grades/1 Describe the enhancement and the motivation for it. Some filters on the rows displayed would be nice: -- All students -- Released Marks -- Unreleased Marks What operating system are you using? What browser? OS X Safari Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1898 in reviewboard: Bugs in release spreadsheet marks
Updates: Status: Invalid Comment #1 on issue 1898 by trowbrds: Bugs in release spreadsheet marks http://code.google.com/p/reviewboard/issues/detail?id=1898 You have the wrong bug tracker. This is for Review Board, not MarkUs. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1899 in reviewboard: Display update after releasing marks in a spreadsheet
Updates: Status: Invalid Comment #1 on issue 1899 by trowbrds: Display update after releasing marks in a spreadsheet http://code.google.com/p/reviewboard/issues/detail?id=1899 You have the wrong bug tracker. This is for Review Board, not MarkUs. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1900 in reviewboard: Add filters to Manage Marks Spreadsheet
Updates: Status: Invalid Comment #1 on issue 1900 by trowbrds: Add filters to Manage Marks Spreadsheet http://code.google.com/p/reviewboard/issues/detail?id=1900 You have the wrong bug tracker. This is for Review Board, not MarkUs. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1901 in reviewboard: Spreadsheet messages do not display to students.
Updates: Status: Invalid Comment #1 on issue 1901 by trowbrds: Spreadsheet messages do not display to students. http://code.google.com/p/reviewboard/issues/detail?id=1901 You have the wrong bug tracker. This is for Review Board, not MarkUs. Please stop filing these bugs here! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1902 in reviewboard: User preference to expand changes by default
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1902 by email.app: User preference to expand changes by default http://code.google.com/p/reviewboard/issues/detail?id=1902 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.5 What's the URL of the page this enhancement relates to, if any? N/A Describe the enhancement and the motivation for it. Some of our users (including me!) like to always expand all changes. It's a hassle to always have to do it manually every time the web browser is quit and relaunched. There should be a user preference to expand changes by default. What operating system are you using? What browser? Mac OS X 10.6.5, Safari 5.0.3 Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1758 in reviewboard: The Linux installation instructions also apply to Mac OS X Server
Comment #1 on issue 1758 by email.app: The Linux installation instructions also apply to Mac OS X Server http://code.google.com/p/reviewboard/issues/detail?id=1758 Same thing for the 1.5 docs. One wrinkle on Mac OS X Server (at least 10.6.x), is that memcached has to be set up to start like this. sudo launchctl load -w /System/Library/LaunchDaemons/com.danga.memcached.plist -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.