Issue 1903 in reviewboard: [Discarded] label could be red to diferentiate from Submitted ones
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1903 by adrianboimvaser: [Discarded] label could be red to diferentiate from Submitted ones http://code.google.com/p/reviewboard/issues/detail?id=1903 What version are you running? 1.5.1 What's the URL of the page containing the problem? /dashboard/?view=mine What is the expected output? What do you see instead? A red [Discarded] label. A green [Discarded] label. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1904 in reviewboard: Adding Bonus/Deduction mark doesn't update total marks.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1904 by byronweberbecker: Adding Bonus/Deduction mark doesn't update total marks. http://code.google.com/p/reviewboard/issues/detail?id=1904 *NOTE: Do not post confidential information in this bug report.* What version are you running? v0.9.2 What's the URL of the page containing the problem? https://markus002.student.cs.uwaterloo.ca/cs135/main/results/edit/1566 What steps will reproduce the problem? 1. Go to the summary tab. Add a bonus/deduction. 2. 3. What is the expected output? What do you see instead? The final mark should be recalculated. It isn't. Refreshing the page doesn't seem to make a difference. Going back to the submissions list and clicking on this student's submission seems to do it. What operating system are you using? What browser? OS X I've observed this in both safari and firefox. Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1904 in reviewboard: Adding Bonus/Deduction mark doesn't update total marks.
Updates: Status: Invalid Comment #1 on issue 1904 by trowbrds: Adding Bonus/Deduction mark doesn't update total marks. http://code.google.com/p/reviewboard/issues/detail?id=1904 This bug tracker is about Review Board, not MarkUs. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1903 in reviewboard: [Discarded] label could be red to diferentiate from Submitted ones
Updates: Labels: -Type-Defect Type-Enhancement Component-Dashboard Comment #1 on issue 1903 by trowbrds: [Discarded] label could be red to diferentiate from Submitted ones http://code.google.com/p/reviewboard/issues/detail?id=1903 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1897 in reviewboard: The Posted Time should be the time of publish
Updates: Labels: Component-Reviews Comment #1 on issue 1897 by trowbrds: The Posted Time should be the time of publish http://code.google.com/p/reviewboard/issues/detail?id=1897 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1896 in reviewboard: Omitting the git repo path throws 500 error
Updates: Labels: Component-Admin Comment #1 on issue 1896 by trowbrds: Omitting the git repo path throws 500 error http://code.google.com/p/reviewboard/issues/detail?id=1896 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1905 in reviewboard: Extra whitespace is not highlighted
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1905 by mikhail@gmail.com: Extra whitespace is not highlighted
http://code.google.com/p/reviewboard/issues/detail?id=1905
What version are you running?
ReviewBoard-1.5-py2.6 and up
What's the URL of the page containing the problem?
e.g. http://reviews.reviewboard.org/r/1914/diff/3/#index_header
What steps will reproduce the problem?
1. create review request, upload patch contained some extra whitespace
2. click View diffs
What is the expected output? What do you see instead?
ACT: only some of extra whitespaces are highlighted
whitespace in RBBugTracker/setup.py:15 is highlighted
whitespace in
RBBugTracker/RBBugTracker/templates/googlecode/save_username.html:7 is not
highlighted
EXP: all whitespaces are highlighted
What operating system are you using? What browser?
Chromium 6.0, Firefox 3.6.12, IE 8
Please provide any additional information below.
The bug occurs because toggleExtraWhitespace called in $(document).ready
(diffviewer.js:1335)
toggleExtraWhitespace function toggles ewhl class on all whitespace
elements. Since diffs content is loaded asynchronously, most of the
whitespace elements are not loaded when document.ready occured.
In my install i fixed it following way:
diff --git a/reviewboard/htdocs/media/rb/js/diffviewer.js
b/reviewboard/htdocs/media/rb/js/diffviewer.js
index d283d89..116b016 100644
--- a/reviewboard/htdocs/media/rb/js/diffviewer.js
+++ b/reviewboard/htdocs/media/rb/js/diffviewer.js
@@ -1325,7 +1325,7 @@ function toggleExtraWhitespace(init)
}
/* Toggle highlighting */
-$(table.sidebyside .ew).toggleClass(ewhl);
+$(#diffs).toggleClass(ewhl);
/* Toggle the display of the button itself */
$(.review-request ul.controls li.ew).toggle();
diff --git a/reviewboard/templates/diffviewer/view_diff.html
b/reviewboard/templates/diffviewer/view_diff.html
index de1f8c2..62dafc8 100644
--- a/reviewboard/templates/diffviewer/view_diff.html
+++ b/reviewboard/templates/diffviewer/view_diff.html
@@ -23,7 +23,7 @@
link rel=stylesheet type=text/css
href={{MEDIA_URL}}rb/css/syntax.css?{{MEDIA_SERIAL}} /
{% if siteconfig.settings.diffviewer_show_trailing_whitespace|
default_if_none:1 %}
style type=text/css
- .ewhl { background: #ee3434; }
+ #diffs.ewhl table.sidebyside .ew { background: #ee3434; }
/style
{% endif %}
{% endblock %}
Toggle ewhl class only on parent element.
ew elements are highlighted depending on this not their own class.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
