Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2054 by fogyw...@gmail.com: RBTools-0.3.2 + Perforce - failed to
upload diff when source file is a new file
http://code.google.com/p/reviewboard/issues/detail?id=2054
Version: RevewBoard 1.5.2 + RBTools-0.3.2-py2.6
Client OS: Windows XP SP3
p4v-version: Perforce Visual Client/NTX86/2009.1/205670
Review-Type: Pre-submit review
Procedure:
1. add a new file to p4 workspace
2. create a new changelist
3. post-review change-num
4. error as below:
---
RBTools 0.3.2
Home = C:\Documents and Settings\fogy_wang\Application Data
svn info
git rev-parse --git-dir
p4 info
repository info: Path: perforce.my-rb-host.org:1666, Base path: None,
Supports changesets: True
HTTP GETting api/
HTTP GETting http://review.my-rb-host.org/api/info/
Using the new web API
Generating diff for changenum 748607
p4 describe -s 748607
Processing add of //Core/TRS/DEV/ID_Reputation/src/ARQ/common/test.cxx
diff -urNp c:\docume~1\fogy_w~1\locals~1\temp\tmp_l6zi6
C:\p4\default.fogy_wang.ID_Reputation-Lead\Core\TRS\DEV\ID_Reputation\src\ARQ\common\test.cxx
Using changenums on Review Board 1.5.2. Falling back to the deprecated
1.0 API
== Review Board Login Required
Enter username and password for Review Board at
http://review.my-rb-host.org/
Logging in with username fogy_wang
HTTP POSTing to http://review.my-rb-host.org/api/json/accounts/login/:
{'username': 'fogy_wang', 'password': '**'}
Logged in.
Attempting to create review request on perforce.my-rb-host.org:1666 for
748607
HTTP POSTing to
http://review.my-rb-host.org/api/json/reviewrequests/new/:
{'changenum': '748607', 'repository_path': 'perforce.my-rb-host.org:1666'}
Review request created
Uploading diff, size: 313
HTTP POSTing to
http://review.my-rb-host.org/api/json/reviewrequests/449/diff/new/: {}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'[P4#run] Warnings during command
execution( p4 files
//Core/TRS/DEV/ID_Reputation/src/ARQ/common/test.cxx#1
)\n\n\t[Warning]:
//Core/TRS/DEV/ID_Reputation/src/ARQ/common/test.cxx#1 - no such
file(s).\n\n']}, u'stat': u'fail', u'err': {u'msg': u'One or more
fields had errors', u'code': 105}, u'deprecated': {u'in_version':
u'1.5'}}
Your review request still exists, but the diff is not attached.
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
---
Additional Description:
This error ONLY appears when the uploaded file is a NEW file (i.e. p4
server has no previous revisions); if the uploaded file already exists on
perforce server (i.e. at least one previous revision exists), the review
could be successfully posted.
I can understand the warning by 'p4 file [file-repository-path]' because
there isn't a file on p4 server but shouldn't RB uses the uploaded diff
(i.e. size 313) instead when the file is 'new'?
I used to use 'RBTools-0.2rc2.dev_20100308-py2.6.bak' with 'Review Board
1.0.5.1' the issue didn't exist.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
