Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #4 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Mercurial can also provide rename information in the patch when doing hg diff -g to give git style diffs. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #5 on issue 1235 by trowb...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 We actually support showing renames with mercurial, now. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff
Comment #2 on issue 2155 by tim.na...@googlemail.com: post-review fails to upload diff if non-ascii characters are used in diff http://code.google.com/p/reviewboard/issues/detail?id=2155 This appears to be caused by a change to the http lib in Python 2.7. There is some discussion on it in this thread - http://groups.google.com/group/reviewboard/browse_thread/thread/a406e73e7c13996f/9e1d7f2c662db181?hl=enlnk=gstq=UnicodeDecodeError+with+Visual+Studio+files#9e1d7f2c662db181 I found downgrading to Python 2.6 resolved the issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2183 in reviewboard: Get internal server errors everyonce in a while
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2183 by bjvi...@gmail.com: Get internal server errors everyonce in a while http://code.google.com/p/reviewboard/issues/detail?id=2183 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6 RC1 What's the URL of the page containing the problem? ...mydomain../r/56/diff/#index_header What steps will reproduce the problem? 1. Trying to publish a review with comments on a few lines and I keep getting internal server errors at random times. Some lines allow saving the comments, others just keep cycling. then a refresh produces a server error every once in a while. 2. 3. What is the expected output? What do you see instead? Draft being saved is expected instead of a server error. What operating system are you using? What browser? Firefox on windows Please provide any additional information below. The server is configured correctly and no other problems have been found except this issue with getting an internal server error every once in a while. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2183 in reviewboard: Get internal server errors everyonce in a while
Updates: Status: NeedInfo Comment #1 on issue 2183 by chip...@gmail.com: Get internal server errors everyonce in a while http://code.google.com/p/reviewboard/issues/detail?id=2183 Can you enable logging and paste the errors found in the log file? We need more information to go on. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1526 in reviewboard: AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'
Updates: Status: Fixed Labels: Djblets Comment #14 on issue 1526 by chip...@gmail.com: AttributeError: 'DashboardDataGrid' object has no attribute 'id_list' http://code.google.com/p/reviewboard/issues/detail?id=1526 Should hopefully be fixed now on Djblets master (1129312) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2183 in reviewboard: Get internal server errors everyonce in a while
Comment #2 on issue 2183 by bjvi...@gmail.com: Get internal server errors everyonce in a while http://code.google.com/p/reviewboard/issues/detail?id=2183 [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] mod_wsgi (pid=..PID..): Target WSGI script '..appLocation../htdocs/reviewboard.wsgi' cannot be loaded as Python modu$ [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] mod_wsgi (pid=..PID..): Exception occurred processing WSGI script '..appLocation../htdocs/reviewboard.wsgi'., refere$ [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] Traceback (most recent call last):, referer: https://myDomain/dashboard/?view=mine [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] File ..appLocation../htdocs/reviewboard.wsgi, line 10, in module, referer: https://myDomain/dashboard/?vie$ [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] import django.core.handlers.wsgi, referer: https://myDomain/dashboard/?view=mine [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] ImportError: No module named django.core.handlers.wsgi, referer: https://myDomain/dashboard/?view=mine [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] mod_wsgi (pid=..PID..): Target WSGI script '..appLocation../htdocs/reviewboard.wsgi' cannot be loaded as Python modu$ [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] mod_wsgi (pid=..PID..): Exception occurred processing WSGI script '..appLocation../htdocs/reviewboard.wsgi'., refere$ [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] Traceback (most recent call last):, referer: https://myDomain/dashboard/?view=mine [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] File ..appLocation../htdocs/reviewboard.wsgi, line 10, in module, referer: https://myDomain/dashboard/?vie$ [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] import django.core.handlers.wsgi, referer: https://myDomain/dashboard/?view=mine [Thu Jul 21 13:39:57 2011] [error] [client ..myIPaddress..] ImportError: No module named django.core.handlers.wsgi, referer: https://myDomain/dashboard/?view=mine I got this after posting a post-review, I went in to publish it, and got this error. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2184 in reviewboard: Mercurial rename support: Pure file renames with *no actual changes* to the file fails with Diff did not apply cleanly
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2184 by yuzi...@gmail.com: Mercurial rename support: Pure file
renames with *no actual changes* to the file fails with Diff did not apply
cleanly
http://code.google.com/p/reviewboard/issues/detail?id=2184
* NOTE: Do not post confidential information in this bug report. *
* If you need immediate support, please contact*
* reviewbo...@googlegroups.com *
What version are you running?
Reviewboard 1.6 RC2 (also reproducible on RC1)
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. hg mv OLD_FILENAME NEW_FILENAME
2. hg commit -m Rename a file without changing it
3. hg export -g `hg parent --template '{node}'` my_patch.diff
4. Log in to reviewboard
5. Create a review and upload this patch to reviewboard
6. Open your newly created review
7. Click [View Diff]
What is the expected output? What do you see instead?
You should see the usual diff view, with:
Files changed:
1. NEW_FILENAME (was OLD_FILENAME) [no changes]
Instead, you see:
The patch to 'NEW_FILENAME' didn't apply cleanly. The temporary files have
been left in '/tmp/reviewboard.IzIH1V' for debugging purposes. `patch`
returned: patch: Only garbage was found in the patch input.
Traceback (most recent call last):
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/diffviewer/views.py,
line 151, in view_diff
interdiffset, highlighting, True)
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/diffviewer/diffutils.py,
line 1071, in get_diff_files
large_data=True)
File /usr/local/lib/python2.7/dist-packages/Djblets-0.6.9-py2.7.egg/djblets/util/misc.py,
line 166, in cache_memoize
data = lookup_callable()
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/diffviewer/diffutils.py,
line 1070, in lambda
enable_syntax_highlighting)),
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/diffviewer/diffutils.py,
line 552, in get_chunks
new = get_patched_file(old, filediff)
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/diffviewer/diffutils.py,
line 374, in get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/diffviewer/diffutils.py,
line 242, in patch
(filename, tempdir, patch_output))
Exception: The patch to 'LICENSE' didn't apply cleanly. The temporary files
have been left in '/tmp/reviewboard.IzIH1V' for debugging purposes.
`patch` returned: patch: Only garbage was found in the patch input.
Contents of /tmp/reviewboard.IzIH1V are attached to this bug report.
What operating system are you using? What browser?
Reviewboard is installed on Ubuntu (AWS/EC2)
% lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 11.04
Release:11.04
Codename: natty
% uname -a
Linux hostname 2.6.38-8-virtual #42-Ubuntu SMP Mon Apr 11 04:06:34 UTC 2011
x86_64 x86_64 x86_64 GNU/Linux
Please provide any additional information below.
Attachments:
NEW_FILENAME.diff 40 bytes
tmpBNKTGj 14 bytes
tmpBNKTGj-new 0 bytes
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2184 in reviewboard: Mercurial rename support: Pure file renames with *no actual changes* to the file fails with Diff did not apply cleanly
Comment #1 on issue 2184 by yuzi...@gmail.com: Mercurial rename support:
Pure file renames with *no actual changes* to the file fails with Diff did
not apply cleanly
http://code.google.com/p/reviewboard/issues/detail?id=2184
In comparison, the following WORKS PERFECTLY
1. hg mv OLD_FILENAME NEW_FILENAME
2. vim NEW_FILENAME
3. (make some changes to the file)
4. hg commit -m Rename a file without changing it
5. hg export -g `hg parent --template '{node}'` my_patch.diff
6. Log in to reviewboard
7. Create a review and upload this patch to reviewboard
8. Open your newly created review
9. Click [View Diff]
This works as expected. The only difference is whether you modify the file
after renaming it or not. It seems that patch just has trouble applying
empty patches.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Comment on Summer_of_Code_Ideas in reviewboard
Comment by dnl.gonz...@gmail.com: Has there been any word on trying to integrate or add JIRA support for ReviewBoard? For more information: http://code.google.com/p/reviewboard/wiki/Summer_of_Code_Ideas -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Comment on IdeasFor2_0 in reviewboard
Comment by dnl.gonz...@gmail.com: Has there been any word on trying to integrate or add JIRA support for ReviewBoard?? For more information: http://code.google.com/p/reviewboard/wiki/IdeasFor2_0 -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Comment on IdeasFor2_0 in reviewboard
Comment by dierk.se...@gmail.com: I'd also like to see integration with JIRA :) For more information: http://code.google.com/p/reviewboard/wiki/IdeasFor2_0 -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
