Re: Issue 1796 in reviewboard: Make recaptcha an optional dependency.
Updates: Labels: -Milestone-Release1.7 Comment #4 on issue 1796 by chip...@gmail.com: Make recaptcha an optional dependency. http://code.google.com/p/reviewboard/issues/detail?id=1796 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2747 in reviewboard: Dirty markup in /dashboard.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2747 by abrou...@yelp.com: Dirty markup in /dashboard. http://code.google.com/p/reviewboard/issues/detail?id=2747 Running 1.6.12, on OS X 10.7.4 and Chrome 22. --- Steps to repro: 1. Go to /dashboard/ 2. Edit your columns and check My comments if that's not active already. 3. Inspect the markup of on of the icon --- Expected: clean markup Actual: there are some nasty django.utils.functional.__proxy__ object at 0x1a31c50 in the title and alt attributes (see attached screenshot) --- Probable cause: string interpolation in django py 2.6.7 print u'%s' % _(foo) foo py 2.6.7 print '%s' % _(foo) django.utils.functional.__proxy__ object at 0x1a31c50 From the Django doc (https://docs.djangoproject.com/en/1.3/topics/i18n/internationalization/#lazy-translation): # This is fine: putting a unicode proxy into a unicode string. uHello %s % ugettext_lazy(people) # This will not work, since you cannot insert a unicode object # into a bytestring (nor can you insert our unicode proxy there) Hello %s % ugettext_lazy(people) Cheers, Arnaud. Attachments: bad-markup-in-RB.png 20.7 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2748 in reviewboard: How do I fix a invalid diff patch upload?????
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2748 by bwmayn...@gmail.com: How do I fix a invalid diff patch upload? http://code.google.com/p/reviewboard/issues/detail?id=2748 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2749 in reviewboard: How do I fix a invalid diff patch upload?????
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2749 by bwmayn...@gmail.com: How do I fix a invalid diff patch upload? http://code.google.com/p/reviewboard/issues/detail?id=2749 Please provide any additional information below. The patch to 'trunk/CommonAPI/CommonC/Include/C:/WORK/NEW_ARCH/eng-mfg-apps-repos/CommonAPI/CommonC/Include/controller.h' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.2w3jya' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.2w3jya/tmppG_cQF Hunk #1 FAILED at 30. Hunk #2 FAILED at 53. Hunk #3 FAILED at 67. Hunk #4 FAILED at 165. 4 out of 4 hunks FAILED -- saving rejects to file /tmp/reviewboard.2w3jya/tmppG_cQF-new.rej Traceback (most recent call last): File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.3-py2.4.egg/reviewboard/diffviewer/views.py, line 151, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.3-py2.4.egg/reviewboard/diffviewer/diffutils.py, line 1071, in get_diff_files large_data=True) File /usr/lib/python2.4/site-packages/Djblets-0.6.14-py2.4.egg/djblets/util/misc.py, line 156, in cache_memoize data = lookup_callable() File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.3-py2.4.egg/reviewboard/diffviewer/diffutils.py, line 1070, in lambda enable_syntax_highlighting)), File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.3-py2.4.egg/reviewboard/diffviewer/diffutils.py, line 552, in get_chunks new = get_patched_file(old, filediff) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.3-py2.4.egg/reviewboard/diffviewer/diffutils.py, line 374, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.3-py2.4.egg/reviewboard/diffviewer/diffutils.py, line 239, in patch raise Exception(_(The patch to '%s' didn't apply cleanly. The temporary + Exception: The patch to 'trunk/CommonAPI/CommonC/Include/C:/WORK/NEW_ARCH/eng-mfg-apps-repos/CommonAPI/CommonC/Include/controller.h' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.2w3jya' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.2w3jya/tmppG_cQF Hunk #1 FAILED at 30. Hunk #2 FAILED at 53. Hunk #3 FAILED at 67. Hunk #4 FAILED at 165. 4 out of 4 hunks FAILED -- saving rejects to file /tmp/reviewboard.2w3jya/tmppG_cQF-new.rej -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2749 in reviewboard: How do I fix a invalid diff patch upload?????
Updates: Status: Invalid Comment #1 on issue 2749 by chip...@gmail.com: How do I fix a invalid diff patch upload? http://code.google.com/p/reviewboard/issues/detail?id=2749 Sorry, going to close this and the other as invalid. Please file a new one with all the fields filled out exactly, or it makes it hard for us to deal with the support. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2748 in reviewboard: How do I fix a invalid diff patch upload?????
Updates: Status: Invalid Comment #1 on issue 2748 by chip...@gmail.com: How do I fix a invalid diff patch upload? http://code.google.com/p/reviewboard/issues/detail?id=2748 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
