Re: Issue 2752 in reviewboard: User is able to submit a review request without filling in required fields

2013-01-18 Thread reviewboard


Comment #3 on issue 2752 by rajas...@gmail.com: User is able to submit a  
review request without filling in required fields

http://code.google.com/p/reviewboard/issues/detail?id=2752

I dont see this happen. Im on 1.7.x and when  I try to publish in the UI  
without filling required fields, I get an alert indicating that field is  
required.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2869 in reviewboard: Missing error warning text when creating new review request with non-existent person

2013-01-18 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2869 by demel...@gmail.com: Missing error warning text when  
creating new review request with non-existent person

http://code.google.com/p/reviewboard/issues/detail?id=2869

* NOTE: For customer support, please post to *
*   reviewbo...@googlegroups.com *
**
*   Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?

1.7.2

What's the URL of the page containing the problem?

Upon creating a new review request

What steps will reproduce the problem?
1. Click New Review Request on top bar.
2. Attempt to add a non-existent (fake) name to the People heading.
3. See that there is no text within the red error bar near the top.

What is the expected output? What do you see instead?

Text within the red warning marker near the top.

What operating system are you using? What browser?

Mac OSX 10.8.2 Mountain Lion in Chrome


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2617 in reviewboard: Broken link to user page in review page auto update feature

2013-01-18 Thread reviewboard


Comment #3 on issue 2617 by kat.sch...@gmail.com: Broken link to user page  
in review page auto update feature

http://code.google.com/p/reviewboard/issues/detail?id=2617

I'm going to try this bug.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2073 in reviewboard: Allow testing email settings configuration bys ending test email

2013-01-18 Thread reviewboard


Comment #4 on issue 2073 by su...@hakc.net: Allow testing email settings  
configuration bys ending test email

http://code.google.com/p/reviewboard/issues/detail?id=2073

Trying to fix this.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2743 in reviewboard: Should allow users to remove ssh config manually

2013-01-18 Thread reviewboard


Comment #2 on issue 2743 by greg...@gmail.com: Should allow users to remove  
ssh config manually

http://code.google.com/p/reviewboard/issues/detail?id=2743

I'm taking it`

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2869 in reviewboard: Missing error warning text when creating new review request with non-existent person

2013-01-18 Thread reviewboard


Comment #1 on issue 2869 by demel...@gmail.com: Missing error warning text  
when creating new review request with non-existent person

http://code.google.com/p/reviewboard/issues/detail?id=2869

I'm working on this.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2869 in reviewboard: Missing error warning text when creating new review request with non-existent person

2013-01-18 Thread reviewboard


Comment #2 on issue 2869 by demel...@gmail.com: Missing error warning text  
when creating new review request with non-existent person

http://code.google.com/p/reviewboard/issues/detail?id=2869

This bug has been fixed.

http://reviews.reviewboard.org/r/3756/

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2073 in reviewboard: Allow testing email settings configuration bys ending test email

2013-01-18 Thread reviewboard


Comment #5 on issue 2073 by su...@hakc.net: Allow testing email settings  
configuration bys ending test email

http://code.google.com/p/reviewboard/issues/detail?id=2073

This doesn't seem like an easy fix; changes required to accommodate this  
functionality possibly include:


-Changing the actual view for site settings from djblets.

or

-Chris suggested adding a MultiWidget (A button right beside the password  
field; stuck beside each other). When clicked a a JQuery listener performs  
an AJAX call in the backend to sanitize. But this approach presents two  
problems:

--Django doesn't have a native button field/widget.
--If a custom widget is created to overcome the above issue, the JSON data  
returned from the callback cannot be presented on the view (success/error  
message) since the view (again) is on djblets.


The only way I see to fix this (keeping in mind the usability) is to make  
some changes on djblets eventually.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2483 in reviewboard: Minor tweak to review request email notification template to include repository name along with review group

2013-01-18 Thread reviewboard


Comment #3 on issue 2483 by kat.sch...@gmail.com: Minor tweak to review  
request email notification template to include repository name along with  
review group

http://code.google.com/p/reviewboard/issues/detail?id=2483

I call dibs!

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1897 in reviewboard: The Posted Time should be the time of publish

2013-01-18 Thread reviewboard


Comment #3 on issue 1897 by demel...@gmail.com: The Posted Time should be  
the time of publish

http://code.google.com/p/reviewboard/issues/detail?id=1897

I can't seem to reproduce this error.

Mac OSX 10.8.2 Chrome/FireFox

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2073 in reviewboard: Allow testing email settings configuration bys ending test email

2013-01-18 Thread reviewboard

Updates:
Labels: -EasyFix

Comment #6 on issue 2073 by mike.d.c...@gmail.com: Allow testing email  
settings configuration bys ending test email

http://code.google.com/p/reviewboard/issues/detail?id=2073

Agreed - this is more complicated than it originally sounded. Thanks for  
investigating.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2620 in reviewboard: Input text field for smtp server address is not stripped from white space

2013-01-18 Thread reviewboard

Updates:
Status: Fixed

Comment #4 on issue 2620 by trowb...@gmail.com: Input text field for smtp  
server address is not stripped from white space

http://code.google.com/p/reviewboard/issues/detail?id=2620

Pushed to release-1.7.x (e6e5d07). Thanks!

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2855 in reviewboard: Clicking into an issue on the summary doesn't focus on the issue

2013-01-18 Thread reviewboard


Comment #2 on issue 2855 by qi0...@gmail.com: Clicking into an issue on the  
summary doesn't focus on the issue

http://code.google.com/p/reviewboard/issues/detail?id=2855

I take this issue

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2073 in reviewboard: Allow testing email settings configuration bys ending test email

2013-01-18 Thread reviewboard


Comment #7 on issue 2073 by rajas...@gmail.com: Allow testing email  
settings configuration bys ending test email

http://code.google.com/p/reviewboard/issues/detail?id=2073

The Create repository page throws an Authentication Failed message when  
a repository that needs authentication but none is provided by the user  
(when the form is submitted). Can the Email settings page be done  
similarly.


This would avoid creating custom widget that does an AJAX call and would  
validate the email settings only on submitting the form.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.