Issue 3169 in reviewboard: (RBTools) Git-p4 repo throws 'UnboundLocalError' on post-review
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3169 by dpr...@gmail.com: (RBTools) Git-p4 repo throws 'UnboundLocalError' on post-review http://code.google.com/p/reviewboard/issues/detail?id=3169 What version are you running? 0.5.2 (also tested with git 74ebdf) What's the URL of the page containing the problem? N/A (RBTools issue) What steps will reproduce the problem? 1. Sync a perforce repository using git-p4 2. Configure reviewboard settings for Perforce depot 2. Create new branch off master and create a commit you want to post to reviewboard 3. Attempt to post with 'post-review' What is the expected output? What do you see instead? Unknown expected output, python throws a UnboundLocalError (log attached) What operating system are you using? What browser? Fedora 19 Please provide any additional information below. Attachments: git-p4-post-review-log.txt 3.1 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3169 in reviewboard: (RBTools) Git-p4 repo throws 'UnboundLocalError' on post-review
Comment #1 on issue 3169 by dpr...@gmail.com: (RBTools) Git-p4 repo throws 'UnboundLocalError' on post-review http://code.google.com/p/reviewboard/issues/detail?id=3169 It would appear 'base_path' is not getting assigned as the regular expression is incorrect. From git.py:445: m = re.search(r'repo-paths = (.+): change = (\d+)\]', log, re.M) repo-paths should be depot-paths git log attached -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3169 in reviewboard: (RBTools) Git-p4 repo throws 'UnboundLocalError' on post-review
Comment #3 on issue 3169 by dpr...@gmail.com: (RBTools) Git-p4 repo throws 'UnboundLocalError' on post-review http://code.google.com/p/reviewboard/issues/detail?id=3169 A fix for this issue was submitted to ReviewBoard. https://reviews.reviewboard.org/r/5120/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1986 in reviewboard: CVS repository(pserver) addition fails
Comment #9 on issue 1986 by jaap.keu...@xs4all.nl: CVS repository(pserver) addition fails http://code.google.com/p/reviewboard/issues/detail?id=1986 Tested with pserver path to remote CVS server and having filled in the Username and Password fields. Checking network traffic with the CVS server shows (obviously obfuscated): BEGIN AUTH REQUEST\x0a/cvsroot/repo\x0aUsername\x0aA\x0aEND AUTH REQUEST\x0a Even though the Username is correctly filled in, the Password is completely missing. The start of a scrambled password is recognizable (the A in between the \x0a characters), but for the rest the password is empty. I would assume the input id_password is detected as being filled (hence the attempt to start a scrambled password), but its actual contents is not used. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1719 in reviewboard: post-review should support subversion changelists.
Updates: Status: Fixed Comment #3 on issue 1719 by trowb...@gmail.com: post-review should support subversion changelists. http://code.google.com/p/reviewboard/issues/detail?id=1719 This has been fixed for a while. This is currently handled with the --svn-changelist option, though that will be changing: https://reviewboard.hackpad.com/RBTools-Diff-Behavior-gRwNAvl3SzJ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2292 in reviewboard: Allow specifying login information in .reviewboardrc
Updates: Summary: Allow specifying login information in .reviewboardrc Comment #3 on issue 2292 by trowb...@gmail.com: Allow specifying login information in .reviewboardrc http://code.google.com/p/reviewboard/issues/detail?id=2292 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
