Re: Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.

2014-01-23 Thread reviewboard


Comment #4 on issue 3204 by jmm.lind...@gmail.com: Viewing review groups  
that you are watching no longer works.

http://code.google.com/p/reviewboard/issues/detail?id=3204

I will take a look on this.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.

2014-01-23 Thread reviewboard

Updates:
Labels: EasyFix

Comment #3 on issue 3204 by chip...@gmail.com: Viewing review groups that  
you are watching no longer works.

http://code.google.com/p/reviewboard/issues/detail?id=3204

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.

2014-01-23 Thread reviewboard

Updates:
Status: Confirmed
Labels: Milestone-Release1.7.x

Comment #2 on issue 3204 by chip...@gmail.com: Viewing review groups that  
you are watching no longer works.

http://code.google.com/p/reviewboard/issues/detail?id=3204

Sort of by design, but it wasn't intended to impact watched groups. Those  
should be allowed as well, so long as the user has access. We'll want to  
fix this.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.

2014-01-23 Thread reviewboard


Comment #1 on issue 3204 by erik.l...@gmail.com: Viewing review groups that  
you are watching no longer works.

http://code.google.com/p/reviewboard/issues/detail?id=3204

Ah, it looks like this is somewhat by design:  
https://github.com/reviewboard/reviewboard/commit/d0611ab9b407814bfd5ce0cd0d4c8ebd5f40f1ba


However, I feel that this makes the watched groups feature pointless. I  
understand the need to honor private groups but couldn't couldn't we just  
check if Group.is_accessible_by() rather than checking if the user is a  
member of the group?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.

2014-01-23 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3204 by erik.l...@gmail.com: Viewing review groups that you are  
watching no longer works.

http://code.google.com/p/reviewboard/issues/detail?id=3204

What version are you running?
1.7.21

What's the URL of the page containing the problem?
http://reviewboard/reviews/dashboard/?view=to-group&group=AutomationCouncil

What steps will reproduce the problem?
1. Click on a review group that you are watching (but not subscribed to)
2. You'll get a 404 error


What is the expected output? What do you see instead?
I expect to see a list of reviews for that group; instead I get a "does not  
exist" page (404).


What operating system are you using? What browser?
OS X. Chrome.

Please provide any additional information below.
If I'm subscribed to the group, those views work but simply groups that I'm  
watching do not. It doesn't seem to matter if the group has 0 reviews or >  
0. The server is also raising the following exception:




2014-01-23 20:26:47,032 - ERROR -  - Exception thrown for user erik.latt at  
http://reviewboard/reviews/dashboard/?view=to-group&group=AutomationCouncil


Traceback (most recent call last):
   
File "/usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/core/handlers/base.py",  
line 111, in get_response

response = callback(request, *callback_args, **callback_kwargs)
   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/auth/util.py",  
line 47, in _checklogin

return view_func(request, *args, **kwargs)
   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/accounts/decorators.py",  
line 52, in _check_valid_prefs

return view_func(request, *args, **kwargs)
   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/reviews/views.py",  
line 840, in dashboard

return grid.render_to_response(template_name, extra_context=context)
   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/datagrid/grids.py",  
line 794, in render_to_response

self.load_state(render_context)
   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/datagrid/grids.py",  
line 579, in load_state

if self.load_extra_state(profile):
   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/reviews/datagrids.py",  
line 684, in load_extra_state

raise Http404
Http404

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Issue 3203 in reviewboard: rbt doesn't authenticate some requests

2014-01-23 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3203 by mra...@rapitasystems.com: rbt doesn't authenticate some  
requests

http://code.google.com/p/reviewboard/issues/detail?id=3203

What version are you running?
1.7.20

What steps will reproduce the problem?
1. Set up a web server configured for basic authentication over HTTPS
2. Set up a ReviewBoard install configured for authentication over LDAP
3. Ensure no .reviewboardrc is set for a user
3. Attempt to query ReviewBoard using manually-specified username and  
password:
rbt status --server https:///reviewboard --user  --password  



What is the expected output? What do you see instead?
rbt outputs:
CRITICAL:root:HTTP 401
Attached is rpt --debug output.

Please provide any additional information below.

Apache access log shows two requests, with the second lacking any  
authorization:


127.0.0.1 - user [23/Jan/2014:14:35:19 +] "GET /reviewboard/api/  
HTTP/1.1" 200 15665 "-" "RBTools/0.5.5"
127.0.0.1 - - [23/Jan/2014:14:35:20 +] "GET /reviewboard/api/info/  
HTTP/1.1" 401 8817 "-" "RBTools/0.5.5"


This seems to be something to do with PresetHTTPAuthHandler in request.py  
being used again before reset and so not adding auth headers.


Attachments:
rbt debug.txt  2.9 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Issue 3202 in reviewboard: 'Last updated' column for review request in 'My Dashboard' page, displays incorrect time, if the server's and the client's time zones are different

2014-01-23 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3202 by rajengin...@gmail.com: 'Last updated' column for review  
request in 'My Dashboard' page, displays incorrect time, if the server's  
and the client's time zones are different

http://code.google.com/p/reviewboard/issues/detail?id=3202

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?
Reviewboard 1.7.17

What's the URL of the page containing the problem?
/rb/s/../dashboard

What steps will reproduce the problem?
1.set the local system time zone as IST
2.set the server(review board installed box) time zone as PST
3.create a review request from local system
4.goto 'My dashboard' and see the 'All Incoming Review Requests'
5.see the 'Last updated' column of the newly created review request.
6.It may show the difference of 13 hours approximately,which seems to be  
wrong.


What is the expected output? What do you see instead?
It should show the actual time difference based on the server's time  
zone.And,it should mention the server's time zone.


What operating system are you using? What browser?
Linux , firefox 26.0

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.