Re: Issue 3045 in reviewboard: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST
Comment #12 on issue 3045 by saar.net...@gmail.com: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST http://code.google.com/p/reviewboard/issues/detail?id=3045 This is what I have found: The new diff is on the server, however, it doesn't have the Diff Set History number and also missing the Commit ID. Once I have manually added them both it appearing in the review. Any pointers why it is not being set during the diff update? Could this be a matter of Configuration or Permissions? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3253 in reviewboard: post-review without US locale fails
Comment #6 on issue 3253 by kenny.ma...@gmail.com: post-review without US locale fails http://code.google.com/p/reviewboard/issues/detail?id=3253 Awesome. Thank you! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3254 in reviewboard: reviewboard.accounts.backends.AuthBackend.login_instructions not documented
Updates: Status: Fixed Comment #1 on issue 3254 by trowb...@gmail.com: reviewboard.accounts.backends.AuthBackend.login_instructions not documented http://code.google.com/p/reviewboard/issues/detail?id=3254 Fixed in master (d2364ff). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3256 in reviewboard: unable to log in (http 500) when using ldap auth backend + unicode password
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3256 by walt.jav...@gmail.com: unable to log in (http 500) when using ldap auth backend + unicode password http://code.google.com/p/reviewboard/issues/detail?id=3256 What version are you running? RB 1.7.21 What's the URL of the page containing the problem? https://reviewboard/account/login What steps will reproduce the problem? 1. Configure Review Board with an Active Directory authentication backend (https://reviewboard/admin/settings/authentication/) 2. In Active Directory (not the RB Active Directory settings, but in the actual AD info), set up an account with a password that contains a non-ascii unicode character. 3. Attempt to login to Review Board with the AD account that has a unicode password. I will work to see if I can find a more precise and concise repo. What is the expected output? I would expect to log in to Review Board successfully. What do you see instead? The client sees 500 Server Error. When I check in the server-side Review Board logs I see the following traceback: 2014-01-30 15:02:12,208 - DEBUG - - User usern...@ad.mycorp.com is trying to log in via AD 2014-01-30 15:02:12,209 - ERROR - - Exception thrown for user AnonymousUser at https://reviewboard.mycorp.com/account/login/ UnicodeEncodeError: 'ascii' codec can't encode character u'\xa3' in position 8: ordinal not in range(128) Traceback (most recent call last): File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/views/decorators/debug.py, line 75, in sensitive_post_parameters_wrapper return view(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/utils/decorators.py, line 91, in _wrapped_view response = view_func(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/views/decorators/cache.py, line 89, in _wrapped_view_func response = view_func(request, *args, **kwargs) File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/contrib/auth/views.py, line 36, in login if form.is_valid(): File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/forms/forms.py, line 124, in is_valid return self.is_bound and not bool(self.errors) File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/forms/forms.py, line 115, in _get_errors self.full_clean() File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/forms/forms.py, line 271, in full_clean self._clean_form() File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/forms/forms.py, line 299, in _clean_form self.cleaned_data = self.clean() File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/contrib/auth/forms.py, line 167, in clean password=password) File /usr/lib/python2.6/site-packages/Django-1.4.10-py2.6.egg/django/contrib/auth/__init__.py, line 45, in authenticate user = backend.authenticate(**credentials) File /usr/lib/python2.6/site-packages/ReviewBoard-1.7.21-py2.6.egg/reviewboard/accounts/backends.py, line 539, in authenticate con.simple_bind_s(bind_username, password) File /usr/lib64/python2.6/site-packages/ldap/ldapobject.py, line 206, in simple_bind_s msgid = self.simple_bind(who,cred,serverctrls,clientctrls) File /usr/lib64/python2.6/site-packages/ldap/ldapobject.py, line 200, in simple_bind return self._ldap_call(self._l.simple_bind,who,cred,EncodeControlTuples(serverctrls),EncodeControlTuples(clientctrls)) File /usr/lib64/python2.6/site-packages/ldap/ldapobject.py, line 96, in _ldap_call result = func(*args,**kwargs) UnicodeEncodeError: 'ascii' codec can't encode character u'\xa3' in position 8: ordinal not in range(128) What operating system are you using? What browser? The RB server is running on CentOS 6.2 behind apache with mod wsgi. The client is: Chromium 30.0.1599.114 Ubuntu 12.04 (30.0.1599.114-0ubuntu0.12.04.3) I've been able to repro this issue with other browsers as well though, and believe this isn't related to the client. Please provide any additional information below. I have not yet tried having a unicode character in the AD username. Only the password. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this
Re: Issue 2045 in reviewboard: Show changes to description or testing done fields as a real diff
Updates: Status: Fixed Comment #3 on issue 2045 by trowb...@gmail.com: Show changes to description or testing done fields as a real diff http://code.google.com/p/reviewboard/issues/detail?id=2045 Fixed in master (a2f9c31). This will ship in 2.0 beta 3. Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3223 in reviewboard: Adding or replacing screenshots isn't represented in change descriptions.
Updates: Status: Fixed Comment #2 on issue 3223 by trowb...@gmail.com: Adding or replacing screenshots isn't represented in change descriptions. http://code.google.com/p/reviewboard/issues/detail?id=3223 Fixed in master (634e674). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3045 in reviewboard: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST
Comment #14 on issue 3045 by saar.net...@gmail.com: when updating new diff
on existing reviews on reviewboard server in clearcase source file revision
is not LATEST
http://code.google.com/p/reviewboard/issues/detail?id=3045
I have tried what you have suggested.
I have created a new review and published it.
The I have deleted the files ~/.post-review-cookies.txt and
~/.rbtools-cookies
When ran the update it is loading the diff but not showing it in the review
request.
This is the command output:
===
post-review -r 140
--revision-range /view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4;/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5
--debug
RBTools 0.5.2
Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23)
[GCC 4.4.6 20120305 (Red Hat 4.4.6-4)]
Running on Linux-2.6.32-220.el6.x86_64-x86_64-with-centos-6.2-Final
Home = /users/saarn
Current Directory = /vobs/build
Checking the repository type. Errors shown below are mostly harmless.
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info build --non-interactive
DEBUG:root:Command exited with rc 1:
['svn', 'info', 'build', '--non-interactive']
svn: '.' is not a working copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Checking for a Plastic repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Running: cleartool pwv -short
DEBUG:root:Running: diff --version
DEBUG:root:Running: cleartool lsview -full -properties -cview
DEBUG:root:Running: cleartool describe -short vob:.
DEBUG:root:Running: cleartool pwv -root
DEBUG:root:repository info: Path: /vobs/build, Base path: /vobs/build,
Supports changesets: False
Finished checking the repository type.
HTTP GETting api/info/
== HTTP Authentication Required
Enter authorization information for Web API at review-board
Username: builder
Password:
DEBUG:root:Running: diff -uN
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5
DEBUG:root:Command exited with rc 1:
['diff', '-uN', '/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4', '/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5']
---
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4
2014-02-20 08:39:28.0 +0200
+++
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5
2014-02-20 08:42:33.0 +0200
@@ -47,3 +47,5 @@
added by saar to test updating existing review
another diff first post
+
+This is the new line to be updated
---
DEBUG:root:Running: cleartool describe -fmt %On
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4
DEBUG:root:Running: cleartool describe -fmt %On
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5
HTTP GETting api/
HTTP GETting http://review-board/api/info/
Using the new web API
HTTP GETting http://review-board/api/review-requests/140/
DEBUG:root:Running: cleartool lsvob -long /vobs/build
DEBUG:root:Repository's /vobs/build uuid
is '87701b00.c21e11d5.b323.00:e0:18:1c:4c:3b'
HTTP GETting http://review-board/api/repositories/
HTTP GETting http://review-board/api/repositories/4/
HTTP GETting http://review-board/api/repositories/4/info/
DEBUG:root:Matching repository
uuid:87701b00.c21e11d5.b323.00:e0:18:1c:4c:3b with
path:/view/izabo-ReviewBoard/vobs/build
DEBUG:root:repository info: Path: /view/izabo-ReviewBoard/vobs/build, Base
path: /view/izabo-ReviewBoard/vobs/build, Supports changesets: False
Uploading diff, size: 499
HTTP POSTing to http://review-board/api/review-requests/140/diffs/:
{'basedir': u'/view/izabo-ReviewBoard/vobs/build'}
Review request #140 posted.
http://review-board/r/140/
Screenshot 1: The status of the review request AFTER the update
Screenshot 2+3+4: The file diff in the Admin screen
Screenshot 5: The review request after I have added the Diff Set History
and Commit ID manually to the diff set. Also, the Parent Diff HASH was
also empty and I had to set it as well
Attachments:
AfterUpdateNoChangeInReviewRequest.JPG 133 KB
NoCommitIDandDiffSetHistory.JPG 165 KB
Re: Issue 3045 in reviewboard: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST
Comment #15 on issue 3045 by trowb...@gmail.com: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST http://code.google.com/p/reviewboard/issues/detail?id=3045 Are you logged in to the Review Board UI as builder ? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1986 in reviewboard: CVS repository(pserver) addition fails
Comment #14 on issue 1986 by trowb...@gmail.com: CVS repository(pserver) addition fails http://code.google.com/p/reviewboard/issues/detail?id=1986 The change for this fix is not in the 1.7.21 release. It will ship in 2.0 beta 3, which is shipping soon (but that's definitely beta-quality). I'll cherry-pick it over to the 1.7.x branch to ship in the next point release. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
