Issue 3442 in reviewboard: Cycle in Depends On causes Review Request Drafts to lock out of publishing
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3442 by thom.ger...@gmail.com: Cycle in Depends On causes Review Request Drafts to lock out of publishing http://code.google.com/p/reviewboard/issues/detail?id=3442 What version are you running? 2.0.1 What's the URL of the page containing the problem? /api/review-requests/#/draft/ [accessed through /r/#/ ] What steps will reproduce the problem? 1. Create a review (#1). Publish it. 2. Create a review (#2). Publish it. 3. Update Review #2 to Depend On #1. Publish. 4. Update Review #1 to Depend On #2. What is the expected output? Expected is a few possible situations: The reviews are publishable; or you get a validation error when you attempt to introduce a cycle in the Depends On Graph. I imagine users would prefer the first: There are situations where code changes in multiple repositories must be committed at the same time thus they're interdependant. What do you see instead? The Review Request Draft gives a 500 error after some time due to a Runtime error: maximum recursion depth. Work around is to create new review requests but if either of the reviews has history, they're both totally locked up. The user can't even discard their draft either after adding the depends on cycle. What operating system are you using? What browser? Server is Debian; triggered exception from modern Firefox and Chrome. Please provide any additional information below. RuntimeError: maximum recursion depth exceeded Partial Traceback: (Sentry removes some of the frames) File django/core/handlers/base.py, line 199, in get_response response = middleware_method(request, response) File django/middleware/http.py, line 14, in process_response response['Content-Length'] = str(len(response.content)) File djblets/webapi/core.py, line 291, in _get_content **self.encoder_kwargs) File djblets/webapi/core.py, line 92, in encode return super(JSONEncoderAdapter, self).encode(o) File json/encoder.py, line 367, in encode chunks = list(self.iterencode(o)) File json/encoder.py, line 309, in _iterencode for chunk in self._iterencode_dict(o, markers): File json/encoder.py, line 275, in _iterencode_dict for chunk in self._iterencode(value, markers): File json/encoder.py, line 309, in _iterencode for chunk in self._iterencode_dict(o, markers): File json/encoder.py, line 275, in _iterencode_dict for chunk in self._iterencode(value, markers): File json/encoder.py, line 306, in _iterencode for chunk in self._iterencode_list(o, markers): File json/encoder.py, line 204, in _iterencode_list for chunk in self._iterencode(value, markers): File json/encoder.py, line 317, in _iterencode for chunk in self._iterencode_default(o, markers): File django/db/models/query.py, line 304, in get num = len(clone) File django/db/models/query.py, line 77, in __len__ self._fetch_all() File django/db/models/query.py, line 857, in _fetch_all self._result_cache = list(self.iterator()) File django/db/models/query.py, line 230, in iterator obj = model(*row_data) File django/db/models/base.py, line 419, in __init__ signals.post_init.send(sender=self.__class__, instance=self) File django/dispatch/dispatcher.py, line 185, in send response = receiver(signal=self, sender=sender, **named) File djblets/db/fields.py, line 206, in post_init value = self.loads(value) File djblets/db/fields.py, line 229, in loads val = json.loads(val, encoding=settings.DEFAULT_CHARSET) File json/__init__.py, line 318, in loads return cls(encoding=encoding, **kw).decode(s) File json/decoder.py, line 319, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File json/decoder.py, line 336, in raw_decode obj, end = self._scanner.iterscan(s, **kw).next() File json/scanner.py, line 55, in iterscan rval, next_pos = action(m, context) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3441 in reviewboard: New request cannot be created in RB 2.0.2 opened with IE 10/11
Comment #1 on issue 3441 by alex...@gmail.com: New request cannot be created in RB 2.0.2 opened with IE 10/11 http://code.google.com/p/reviewboard/issues/detail?id=3441 Additional info: The page containing the problem against root is /r/new/ RB hangs after selecting a valid diff. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3443 in reviewboard: Can't review long lines that does not contain whitespaces
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3443 by gol...@gmail.com: Can't review long lines that does not contain whitespaces http://code.google.com/p/reviewboard/issues/detail?id=3443 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? 2.0.1 What's the URL of the page containing the problem? https://server/r/number/diff/# What steps will reproduce the problem? 1. Go into Review Board 2. Select Review 3. Click on View Diff 4. Review change on line that contain 100 (depends on size of your screen, font, ...) or more characters and no white spaces What is the expected output? What do you see instead? Able to scroll left and right to see both sides of the change like you were available in older versions. Instead right side of the diff is truncated to fit the screen. What operating system are you using? What browser? Mac with Chrome Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3309 in reviewboard: Really long comment causes unreadable review
Comment #4 on issue 3309 by chip...@gmail.com: Really long comment causes unreadable review http://code.google.com/p/reviewboard/issues/detail?id=3309 Issue 3443 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3443 in reviewboard: Can't review long lines that does not contain whitespaces
Updates: Status: Duplicate Mergedinto: 3309 Comment #1 on issue 3443 by chip...@gmail.com: Can't review long lines that does not contain whitespaces http://code.google.com/p/reviewboard/issues/detail?id=3443 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3444 in reviewboard: Autocomplete is too aggressive
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3444 by jamesd...@gmail.com: Autocomplete is too aggressive http://code.google.com/p/reviewboard/issues/detail?id=3444 What version are you running? 2.0.3 alpha 0 (dev) What's the URL of the page containing the problem? http://demo.reviewboard.org/ What steps will reproduce the problem? 1. Create two users: john and johndoe. 2. Create a review request. 3. In the People list, type john and wait a moment. The autocomplete list appears with john as the first match. 5. Type doe and hit the comma key to start adding a second reviewer. What is the expected output? What do you see instead? I expect my input to be unmolested if it's already valid, but johndoe (a valid username) gets replaced with john (the first autocomplete match). Valid input should never be autocorrected. Note that this does not happen if hitting the Enter key instead of comma. What operating system are you using? What browser? Firefox 30.0 on Windows 7 x64 SP1 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3439 in reviewboard: 'ClearCaseClient' object has no attribute 'REVISION_BRANCH_BASE'
Updates: Status: Fixed Comment #5 on issue 3439 by trowb...@gmail.com: 'ClearCaseClient' object has no attribute 'REVISION_BRANCH_BASE' http://code.google.com/p/reviewboard/issues/detail?id=3439 Fixed in rbtools release-0.6.x (5404f87). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3433 in reviewboard: CVS file path stored incorrectly in database
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Component-SCMTools Comment #9 on issue 3433 by trowb...@gmail.com: CVS file path stored incorrectly in database http://code.google.com/p/reviewboard/issues/detail?id=3433 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3433 in reviewboard: CVS file path stored incorrectly in database
Updates: Status: Fixed Comment #10 on issue 3433 by trowb...@gmail.com: CVS file path stored incorrectly in database http://code.google.com/p/reviewboard/issues/detail?id=3433 Fixed in release-2.0.x (8214183). This will ship with 2.0.3. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
