Issue 3715 in reviewboard: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int'
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3715 by mami...@gmail.com: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int' https://code.google.com/p/reviewboard/issues/detail?id=3715 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? 2.0.12 What's the URL of the page containing the problem? https://bld-rb01.cisco.com/r/13072/ What steps will reproduce the problem? 1. Not sure - the screen is just crashing after upgrade. 2. 3. What is the expected output? What do you see instead? The screen should not crash. What operating system are you using? What browser? Red Hat Linux 5.5 server and Google Chrome browser. Please provide any additional information below. 2015-01-12 15:33:50,719 - ERROR - - Exception thrown for user mamiles at https://bld-rb01.cisco.com/r/13072/ unsupported operand type(s) for +=: 'instance' and 'int' Traceback (most recent call last): File /local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/Django-1.6.9-py2.7.egg/django/core/handlers/bas e.py, line 112, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File /local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/accoun ts/decorators.py, line 21, in _check return login_required(view_func)(*args, **kwargs) File /local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/Django-1.6.9-py2.7.egg/django/contrib/auth/deco rators.py, line 22, in _wrapped_view return view_func(request, *args, **kwargs) File /local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/site/d ecorators.py, line 35, in _check return view_func(request, local_site=local_site, *args, **kwargs) File /local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/review s/views.py, line 663, in review_detail changedesc.fields_changed[field_id]) File /local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/reviews/fields.py, line 161, in get_change_entry_sections_html 'rendered_html': mark_safe(self.render_change_entry_html(info)), File /local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/reviews/fields.py, line 514, in render_change_entry_html new_lines = list(iter_markdown_lines(new_value)) File /local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/reviews/markdown_utils.py, line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int' -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3715 in reviewboard: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int'
Comment #1 on issue 3715 by chip...@gmail.com: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int' https://code.google.com/p/reviewboard/issues/detail?id=3715 Hmm, that seems very strange. `i` is never anything but an integer in that code. We have a support contract with Cisco covering at least some of the servers there. I don't know if this is one of them, but let me reach out to our contact there. We might be able to arrange to get more information on this. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3660 in reviewboard: Files randomly get lost from a review request (This is an empty file.)
Updates: Status: Duplicate Mergedinto: 3601 Comment #15 on issue 3660 by trowb...@gmail.com: Files randomly get lost from a review request (This is an empty file.) https://code.google.com/p/reviewboard/issues/detail?id=3660 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Comment #8 on issue 3601 by trowb...@gmail.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 Issue 3660 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Updates: Labels: EasyFix Comment #12 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3715 in reviewboard: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int'
Comment #2 on issue 3715 by mami...@gmail.com: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int' https://code.google.com/p/reviewboard/issues/detail?id=3715 To allow us to see the review in the web GUI I added this code right after the i += 1 line. /local/ichnaea_conf/site/python_ve/reviewboard_v2.0/lib/python2.7/site-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/reviews diff markdown_utils.py markdown_utils.py.orig 231,232d230 if not isinstance(i, int): i = 1 In this review it seems they cut and pasted the all the test cases and the results of each test. Maybe there was special chars or something in the description. -Marvin -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3687 in reviewboard: rbt - helpful error message when repository cannot be found
Updates: Labels: EasyFix Component-RBTools Comment #1 on issue 3687 by trowb...@gmail.com: rbt - helpful error message when repository cannot be found https://code.google.com/p/reviewboard/issues/detail?id=3687 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3715 in reviewboard: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int'
Comment #3 on issue 3715 by mami...@gmail.com: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int' https://code.google.com/p/reviewboard/issues/detail?id=3715 We made these changes to the code: diff markdown_utils.py.orig markdown_utils.py 230a231,237 try: print next line is out i print i, i.name, i.value i = int(i.value) except: print we went to except i = 1 This is the output when we access this review. [Mon Jan 12 21:42:20 2015] [error] next line is out i [Mon Jan 12 21:42:20 2015] [error] xml.dom.minidom.Attr instance at 0x2af3e15be9e0 start 2 [Mon Jan 12 21:42:20 2015] [error] next line is out i [Mon Jan 12 21:42:20 2015] [error] xml.dom.minidom.Attr instance at 0x2af3e16346c8 start 10 [Mon Jan 12 21:42:20 2015] [error] next line is out i [Mon Jan 12 21:42:20 2015] [error] xml.dom.minidom.Attr instance at 0x2af3e1634f38 start 24 [Mon Jan 12 21:42:20 2015] [error] next line is out i [Mon Jan 12 21:42:20 2015] [error] xml.dom.minidom.Attr instance at 0x2af3e18c1560 start 25 [Mon Jan 12 21:42:20 2015] [error] next line is out i [Mon Jan 12 21:42:20 2015] [error] xml.dom.minidom.Attr instance at 0x2af3e18d32d8 start 27 [Mon Jan 12 21:42:20 2015] [error] next line is out i [Mon Jan 12 21:42:20 2015] [error] xml.dom.minidom.Attr instance at 0x2af3e19040e0 start 26 I hope this helps. -Marvin 512-423-3542 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3716 in reviewboard: Diff crashing with non-utf8 characters
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Component-SCMTools Comment #2 on issue 3716 by trowb...@gmail.com: Diff crashing with non-utf8 characters https://code.google.com/p/reviewboard/issues/detail?id=3716 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3716 in reviewboard: Diff crashing with non-utf8 characters
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3716 by msu...@aurea.com: Diff crashing with non-utf8 characters
https://code.google.com/p/reviewboard/issues/detail?id=3716
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
2.0.12
What's the URL of the page containing the problem?
Any URL that involves a diff on files containing non-utf8 characters.
What steps will reproduce the problem?
1. Create new review request.
2. Browse repo
3. Create a review from an existing change.
4. The new review page does not come up with the diff information.
5. The problem is also reproducible when uploading a patch file.
What is the expected output? What do you see instead?
The patch and diff files, etc should be processed based on the encoding
configured on the repository advanced settings in reviewboard. In this
case, the advanced setting was configured to: ISO-8859-1
What operating system are you using? What browser?
Server is running on Amazon Linux. Latest Version.
Browser is Google Chrome latest version.
Please provide any additional information below.
The files checked into Subversion do not have any svn:mime-type properties
set so relying on this reviewboard advanced setting to specify the
character encoding.
The specific character that is causing a problem is: é
This character is encoded as E9 in ISO-8859-1, which is how it appears in
the repository or svn diff file.
But as C3 A9 in UTF-8, which is why review board gets confused.
The error from the logs:
23:12:21ERROR
- Failed to generate diff using pysvn for revisions 14128:14129 for path
https://subversion.devfactory.com/repos/AureaGCE_Generix: 'utf8' codec
can't decode byte 0xe9 in position 534: invalid continuation byte
Traceback (most recent call last):
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/scmtools/svn/pysvn.py,
line 269, in diff
diff_options=['-u']).decode('utf-8')
File /usr/lib64/python2.6/encodings/utf_8.py, line 16, in decode
return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xe9 in position 534:
invalid continuation byte
23:12:21ERROR
- Unable to update new review request from commit ID 14129: Unable to get
diff revisions 14128 through 14129: 'utf8' codec can't decode byte 0xe9 in
position 534: invalid continuation byte
Traceback (most recent call last):
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/reviews/managers.py,
line 146, in create
review_request.update_from_commit_id(commit_id)
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/reviews/models/base_review_request_details.py,
line 195, in update_from_commit_id
self.update_from_committed_change(commit_id)
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/reviews/models/base_review_request_details.py,
line 243, in update_from_committed_change
commit = self.repository.get_change(commit_id)
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/scmtools/models.py,
line 435, in get_change
return self.get_scmtool().get_change(revision)
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/scmtools/svn/__init__.py,
line 221, in get_change
raise self.normalize_error(e)
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.12-py2.6.egg/reviewboard/scmtools/svn/__init__.py,
line 312, in normalize_error
raise SCMError(e)
SCMError: Unable to get diff revisions 14128 through 14129: 'utf8' codec
can't decode byte 0xe9 in position 534: invalid continuation byte
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 3555 in reviewboard: ExpatError: not well-formed (invalid token) when browsing to review
Comment #4 on issue 3555 by mami...@gmail.com: ExpatError: not well-formed (invalid token) when browsing to review https://code.google.com/p/reviewboard/issues/detail?id=3555 I am going to open a new issue since this one is closed. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
