Re: Issue 3858 in reviewboard: rbt post --username does not always authenticate properly
Updates: Status: Fixed Comment #1 on issue 3858 by bar...@beanbaginc.com: rbt post --username does not always authenticate properly https://code.google.com/p/reviewboard/issues/detail?id=3858 The fix for this issue has landed on the release-0.7.x and master branches as commit 6419501d88b5ce313e8a7e13316c9afae0b3ead5. It will be released in RBTool 0.7.3, as well as all later versions. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #8 on issue 3866 by chip...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 It's a bit more complex than that. We don't just shell out to diff. Rather, we use that as a base, and generate a more thorough diff that Review Board can read. This is custom to us, and requires RBTools. post-review is old, and hasn't been part of RBTools for a couple years now, so it's not a safe bet for future use. If you're still hitting trouble with using RBTools to post the change, run it with --debug and show us the output. We'll see what may be going wrong. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #7 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 I am using a post-review script built on top of RBTools. I looked in the source and the way diff is done is using the unix diff command under the clients/perforce.py script. diff_cmd = ['diff', '-urNp', old_file, new_file] However, I installed RBTools and used rbt diff with my reviewboard server URL. These diff produces patchable files. But the diff was not accurate. The line additions do not seem to be the same as I expect. Let me look at this a bit more to confirm. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3863 in reviewboard: Web API should provide an id field for a review request's every depends_on entry
Comment #2 on issue 3863 by csipak.a...@ardinsys.eu: Web API should provide an id field for a review request's every depends_on entry https://code.google.com/p/reviewboard/issues/detail?id=3863 Thanks for the tip, but that would still mean a big payload and a lot of processing on the server side for just a couple of bytes of relevant result. I'm going with unelegant solution a) for now, and shall wait for a fix. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #6 on issue 3866 by trowb...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 You created your diff via `p4 diff`? Could you try with `rbt diff`? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #5 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 The generated diff file does not look correct. I use perforce. The edited lines are not in the patch at all. Maybe this is a p4 diff issue and not a ReviewBoard one? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #4 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 Nope, fails. $ patch -p2 ZoroDebugPlayer.mxml ~/zdp.diff patching file ZoroDebugPlayer.mxml patch: malformed patch at line 5: xmlns:fx="http://ns.adobe.com/mxml/2009"; -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #3 on issue 3866 by trowb...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 Hrmph, ok. I really don't know why `patch` would say that it's malformed. If you try applying that patch manually (by executing the patch command), does it work? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Comment #2 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 This code is protected under license, but I can share the initial few lines if it helps. If not, I can just create a new mxml application to demonstrate this. Whichever is better: --- //.../ZoroDebugPlayer/src/ZoroDebugPlayer.mxml //.../ZoroDebugPlayer/src/ZoroDebugPlayer.mxml#2 +++ //.../ZoroDebugPlayer/src/ZoroDebugPlayer.mxml 2015-04-15 16:03:45 @@ -1,6 +1,6 @@ - http://ns.adobe.com/mxml/2009"; xmlns:s="library://ns.adobe.com/flex/spark" xmlns:mx="library://ns.adobe.com/flex/mx" xmlns:metadata="org.osmf.metadata.*" xmlns:local="*" width="100%" height="100%" applicationComplete="init()" backgroundAlpha="0" backgroundColor="#444242" currentState="videotracestats" preloaderChromeColor="#BB" stateChangeComplete="startDelayedResize()" > -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 1395 in reviewboard: Exporting review comments
Comment #11 on issue 1395 by rohithra...@gmail.com: Exporting review comments https://code.google.com/p/reviewboard/issues/detail?id=1395 It's been 5+ years now. using Reviewboard. Thanks a lot to the developers. Unfortunately, there was no response to: "liannela...@gmail.com"'s question. I believe csv file is fine. Of course, Someone has to decide the fields that are required in the report. As someone mentioned: It's helpful for reporting (Without providing access to the repository) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3814 in reviewboard: AttributeError: 'Namespace' object has no attribute 'revision_range'
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Component-RBTools Comment #2 on issue 3814 by trowb...@gmail.com: AttributeError: 'Namespace' object has no attribute 'revision_range' https://code.google.com/p/reviewboard/issues/detail?id=3814 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3857 in reviewboard: Problem with displaying java diffs of maven projects in clearcase
Updates: Status: NeedInfo Comment #2 on issue 3857 by trowb...@gmail.com: Problem with displaying java diffs of maven projects in clearcase https://code.google.com/p/reviewboard/issues/detail?id=3857 Is there a reason why you discarded the above-mentioned review request? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 1395 in reviewboard: Exporting review comments
Comment #10 on issue 1395 by namrata@gmail.com: Exporting review comments https://code.google.com/p/reviewboard/issues/detail?id=1395 We need this feature too. It will be really useful extension. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied
Updates: Status: NeedInfo Comment #1 on issue 3866 by trowb...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 It would be very helpful to see the patch file in question, not just the source file. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
