Re: Review Board Ticket #4159: expandable udiff view as alternate to side-by-side

2016-10-03 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4159/
--

New update by darrenmoffat
For Beanbag, Inc. > Review Board > Ticket #4159


Reply:

Adding additional diff modes is a massive amount of work with a relatively 
small gain. The particularly hard problem is how to make sure that comments 
made against code can translate in a non-confusing way between the different 
diff modes. We've played around with this problem on a number of occasions but 
there doesn't seem to be any good solution. It would also involve a lot of 
restructuring and refactoring of core code, which is always scary.

We'd be willing to look at contributions, but because it would be such a 
big, invasive change, it would have to be extremely compelling in order for us 
to accept it.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4159: expandable udiff view as alternate to side-by-side

2016-10-03 Thread Darren Moffat
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4159/
--

New update by darrenmoffat
For Beanbag, Inc. > Review Board > Ticket #4159


Reply:

Rather than just saying you won't do it can you please explain why ?  There 
are some file types or styles of change that really don't review well when all 
you have is side by side diffs.
If patches for this feature were contributed would you change your stance 
on this ?

While I appreciate that others might not need this style of review it is a 
very important feature for us being able to deploy ReviewBoard and if we don't 
have it then that ends our current evaluation now and we will look for 
something else.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.