Re: Review Board Ticket #1575: Show image files inline as part of diff view
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/1575/ -- New update by philip.@gmai* (Google Code) For Beanbag, Inc. > Review Board > Ticket #1575 Reply: There's a lot of work that went into the tree for allowing review of images and other file types in diffs, but we never put together all the actual support for uploading files (as they're not contained within diffs themselves, except on Git in a way that's not efficient enough for our usage). I want to get that into 4.0 (3.0 is currently under development and we're working to finish off the last of the features). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #1575: Show image files inline as part of diff view
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/1575/ -- New update by philip.@gmai* (Google Code) For Beanbag, Inc. > Review Board > Ticket #1575 Reply: Actually, we do check into version control the icons and other images that show up on the final product. The diffs/comments on attached images are super useful and we attach screenshots on every GUI review. Would be great to do something similar to committed images too. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #1575: Show image files inline as part of diff view
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/1575/ -- New update by philip.@gmai* (Google Code) For Beanbag, Inc. > Review Board > Ticket #1575 Reply: Hi Juan, Review Board does do diffs of images that are attached to review requests, which is probably more what you want (since I assume you're not actually committing images to version control?) See https://www.reviewboard.org/docs/manual/2.5/users/reviews/reviewing-images/ and https://www.reviewboard.org/docs/manual/2.5/users/reviews/reviewing-files/#reviewing-file-attachments -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
