Review Board Ticket #4699: Wrong filtering of opcodes for an interdiff

[Alexander Galperin]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4699/
--

New ticket #4699 by alexG
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * src2.txt
   

 * rev1.txt
   

 * src1.txt
   

 * rev2.txt
   



--
Wrong filtering of opcodes for an interdiff
==

# What version are you running?
2.5.17, but the same issue in the latest RB

# What's the URL of the page containing the problem?


# What steps will reproduce the problem?
1. Original file 'src1'
2. 1-st user modify 'src1' in line 6: '-4.0.16' to '-4.0.17' and post this 
change to RB#1 (rev1)
3. 2-nd user modify 'src1' in line 5: '6.0.11' -> '6.0.12' and check in to 
repository (src2)
4. 1-st user update from repository, and revert modified file
5. 1-st user  modify 'src2' in line 6: '-4.0.16' to '-4.0.17' and post this 
change to RB (rev2)


# What is the expected output? What do you see instead?
in RB#1. inerdiff 2-3 show that line 5 changed
diff 2-1 and 3-1 show line 6 changed

Expected that interdiff will show white space only, and not mark line 5 as 
modified, because this change has been done by another user


# What operating system are you using? What browser?
windows, Ubuntu, Chrome, Firefox,..

# Please provide any additional information below.
In function 'filter_interdiff_opcodes', opcodes range: (4,5), the new_range and 
orig_range: (4,5) in the latest RB revision, and (4,9) in rev 2.5.17

I can provide other cases, where in similar situation, when different source 
versions in interdiff, the lines that really changed by the user, marked as 
equal

Please let me know what you think, and I will dig a code to solve this issue


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4698: Interdiff returns Unable to locate file record for filediff error

[manoj kumar]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4698/
--

New ticket #4698 by manojm321
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * Screen Shot 2018-06-01 at 2.07.42 PM.png
   



--
Interdiff returns Unable to locate file record for filediff error
==

# What version are you running?
2.5.9

# What's the URL of the page containing the problem?


# What steps will reproduce the problem?
1. Upload a diffset and publish it
2. Upload a second diffset and let it be draft
3. Go to diff view and before all the hunks are loaded try diff between 1 & 2


# What is the expected output? What do you see instead?
Diff view should show interdiff between 1 & 2 instead I see an error as shown 
in the attachement

# What operating system are you using? What browser?
Centos Linux 7 (core) based docker container. Chrome browser

# Please provide any additional information below.
Work around for this is just refresh the page or wair for all the 

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.