RBTools Ticket #4700: Add a flag (or modify existing flag) to rbt post to override OPEN_BROWSER setting from config files
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4700/ -- New ticket #4700 by joekuang For Beanbag, Inc. > RBTools Status: New Tags: Priority:Medium, Type:Enhancement -- Add a flag (or modify existing flag) to rbt post to override OPEN_BROWSER setting from config files == # What version are you running? 0.7.11 # Describe the enhancement and the motivation for it. Adding a flag to allow users to explicitly disable the open browser default from the .reviewboardrc file under a repository (such as `rbt post --no-browser`). The motivation is to offer users the capability of overriding configs like OPEN_BROWSER which potentially breaks the user experience of their development tooling if they were working with a repository that contains a .reviewboardrc file. Perhaps adding overrides can also apply to other rbt arguments. # Please provide any additional information below. -- -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4699: Wrong filtering of opcodes for an interdiff
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4699/ -- New update by alexG For Beanbag, Inc. > Review Board > Ticket #4699 Reply: Thanks for the contribution, but as mentioned above, I have a rewrite of the algorith mthat does the right thing. It's aimed for the next 3.0.x release (had to delay it for other reasons). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4699: Wrong filtering of opcodes for an interdiff
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4699/ -- New update by alexG For Beanbag, Inc. > Review Board > Ticket #4699 Reply: I posted review request with fix for filtering issue: https://reviews.reviewboard.org/r/1/ I commented out call to 'opcodes = self._apply_processors(opcodes) ' , ( so the processors.py file can be removed) After receiving not filtered interdiff chunks, I created diff chunks, and compare changed lines in both chunks(diff and interdiff) The Lines from interdiff, that do not exist in diff chunk, marked as 'equal' The new code is much shorter and clear, and create correct results in all cases -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
