------------------------------------------------------------------------------ To reply, visit https://hellosplat.com/s/beanbag/tickets/4784/ ------------------------------------------------------------------------------
New ticket #4784 by jcannon For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Defect ------------------------------------------------------------------------------ X509 authentication hits database for every request ============================================================================== Compare The X509Middleware https://github.com/reviewboard/reviewboard/blob/master/reviewboard/accounts/middleware.py#L58from Review-board with the RemoteUserMiddleware from Django https://github.com/django/django/blob/master/django/contrib/auth/middleware.py#L27 Specifically see [this comment/code](https://github.com/django/django/blob/master/django/contrib/auth/middleware.py#L65) from RemoteUserMiddleware which simply returns if the request's session already has a user and that user has the same username. ReviewBoard currently hits the DB for every request, as it doesn't have this logic. See [this commit](https://github.com/pds-support/reviewboard/commit/08dd68343ecdb569c73d178cf9d0e1cdc76e3c7c#diff-93d6d4bee8444b20040a56f7b48877f5) of our fork of ReviewBoard for changes that add this improvement (along with other X509 fields to use when creating users, feel free to ignore). ------------------------------------------------------------------------------ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
