Review Board Ticket #4518: Copying from diff viewer in Firefox omits last line

[Griffin Myers]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4518/
--

New ticket #4518 by gmyers
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Copying from diff viewer in Firefox omits last line
==

# What version are you running?
Have observed with 3.0a0, 2.5.7, and 2.5.2.

# What's the URL of the page containing the problem?
Any diff viewer page.

# What steps will reproduce the problem?
First, let me say I'm having a bit of a hard time believing that this is a bug, 
especially because I've never encountered it before despite years of daily RB 
use with Firefox.  But I have now reproduced the issue on multiple machines 
with multiple versions of Firefox.  Maybe a Windows Firefox user could be so 
kind as attempt to reproduce it and report back?

The issue is when using Firefox in Windows and attempting to copy code from the 
diff viewer.  Doesn't seem to matter if the copy is from the left or right 
side, or if the selected line(s) have modifications or not.  If a single line 
is copied then it can be pasted successfully into any other application, such 
as a notepad tool.  However, if N lines are selected and copied (when N>1), 
then only N-1 lines paste successfully and the final line is always omitted.  
Does not matter if the copy is performed via Ctrl-C or the right-click context 
menu.

I have verified this on several machines with Firefox versions including 48.?, 
50.0.2, 50.1.0, 51.0.1, and against the range of RB versions listed above.  
I've tried running Firefox in safe mode with plugins disabled, but it makes no 
difference.  I've also tested with Chrome and IE on these machines and here all 
lines do in fact copy/paste as expected.  Finally I've tested with several 
Firefox versions under CentOS and can not reproduce the issue there.

Going even further, I've observed no problem with copy/paste from the 
Description or Testing Done fields of the review request.  When considering all 
of these observations, perhaps it points to a Firefox and not an RB bug, but 
either way it seems very specific an localized.

# What is the expected output? What do you see instead?
All selected lines are copied and can be succesfully pasted.

# What operating system are you using? What browser?
Windows 7 and 10.  Firefox 48.?, 50.0.2, 50.1.0, 51.0.1


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4434: Creating a new comment discards any existing unsaved draft comments

[Griffin Myers]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4434/
--

New update by chipx86
For Beanbag, Inc. > Review Board > Ticket #4434


Reply:

Perhaps https://hellosplat.com/s/beanbag/tickets/4373/ could be worked at 
the same time as they both involve losing un-saved comments.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4428: General comments do not fully support Comment Severity extension

[Griffin Myers]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4428/
--

New ticket #4428 by gmyers
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * severity_animation.gif
   



--
General comments do not fully support Comment Severity extension
==

# What version are you running?
3.0 alpha 0 (dev)

# What's the URL of the page containing the problem?
/r/{id}/

# What steps will reproduce the problem?
General comments can be added in two ways: 1) By clicking "Add Comment" on the 
review request action bar, or 2) in the Review dialog by clicking The "Add 
Comment" button.

When adding a general comment via method 1, the severity choice (Major, Minor, 
Info) can be set as it is typically for diff comments, and this severity is 
reflected in the published review.

However, when adding a general comment via method 2 the severity choice does 
not appear to be saved as it does not show on the published review.  Checking 
the database confirms that the severity data is not serialized into extra data 
as it is for method 1.  Additionally, for this method the severity drop down 
allows for choosing no severity level, whereas that is not an option for any 
other comments.  This may be a secondary issue, or it may be a "feature" of 
general comments?

While this is written specifically against the Comment Severity extension, it 
is likely this issue would cause problems for any extensions that utilizes the 
`CommentDetailDisplayHook`.

An animation of this problem is attached.  The specific steps taken in this 
example are outlined below, although I doubt steps one and two are really 
necessary.

1. Add any diff comment and set a severity level.
2. Add a general comment by clicking "Add Comment" on the review request action 
bar.  Set a severity level
3. Click Review on action bar to enter review dialog.
4. Add a general comment in the review dialog by clicking the "Add Comment" 
button.  Set a severity level.
5. Publish review.
6. Examine published review.


# What is the expected output? What do you see instead?
Severity should be indicated in the published review, regardless of how the 
general comment was opened.

# What operating system are you using? What browser?
CentOS 7

# Please provide any additional information below.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4423: Download Diff always downloads latest diff regardless of currently selected revision

[Griffin Myers]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4423/
--

New ticket #4423 by gmyers
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Download Diff always downloads latest diff regardless of currently selected 
revision
==

# What version are you running?
3.0 alpha 0 at https://reviews.reviewboard.org

# What's the URL of the page containing the problem?
/r/{id}/diff/{N}/   when N is less than the latest revision number, R

# What steps will reproduce the problem?
1. Click Download Diff
2. 
3. 


# What is the expected output? What do you see instead?
Diff for revision R is downloaded, whereas diff for revision N is expected.

# What operating system are you using? What browser?
Windows 7, Firefox 46.0.1

# Please provide any additional information below.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4418: Unexpected behavior related to long reply and scrolling when clicking OK or enabling markdown

[Griffin Myers]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4418/
--

New ticket #4418 by gmyers
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * Animation.gif
   



--
Unexpected behavior related to long reply and scrolling when clicking OK or 
enabling markdown
==

# What version are you running?
3.0 alpha 0 (dev) at https://reviews.reviewboard.org

# What's the URL of the page containing the problem?
Observed at https://reviews.reviewboard.org/r/8151

# What steps will reproduce the problem?
1. Enter a very lengthy reply.  In my case it consumed more than one full 
screen.  I don't know to what degree that matters.
2. Ticking 'Enable Markdown' takes me way up to what seems to correspond with 
the original reply.
3. Next, disabling markdown takes me up a few lines.
4. Finally, clicking OK takes me way up again with a server error message that 
quickly disappears.


# What is the expected output? What do you see instead?
Don't expect all the scrolling, nor the server error message.

# What operating system are you using? What browser?
Windows 7, Firefox 46.0.1.  Forgot to try with other browsers.

# Please provide any additional information below.
Attached animated GIF should provide further clarity about the issue.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.