Re: Issue 1321 in reviewboard: post-review fails when submitting a Perforce CLN that includes a symlink to a symlink.

[reviewboard]

Updates:
Status: Fixed

Comment #2 on issue 1321 by trowb...@gmail.com: post-review fails when  
submitting a Perforce CLN that includes a symlink to a symlink.

http://code.google.com/p/reviewboard/issues/detail?id=1321

Fixed in rbtools master (8e72821). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.

Issue 1321 in reviewboard: post-review fails when submitting a Perforce CLN that includes a symlink to a symlink.

[codesite-noreply]

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1321 by josh.hamacher: post-review fails when submitting a  
Perforce CLN that includes a symlink to a symlink.
http://code.google.com/p/reviewboard/issues/detail?id=1321

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.0

What's the URL of the page containing the problem?
None - this is an issue with post-review.

What steps will reproduce the problem?
1. Find an existing symlink (A) somewhere on your system.
2. Inside a Perforce client view, create a symlink (B) to A.
3. Create a changelist.
4. p4 add -c XXX B
5. Run post-review XXX.

What is the expected output? What do you see instead?
We see this:
Traceback (most recent call last):
   File /apollo/env/SDETools/share/rbtools/scripts/post-review, line 2348,
in module
 main(sys.argv[1:])
   File /apollo/env/SDETools/share/rbtools/scripts/post-review, line 2294,
in main
 diff, parent_diff = tool.diff(args)
   File /apollo/env/SDETools/share/rbtools/scripts/post-review, line 1473,
in diff
 m = re.search(r'(\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d)', dl[1])
IndexError: list index out of range

Symlinks to files and directories seem to work, so I'd expect symlinks to
symlinks to work the same.

What operating system are you using? What browser?
Red Hat Enterprise Linux 5.3 on the server.  Post-review is running under
Red Hat Enterprise Linux 3.

Please provide any additional information below.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---